Skip to content

Beautiful, AI-native markdown IDE and LLM wiki

Fix folder admission warnings across working directories (#5581)

Nick Gomez86494b098b27
diff --git a/packages/desktop/src/main/folder-admission.test.ts b/packages/desktop/src/main/folder-admission.test.ts
index a5fbad5b6..862e95263 100644
--- a/packages/desktop/src/main/folder-admission.test.ts
+++ b/packages/desktop/src/main/folder-admission.test.ts
@@ -3,7 +3,7 @@ import { mkdirSync, mkdtempSync, realpathSync, rmSync, symlinkSync, writeFileSyn
import { tmpdir } from 'node:os';
import { join, resolve } from 'node:path';
import { promisify } from 'node:util';
-import { afterEach, beforeEach, describe, expect, test } from 'vitest';
+import { afterEach, beforeEach, describe, expect, test, vi } from 'vitest';
import {
type DiscoverProjectOptions,
type DiscoverProjectResult,
@@ -108,6 +108,24 @@ describe('validateFolderPick — /Volumes warnings', () => {
});
describe('validateFolderPick — drive-root warning (Windows shape)', () => {
+ test.each(['C:\\', 'C:', 'C:/'])(
+ 'drive warnings for %s do not inherit the working directory',
+ (drivePath) => {
+ const workingDirectories = [resolve('/Users/test/project'), resolve('/Volumes/External')];
+ const cwd = vi.spyOn(process, 'cwd');
+ try {
+ for (const directory of workingDirectories) {
+ cwd.mockReturnValue(directory);
+ expect(validateFolderPick(drivePath, { homeDir: HOME }).warnings).toEqual([
+ { kind: 'drive-root' },
+ ]);
+ }
+ } finally {
+ cwd.mockRestore();
+ }
+ },
+ );
+
test('C:\\ returns drive-root warning', () => {
const result = validateFolderPick('C:\\', { homeDir: HOME });
expect(result.warnings).toEqual([{ kind: 'drive-root' }]);
diff --git a/packages/desktop/src/main/folder-admission.ts b/packages/desktop/src/main/folder-admission.ts
index 9393a3685..4d2dbfc1e 100644
--- a/packages/desktop/src/main/folder-admission.ts
+++ b/packages/desktop/src/main/folder-admission.ts
@@ -35,6 +35,9 @@ export function validateFolderPick(
if (/^[A-Za-z]:[\\/]?$/.test(absPath)) {
warnings.push({ kind: 'drive-root' });
+ if (process.platform !== 'win32') {
+ return { warnings, blocked: false };
+ }
}
const resolved = resolve(absPath);