Skip to content

Beautiful, AI-native markdown IDE and LLM wiki

fix(ok): immediate feedback for manual update checks (PRD-8552) (#4150)

Andrew Mikofalvy898f4aa69050
diff --git a/.changeset/manual-update-check-feedback.md b/.changeset/manual-update-check-feedback.md
new file mode 100644
index 000000000..0d509cf2b
--- /dev/null
+++ b/.changeset/manual-update-check-feedback.md
@@ -0,0 +1,5 @@
+---
+'@inkeep/open-knowledge': patch
+---
+
+Manual update checks now show immediate in-app feedback while OpenKnowledge looks for updates. The feedback clears as soon as the check finishes and the existing result dialog appears.
diff --git a/packages/app/src/components/UpdateNotices.shared.ts b/packages/app/src/components/UpdateNotices.shared.ts
index dc4ff63bd..dc208cac5 100644
--- a/packages/app/src/components/UpdateNotices.shared.ts
+++ b/packages/app/src/components/UpdateNotices.shared.ts
@@ -1,3 +1,5 @@
+import { MANUAL_CHECK_NOTICE_EXPIRY_MS } from '@inkeep/open-knowledge-core';
+import { t } from '@lingui/core/macro';
import type { OkDesktopBridge } from '@/lib/desktop-bridge-types';
export const TOAST_A_ACTION = 'Relaunch';
@@ -54,9 +56,11 @@ const PRIORITY_SCHEMA_INCOMPATIBILITY = 0;
const PRIORITY_STUCK_HINT = 0;
const PRIORITY_RELAUNCH_ERROR = 1;
const PRIORITY_UPDATE_DOWNLOADED = 2;
-const PRIORITY_WHATS_NEW = 3;
+const PRIORITY_MANUAL_CHECK = 3;
+const PRIORITY_WHATS_NEW = 4;
export const WHATS_NEW_AUTO_DISMISS_MS = 60_000;
+const MANUAL_CHECK_AUTO_DISMISS_MS = MANUAL_CHECK_NOTICE_EXPIRY_MS;
type AddNoticeFn = (notice: UpdateNotice) => void;
@@ -71,11 +75,14 @@ export function attachUpdateSubscribers(
isEligible: (version: string) => boolean;
onShown: (version: string) => void;
} = { isEligible: () => false, onShown: () => {} },
+ manualCheckAutoDismissMs: number = MANUAL_CHECK_AUTO_DISMISS_MS,
): () => void {
const unsubscribers: Array<() => void> = [];
const autoDismissTimers = new Set<ReturnType<typeof setTimeout>>();
+ let manualCheckAutoDismissTimer: ReturnType<typeof setTimeout> | null = null;
const downloadedNoticeId = 'update-downloaded';
+ const manualCheckNoticeId = 'update-checking';
unsubscribers.push(
bridge.onUpdateDownloaded(({ version }) => {
@@ -254,8 +261,35 @@ export function attachUpdateSubscribers(
}),
);
+ unsubscribers.push(
+ bridge.onUpdateManualCheck(({ phase }) => {
+ if (phase === 'settled') {
+ if (manualCheckAutoDismissTimer !== null) {
+ clearTimeout(manualCheckAutoDismissTimer);
+ manualCheckAutoDismissTimer = null;
+ }
+ dismissNotice(manualCheckNoticeId);
+ return;
+ }
+ if (manualCheckAutoDismissTimer !== null) clearTimeout(manualCheckAutoDismissTimer);
+ addNotice({
+ id: manualCheckNoticeId,
+ body: t`Checking for updates…`,
+ priority: PRIORITY_MANUAL_CHECK,
+ });
+ manualCheckAutoDismissTimer = setTimeout(() => {
+ manualCheckAutoDismissTimer = null;
+ console.warn('[update-notice] manual check notice expired without settled', {
+ ms: manualCheckAutoDismissMs,
+ });
+ dismissNotice(manualCheckNoticeId);
+ }, manualCheckAutoDismissMs);
+ }),
+ );
+
return () => {
for (const off of unsubscribers) off();
+ if (manualCheckAutoDismissTimer !== null) clearTimeout(manualCheckAutoDismissTimer);
for (const timer of autoDismissTimers) clearTimeout(timer);
autoDismissTimers.clear();
};
diff --git a/packages/app/src/components/UpdateNotices.test.ts b/packages/app/src/components/UpdateNotices.test.ts
index 6bb5fac21..6ec0aeb7b 100644
--- a/packages/app/src/components/UpdateNotices.test.ts
+++ b/packages/app/src/components/UpdateNotices.test.ts
@@ -31,6 +31,7 @@ type RelaunchFailedCb = (info: { version: string; message?: string; downloadUrl?
type WhatsNewCb = (info: { version: string; releaseUrl: string }) => void;
type WhatsNewDismissedCb = (info: { version: string }) => void;
type StuckHintCb = (info: { downloadUrl: string }) => void;
+type ManualCheckCb = (info: { phase: 'started' | 'settled' }) => void;
interface FakeBridge {
onUpdateDownloaded: ReturnType<typeof vi.fn>;
@@ -40,6 +41,7 @@ interface FakeBridge {
onWhatsNew: ReturnType<typeof vi.fn>;
onWhatsNewDismissed: ReturnType<typeof vi.fn>;
onUpdateStuckHint: ReturnType<typeof vi.fn>;
+ onUpdateManualCheck: ReturnType<typeof vi.fn>;
update: {
relaunchNow: ReturnType<typeof vi.fn>;
dismissWhatsNew: ReturnType<typeof vi.fn>;
@@ -56,6 +58,7 @@ interface FakeBridge {
_whatsNew?: WhatsNewCb;
_whatsNewDismissed?: WhatsNewDismissedCb;
_stuckHint?: StuckHintCb;
+ _manualCheck?: ManualCheckCb;
_downloadedUnsub: ReturnType<typeof vi.fn>;
_relaunchingUnsub: ReturnType<typeof vi.fn>;
_fetchingLatestUnsub: ReturnType<typeof vi.fn>;
@@ -63,6 +66,7 @@ interface FakeBridge {
_whatsNewUnsub: ReturnType<typeof vi.fn>;
_whatsNewDismissedUnsub: ReturnType<typeof vi.fn>;
_stuckHintUnsub: ReturnType<typeof vi.fn>;
+ _manualCheckUnsub: ReturnType<typeof vi.fn>;
}
function makeFakeBridge(): FakeBridge {
@@ -74,6 +78,7 @@ function makeFakeBridge(): FakeBridge {
_whatsNewUnsub: vi.fn(() => {}),
_whatsNewDismissedUnsub: vi.fn(() => {}),
_stuckHintUnsub: vi.fn(() => {}),
+ _manualCheckUnsub: vi.fn(() => {}),
onUpdateDownloaded: vi.fn(() => {}),
onUpdateRelaunching: vi.fn(() => {}),
onUpdateFetchingLatest: vi.fn(() => {}),
@@ -81,6 +86,7 @@ function makeFakeBridge(): FakeBridge {
onWhatsNew: vi.fn(() => {}),
onWhatsNewDismissed: vi.fn(() => {}),
onUpdateStuckHint: vi.fn(() => {}),
+ onUpdateManualCheck: vi.fn(() => {}),
update: {
relaunchNow: vi.fn(() => Promise.resolve(undefined)),
dismissWhatsNew: vi.fn(() => Promise.resolve(undefined)),
@@ -119,6 +125,10 @@ function makeFakeBridge(): FakeBridge {
b._stuckHint = cb;
return b._stuckHintUnsub;
});
+ b.onUpdateManualCheck = vi.fn((cb: ManualCheckCb) => {
+ b._manualCheck = cb;
+ return b._manualCheckUnsub;
+ });
return b;
}
@@ -189,29 +199,177 @@ describe('appendErrorDetail', () => {
});
describe('attachUpdateSubscribers — registration', () => {
- test('subscribes to all six update channels on the bridge', () => {
+ test('subscribes to all eight update channels on the bridge', () => {
const bridge = makeFakeBridge();
const addNotice = vi.fn<(notice: UpdateNotice) => void>(() => {});
attachUpdateSubscribers(castBridge(bridge), addNotice);
expect(bridge.onUpdateDownloaded).toHaveBeenCalledTimes(1);
expect(bridge.onUpdateRelaunching).toHaveBeenCalledTimes(1);
+ expect(bridge.onUpdateFetchingLatest).toHaveBeenCalledTimes(1);
expect(bridge.onUpdateRelaunchFailed).toHaveBeenCalledTimes(1);
expect(bridge.onWhatsNew).toHaveBeenCalledTimes(1);
expect(bridge.onWhatsNewDismissed).toHaveBeenCalledTimes(1);
expect(bridge.onUpdateStuckHint).toHaveBeenCalledTimes(1);
+ expect(bridge.onUpdateManualCheck).toHaveBeenCalledTimes(1);
});
- test('returns a single unsubscribe closure that detaches ALL six listeners', () => {
+ test('returns a single unsubscribe closure that detaches all eight listeners', () => {
const bridge = makeFakeBridge();
const addNotice = vi.fn<(notice: UpdateNotice) => void>(() => {});
const unsubscribe = attachUpdateSubscribers(castBridge(bridge), addNotice);
unsubscribe();
expect(bridge._downloadedUnsub).toHaveBeenCalledTimes(1);
expect(bridge._relaunchingUnsub).toHaveBeenCalledTimes(1);
+ expect(bridge._fetchingLatestUnsub).toHaveBeenCalledTimes(1);
expect(bridge._relaunchFailedUnsub).toHaveBeenCalledTimes(1);
expect(bridge._whatsNewUnsub).toHaveBeenCalledTimes(1);
expect(bridge._whatsNewDismissedUnsub).toHaveBeenCalledTimes(1);
expect(bridge._stuckHintUnsub).toHaveBeenCalledTimes(1);
+ expect(bridge._manualCheckUnsub).toHaveBeenCalledTimes(1);
+ });
+});
+
+describe('Notice F — ok:update:manual-check', () => {
+ test('repeated started events reuse the notice id and replace the pending expiry', async () => {
+ const warn = vi.spyOn(console, 'warn').mockImplementation(() => {});
+ const bridge = makeFakeBridge();
+ const addNotice = vi.fn<(notice: UpdateNotice) => void>(() => {});
+ const dismissNotice = vi.fn<(id: string) => void>(() => {});
+ const unsubscribe = attachUpdateSubscribers(
+ castBridge(bridge),
+ addNotice,
+ dismissNotice,
+ undefined,
+ undefined,
+ 15,
+ );
+ try {
+ bridge._manualCheck?.({ phase: 'started' });
+ bridge._manualCheck?.({ phase: 'started' });
+ expect(addNotice).toHaveBeenCalledTimes(2);
+ expect(addNotice.mock.calls.map(([notice]) => notice.id)).toEqual([
+ 'update-checking',
+ 'update-checking',
+ ]);
+ expect(dismissNotice).not.toHaveBeenCalled();
+ await new Promise((resolve) => setTimeout(resolve, 45));
+ expect(dismissNotice).toHaveBeenCalledExactlyOnceWith('update-checking');
+ expect(warn).toHaveBeenCalledExactlyOnceWith(
+ '[update-notice] manual check notice expired without settled',
+ { ms: 15 },
+ );
+ } finally {
+ unsubscribe();
+ warn.mockRestore();
+ }
+ });
+
+ test('unsubscribe clears the manual-check expiry timer', async () => {
+ const warn = vi.spyOn(console, 'warn').mockImplementation(() => {});
+ const bridge = makeFakeBridge();
+ const dismissNotice = vi.fn<(id: string) => void>(() => {});
+ const unsubscribe = attachUpdateSubscribers(
+ castBridge(bridge),
+ () => {},
+ dismissNotice,
+ undefined,
+ undefined,
+ 15,
+ );
+ try {
+ bridge._manualCheck?.({ phase: 'started' });
+ unsubscribe();
+ await new Promise((resolve) => setTimeout(resolve, 45));
+ expect(dismissNotice).not.toHaveBeenCalled();
+ expect(warn).not.toHaveBeenCalled();
+ } finally {
+ unsubscribe();
+ warn.mockRestore();
+ }
+ });
+
+ test('started adds the fixed update-checking notice with translated copy and no action', () => {
+ const bridge = makeFakeBridge();
+ const addNotice = vi.fn<(notice: UpdateNotice) => void>(() => {});
+ const unsubscribe = attachUpdateSubscribers(castBridge(bridge), addNotice);
+
+ bridge._manualCheck?.({ phase: 'started' });
+
+ expect(addNotice).toHaveBeenCalledTimes(1);
+ const notice = addNotice.mock.calls[0]?.[0] as UpdateNotice;
+ expect(notice.id).toBe('update-checking');
+ expect(notice.body).toBe('Checking for updates…');
+ expect(notice.action).toBeUndefined();
+ expect(notice.priority).toBe(3);
+ unsubscribe();
+ });
+
+ test('settled dismisses the update-checking notice', () => {
+ const bridge = makeFakeBridge();
+ const addNotice = vi.fn<(notice: UpdateNotice) => void>(() => {});
+ const dismissNotice = vi.fn<(id: string) => void>(() => {});
+ attachUpdateSubscribers(castBridge(bridge), addNotice, dismissNotice);
+
+ bridge._manualCheck?.({ phase: 'started' });
+ bridge._manualCheck?.({ phase: 'settled' });
+
+ expect(dismissNotice).toHaveBeenCalledTimes(1);
+ expect(dismissNotice).toHaveBeenCalledWith('update-checking');
+ });
+
+ test('the safety timer warns and dismisses the notice without settled', async () => {
+ const warn = vi.spyOn(console, 'warn').mockImplementation(() => {});
+ const bridge = makeFakeBridge();
+ const addNotice = vi.fn<(notice: UpdateNotice) => void>(() => {});
+ const dismissNotice = vi.fn<(id: string) => void>(() => {});
+ const unsubscribe = attachUpdateSubscribers(
+ castBridge(bridge),
+ addNotice,
+ dismissNotice,
+ undefined,
+ undefined,
+ 15,
+ );
+ try {
+ bridge._manualCheck?.({ phase: 'started' });
+ expect(dismissNotice).not.toHaveBeenCalled();
+ await new Promise((resolve) => setTimeout(resolve, 45));
+ expect(dismissNotice).toHaveBeenCalledExactlyOnceWith('update-checking');
+ expect(warn).toHaveBeenCalledExactlyOnceWith(
+ '[update-notice] manual check notice expired without settled',
+ { ms: 15 },
+ );
+ } finally {
+ unsubscribe();
+ warn.mockRestore();
+ }
+ });
+
+ test('settled clears the safety timer', async () => {
+ const warn = vi.spyOn(console, 'warn').mockImplementation(() => {});
+ const bridge = makeFakeBridge();
+ const addNotice = vi.fn<(notice: UpdateNotice) => void>(() => {});
+ const dismissNotice = vi.fn<(id: string) => void>(() => {});
+ const unsubscribe = attachUpdateSubscribers(
+ castBridge(bridge),
+ addNotice,
+ dismissNotice,
+ undefined,
+ undefined,
+ 15,
+ );
+ try {
+ bridge._manualCheck?.({ phase: 'started' });
+ bridge._manualCheck?.({ phase: 'settled' });
+ expect(dismissNotice).toHaveBeenCalledExactlyOnceWith('update-checking');
+ dismissNotice.mockClear();
+ await new Promise((resolve) => setTimeout(resolve, 45));
+ expect(dismissNotice).not.toHaveBeenCalled();
+ expect(warn).not.toHaveBeenCalled();
+ } finally {
+ unsubscribe();
+ warn.mockRestore();
+ }
});
});
@@ -557,7 +715,7 @@ describe('Notice B — ok:update:whats-new', () => {
expect(notice.id).toBe('whats-new-0.3.1');
expect(notice.action?.label).toBe(TOAST_B_ACTION);
expect(notice.variant).toBe('success');
- expect(notice.priority).toBe(3);
+ expect(notice.priority).toBe(4);
notice.action?.onClick();
expect(bridge.shell.openExternal).toHaveBeenCalledWith(releaseUrl);
});
@@ -618,7 +776,13 @@ describe('Notice B — ok:update:whats-new', () => {
attachUpdateSubscribers(castBridge(bridge), addNotice, dismissNotice, 15);
bridge._whatsNew?.({ version: '0.3.1', releaseUrl: 'https://example.com/r' });
await new Promise((resolve) => setTimeout(resolve, 45));
+ expect(dismissNotice).toHaveBeenCalledExactlyOnceWith('whats-new-0.3.1');
expect(bridge.update.dismissWhatsNew).toHaveBeenCalledWith('0.3.1');
+ bridge.update.dismissWhatsNew.mockClear();
+ const notice = addNotice.mock.calls[0]?.[0];
+ expect(notice?.onDismiss).toBeTypeOf('function');
+ notice?.onDismiss?.();
+ expect(bridge.update.dismissWhatsNew).toHaveBeenCalledExactlyOnceWith('0.3.1');
});
test('onWhatsNewDismissed echo clears the card by id without re-notifying main (no loop)', () => {
@@ -802,7 +966,8 @@ describe('Notice E — schema-incompatibility refuse-downgrade', () => {
describe('pickActiveNotice', () => {
const a: UpdateNotice = { id: 'a', body: 'A', priority: 2 };
- const b: UpdateNotice = { id: 'b', body: 'B', priority: 3 };
+ const checking: UpdateNotice = { id: 'update-checking', body: 'Checking', priority: 3 };
+ const b: UpdateNotice = { id: 'b', body: 'B', priority: 4 };
const c: UpdateNotice = { id: 'c', body: 'C', priority: 0 };
const err: UpdateNotice = { id: 'err', body: 'Err', priority: 1, variant: 'error' };
@@ -822,23 +987,32 @@ describe('pickActiveNotice', () => {
expect(pickActiveNotice([b, a])).toBe(a);
});
- test('relaunch-error (1) wins over A (2) and B (3) but not C (0)', () => {
+ test('checking ranks below update notices and above whats-new', () => {
+ expect(pickActiveNotice([b, checking])).toBe(checking);
+ expect(pickActiveNotice([b, checking, a])).toBe(a);
+ expect(pickActiveNotice([b, checking, err])).toBe(err);
+ expect(pickActiveNotice([b, checking, c])).toBe(c);
+ });
+
+ test('relaunch-error (1) wins over A (2) and B (4) but not C (0)', () => {
expect(pickActiveNotice([a, b, err])).toBe(err);
expect(pickActiveNotice([a, b, err, c])).toBe(c);
});
});
describe('unsubscribe semantics', () => {
- test('after unsubscribe, all six per-channel unsub closures fire', () => {
+ test('after unsubscribe, all eight per-channel unsub closures fire', () => {
const bridge = makeFakeBridge();
const addNotice = vi.fn<(notice: UpdateNotice) => void>(() => {});
const unsubscribe = attachUpdateSubscribers(castBridge(bridge), addNotice);
unsubscribe();
expect(bridge._downloadedUnsub).toHaveBeenCalledTimes(1);
expect(bridge._relaunchingUnsub).toHaveBeenCalledTimes(1);
+ expect(bridge._fetchingLatestUnsub).toHaveBeenCalledTimes(1);
expect(bridge._relaunchFailedUnsub).toHaveBeenCalledTimes(1);
expect(bridge._whatsNewUnsub).toHaveBeenCalledTimes(1);
expect(bridge._whatsNewDismissedUnsub).toHaveBeenCalledTimes(1);
expect(bridge._stuckHintUnsub).toHaveBeenCalledTimes(1);
+ expect(bridge._manualCheckUnsub).toHaveBeenCalledTimes(1);
});
});
diff --git a/packages/app/src/lib/update-notices-store.test.ts b/packages/app/src/lib/update-notices-store.test.ts
index af9a440b4..74bcf4fa2 100644
--- a/packages/app/src/lib/update-notices-store.test.ts
+++ b/packages/app/src/lib/update-notices-store.test.ts
@@ -26,6 +26,7 @@ describe('update-notices-store install-time runtime wiring', () => {
const whatsNewUnsub = vi.fn(() => {});
const whatsNewDismissedUnsub = vi.fn(() => {});
const stuckHintUnsub = vi.fn(() => {});
+ const manualCheckUnsub = vi.fn(() => {});
const bridge = {
onUpdateDownloaded: vi.fn(() => downloadedUnsub),
onUpdateRelaunching: vi.fn(() => relaunchingUnsub),
@@ -34,6 +35,9 @@ describe('update-notices-store install-time runtime wiring', () => {
onWhatsNew: vi.fn(() => whatsNewUnsub),
onWhatsNewDismissed: vi.fn(() => whatsNewDismissedUnsub),
onUpdateStuckHint: vi.fn(() => stuckHintUnsub),
+ onUpdateManualCheck: vi.fn(
+ (_cb: (info: { phase: 'started' | 'settled' }) => void) => manualCheckUnsub,
+ ),
update: {
relaunchNow: vi.fn(() => Promise.resolve(undefined)),
dismissWhatsNew: vi.fn(() => Promise.resolve(undefined)),
@@ -63,6 +67,7 @@ describe('update-notices-store install-time runtime wiring', () => {
expect(bridge.onWhatsNew).toHaveBeenCalledWith(expect.any(Function));
expect(bridge.onWhatsNewDismissed).toHaveBeenCalledWith(expect.any(Function));
expect(bridge.onUpdateStuckHint).toHaveBeenCalledWith(expect.any(Function));
+ expect(bridge.onUpdateManualCheck).toHaveBeenCalledWith(expect.any(Function));
expect(queryMock).toHaveBeenCalledTimes(1);
await Promise.resolve();
@@ -76,14 +81,33 @@ describe('update-notices-store install-time runtime wiring', () => {
expect(notice?.action?.label).toBe('Reset to defaults');
expect(typeof notice?.action?.onClick).toBe('function');
+ const manualCheck = bridge.onUpdateManualCheck.mock.calls[0]?.[0];
+ expect(manualCheck).toBeDefined();
+ manualCheck?.({ phase: 'started' });
+ manualCheck?.({ phase: 'started' });
+ expect(
+ store.getNoticesSnapshot().filter((entry) => entry.id === 'update-checking'),
+ ).toHaveLength(1);
+ store.dismissNotice('update-checking');
+ manualCheck?.({ phase: 'started' });
+ expect(
+ store.getNoticesSnapshot().filter((entry) => entry.id === 'update-checking'),
+ ).toHaveLength(1);
+ manualCheck?.({ phase: 'settled' });
+ expect(
+ store.getNoticesSnapshot().filter((entry) => entry.id === 'update-checking'),
+ ).toHaveLength(0);
+
store.installUpdateNoticesBridge();
expect(bridge.onUpdateDownloaded).toHaveBeenCalledTimes(1);
expect(bridge.onUpdateRelaunching).toHaveBeenCalledTimes(1);
+ expect(bridge.onUpdateFetchingLatest).toHaveBeenCalledTimes(1);
expect(bridge.onUpdateRelaunchFailed).toHaveBeenCalledTimes(1);
expect(bridge.onWhatsNew).toHaveBeenCalledTimes(1);
expect(bridge.onWhatsNewDismissed).toHaveBeenCalledTimes(1);
expect(bridge.onUpdateStuckHint).toHaveBeenCalledTimes(1);
+ expect(bridge.onUpdateManualCheck).toHaveBeenCalledTimes(1);
expect(queryMock).toHaveBeenCalledTimes(1);
});
});
diff --git a/packages/app/src/locales/ar/messages.json b/packages/app/src/locales/ar/messages.json
index 5c4cb5b7b..20842f632 100644
--- a/packages/app/src/locales/ar/messages.json
+++ b/packages/app/src/locales/ar/messages.json
@@ -3093,6 +3093,7 @@
"YGIi_c": ["إعادة التثبيت"],
"YGNRB5": ["— باستثناء"],
"YGt-0e": ["يجري القراءة…"],
+ "YHOIrR": ["يجري التحقق من التحديثات…"],
"YJ1BTp": ["توجد بالفعل مهارة بهذا الاسم."],
"YJPN3F": ["بطيء جدًا"],
"YKLP_-": ["أُعيدت تسمية القالب"],
diff --git a/packages/app/src/locales/ar/messages.po b/packages/app/src/locales/ar/messages.po
index 5a1c7f766..944944296 100644
--- a/packages/app/src/locales/ar/messages.po
+++ b/packages/app/src/locales/ar/messages.po
@@ -2578,6 +2578,10 @@ msgstr "يجري التحقق من التحديثات"
msgid "Checking for updates on GitHub"
msgstr "يجري التحقق من التحديثات على GitHub"
+#: src/components/UpdateNotices.shared.ts
+msgid "Checking for updates…"
+msgstr "يجري التحقق من التحديثات…"
+
#: src/components/ShareReceiveDialog.tsx
msgid "Checking GitHub connection..."
msgstr "يجري التحقق من الاتصال بـ GitHub..."
diff --git a/packages/app/src/locales/bn/messages.json b/packages/app/src/locales/bn/messages.json
index 98cc2130a..09425a8fb 100644
--- a/packages/app/src/locales/bn/messages.json
+++ b/packages/app/src/locales/bn/messages.json
@@ -2639,6 +2639,7 @@
"YGIi_c": ["আবার ইনস্টল করুন"],
"YGNRB5": ["— ছাড়া"],
"YGt-0e": ["পড়া হচ্ছে…"],
+ "YHOIrR": ["হালনাগাদ দেখা হচ্ছে…"],
"YJ1BTp": ["ওই নামের একটি স্কিল আগে থেকেই আছে।"],
"YJPN3F": ["খুব ধীর"],
"YKLP_-": ["টেমপ্লেটের নাম বদলানো হয়েছে"],
diff --git a/packages/app/src/locales/bn/messages.po b/packages/app/src/locales/bn/messages.po
index 03533368d..c243183ac 100644
--- a/packages/app/src/locales/bn/messages.po
+++ b/packages/app/src/locales/bn/messages.po
@@ -2574,6 +2574,10 @@ msgstr "হালনাগাদ দেখা হচ্ছে"
msgid "Checking for updates on GitHub"
msgstr "GitHub-এ হালনাগাদ দেখা হচ্ছে"
+#: src/components/UpdateNotices.shared.ts
+msgid "Checking for updates…"
+msgstr "হালনাগাদ দেখা হচ্ছে…"
+
#: src/components/ShareReceiveDialog.tsx
msgid "Checking GitHub connection..."
msgstr "GitHub সংযোগ পরীক্ষা করা হচ্ছে…"
diff --git a/packages/app/src/locales/en/messages.json b/packages/app/src/locales/en/messages.json
index dd953fe8d..e0494f42c 100644
--- a/packages/app/src/locales/en/messages.json
+++ b/packages/app/src/locales/en/messages.json
@@ -2694,6 +2694,7 @@
"YGIi_c": ["Reinstall"],
"YGNRB5": ["— except"],
"YGt-0e": ["Reading…"],
+ "YHOIrR": ["Checking for updates…"],
"YJ1BTp": ["A skill with that name already exists."],
"YJPN3F": ["Too slow"],
"YKLP_-": ["Template renamed"],
diff --git a/packages/app/src/locales/en/messages.po b/packages/app/src/locales/en/messages.po
index df4d06950..84e960b32 100644
--- a/packages/app/src/locales/en/messages.po
+++ b/packages/app/src/locales/en/messages.po
@@ -2578,6 +2578,10 @@ msgstr "Checking for updates"
msgid "Checking for updates on GitHub"
msgstr "Checking for updates on GitHub"
+#: src/components/UpdateNotices.shared.ts
+msgid "Checking for updates…"
+msgstr "Checking for updates…"
+
#: src/components/ShareReceiveDialog.tsx
msgid "Checking GitHub connection..."
msgstr "Checking GitHub connection..."
diff --git a/packages/app/src/locales/es/messages.json b/packages/app/src/locales/es/messages.json
index 0b135b55d..2f84f0676 100644
--- a/packages/app/src/locales/es/messages.json
+++ b/packages/app/src/locales/es/messages.json
@@ -3138,6 +3138,7 @@
"YGIi_c": ["Reinstalar"],
"YGNRB5": ["— excepto"],
"YGt-0e": ["Leyendo…"],
+ "YHOIrR": ["Buscando actualizaciones…"],
"YJ1BTp": ["Ya existe una habilidad con ese nombre."],
"YJPN3F": ["Demasiado lento"],
"YKLP_-": ["Plantilla renombrada"],
diff --git a/packages/app/src/locales/es/messages.po b/packages/app/src/locales/es/messages.po
index 2fc50f136..51d9876bc 100644
--- a/packages/app/src/locales/es/messages.po
+++ b/packages/app/src/locales/es/messages.po
@@ -2578,6 +2578,10 @@ msgstr "Buscando actualizaciones"
msgid "Checking for updates on GitHub"
msgstr "Buscando actualizaciones en GitHub"
+#: src/components/UpdateNotices.shared.ts
+msgid "Checking for updates…"
+msgstr "Buscando actualizaciones…"
+
#: src/components/ShareReceiveDialog.tsx
msgid "Checking GitHub connection..."
msgstr "Comprobando la conexión con GitHub..."
diff --git a/packages/app/src/locales/fr/messages.json b/packages/app/src/locales/fr/messages.json
index fefebba81..1e1d93545 100644
--- a/packages/app/src/locales/fr/messages.json
+++ b/packages/app/src/locales/fr/messages.json
@@ -3165,6 +3165,7 @@
"YGIi_c": ["Réinstaller"],
"YGNRB5": ["— sauf"],
"YGt-0e": ["Lecture…"],
+ "YHOIrR": ["Recherche de mises à jour…"],
"YJ1BTp": ["Une compétence portant ce nom existe déjà."],
"YJPN3F": ["Trop lent"],
"YKLP_-": ["Modèle renommé"],
diff --git a/packages/app/src/locales/fr/messages.po b/packages/app/src/locales/fr/messages.po
index 499188b0b..51645e116 100644
--- a/packages/app/src/locales/fr/messages.po
+++ b/packages/app/src/locales/fr/messages.po
@@ -2578,6 +2578,10 @@ msgstr "Recherche de mises à jour"
msgid "Checking for updates on GitHub"
msgstr "Recherche de mises à jour sur GitHub"
+#: src/components/UpdateNotices.shared.ts
+msgid "Checking for updates…"
+msgstr "Recherche de mises à jour…"
+
#: src/components/ShareReceiveDialog.tsx
msgid "Checking GitHub connection..."
msgstr "Vérification de la connexion GitHub…"
diff --git a/packages/app/src/locales/hi/messages.json b/packages/app/src/locales/hi/messages.json
index 8ef246805..3a30b01b2 100644
--- a/packages/app/src/locales/hi/messages.json
+++ b/packages/app/src/locales/hi/messages.json
@@ -2625,6 +2625,7 @@
"YGIi_c": ["फिर से इंस्टॉल करें"],
"YGNRB5": ["— सिवाय"],
"YGt-0e": ["पढ़ा जा रहा है…"],
+ "YHOIrR": ["अपडेट देखे जा रहे हैं…"],
"YJ1BTp": ["उस नाम की एक स्किल पहले से मौजूद है।"],
"YJPN3F": ["बहुत धीमा"],
"YKLP_-": ["टेम्पलेट का नाम बदला गया"],
diff --git a/packages/app/src/locales/hi/messages.po b/packages/app/src/locales/hi/messages.po
index fb7581c89..9a55eec28 100644
--- a/packages/app/src/locales/hi/messages.po
+++ b/packages/app/src/locales/hi/messages.po
@@ -2574,6 +2574,10 @@ msgstr "अपडेट देखे जा रहे हैं"
msgid "Checking for updates on GitHub"
msgstr "GitHub पर अपडेट देखे जा रहे हैं"
+#: src/components/UpdateNotices.shared.ts
+msgid "Checking for updates…"
+msgstr "अपडेट देखे जा रहे हैं…"
+
#: src/components/ShareReceiveDialog.tsx
msgid "Checking GitHub connection..."
msgstr "GitHub कनेक्शन जाँचा जा रहा है…"
diff --git a/packages/app/src/locales/id/messages.json b/packages/app/src/locales/id/messages.json
index 20d4f61fa..9b7952384 100644
--- a/packages/app/src/locales/id/messages.json
+++ b/packages/app/src/locales/id/messages.json
@@ -2716,6 +2716,7 @@
"YGIi_c": ["Pasang ulang"],
"YGNRB5": ["— kecuali"],
"YGt-0e": ["Membaca…"],
+ "YHOIrR": ["Memeriksa pembaruan…"],
"YJ1BTp": ["Keterampilan dengan nama itu sudah ada."],
"YJPN3F": ["Terlalu lambat"],
"YKLP_-": ["Nama templat diganti"],
diff --git a/packages/app/src/locales/id/messages.po b/packages/app/src/locales/id/messages.po
index 1bda5187c..9ed28714b 100644
--- a/packages/app/src/locales/id/messages.po
+++ b/packages/app/src/locales/id/messages.po
@@ -2574,6 +2574,10 @@ msgstr "Memeriksa pembaruan"
msgid "Checking for updates on GitHub"
msgstr "Memeriksa pembaruan di GitHub"
+#: src/components/UpdateNotices.shared.ts
+msgid "Checking for updates…"
+msgstr "Memeriksa pembaruan…"
+
#: src/components/ShareReceiveDialog.tsx
msgid "Checking GitHub connection..."
msgstr "Memeriksa koneksi GitHub..."
diff --git a/packages/app/src/locales/ko/messages.json b/packages/app/src/locales/ko/messages.json
index 1ceedf691..b4df96f60 100644
--- a/packages/app/src/locales/ko/messages.json
+++ b/packages/app/src/locales/ko/messages.json
@@ -2614,6 +2614,7 @@
"YGIi_c": ["재설치"],
"YGNRB5": ["제외"],
"YGt-0e": ["읽는 중…"],
+ "YHOIrR": ["업데이트 확인 중…"],
"YJ1BTp": ["같은 이름의 스킬이 이미 있습니다."],
"YJPN3F": ["너무 느림"],
"YKLP_-": ["템플릿 이름 변경됨"],
diff --git a/packages/app/src/locales/ko/messages.po b/packages/app/src/locales/ko/messages.po
index a1a6f835d..9b9861fe3 100644
--- a/packages/app/src/locales/ko/messages.po
+++ b/packages/app/src/locales/ko/messages.po
@@ -2578,6 +2578,10 @@ msgstr "업데이트 확인 중"
msgid "Checking for updates on GitHub"
msgstr "GitHub에서 업데이트 확인 중"
+#: src/components/UpdateNotices.shared.ts
+msgid "Checking for updates…"
+msgstr "업데이트 확인 중…"
+
#: src/components/ShareReceiveDialog.tsx
msgid "Checking GitHub connection..."
msgstr "GitHub 연결 확인 중…"
diff --git a/packages/app/src/locales/pseudo/messages.json b/packages/app/src/locales/pseudo/messages.json
index 54f75e015..7d1731f0e 100644
--- a/packages/app/src/locales/pseudo/messages.json
+++ b/packages/app/src/locales/pseudo/messages.json
@@ -2694,6 +2694,7 @@
"YGIi_c": ["Ŕēĩńśţàĺĺ"],
"YGNRB5": ["— ēxćēƥţ"],
"YGt-0e": ["Ŕēàďĩńĝ…"],
+ "YHOIrR": ["Ćĥēćķĩńĝ ƒōŕ ũƥďàţēś…"],
"YJ1BTp": ["À śķĩĺĺ ŵĩţĥ ţĥàţ ńàḿē àĺŕēàďŷ ēxĩśţś."],
"YJPN3F": ["Ţōō śĺōŵ"],
"YKLP_-": ["Ţēḿƥĺàţē ŕēńàḿēď"],
diff --git a/packages/app/src/locales/pseudo/messages.po b/packages/app/src/locales/pseudo/messages.po
index 536a3d504..fc5e62c22 100644
--- a/packages/app/src/locales/pseudo/messages.po
+++ b/packages/app/src/locales/pseudo/messages.po
@@ -2574,6 +2574,10 @@ msgstr ""
msgid "Checking for updates on GitHub"
msgstr ""
+#: src/components/UpdateNotices.shared.ts
+msgid "Checking for updates…"
+msgstr ""
+
#: src/components/ShareReceiveDialog.tsx
msgid "Checking GitHub connection..."
msgstr ""
diff --git a/packages/app/src/locales/pt-BR/messages.json b/packages/app/src/locales/pt-BR/messages.json
index ca2a6db44..59902974d 100644
--- a/packages/app/src/locales/pt-BR/messages.json
+++ b/packages/app/src/locales/pt-BR/messages.json
@@ -3078,6 +3078,7 @@
"YGIi_c": ["Reinstalar"],
"YGNRB5": ["— exceto"],
"YGt-0e": ["Lendo…"],
+ "YHOIrR": ["Buscando atualizações…"],
"YJ1BTp": ["Já existe uma habilidade com esse nome."],
"YJPN3F": ["Lento demais"],
"YKLP_-": ["Modelo renomeado"],
diff --git a/packages/app/src/locales/pt-BR/messages.po b/packages/app/src/locales/pt-BR/messages.po
index 6cfe2a5ae..e840885fa 100644
--- a/packages/app/src/locales/pt-BR/messages.po
+++ b/packages/app/src/locales/pt-BR/messages.po
@@ -2574,6 +2574,10 @@ msgstr "Buscando atualizações"
msgid "Checking for updates on GitHub"
msgstr "Buscando atualizações no GitHub"
+#: src/components/UpdateNotices.shared.ts
+msgid "Checking for updates…"
+msgstr "Buscando atualizações…"
+
#: src/components/ShareReceiveDialog.tsx
msgid "Checking GitHub connection..."
msgstr "Verificando a conexão com o GitHub..."
diff --git a/packages/app/src/locales/ur/messages.json b/packages/app/src/locales/ur/messages.json
index e376eafdf..898c747d3 100644
--- a/packages/app/src/locales/ur/messages.json
+++ b/packages/app/src/locales/ur/messages.json
@@ -2760,6 +2760,7 @@
"YGIi_c": ["دوبارہ نصب کریں"],
"YGNRB5": ["— سوائے"],
"YGt-0e": ["پڑھا جا رہا ہے…"],
+ "YHOIrR": ["اپ ڈیٹس دیکھے جا رہے ہیں…"],
"YJ1BTp": ["اس نام کی مہارت پہلے سے موجود ہے۔"],
"YJPN3F": ["بہت سست"],
"YKLP_-": ["ٹیمپلیٹ کا نام بدل گیا"],
diff --git a/packages/app/src/locales/ur/messages.po b/packages/app/src/locales/ur/messages.po
index ff7d4cb0f..2b5a1f256 100644
--- a/packages/app/src/locales/ur/messages.po
+++ b/packages/app/src/locales/ur/messages.po
@@ -2578,6 +2578,10 @@ msgstr "اپ ڈیٹس دیکھے جا رہے ہیں"
msgid "Checking for updates on GitHub"
msgstr "GitHub پر اپ ڈیٹس دیکھے جا رہے ہیں"
+#: src/components/UpdateNotices.shared.ts
+msgid "Checking for updates…"
+msgstr "اپ ڈیٹس دیکھے جا رہے ہیں…"
+
#: src/components/ShareReceiveDialog.tsx
msgid "Checking GitHub connection..."
msgstr "GitHub کنکشن جانچا جا رہا ہے..."
diff --git a/packages/app/src/locales/zh-Hans/messages.json b/packages/app/src/locales/zh-Hans/messages.json
index 1731486a7..148be7ed3 100644
--- a/packages/app/src/locales/zh-Hans/messages.json
+++ b/packages/app/src/locales/zh-Hans/messages.json
@@ -2383,6 +2383,7 @@
"YGIi_c": ["重新安装"],
"YGNRB5": ["— 除了"],
"YGt-0e": ["正在阅读…"],
+ "YHOIrR": ["正在检查更新…"],
"YJ1BTp": ["同名技能已存在。"],
"YJPN3F": ["太慢了"],
"YKLP_-": ["模板已重命名"],
diff --git a/packages/app/src/locales/zh-Hans/messages.po b/packages/app/src/locales/zh-Hans/messages.po
index e6bb51b3d..fe1ec5bc3 100644
--- a/packages/app/src/locales/zh-Hans/messages.po
+++ b/packages/app/src/locales/zh-Hans/messages.po
@@ -2578,6 +2578,10 @@ msgstr "正在检查更新"
msgid "Checking for updates on GitHub"
msgstr "正在 GitHub 上检查更新"
+#: src/components/UpdateNotices.shared.ts
+msgid "Checking for updates…"
+msgstr "正在检查更新…"
+
#: src/components/ShareReceiveDialog.tsx
msgid "Checking GitHub connection..."
msgstr "正在检查 GitHub 连接…"
diff --git a/packages/app/src/locales/zh-Hant/messages.json b/packages/app/src/locales/zh-Hant/messages.json
index a57b4ebce..56f4c8337 100644
--- a/packages/app/src/locales/zh-Hant/messages.json
+++ b/packages/app/src/locales/zh-Hant/messages.json
@@ -2409,6 +2409,7 @@
"YGIi_c": ["重新安裝"],
"YGNRB5": ["— 除了"],
"YGt-0e": ["閱讀中…"],
+ "YHOIrR": ["正在檢查更新…"],
"YJ1BTp": ["同名的技能已存在。"],
"YJPN3F": ["太慢了"],
"YKLP_-": ["範本已重新命名"],
diff --git a/packages/app/src/locales/zh-Hant/messages.po b/packages/app/src/locales/zh-Hant/messages.po
index f3d7d76aa..97cb0d348 100644
--- a/packages/app/src/locales/zh-Hant/messages.po
+++ b/packages/app/src/locales/zh-Hant/messages.po
@@ -2578,6 +2578,10 @@ msgstr "正在檢查更新"
msgid "Checking for updates on GitHub"
msgstr "正在 GitHub 上檢查更新"
+#: src/components/UpdateNotices.shared.ts
+msgid "Checking for updates…"
+msgstr "正在檢查更新…"
+
#: src/components/ShareReceiveDialog.tsx
msgid "Checking GitHub connection..."
msgstr "正在檢查 GitHub 連線…"
diff --git a/packages/app/tests/stress/file-tree-create.e2e.ts b/packages/app/tests/stress/file-tree-create.e2e.ts
index d5d62857d..a8f617f8c 100644
--- a/packages/app/tests/stress/file-tree-create.e2e.ts
+++ b/packages/app/tests/stress/file-tree-create.e2e.ts
@@ -191,6 +191,7 @@ async function installDelayedDesktopSessionBridge(
return raw ? JSON.parse(raw) : { ...initialSession, updatedAt: '2026-05-08T00:00:00.000Z' };
};
const unsubscribe = () => {};
+ // STOP: this fixture must implement every OkDesktopBridge member main.tsx invokes at boot; it is outside packages/app/tsconfig.json include, so nothing typechecks it.
const okDesktop = {
appVersion: 'test',
platform: 'darwin',
@@ -210,6 +211,7 @@ async function installDelayedDesktopSessionBridge(
onWhatsNew: () => unsubscribe,
onWhatsNewDismissed: () => unsubscribe,
onUpdateStuckHint: () => unsubscribe,
+ onUpdateManualCheck: () => unsubscribe,
onDeepLink: () => unsubscribe,
onShareReceived: () => unsubscribe,
onServerVersionDrift: () => unsubscribe,
diff --git a/packages/app/tests/stress/fixtures/handoff-mocks.ts b/packages/app/tests/stress/fixtures/handoff-mocks.ts
index 1b46904ac..620e32734 100644
--- a/packages/app/tests/stress/fixtures/handoff-mocks.ts
+++ b/packages/app/tests/stress/fixtures/handoff-mocks.ts
@@ -368,6 +368,7 @@ export async function installHandoffMocks(page: Page, cfg: HandoffMockConfig): P
onWhatsNew: () => () => {},
onWhatsNewDismissed: () => () => {},
onUpdateStuckHint: () => () => {},
+ onUpdateManualCheck: () => () => {},
onDeepLink: () => () => {},
onShareReceived: () => () => {},
onServerVersionDrift: () => () => {},
diff --git a/packages/core/src/constants/manual-update-check.ts b/packages/core/src/constants/manual-update-check.ts
new file mode 100644
index 000000000..df35f57b1
--- /dev/null
+++ b/packages/core/src/constants/manual-update-check.ts
@@ -0,0 +1,2 @@
+export const MANUAL_CHECK_WATCHDOG_MS = 240_000;
+export const MANUAL_CHECK_NOTICE_EXPIRY_MS = MANUAL_CHECK_WATCHDOG_MS + 60_000;
diff --git a/packages/core/src/desktop-bridge.ts b/packages/core/src/desktop-bridge.ts
index 39d85ed9d..2ef4eedff 100644
--- a/packages/core/src/desktop-bridge.ts
+++ b/packages/core/src/desktop-bridge.ts
@@ -260,6 +260,10 @@ export interface OkUpdateStuckHintInfo {
readonly downloadUrl: string;
}
+export interface OkUpdateManualCheckInfo {
+ readonly phase: 'started' | 'settled';
+}
+
export type ShareTarget =
| { readonly kind: 'doc'; readonly docPath: string }
| { readonly kind: 'folder'; readonly folderPath: string };
@@ -900,6 +904,7 @@ export interface OkDesktopBridge {
onWhatsNew(cb: (info: OkWhatsNewInfo) => void): OkUnsubscribe;
onWhatsNewDismissed(cb: (info: { readonly version: string }) => void): OkUnsubscribe;
onUpdateStuckHint(cb: (info: OkUpdateStuckHintInfo) => void): OkUnsubscribe;
+ onUpdateManualCheck(cb: (info: OkUpdateManualCheckInfo) => void): OkUnsubscribe;
onDeepLink(
cb: (evt: {
doc: string;
diff --git a/packages/core/src/index.ts b/packages/core/src/index.ts
index 507375557..ff6ab74bf 100644
--- a/packages/core/src/index.ts
+++ b/packages/core/src/index.ts
@@ -443,6 +443,10 @@ export {
sliceLastSpawnAttempt,
spawnErrorLogOpenMode,
} from './constants/lifecycle.ts';
+export {
+ MANUAL_CHECK_NOTICE_EXPIRY_MS,
+ MANUAL_CHECK_WATCHDOG_MS,
+} from './constants/manual-update-check.ts';
export {
GREP_MAX_RESULTS,
MCP_SERVER_NAME,
diff --git a/packages/desktop/src/main/auto-updater.ts b/packages/desktop/src/main/auto-updater.ts
index 0699f1cf0..bc2259f5d 100644
--- a/packages/desktop/src/main/auto-updater.ts
+++ b/packages/desktop/src/main/auto-updater.ts
@@ -1,4 +1,5 @@
import type { OutgoingHttpHeaders } from 'node:http';
+import { MANUAL_CHECK_WATCHDOG_MS } from '@inkeep/open-knowledge-core';
import type { IpcMain, IpcMainInvokeEvent } from 'electron';
import type { EventChannels } from '../shared/ipc-events.ts';
import { createHandler } from '../shared/ipc-handler.ts';
@@ -87,6 +88,8 @@ export type DispatchKind =
| 'relaunch-refresh-timed-out'
| 'relaunch-awaited-in-flight-staging'
| 'relaunch-double-invoke-blocked'
+ | 'check-now-already-pending'
+ | 'check-now-watchdog-fired'
| 'toast-a-deferred-post-update-quiet'
| 'toast-a-quiet-window-elapsed';
@@ -162,6 +165,9 @@ export const UPDATE_CHECK_JITTER_MS = 5 * 60 * 1000;
export const RELAUNCH_WATCHDOG_MS = 15_000;
+export const MANUAL_CHECK_TIMED_OUT_MESSAGE =
+ 'The update check took too long to respond. Check your connection and try again.';
+
export const STUCK_HINT_THRESHOLD_MS = 7 * 24 * 60 * 60 * 1000;
export const INSTALL_FAILURE_MAX_SURFACES = 3;
@@ -505,7 +511,24 @@ export function startAutoUpdater(opts: StartAutoUpdaterOpts): StartAutoUpdaterHa
logger.info('checking-for-update');
};
- let menuCheckPending = false;
+ let menuCheck: { watchdog: ReturnType<typeof setTimeout> } | null = null;
+
+ const settleMenuCheck = (result: CheckNowResult | null): void => {
+ if (menuCheck === null) return;
+ clock.clearTimeout(menuCheck.watchdog);
+ menuCheck = null;
+ broadcastToAllWindows('ok:update:manual-check', { phase: 'settled' });
+ if (result !== null) {
+ try {
+ showCheckNowResult?.(result);
+ } catch (err) {
+ logger.error('showCheckNowResult threw, check-now result dialog not shown', {
+ err,
+ result,
+ });
+ }
+ }
+ };
let relaunchInFlight: {
version: string;
@@ -636,21 +659,41 @@ export function startAutoUpdater(opts: StartAutoUpdaterOpts): StartAutoUpdaterHa
let activeWhatsNew: { version: string; releaseUrl: string; firedAt: number } | null = null;
const runMenuDrivenCheck = (): Promise<unknown> => {
- menuCheckPending = true;
+ broadcastToAllWindows('ok:update:manual-check', { phase: 'started' });
+ if (menuCheck !== null) {
+ logger.info('check-now already pending, re-acknowledged');
+ onDispatch?.('check-now-already-pending');
+ return Promise.resolve(undefined);
+ }
+ menuCheck = {
+ watchdog: clock.setTimeout(() => {
+ if (menuCheck === null) return;
+ logger.warn('check-now did not settle within the watchdog window', {
+ ms: MANUAL_CHECK_WATCHDOG_MS,
+ });
+ onDispatch?.('check-now-watchdog-fired');
+ settleMenuCheck({ kind: 'error', message: MANUAL_CHECK_TIMED_OUT_MESSAGE });
+ }, MANUAL_CHECK_WATCHDOG_MS),
+ };
const checkPromise = updater.checkForUpdates();
- void checkPromise.catch((err: unknown) => {
- const code = err instanceof Error ? (err as Error & { code?: unknown }).code : undefined;
- const logFn = isClassifiedUpdaterError(err) ? logger.warn : logger.debug;
- logFn('check-now checkForUpdates rejected', {
- code,
- err,
- timestamp: now().toISOString(),
+ void checkPromise
+ .then(() => {
+ // UPSTREAM([email protected]): checkForUpdates emits its verdict event before its promise resolves, so a check still pending at resolve time produced no verdict; an inactive dev updater resolves the same way.
+ if (menuCheck !== null) {
+ logger.info('check-now resolved without a verdict');
+ settleMenuCheck(null);
+ }
+ })
+ .catch((err: unknown) => {
+ const code = err instanceof Error ? (err as Error & { code?: unknown }).code : undefined;
+ const logFn = isClassifiedUpdaterError(err) ? logger.warn : logger.debug;
+ logFn('check-now checkForUpdates rejected', {
+ code,
+ err,
+ timestamp: now().toISOString(),
+ });
+ settleMenuCheck(buildCheckNowResultFromError(err, getAppVersion()));
});
- if (menuCheckPending) {
- menuCheckPending = false;
- showCheckNowResult?.(buildCheckNowResultFromError(err, getAppVersion()));
- }
- });
return checkPromise;
};
@@ -721,22 +764,21 @@ export function startAutoUpdater(opts: StartAutoUpdaterOpts): StartAutoUpdaterHa
};
const onUpdateAvailableForMenuCheck = (info: { version?: string }): void => {
- if (!menuCheckPending) return;
- menuCheckPending = false;
+ if (menuCheck === null) return;
if (classifyOffer(info.version) !== 'same-channel') {
- showCheckNowResult?.({ kind: 'not-available', currentVersion: getAppVersion() });
+ settleMenuCheck({ kind: 'not-available', currentVersion: getAppVersion() });
return;
}
const armedVersion = declinedForStagedVersion(info.version);
if (armedVersion !== null) {
- showCheckNowResult?.({
+ settleMenuCheck({
kind: 'ready-to-install',
currentVersion: getAppVersion(),
stagedVersion: armedVersion,
});
return;
}
- showCheckNowResult?.({
+ settleMenuCheck({
kind: 'available',
currentVersion: getAppVersion(),
latestVersion: typeof info.version === 'string' ? info.version : 'unknown',
@@ -747,13 +789,10 @@ export function startAutoUpdater(opts: StartAutoUpdaterOpts): StartAutoUpdaterHa
logger.info('update-not-available', { version: info.version });
markCheckSucceeded();
settleCheckWaiters('settled');
- if (menuCheckPending) {
- menuCheckPending = false;
- showCheckNowResult?.({
- kind: 'not-available',
- currentVersion: getAppVersion(),
- });
- }
+ settleMenuCheck({
+ kind: 'not-available',
+ currentVersion: getAppVersion(),
+ });
};
const onDownloadProgress = (info: { percent?: number; bytesPerSecond?: number }): void => {
@@ -872,10 +911,7 @@ export function startAutoUpdater(opts: StartAutoUpdaterOpts): StartAutoUpdaterHa
offerManualInstallFallback(failedVersion, 'linux-manual-fallback-after-error');
}
}
- if (menuCheckPending) {
- menuCheckPending = false;
- showCheckNowResult?.(buildCheckNowResultFromError(err, getAppVersion()));
- }
+ settleMenuCheck(buildCheckNowResultFromError(err, getAppVersion()));
maybeFireStuckHint();
};
@@ -1439,6 +1475,7 @@ export function startAutoUpdater(opts: StartAutoUpdaterOpts): StartAutoUpdaterHa
clock.clearTimeout(quietWindowTimer);
quietWindowTimer = null;
}
+ settleMenuCheck(null);
settleCheckWaiters('settled');
stagingInFlight = null;
settleStagingWaiters(false);
diff --git a/packages/desktop/src/preload/index.ts b/packages/desktop/src/preload/index.ts
index c64a13cc0..37b5967f5 100644
--- a/packages/desktop/src/preload/index.ts
+++ b/packages/desktop/src/preload/index.ts
@@ -48,6 +48,7 @@ import type {
OkThemeSource,
OkUpdateDownloadedInfo,
OkUpdateFetchingLatestInfo,
+ OkUpdateManualCheckInfo,
OkUpdateRelaunchFailedInfo,
OkUpdateRelaunchingInfo,
OkUpdateStuckHintInfo,
@@ -395,6 +396,13 @@ const bridge: OkDesktopBridge = {
return () => ipcRenderer.removeListener('ok:update:stuck-hint', listener);
},
+ onUpdateManualCheck(cb: (info: OkUpdateManualCheckInfo) => void) {
+ const listener = (_event: IpcRendererEvent, info: OkUpdateManualCheckInfo) => cb(info);
+ // biome-ignore lint/plugin/no-loosely-typed-webcontents-ipc: preload-side subscription wrapper (precedent #14)
+ ipcRenderer.on('ok:update:manual-check', listener);
+ return () => ipcRenderer.removeListener('ok:update:manual-check', listener);
+ },
+
onDeepLink(
cb: (evt: {
doc: string;
diff --git a/packages/desktop/src/shared/ipc-events.ts b/packages/desktop/src/shared/ipc-events.ts
index a14dfa650..0bd8103d2 100644
--- a/packages/desktop/src/shared/ipc-events.ts
+++ b/packages/desktop/src/shared/ipc-events.ts
@@ -40,6 +40,7 @@ export interface EventChannels {
'ok:update:whats-new': { payload: { version: string; releaseUrl: string } };
'ok:update:whats-new-dismissed': { payload: { version: string } };
'ok:update:stuck-hint': { payload: { downloadUrl: string } };
+ 'ok:update:manual-check': { payload: { phase: 'started' | 'settled' } };
'ok:deep-link': {
payload: {
doc: string;
diff --git a/packages/desktop/tests/integration/auto-updater.test.ts b/packages/desktop/tests/integration/auto-updater.test.ts
index a45c35734..0c593b21c 100644
--- a/packages/desktop/tests/integration/auto-updater.test.ts
+++ b/packages/desktop/tests/integration/auto-updater.test.ts
@@ -3,6 +3,7 @@ import { readdirSync, readFileSync } from 'node:fs';
import type { OutgoingHttpHeaders } from 'node:http';
import { dirname, join } from 'node:path';
import { fileURLToPath } from 'node:url';
+import { MANUAL_CHECK_WATCHDOG_MS } from '@inkeep/open-knowledge-core';
import { describe, expect, test, vi } from 'vitest';
import {
bootAutoUpdater,
@@ -12,6 +13,7 @@ import {
type IpcMainLike,
installReached,
isClassifiedUpdaterError,
+ MANUAL_CHECK_TIMED_OUT_MESSAGE,
POST_UPDATE_QUIET_MS,
RELAUNCH_REFRESH_CHECK_MS,
RELAUNCH_REFRESH_DOWNLOAD_MS,
@@ -105,6 +107,12 @@ function makeFakeWindow(captured: CapturedSend[]): SendTarget {
};
}
+function manualCheckPhases(rig: TestRig): Array<'started' | 'settled'> {
+ return rig.captured
+ .filter((entry) => entry.channel === 'ok:update:manual-check')
+ .map((entry) => (entry.payload as { phase: 'started' | 'settled' }).phase);
+}
+
interface FakeClock {
setTimeout: ReturnType<typeof vi.fn>;
clearTimeout: ReturnType<typeof vi.fn>;
@@ -2213,6 +2221,20 @@ describe('versionAtLeast (MMP compare)', () => {
});
describe('multi-window delivery: relaunch banner and "updated to" notice both reach every window', () => {
+ test('manual check started and settled phases reach every open window', async () => {
+ const { rig } = makeRig({ extraWindowCount: 2 });
+ expect(rig.windows).toHaveLength(3);
+ rig.ipc.invoke('ok:update:check-now');
+ rig.updater.emit('update-not-available', { version: '0.3.1' });
+ await new Promise((resolve) => setTimeout(resolve, 0));
+ for (const win of rig.windows) {
+ const phases = win
+ .filter((entry) => entry.channel === 'ok:update:manual-check')
+ .map((entry) => (entry.payload as { phase: 'started' | 'settled' }).phase);
+ expect(phases).toEqual(['started', 'settled']);
+ }
+ });
+
test('ok:update:downloaded (relaunch banner) reaches every open window', () => {
const { rig } = makeRig({ extraWindowCount: 2 });
expect(rig.windows).toHaveLength(3);
@@ -2826,6 +2848,22 @@ describe('ok:update:check-now IPC handler', () => {
expect(rig.updater.checkForUpdates).toHaveBeenCalledTimes(1);
});
+ test('a second invocation while pending re-acknowledges without starting another check', () => {
+ const { rig } = makeRig();
+ rig.updater.checkForUpdates = vi.fn(() => new Promise(() => {}));
+ rig.updater.checkForUpdates.mockClear();
+
+ rig.ipc.invoke('ok:update:check-now');
+ rig.ipc.invoke('ok:update:check-now');
+
+ expect(rig.updater.checkForUpdates).toHaveBeenCalledTimes(1);
+ expect(manualCheckPhases(rig)).toEqual(['started', 'started']);
+ expect(rig.dispatches.filter((kind) => kind === 'check-now-already-pending')).toEqual([
+ 'check-now-already-pending',
+ ]);
+ expect(rig.logger.info).toHaveBeenCalledWith('check-now already pending, re-acknowledged');
+ });
+
test('handler invocation does NOT gate on versionPendingInstall', () => {
const { rig } = makeRig({ versionPendingInstall: null });
rig.updater.checkForUpdates.mockClear();
@@ -2854,44 +2892,187 @@ describe('ok:update:check-now IPC handler', () => {
});
describe('check-now → showCheckNowResult feedback dispatch', () => {
- test('update-not-available after menu-check fires not-available result', () => {
+ test.each([
+ 'update-available',
+ 'update-not-available',
+ 'error',
+ 'resolve',
+ 'reject',
+ ] as const)('%s clears the manual watchdog and prevents a later timeout dialog', async (outcome) => {
+ const showCheckNowResult = vi.fn(() => {});
+ const { rig } = makeRig({ showCheckNowResult, isPackaged: false });
+ rig.updater.checkForUpdates = vi.fn(() =>
+ outcome === 'reject'
+ ? Promise.reject(new Error('network unavailable'))
+ : Promise.resolve(null),
+ );
+ rig.ipc.invoke('ok:update:check-now');
+ const watchdog = rig.clock.lastCallback;
+ const watchdogHandle = rig.clock.lastHandle;
+ expect(rig.clock.lastMs).toBe(MANUAL_CHECK_WATCHDOG_MS);
+ expect(watchdog).not.toBeNull();
+
+ if (outcome === 'error') rig.updater.emit('error', new Error('network unavailable'));
+ else if (outcome !== 'resolve' && outcome !== 'reject') {
+ rig.updater.emit(outcome, { version: '0.3.2' });
+ }
+ await new Promise((resolve) => setTimeout(resolve, 0));
+ expect(rig.clock.clearTimeout).toHaveBeenCalledWith(watchdogHandle);
+ expect(manualCheckPhases(rig)).toEqual(['started', 'settled']);
+ expect(showCheckNowResult).toHaveBeenCalledTimes(outcome === 'resolve' ? 0 : 1);
+ showCheckNowResult.mockClear();
+ watchdog?.();
+ expect(showCheckNowResult).not.toHaveBeenCalled();
+ expect(manualCheckPhases(rig)).toEqual(['started', 'settled']);
+ });
+
+ test('destroy clears a pending manual watchdog without showing a dialog', () => {
+ const showCheckNowResult = vi.fn(() => {});
+ const { rig, handle } = makeRig({ showCheckNowResult, isPackaged: false });
+ rig.updater.checkForUpdates = vi.fn(() => new Promise(() => {}));
+ rig.ipc.invoke('ok:update:check-now');
+ const watchdog = rig.clock.lastCallback;
+ const watchdogHandle = rig.clock.lastHandle;
+ handle.destroy();
+ expect(rig.clock.clearTimeout).toHaveBeenCalledWith(watchdogHandle);
+ expect(manualCheckPhases(rig)).toEqual(['started', 'settled']);
+ watchdog?.();
+ expect(showCheckNowResult).not.toHaveBeenCalled();
+ });
+
+ test('a throwing result dialog does not escape the verdict event or prevent settlement', () => {
+ const dialogError = new Error('native dialog unavailable');
+ const { rig } = makeRig({
+ isPackaged: false,
+ showCheckNowResult: () => {
+ throw dialogError;
+ },
+ });
+ rig.ipc.invoke('ok:update:check-now');
+ const watchdogHandle = rig.clock.lastHandle;
+
+ expect(() => rig.updater.emit('update-not-available', { version: '0.3.1' })).not.toThrow();
+ expect(manualCheckPhases(rig)).toEqual(['started', 'settled']);
+ expect(rig.clock.clearTimeout).toHaveBeenCalledWith(watchdogHandle);
+ expect(rig.logger.error).toHaveBeenCalledWith(
+ 'showCheckNowResult threw, check-now result dialog not shown',
+ { err: dialogError, result: { kind: 'not-available', currentVersion: '0.3.1' } },
+ );
+ });
+
+ test('the manual watchdog settles a hung check with an error and does not re-arm on re-click', () => {
+ const showCheckNowResult = vi.fn(() => {});
+ const { rig } = makeRig({ showCheckNowResult, isPackaged: false });
+ rig.updater.checkForUpdates = vi.fn(() => new Promise(() => {}));
+
+ rig.ipc.invoke('ok:update:check-now');
+ expect(rig.clock.lastMs).toBe(MANUAL_CHECK_WATCHDOG_MS);
+ const watchdog = rig.clock.lastCallback;
+ const watchdogHandle = rig.clock.lastHandle;
+ expect(watchdog).not.toBeNull();
+ rig.ipc.invoke('ok:update:check-now');
+ expect(rig.clock.setTimeout).toHaveBeenCalledTimes(1);
+ expect(showCheckNowResult).not.toHaveBeenCalled();
+
+ watchdog?.();
+ expect(manualCheckPhases(rig)).toEqual(['started', 'started', 'settled']);
+ expect(rig.clock.clearTimeout).toHaveBeenCalledWith(watchdogHandle);
+ expect(showCheckNowResult).toHaveBeenCalledExactlyOnceWith({
+ kind: 'error',
+ message: MANUAL_CHECK_TIMED_OUT_MESSAGE,
+ });
+ expect(rig.logger.warn).toHaveBeenCalledWith(
+ 'check-now did not settle within the watchdog window',
+ { ms: MANUAL_CHECK_WATCHDOG_MS },
+ );
+ expect(rig.dispatches).toContain('check-now-watchdog-fired');
+ rig.ipc.invoke('ok:update:check-now');
+ expect(rig.updater.checkForUpdates).toHaveBeenCalledTimes(2);
+ expect(manualCheckPhases(rig)).toEqual(['started', 'started', 'settled', 'started']);
+ });
+
+ test('a verdict-less check settles silently and allows another manual check', async () => {
+ const showCheckNowResult = vi.fn(() => {});
+ const { rig } = makeRig({ showCheckNowResult });
+ rig.updater.checkForUpdates = vi.fn(() => Promise.resolve(null));
+
+ rig.ipc.invoke('ok:update:check-now');
+ expect(manualCheckPhases(rig)).toEqual(['started']);
+ await new Promise((resolve) => setTimeout(resolve, 0));
+ expect(manualCheckPhases(rig)).toEqual(['started', 'settled']);
+ expect(showCheckNowResult).not.toHaveBeenCalled();
+
+ rig.ipc.invoke('ok:update:check-now');
+ expect(rig.updater.checkForUpdates).toHaveBeenCalledTimes(2);
+ expect(manualCheckPhases(rig)).toEqual(['started', 'settled', 'started']);
+ await new Promise((resolve) => setTimeout(resolve, 0));
+ expect(manualCheckPhases(rig)).toEqual(['started', 'settled', 'started', 'settled']);
+ expect(showCheckNowResult).not.toHaveBeenCalled();
+ expect(rig.logger.info).toHaveBeenCalledWith('check-now resolved without a verdict');
+ });
+
+ test('update-not-available after menu-check fires not-available result', async () => {
const showCheckNowResult = vi.fn(() => {});
const { rig } = makeRig({ appVersion: '0.4.0-beta.13', showCheckNowResult });
+ let phasesAtDialog: Array<'started' | 'settled'> = [];
+ showCheckNowResult.mockImplementation(() => {
+ phasesAtDialog = manualCheckPhases(rig);
+ });
rig.ipc.invoke('ok:update:check-now');
+ expect(manualCheckPhases(rig)).toEqual(['started']);
rig.updater.emit('update-not-available', { version: '0.4.0-beta.13' });
+ await new Promise((resolve) => setTimeout(resolve, 0));
+ expect(phasesAtDialog).toEqual(['started', 'settled']);
expect(showCheckNowResult).toHaveBeenCalledTimes(1);
expect(showCheckNowResult).toHaveBeenCalledWith({
kind: 'not-available',
currentVersion: '0.4.0-beta.13',
});
+ expect(manualCheckPhases(rig)).toEqual(['started', 'settled']);
});
- test('update-available after menu-check fires available result with versions', () => {
+ test('update-available after menu-check fires available result with versions', async () => {
const showCheckNowResult = vi.fn(() => {});
const { rig } = makeRig({
appVersion: '0.4.0-beta.13',
showCheckNowResult,
});
+ let phasesAtDialog: Array<'started' | 'settled'> = [];
+ showCheckNowResult.mockImplementation(() => {
+ phasesAtDialog = manualCheckPhases(rig);
+ });
rig.ipc.invoke('ok:update:check-now');
+ expect(manualCheckPhases(rig)).toEqual(['started']);
rig.updater.emit('update-available', { version: '0.4.0-beta.14' });
+ await new Promise((resolve) => setTimeout(resolve, 0));
+ expect(phasesAtDialog).toEqual(['started', 'settled']);
expect(showCheckNowResult).toHaveBeenCalledTimes(1);
expect(showCheckNowResult).toHaveBeenCalledWith({
kind: 'available',
currentVersion: '0.4.0-beta.13',
latestVersion: '0.4.0-beta.14',
});
+ expect(manualCheckPhases(rig)).toEqual(['started', 'settled']);
});
- test('error after menu-check fires error result with the message', () => {
+ test('error after menu-check fires error result with the message', async () => {
const showCheckNowResult = vi.fn(() => {});
const { rig } = makeRig({ showCheckNowResult });
+ let phasesAtDialog: Array<'started' | 'settled'> = [];
+ showCheckNowResult.mockImplementation(() => {
+ phasesAtDialog = manualCheckPhases(rig);
+ });
rig.ipc.invoke('ok:update:check-now');
+ expect(manualCheckPhases(rig)).toEqual(['started']);
rig.updater.emit('error', new Error('network timeout'));
+ await new Promise((resolve) => setTimeout(resolve, 0));
+ expect(phasesAtDialog).toEqual(['started', 'settled']);
expect(showCheckNowResult).toHaveBeenCalledTimes(1);
expect(showCheckNowResult).toHaveBeenCalledWith({
kind: 'error',
message: 'network timeout',
});
+ expect(manualCheckPhases(rig)).toEqual(['started', 'settled']);
});
test('ERR_UPDATER_CHANNEL_FILE_NOT_FOUND routes to not-available (cascade-fallback path)', () => {
@@ -2931,6 +3112,7 @@ describe('check-now → showCheckNowResult feedback dispatch', () => {
const { rig } = makeRig({ showCheckNowResult });
rig.updater.emit('update-not-available', { version: '0.4.0-beta.13' });
expect(showCheckNowResult).not.toHaveBeenCalled();
+ expect(manualCheckPhases(rig)).toEqual([]);
});
test('subsequent events after dispatch do NOT re-fire (single-shot per check-now)', () => {
@@ -2947,12 +3129,19 @@ describe('check-now → showCheckNowResult feedback dispatch', () => {
const showCheckNowResult = vi.fn(() => {});
const { rig } = makeRig({ showCheckNowResult });
rig.updater.checkForUpdates = vi.fn(() => Promise.reject(new Error('feed not reachable')));
+ let phasesAtDialog: Array<'started' | 'settled'> = [];
+ showCheckNowResult.mockImplementation(() => {
+ phasesAtDialog = manualCheckPhases(rig);
+ });
rig.ipc.invoke('ok:update:check-now');
+ expect(manualCheckPhases(rig)).toEqual(['started']);
await new Promise((r) => setTimeout(r, 0));
+ expect(phasesAtDialog).toEqual(['started', 'settled']);
expect(showCheckNowResult).toHaveBeenCalledWith({
kind: 'error',
message: 'feed not reachable',
});
+ expect(manualCheckPhases(rig)).toEqual(['started', 'settled']);
});
test('checkForUpdates synchronous reject with ERR_UPDATER_CHANNEL_FILE_NOT_FOUND routes to not-available', async () => {
diff --git a/packages/desktop/tests/preload/update-listeners.test.ts b/packages/desktop/tests/preload/update-listeners.test.ts
index 9a597141d..9766be67e 100644
--- a/packages/desktop/tests/preload/update-listeners.test.ts
+++ b/packages/desktop/tests/preload/update-listeners.test.ts
@@ -81,6 +81,7 @@ describe('M3 update-listener subscribe/unsubscribe pattern', () => {
'ok:update:whats-new',
'ok:update:whats-new-dismissed',
'ok:update:stuck-hint',
+ 'ok:update:manual-check',
] as const;
for (const channel of channels) {
const ipc = makeFakeIpc();
@@ -91,4 +92,17 @@ describe('M3 update-listener subscribe/unsubscribe pattern', () => {
expect(ipc.removeListener.mock.calls[0]?.[0]).toBe(channel);
}
});
+
+ test('manual-check payload is delivered and unsubscribed by wrapper identity', () => {
+ const ipc = makeFakeIpc();
+ const cb = vi.fn<(info: { phase: 'started' | 'settled' }) => void>(() => {});
+ const unsubscribe = createUpdateSubscription(ipc, 'ok:update:manual-check', cb);
+ const registeredWrapper = ipc.on.mock.calls[0]?.[1] as FakeListener | undefined;
+
+ registeredWrapper?.(null, { phase: 'started' });
+ expect(cb).toHaveBeenCalledWith({ phase: 'started' });
+
+ unsubscribe();
+ expect(ipc.removeListener).toHaveBeenCalledWith('ok:update:manual-check', registeredWrapper);
+ });
});