Skip to content

Beautiful, AI-native markdown IDE and LLM wiki

Isolate nested Playwright JSON reporter output (#5587)

Nick Gomez8adce2cea0ee
diff --git a/packages/app/tests/meta/worker-server-boot-verdict.test.ts b/packages/app/tests/meta/worker-server-boot-verdict.test.ts
index 01887b712..64a59fa68 100644
--- a/packages/app/tests/meta/worker-server-boot-verdict.test.ts
+++ b/packages/app/tests/meta/worker-server-boot-verdict.test.ts
@@ -11,7 +11,8 @@ import type {
JSONReportTest,
JSONReportTestResult,
} from '@playwright/test/reporter';
-import { afterAll, beforeAll, describe, expect, test } from 'vitest';
+import { afterAll, beforeAll, describe, expect, test, vi } from 'vitest';
+import { createNestedPlaywrightEnv } from '../stress/_helpers/port-ownership/nested-playwright-env.test-helper.ts';
const APP_ROOT = fileURLToPath(new URL('../..', import.meta.url));
const CASES_DIR = fileURLToPath(new URL('../stress/_helpers/boot-verdict/', import.meta.url));
@@ -78,15 +79,14 @@ async function runVerdictCases(cases: string[], retries: number): Promise<Verdic
runDirs.push(runDir);
const childTmp = join(runDir, 'tmp');
mkdirSync(childTmp);
- const env: NodeJS.ProcessEnv = {
- ...process.env,
+ const env = createNestedPlaywrightEnv({
OK_BOOT_VERDICT_RUN_DIR: runDir,
OK_BOOT_VERDICT_LIVENESS_BOUND_MS: String(PLAYWRIGHT_RUN_LIVENESS_BOUND_MS),
NODE_OPTIONS: `--import=${REFUSE_PID_SIGNALS}`,
TMPDIR: childTmp,
PLAYWRIGHT_HTML_OUTPUT_DIR: join(runDir, 'html-report'),
PLAYWRIGHT_HTML_OPEN: 'never',
- };
+ });
delete env.CI;
delete env.GITHUB_ACTIONS;
@@ -289,6 +289,20 @@ function settledRun(settled: PromiseSettledResult<VerdictRun>): VerdictRun {
}
beforeAll(async () => {
+ const outerReportDir = mkdtempSync(join(tmpdir(), 'ok-boot-verdict-outer-'));
+ runDirs.push(outerReportDir);
+ vi.stubEnv(
+ 'PLAYWRIGHT_JSON_OUTPUT_FILE',
+ process.env.PLAYWRIGHT_JSON_OUTPUT_FILE || join(outerReportDir, 'outer.json'),
+ );
+ vi.stubEnv(
+ 'PLAYWRIGHT_JSON_OUTPUT_NAME',
+ process.env.PLAYWRIGHT_JSON_OUTPUT_NAME ?? 'outer-name.json',
+ );
+ vi.stubEnv(
+ 'PLAYWRIGHT_JSON_OUTPUT_DIR',
+ process.env.PLAYWRIGHT_JSON_OUTPUT_DIR ?? outerReportDir,
+ );
const [boot, assertion, retriedBoot, recovered] = await Promise.allSettled([
runVerdictCases([BOOT_CASE, CONTROL_CASE], 0),
runVerdictCases([ASSERTION_CASE], 0),
@@ -299,6 +313,9 @@ beforeAll(async () => {
assertionRun = settledRun(assertion);
retriedBootRun = settledRun(retriedBoot);
recoveredRun = settledRun(recovered);
+}, VERDICT_RUNS_HOOK_TIMEOUT_MS);
+
+test('nested runs retain their own reports and setup outcomes', () => {
for (const run of [bootRun, assertionRun, retriedBootRun, recoveredRun]) {
requireCompletedRun(run);
}
@@ -324,9 +341,10 @@ beforeAll(async () => {
recoveredRun.bodiesRan,
'the recovered case ran its body once its setup completed',
).toEqual([RECOVERED_CASE]);
-}, VERDICT_RUNS_HOOK_TIMEOUT_MS);
+});
afterAll(() => {
+ vi.unstubAllEnvs();
for (const child of liveChildren) {
if (child.exitCode === null && child.signalCode === null) child.kill('SIGKILL');
}
diff --git a/packages/app/tests/stress/_helpers/port-ownership/nested-playwright-env.test-helper.ts b/packages/app/tests/stress/_helpers/port-ownership/nested-playwright-env.test-helper.ts
new file mode 100644
index 000000000..aabe83728
--- /dev/null
+++ b/packages/app/tests/stress/_helpers/port-ownership/nested-playwright-env.test-helper.ts
@@ -0,0 +1,7 @@
+export function createNestedPlaywrightEnv(overrides: NodeJS.ProcessEnv): NodeJS.ProcessEnv {
+ const env = { ...process.env, ...overrides };
+ delete env.PLAYWRIGHT_JSON_OUTPUT_FILE;
+ delete env.PLAYWRIGHT_JSON_OUTPUT_NAME;
+ delete env.PLAYWRIGHT_JSON_OUTPUT_DIR;
+ return env;
+}
diff --git a/packages/app/tests/stress/_helpers/port-ownership/run-case.test-helper.ts b/packages/app/tests/stress/_helpers/port-ownership/run-case.test-helper.ts
index 97faefcc7..9e1a1da38 100644
--- a/packages/app/tests/stress/_helpers/port-ownership/run-case.test-helper.ts
+++ b/packages/app/tests/stress/_helpers/port-ownership/run-case.test-helper.ts
@@ -14,6 +14,7 @@ import { tmpdir } from 'node:os';
import { join } from 'node:path';
import { fileURLToPath } from 'node:url';
import type { JSONReport, JSONReportSpec, JSONReportSuite } from '@playwright/test/reporter';
+import { createNestedPlaywrightEnv } from './nested-playwright-env.test-helper.ts';
const APP_ROOT = fileURLToPath(new URL('../../../..', import.meta.url));
const SUBTREE_ROOT = fileURLToPath(new URL('../../../../../..', import.meta.url));
@@ -145,8 +146,7 @@ export async function runOwnershipCase(ownershipCase: OwnershipCase): Promise<Ow
rmSync(runDir, { recursive: true, force: true });
throw error;
});
- const env: NodeJS.ProcessEnv = {
- ...process.env,
+ const env = createNestedPlaywrightEnv({
NODE_OPTIONS: `${process.env.NODE_OPTIONS ?? ''} --require=${PRELOAD}`.trim(),
OK_PORT_OWNERSHIP_CALLER: ownershipCase.caller,
OK_PORT_OWNERSHIP_RECORDS: join(runDir, 'events.jsonl'),
@@ -159,7 +159,7 @@ export async function runOwnershipCase(ownershipCase: OwnershipCase): Promise<Ow
TMPDIR: runtimeTmp,
TURBO_CACHE_DIR: join(SUBTREE_ROOT, '.turbo', 'cache'),
PLAYWRIGHT_HTML_OPEN: 'never',
- };
+ });
try {
const child = spawn(
diff --git a/packages/app/tests/stress/harness-port-ownership.e2e.ts b/packages/app/tests/stress/harness-port-ownership.e2e.ts
index 0bc0d417b..c17f89a01 100644
--- a/packages/app/tests/stress/harness-port-ownership.e2e.ts
+++ b/packages/app/tests/stress/harness-port-ownership.e2e.ts
@@ -10,6 +10,28 @@ import {
test.describe.configure({ retries: 0 });
test.use({ trace: 'retain-on-failure' });
+const inheritedJsonOutput = {
+ PLAYWRIGHT_JSON_OUTPUT_FILE: process.env.PLAYWRIGHT_JSON_OUTPUT_FILE,
+ PLAYWRIGHT_JSON_OUTPUT_NAME: process.env.PLAYWRIGHT_JSON_OUTPUT_NAME,
+ PLAYWRIGHT_JSON_OUTPUT_DIR: process.env.PLAYWRIGHT_JSON_OUTPUT_DIR,
+};
+
+test.beforeEach(() => {
+ process.env.PLAYWRIGHT_JSON_OUTPUT_FILE =
+ inheritedJsonOutput.PLAYWRIGHT_JSON_OUTPUT_FILE || test.info().outputPath('outer.json');
+ process.env.PLAYWRIGHT_JSON_OUTPUT_NAME =
+ inheritedJsonOutput.PLAYWRIGHT_JSON_OUTPUT_NAME ?? 'outer-name.json';
+ process.env.PLAYWRIGHT_JSON_OUTPUT_DIR =
+ inheritedJsonOutput.PLAYWRIGHT_JSON_OUTPUT_DIR ?? test.info().outputPath('outer-json');
+});
+
+test.afterEach(() => {
+ for (const [name, value] of Object.entries(inheritedJsonOutput)) {
+ if (value === undefined) delete process.env[name];
+ else process.env[name] = value;
+ }
+});
+
async function attachLifetimeRun(run: OwnershipRun): Promise<void> {
const testInfo = test.info();
const path = testInfo.outputPath('lifetime-run.json');