Skip to content

Beautiful, AI-native markdown IDE and LLM wiki

fix(ok): gate the post-reload dock-state assert on renderer settle (#4755)

Nick Gomez91e66a536b61
diff --git a/knip.config.ts b/knip.config.ts
index 5b8951125..659eef71e 100644
--- a/knip.config.ts
+++ b/knip.config.ts
@@ -143,11 +143,15 @@ export default {
'packages/server': {
entry: ['src/**/*.test.ts', 'src/parse-worker.ts'],
project: 'src/**',
- ignoreDependencies: ['@types/shell-quote'],
+ ignoreDependencies: [
+ '@types/shell-quote',
+ ],
},
'packages/cli': {
entry: ['src/**/*.test.ts', 'scripts/*.ts', 'tests/**/*.ts', 'src/parse-worker.ts'],
- ignoreDependencies: ['yjs'],
+ ignoreDependencies: [
+ 'yjs',
+ ],
},
'packages/desktop': {
entry: [
diff --git a/packages/app/tests/integration/bug3-source-mode-writeback.test.ts b/packages/app/tests/integration/bug3-source-mode-writeback.test.ts
index 8a60e5826..a28cc2b18 100644
--- a/packages/app/tests/integration/bug3-source-mode-writeback.test.ts
+++ b/packages/app/tests/integration/bug3-source-mode-writeback.test.ts
@@ -1,3 +1,4 @@
+
import { readFileSync } from 'node:fs';
import { join } from 'node:path';
import { setTimeout as wait } from 'node:timers/promises';
diff --git a/packages/app/tests/integration/indented-jsx-byte-sacred.test.ts b/packages/app/tests/integration/indented-jsx-byte-sacred.test.ts
index 6fcdc23f2..4fc2c11f9 100644
--- a/packages/app/tests/integration/indented-jsx-byte-sacred.test.ts
+++ b/packages/app/tests/integration/indented-jsx-byte-sacred.test.ts
@@ -1,3 +1,4 @@
+
import { setTimeout as wait } from 'node:timers/promises';
import { normalizeBridge } from '@inkeep/open-knowledge-core';
import { updateYFragment } from '@tiptap/y-tiptap';
diff --git a/packages/app/tests/integration/interior-edit-freshness.test.ts b/packages/app/tests/integration/interior-edit-freshness.test.ts
index 40b5cdfd6..9f2f6feb6 100644
--- a/packages/app/tests/integration/interior-edit-freshness.test.ts
+++ b/packages/app/tests/integration/interior-edit-freshness.test.ts
@@ -1,3 +1,4 @@
+
import { setTimeout as wait } from 'node:timers/promises';
import { updateYFragment, yXmlFragmentToProseMirrorRootNode } from '@tiptap/y-tiptap';
import { afterAll, beforeAll, describe, expect, test } from 'vitest';
diff --git a/packages/app/tests/integration/keystroke-cadence-danger-space.test.ts b/packages/app/tests/integration/keystroke-cadence-danger-space.test.ts
index 93666af70..2a085742b 100644
--- a/packages/app/tests/integration/keystroke-cadence-danger-space.test.ts
+++ b/packages/app/tests/integration/keystroke-cadence-danger-space.test.ts
@@ -1,3 +1,4 @@
+
import { setTimeout as wait } from 'node:timers/promises';
import { updateYFragment, yXmlFragmentToProseMirrorRootNode } from '@tiptap/y-tiptap';
import { afterAll, beforeAll, describe, expect, test } from 'vitest';
diff --git a/packages/app/tests/integration/producer-guard-wiring.test.ts b/packages/app/tests/integration/producer-guard-wiring.test.ts
index 867598d34..878d5196b 100644
--- a/packages/app/tests/integration/producer-guard-wiring.test.ts
+++ b/packages/app/tests/integration/producer-guard-wiring.test.ts
@@ -1,3 +1,4 @@
+
import { setTimeout as wait } from 'node:timers/promises';
import { updateYFragment, yXmlFragmentToProseMirrorRootNode } from '@tiptap/y-tiptap';
import { afterAll, beforeAll, describe, expect, test } from 'vitest';
diff --git a/packages/app/tests/integration/qa-039-reconciliation-counters-http.test.ts b/packages/app/tests/integration/qa-039-reconciliation-counters-http.test.ts
index 0970ac12f..4ada3cf26 100644
--- a/packages/app/tests/integration/qa-039-reconciliation-counters-http.test.ts
+++ b/packages/app/tests/integration/qa-039-reconciliation-counters-http.test.ts
@@ -1,3 +1,4 @@
+
import { randomUUID } from 'node:crypto';
import { afterEach, describe, expect, test } from 'vitest';
import { agentWriteMd, createTestServer, type TestServer } from './test-harness';
diff --git a/packages/app/tests/integration/qa-045-restore-after-gc.test.ts b/packages/app/tests/integration/qa-045-restore-after-gc.test.ts
index b632185e1..cbe2b705f 100644
--- a/packages/app/tests/integration/qa-045-restore-after-gc.test.ts
+++ b/packages/app/tests/integration/qa-045-restore-after-gc.test.ts
@@ -1,3 +1,4 @@
+
import { execFileSync } from 'node:child_process';
import { randomUUID } from 'node:crypto';
import { join } from 'node:path';
diff --git a/packages/app/tests/integration/qa-050-rollback-undo-shipped-path.test.ts b/packages/app/tests/integration/qa-050-rollback-undo-shipped-path.test.ts
index c530ce4ba..89bc9b4d9 100644
--- a/packages/app/tests/integration/qa-050-rollback-undo-shipped-path.test.ts
+++ b/packages/app/tests/integration/qa-050-rollback-undo-shipped-path.test.ts
@@ -1,3 +1,4 @@
+
import { randomUUID } from 'node:crypto';
import { afterAll, afterEach, beforeAll, describe, expect, test } from 'vitest';
import type * as Y from 'yjs';
diff --git a/packages/app/tests/integration/undo-after-rollback.test.ts b/packages/app/tests/integration/undo-after-rollback.test.ts
index d3767adc9..a78aeb0e4 100644
--- a/packages/app/tests/integration/undo-after-rollback.test.ts
+++ b/packages/app/tests/integration/undo-after-rollback.test.ts
@@ -1,3 +1,4 @@
+
import { ROLLBACK_ORIGIN } from '@inkeep/open-knowledge-server';
import { afterAll, beforeAll, describe, expect, test } from 'vitest';
import * as Y from 'yjs';
diff --git a/packages/app/tests/integration/undo-recycle-reset.test.ts b/packages/app/tests/integration/undo-recycle-reset.test.ts
index b076f955c..e7cc69c3f 100644
--- a/packages/app/tests/integration/undo-recycle-reset.test.ts
+++ b/packages/app/tests/integration/undo-recycle-reset.test.ts
@@ -1,3 +1,4 @@
+
import { writeFileSync } from 'node:fs';
import { join } from 'node:path';
import { setTimeout as wait } from 'node:timers/promises';
diff --git a/packages/app/tests/integration/undo-rederive-survival.test.ts b/packages/app/tests/integration/undo-rederive-survival.test.ts
index 7935e35f8..9ddcd0730 100644
--- a/packages/app/tests/integration/undo-rederive-survival.test.ts
+++ b/packages/app/tests/integration/undo-rederive-survival.test.ts
@@ -1,3 +1,4 @@
+
import { prependFrontmatter } from '@inkeep/open-knowledge-core';
import { Plugin, PluginKey } from '@tiptap/pm/state';
import { updateYFragment, yXmlFragmentToProseMirrorRootNode } from '@tiptap/y-tiptap';
diff --git a/packages/core/src/bridge/compose.ts b/packages/core/src/bridge/compose.ts
index f4cc8a286..2a597ec3d 100644
--- a/packages/core/src/bridge/compose.ts
+++ b/packages/core/src/bridge/compose.ts
@@ -1,3 +1,4 @@
+
import { prependFrontmatter, stripFrontmatter } from '../extensions/frontmatter.ts';
export type ComposeAdjustment = 'none' | 'body' | 'frontmatter' | 'unresolved';
diff --git a/packages/core/src/bridge/doc-boundary-space.ts b/packages/core/src/bridge/doc-boundary-space.ts
index 8fb428b90..01ef76a9f 100644
--- a/packages/core/src/bridge/doc-boundary-space.ts
+++ b/packages/core/src/bridge/doc-boundary-space.ts
@@ -1,3 +1,4 @@
+
import { FRONTMATTER_RE, stripFrontmatter } from '../extensions/frontmatter.ts';
import { carriedEdgeEmpties, type DocEdgeEmpties } from '../markdown/doc-edge-blank-runs.ts';
diff --git a/packages/core/src/markdown/comment-promoter.ts b/packages/core/src/markdown/comment-promoter.ts
index fc267cbea..fb0ba5a7c 100644
--- a/packages/core/src/markdown/comment-promoter.ts
+++ b/packages/core/src/markdown/comment-promoter.ts
@@ -1,3 +1,4 @@
+
import type { Nodes, Paragraph, PhrasingContent, Root, RootContent, Text } from 'mdast';
import { SKIP, visit } from 'unist-util-visit';
import type { VFile } from 'vfile';
diff --git a/packages/core/src/markdown/merged-walker.ts b/packages/core/src/markdown/merged-walker.ts
index bfd7e3109..fa3cfcd86 100644
--- a/packages/core/src/markdown/merged-walker.ts
+++ b/packages/core/src/markdown/merged-walker.ts
@@ -1,3 +1,4 @@
+
import type { Nodes, Parent, Root } from 'mdast';
import { SKIP, visit } from 'unist-util-visit';
import type { VFile } from 'vfile';
diff --git a/packages/core/src/markdown/safe-url.ts b/packages/core/src/markdown/safe-url.ts
index 4d3250d3a..8be632ba4 100644
--- a/packages/core/src/markdown/safe-url.ts
+++ b/packages/core/src/markdown/safe-url.ts
@@ -1,3 +1,4 @@
+
export const SAFE_URL_SCHEMES = ['https', 'http', 'mailto', 'tel', 'ftp', 'sms'] as const;
const SCHEME_ALT = SAFE_URL_SCHEMES.map((s) => `${s}:`).join('|');
diff --git a/packages/desktop/tests/smoke/_helpers/dock-state-ready.test.ts b/packages/desktop/tests/smoke/_helpers/dock-state-ready.test.ts
new file mode 100644
index 000000000..f0f8d744a
--- /dev/null
+++ b/packages/desktop/tests/smoke/_helpers/dock-state-ready.test.ts
@@ -0,0 +1,240 @@
+import { describe, expect, test } from 'vitest';
+import { type AgentsDockRecord, waitForAgentsDockPublish } from './dock-state-ready';
+
+const SEEDED_BEFORE_RELOAD: AgentsDockRecord = {
+ order: ['thread-a', 'thread-b'],
+ activeKey: 'thread-a',
+};
+const SETTLED_EMPTY_ROSTER: AgentsDockRecord = { order: [], activeKey: null };
+
+describe('agents dock republish barrier', () => {
+ test('holds while the main-process record still serves the pre-reload agents order', async () => {
+ const REPUBLISH_AT_READ = 4;
+ let reads = 0;
+
+ await waitForAgentsDockPublish(
+ () => {
+ reads += 1;
+ return Promise.resolve({
+ agents:
+ reads < REPUBLISH_AT_READ
+ ? structuredClone(SEEDED_BEFORE_RELOAD)
+ : SETTLED_EMPTY_ROSTER,
+ });
+ },
+ SEEDED_BEFORE_RELOAD,
+ { interval: 5, timeout: 1_000 },
+ );
+
+ expect(reads).toBe(REPUBLISH_AT_READ);
+ });
+
+ test('holds while the record is absent instead of reading absence as a publication', async () => {
+ const PUBLISH_AT_READ = 3;
+ let reads = 0;
+
+ await waitForAgentsDockPublish(
+ () => {
+ reads += 1;
+ return Promise.resolve(reads < PUBLISH_AT_READ ? {} : { agents: SETTLED_EMPTY_ROSTER });
+ },
+ undefined,
+ { interval: 5, timeout: 1_000 },
+ );
+
+ expect(reads).toBe(PUBLISH_AT_READ);
+ });
+
+ test('accepts a republish that changes only the active key', async () => {
+ const HELD: AgentsDockRecord = { order: ['thread-a'], activeKey: 'thread-a' };
+ const REPUBLISH_AT_READ = 2;
+ let reads = 0;
+
+ await waitForAgentsDockPublish(
+ () => {
+ reads += 1;
+ return Promise.resolve({
+ agents:
+ reads < REPUBLISH_AT_READ
+ ? structuredClone(HELD)
+ : { order: ['thread-a'], activeKey: null },
+ });
+ },
+ HELD,
+ { interval: 5, timeout: 1_000 },
+ );
+
+ expect(reads).toBe(REPUBLISH_AT_READ);
+ });
+
+ test('accepts a republish that reorders the same keys under the same active key', async () => {
+ const HELD: AgentsDockRecord = { order: ['thread-a', 'thread-b'], activeKey: 'thread-a' };
+ const REORDERED: AgentsDockRecord = { order: ['thread-b', 'thread-a'], activeKey: 'thread-a' };
+ const REPUBLISH_AT_READ = 2;
+ let reads = 0;
+
+ await waitForAgentsDockPublish(
+ () => {
+ reads += 1;
+ return Promise.resolve({
+ agents: reads < REPUBLISH_AT_READ ? structuredClone(HELD) : REORDERED,
+ });
+ },
+ HELD,
+ { interval: 5, timeout: 1_000 },
+ );
+
+ expect(reads).toBe(REPUBLISH_AT_READ);
+ });
+
+ test('accepts a republish that drops a trailing key under the same active key', async () => {
+ const HELD: AgentsDockRecord = { order: ['thread-a', 'thread-b'], activeKey: 'thread-a' };
+ const SHRUNK: AgentsDockRecord = { order: ['thread-a'], activeKey: 'thread-a' };
+ const REPUBLISH_AT_READ = 2;
+ let reads = 0;
+
+ await waitForAgentsDockPublish(
+ () => {
+ reads += 1;
+ return Promise.resolve({
+ agents: reads < REPUBLISH_AT_READ ? structuredClone(HELD) : SHRUNK,
+ });
+ },
+ HELD,
+ { interval: 5, timeout: 1_000 },
+ );
+
+ expect(reads).toBe(REPUBLISH_AT_READ);
+ });
+
+ test('fails loud naming absence when the record is never published', async () => {
+ let reads = 0;
+
+ await expect(
+ waitForAgentsDockPublish(
+ () => {
+ reads += 1;
+ return Promise.resolve({});
+ },
+ undefined,
+ { interval: 5, timeout: 200 },
+ ),
+ ).rejects.toThrow(/no agents dock record published/u);
+
+ expect(reads).toBeGreaterThan(1);
+ });
+
+ test('fails loud naming the stale record when the renderer never republishes', async () => {
+ let reads = 0;
+
+ await expect(
+ waitForAgentsDockPublish(
+ () => {
+ reads += 1;
+ return Promise.resolve({ agents: structuredClone(SEEDED_BEFORE_RELOAD) });
+ },
+ SEEDED_BEFORE_RELOAD,
+ { interval: 5, timeout: 200 },
+ ),
+ ).rejects.toThrow(/thread-a/u);
+
+ expect(reads).toBeGreaterThan(1);
+ });
+
+ test('fails loud naming the bridge when the reader itself returns no dock state', async () => {
+ let reads = 0;
+
+ await expect(
+ waitForAgentsDockPublish(
+ () => {
+ reads += 1;
+ return Promise.resolve(undefined);
+ },
+ SEEDED_BEFORE_RELOAD,
+ { interval: 5, timeout: 200 },
+ ),
+ ).rejects.toThrow(/no dock state read from the desktop bridge/u);
+
+ expect(reads).toBeGreaterThan(1);
+ });
+
+ test('rejects a negative budget by naming the contract, not an already-elapsed deadline', async () => {
+ await expect(
+ waitForAgentsDockPublish(() => Promise.resolve({}), undefined, {
+ interval: 5,
+ timeout: -1,
+ }),
+ ).rejects.toThrow(/positive timeout budget/u);
+ });
+
+ test('rejects a zero budget rather than polling past the caller deadline', async () => {
+ const settled = await Promise.race([
+ waitForAgentsDockPublish(() => Promise.resolve({}), undefined, {
+ interval: 5,
+ timeout: 0,
+ }).then(
+ () => 'resolved',
+ (error: Error) => error.message,
+ ),
+ new Promise<string>((resolve) => {
+ setTimeout(() => resolve('still waiting'), 500);
+ }),
+ ]);
+
+ expect(settled).toMatch(/positive timeout budget/u);
+ });
+
+ test('rejects a NaN budget, which toPass would otherwise read as no deadline', async () => {
+ const settled = await Promise.race([
+ waitForAgentsDockPublish(() => Promise.resolve({}), undefined, {
+ interval: 5,
+ timeout: Number.NaN,
+ }).then(
+ () => 'resolved',
+ (error: Error) => error.message,
+ ),
+ new Promise<string>((resolve) => {
+ setTimeout(() => resolve('still waiting'), 500);
+ }),
+ ]);
+
+ expect(settled).toMatch(/positive timeout budget/u);
+ });
+
+ test('retries through a bounded run of reader rejections and resolves on the publication', async () => {
+ const NAVIGATION_ERROR = 'Execution context was destroyed, most likely because of a navigation';
+ const PUBLISH_AT_READ = 3;
+ let reads = 0;
+
+ await waitForAgentsDockPublish(
+ () => {
+ reads += 1;
+ return reads < PUBLISH_AT_READ
+ ? Promise.reject(new Error(NAVIGATION_ERROR))
+ : Promise.resolve({ agents: SETTLED_EMPTY_ROSTER });
+ },
+ SEEDED_BEFORE_RELOAD,
+ { interval: 5, timeout: 1_000 },
+ );
+
+ expect(reads).toBe(PUBLISH_AT_READ);
+ });
+
+ test('surfaces the reader rejection when the bridge read fails for the whole budget', async () => {
+ const NAVIGATION_ERROR = 'Execution context was destroyed, most likely because of a navigation';
+ let reads = 0;
+
+ await expect(
+ waitForAgentsDockPublish(
+ () => {
+ reads += 1;
+ return Promise.reject(new Error(NAVIGATION_ERROR));
+ },
+ undefined,
+ { interval: 5, timeout: 200 },
+ ),
+ ).rejects.toThrow(/Execution context was destroyed/u);
+
+ expect(reads).toBeGreaterThan(1);
+ });
+});
diff --git a/packages/desktop/tests/smoke/_helpers/dock-state-ready.ts b/packages/desktop/tests/smoke/_helpers/dock-state-ready.ts
new file mode 100644
index 000000000..112aa5390
--- /dev/null
+++ b/packages/desktop/tests/smoke/_helpers/dock-state-ready.ts
@@ -0,0 +1,41 @@
+import { isDeepStrictEqual } from 'node:util';
+import type { OkTerminalDockState } from '@inkeep/open-knowledge-core/desktop-bridge';
+import { expect } from '@playwright/test';
+
+export type AgentsDockRecord = NonNullable<OkTerminalDockState['agents']>;
+
+export interface WaitForAgentsDockPublishOptions {
+ timeout: number;
+ interval?: number;
+}
+
+const PUBLISHED = 'agents dock record published';
+
+export async function waitForAgentsDockPublish(
+ readDockState: () => Promise<Pick<OkTerminalDockState, 'agents'> | undefined>,
+ priorAgents: AgentsDockRecord | undefined,
+ { timeout, interval = 250 }: WaitForAgentsDockPublishOptions,
+): Promise<void> {
+ if (!(timeout > 0)) {
+ throw new Error(
+ `waitForAgentsDockPublish needs a positive timeout budget; received ${timeout}. ` +
+ `toPass({ timeout: 0 }) waits without a deadline and fails as an unattributable test timeout.`,
+ );
+ }
+ await expect(async () => {
+ expect(describeAgentsPublish(await readDockState(), priorAgents)).toBe(PUBLISHED);
+ }).toPass({ timeout, intervals: [interval] });
+}
+
+function describeAgentsPublish(
+ state: Pick<OkTerminalDockState, 'agents'> | undefined,
+ prior: AgentsDockRecord | undefined,
+): string {
+ if (state === undefined) return 'no dock state read from the desktop bridge';
+ const latest = state.agents;
+ if (latest === undefined) return 'no agents dock record published';
+ if (prior !== undefined && isDeepStrictEqual(latest, prior)) {
+ return `agents dock record unchanged from ${JSON.stringify(prior)}`;
+ }
+ return PUBLISHED;
+}
diff --git a/packages/desktop/tests/smoke/terminal-dock-state.e2e.ts b/packages/desktop/tests/smoke/terminal-dock-state.e2e.ts
index efbd11a31..a4de02f83 100644
--- a/packages/desktop/tests/smoke/terminal-dock-state.e2e.ts
+++ b/packages/desktop/tests/smoke/terminal-dock-state.e2e.ts
@@ -3,6 +3,7 @@ import { tmpdir } from 'node:os';
import { join } from 'node:path';
import type { Page } from '@playwright/test';
import { _electron as electron } from '@playwright/test';
+import { waitForAgentsDockPublish } from './_helpers/dock-state-ready';
import { desktopLaunchOptions, resolveDesktopTarget } from './_helpers/launch-desktop';
import { PTY_PLATFORM_SKIP_REASON, PTY_PLATFORM_SUPPORTED } from './_helpers/platform-gate';
import { expect, test } from './_helpers/smoke-test';
@@ -16,6 +17,7 @@ test.describe('terminal dock-state IPC', () => {
test.skip(!TARGET.exists, TARGET.missingReason);
test('terminal tab snapshot survives renderer reload together', async ({ captureStderrFor }) => {
+ test.setTimeout(200_000);
const testRoot = mkdtempSync(join(tmpdir(), 'ok-terminal-dock-state-'));
const projectDir = join(testRoot, 'project');
mkdirSync(join(projectDir, '.ok'), { recursive: true });
@@ -61,38 +63,50 @@ test.describe('terminal dock-state IPC', () => {
const editorPage = page;
if (editorPage == null) throw new Error('editor window vanished after readiness poll');
+ await waitForAgentsDockPublish(
+ () => editorPage.evaluate(() => window.okDesktop?.terminal.getDockState()),
+ undefined,
+ { timeout: 35_000 },
+ );
await expect
- .poll(() => editorPage.evaluate(() => window.okDesktop?.terminal.getDockState()))
+ .poll(() => editorPage.evaluate(() => window.okDesktop?.terminal.getDockState()), {
+ timeout: 10_000,
+ })
.toMatchObject({ agents: { order: [], activeKey: null } });
await expect
- .poll(async () => {
- await editorPage.evaluate(() =>
- window.okDesktop?.terminal.setDockState({
- surface: 'agents',
- order: ['thread-a', 'thread-b'],
- activeKey: 'thread-a',
- }),
- );
- return editorPage.evaluate(() => window.okDesktop?.terminal.getDockState());
- })
+ .poll(
+ async () => {
+ await editorPage.evaluate(() =>
+ window.okDesktop?.terminal.setDockState({
+ surface: 'agents',
+ order: ['thread-a', 'thread-b'],
+ activeKey: 'thread-a',
+ }),
+ );
+ return editorPage.evaluate(() => window.okDesktop?.terminal.getDockState());
+ },
+ { timeout: 5_000 },
+ )
.toMatchObject({ agents: { order: ['thread-a', 'thread-b'], activeKey: 'thread-a' } });
await expect
- .poll(() =>
- editorPage.evaluate(() =>
- window.okDesktop?.terminal.setDockState({
- surface: 'terminal',
- order: ['pty-a', 'pty-b'],
- activeKey: 'pty-b',
- terminalSnapshot: {
- tabs: [
- { ordinal: 1, customLabel: null },
- { ordinal: 2, customLabel: 'Build' },
- ],
- activeOrdinal: 2,
- },
- }),
- ),
+ .poll(
+ () =>
+ editorPage.evaluate(() =>
+ window.okDesktop?.terminal.setDockState({
+ surface: 'terminal',
+ order: ['pty-a', 'pty-b'],
+ activeKey: 'pty-b',
+ terminalSnapshot: {
+ tabs: [
+ { ordinal: 1, customLabel: null },
+ { ordinal: 2, customLabel: 'Build' },
+ ],
+ activeOrdinal: 2,
+ },
+ }),
+ ),
+ { timeout: 5_000 },
)
.toEqual({ ok: true });
@@ -108,24 +122,33 @@ test.describe('terminal dock-state IPC', () => {
agents: { order: ['thread-a', 'thread-b'], activeKey: 'thread-a' },
};
await expect
- .poll(() => editorPage.evaluate(() => window.okDesktop?.terminal.getDockState()))
+ .poll(() => editorPage.evaluate(() => window.okDesktop?.terminal.getDockState()), {
+ timeout: 5_000,
+ })
.toMatchObject(expectedBeforeReload);
const dockState = await editorPage.evaluate(() => window.okDesktop?.terminal.getDockState());
expect(dockState).not.toHaveProperty('placement');
expect(dockState).not.toHaveProperty('rightWidth');
await editorPage.reload({ waitUntil: 'domcontentloaded' });
+ await waitForAgentsDockPublish(
+ () => editorPage.evaluate(() => window.okDesktop?.terminal.getDockState()),
+ expectedBeforeReload.agents,
+ { timeout: 25_000 },
+ );
await expect
- .poll(() =>
- editorPage.evaluate(async () => {
- const state = await window.okDesktop?.terminal.getDockState();
- return {
- agents: state?.agents,
- terminalCount: state?.terminal?.order.length,
- activeIndex: state?.terminal?.order.indexOf(state.terminal.activeKey ?? ''),
- terminalSnapshot: state?.terminalSnapshot,
- };
- }),
+ .poll(
+ () =>
+ editorPage.evaluate(async () => {
+ const state = await window.okDesktop?.terminal.getDockState();
+ return {
+ agents: state?.agents,
+ terminalCount: state?.terminal?.order.length,
+ activeIndex: state?.terminal?.order.indexOf(state.terminal.activeKey ?? ''),
+ terminalSnapshot: state?.terminalSnapshot,
+ };
+ }),
+ { timeout: 20_000 },
)
.toEqual({
agents: { order: [], activeKey: null },