Skip to content

Beautiful, AI-native markdown IDE and LLM wiki

fix: bound MDX prop processing (PRD-10111) (#7920)

Andrew Mikofalvy92cfd46f0b5e
diff --git a/.changeset/bounded-mdx-props.md b/.changeset/bounded-mdx-props.md
new file mode 100644
index 000000000..d03b2713d
--- /dev/null
+++ b/.changeset/bounded-mdx-props.md
@@ -0,0 +1,5 @@
+---
+"@inkeep/open-knowledge": patch
+---
+
+Documents with very large or deeply nested MDX component props stay editable instead of failing to render.
diff --git a/packages/app/src/editor/bubble-menu/ViewInSourceBubbleButton.dom.test.tsx b/packages/app/src/editor/bubble-menu/ViewInSourceBubbleButton.dom.test.tsx
index c149e8469..c456f641f 100644
--- a/packages/app/src/editor/bubble-menu/ViewInSourceBubbleButton.dom.test.tsx
+++ b/packages/app/src/editor/bubble-menu/ViewInSourceBubbleButton.dom.test.tsx
@@ -43,10 +43,10 @@ function makeEditor(
return { editor, ydoc };
}
-function renderButton(editor: Editor) {
+function renderButton(editor: Editor, getTargetPosition?: () => number | undefined) {
return render(
<TooltipProvider>
- <ViewInSourceBubbleButton editor={editor} />
+ <ViewInSourceBubbleButton editor={editor} getTargetPosition={getTargetPosition} />
</TooltipProvider>,
);
}
@@ -71,6 +71,46 @@ afterEach(() => {
});
describe('ViewInSourceBubbleButton', () => {
+ test('a node target at a non-first block boundary lands in that block', async () => {
+ const user = userEvent.setup();
+ const { editor } = makeEditor(DOC, 2);
+ const doc = (editor as unknown as { editorView: { state: { doc: PmNode } } }).editorView.state
+ .doc;
+ renderButton(editor, () => doc.child(0).nodeSize);
+ await user.click(screen.getByTestId('view-in-source-bubble-button'));
+ const nav = peekPendingSourceNavigation('doc-view');
+ if (nav?.kind !== 'selection-offset') throw new Error('expected a selection-offset nav');
+ expect(nav.anchor.blockIndex).toBe(1);
+ });
+
+ test.each(['click', 'keyboard'] as const)(
+ 'a node-bound %s action targets its node instead of an unrelated caret',
+ async (activation) => {
+ const user = userEvent.setup();
+ const { editor } = makeEditor(DOC, 2);
+ renderButton(editor, () => 0);
+ const button = screen.getByTestId('view-in-source-bubble-button');
+ if (activation === 'click') await user.click(button);
+ else {
+ button.focus();
+ await user.keyboard('{Enter}');
+ }
+ expect(flipped).toEqual(['doc-view']);
+ const nav = peekPendingSourceNavigation('doc-view');
+ if (nav?.kind !== 'selection-offset') throw new Error('expected a selection-offset nav');
+ expect(nav.anchor.blockIndex).toBe(0);
+ },
+ );
+
+ test('does not jump to an old caret when a node target is no longer present', async () => {
+ const user = userEvent.setup();
+ const { editor } = makeEditor(DOC, 2);
+ renderButton(editor, () => undefined);
+ await user.click(screen.getByTestId('view-in-source-bubble-button'));
+ expect(flipped).toEqual([]);
+ expect(peekPendingSourceNavigation('doc-view')).toBeNull();
+ });
+
test('renders a labelled, native-button entry', () => {
const { editor } = makeEditor(DOC, 2);
renderButton(editor);
diff --git a/packages/app/src/editor/bubble-menu/ViewInSourceBubbleButton.tsx b/packages/app/src/editor/bubble-menu/ViewInSourceBubbleButton.tsx
index 91629c1c8..3a4398477 100644
--- a/packages/app/src/editor/bubble-menu/ViewInSourceBubbleButton.tsx
+++ b/packages/app/src/editor/bubble-menu/ViewInSourceBubbleButton.tsx
@@ -10,14 +10,22 @@ import { getEditorDocName } from '../extensions/doc-context';
import { requestViewInSource } from '../mode-switch-landing';
import { getYDoc } from '../utils/get-ydoc';
-export function ViewInSourceBubbleButton({ editor }: { editor: Editor }): ReactNode {
+export function ViewInSourceBubbleButton({
+ editor,
+ getTargetPosition,
+}: {
+ editor: Editor;
+ getTargetPosition?: () => number | undefined;
+}): ReactNode {
const { t } = useLingui();
const jump = (): void => {
const docName = getEditorDocName(editor);
const ydoc = getYDoc(editor);
if (docName === null || !ydoc) return;
- requestViewInSource({ editor, docName, ytext: ydoc.getText('source') });
+ const pmPosition = getTargetPosition?.();
+ if (getTargetPosition && pmPosition === undefined) return;
+ requestViewInSource({ editor, docName, ytext: ydoc.getText('source'), pmPosition });
};
return (
diff --git a/packages/app/src/editor/extensions/JsxComponentView.test.ts b/packages/app/src/editor/extensions/JsxComponentView.test.ts
index 8f6d4bf9c..f210dec86 100644
--- a/packages/app/src/editor/extensions/JsxComponentView.test.ts
+++ b/packages/app/src/editor/extensions/JsxComponentView.test.ts
@@ -265,6 +265,10 @@ describe('attrsWithChangedProp', () => {
});
describe('stableHash', () => {
+ test('rejects over-budget inputs before recursively hashing them', () => {
+ const props = { items: JSON.parse(`${'['.repeat(6000)}0${']'.repeat(6000)}`) };
+ expect(() => stableHash(props)).toThrow('rendering budget');
+ });
test('key-order independence — primary load-bearing invariant', () => {
expect(stableHash({ a: 1, b: 2 })).toBe(stableHash({ b: 2, a: 1 }));
expect(stableHash({ type: 'warn', title: 'x' })).toBe(stableHash({ title: 'x', type: 'warn' }));
diff --git a/packages/app/src/editor/extensions/JsxComponentView.tsx b/packages/app/src/editor/extensions/JsxComponentView.tsx
index 97382291c..bc5c6f5d4 100644
--- a/packages/app/src/editor/extensions/JsxComponentView.tsx
+++ b/packages/app/src/editor/extensions/JsxComponentView.tsx
@@ -6,7 +6,6 @@
import { commentLeafText } from '@inkeep/open-knowledge-core/comments/leaf-text';
import {
- incrementJsxActionAborted,
incrementJsxAutoConvertFailed,
incrementJsxAutoConvertSucceeded,
incrementJsxChromeDeleteFailed,
@@ -17,6 +16,7 @@ import {
incrementJsxStuckDeleteFailed,
type JsxNodeAction,
} from '@inkeep/open-knowledge-core/metrics/parse-health';
+import { componentPropsBudgetError } from '@inkeep/open-knowledge-core/registry';
import { Trans, useLingui } from '@lingui/react/macro';
import type { NodeViewProps } from '@tiptap/core';
import { NodeViewContent, NodeViewWrapper } from '@tiptap/react';
@@ -33,7 +33,6 @@ import {
import type { ReactNode } from 'react';
import { useEffect, useRef, useState } from 'react';
import { ErrorBoundary, type FallbackProps } from 'react-error-boundary';
-import { toast } from 'sonner';
import { emitStartComment } from '@/comments/store';
import { Button } from '@/components/ui/button';
import { useIsEmbedded } from '@/hooks/use-is-embedded';
@@ -44,6 +43,7 @@ import {
PopoverContent,
PopoverTrigger,
} from '../../components/ui/popover.tsx';
+import { ViewInSourceBubbleButton } from '../bubble-menu/ViewInSourceBubbleButton.tsx';
import { OPT_OUT_ATTR } from '../clipboard/index.ts';
import { CodePreviewEditModal } from '../components/CodePreviewEditModal';
import { DescriptorPlaceholder } from '../components/DescriptorPlaceholder.tsx';
@@ -74,12 +74,13 @@ import {
autonomousFragmentEditAllowed,
markAutonomousFragmentEdit,
} from './autonomous-fragment-edit.ts';
+import { reportJsxActionAborted, resolveJsxActionTarget } from './jsx-node-action.ts';
import { isSameJsxElement, resolveJsxNodeTarget } from './jsx-node-target.ts';
import {
- extractPrimitiveProps,
JSX_WRAPPER_CLASS,
jsxChildrenClassName,
jsxWrapperDataAttributes,
+ prepareJsxProps,
reportJsxRenderFailure,
resolveJsxRenderProps,
resolveJsxSourceDocName,
@@ -115,15 +116,21 @@ function ComponentErrorBoundary(props: ComponentErrorBoundaryProps) {
}
export function stableHash(value: unknown): string {
+ const budgetError = componentPropsBudgetError(value);
+ if (budgetError) throw new RangeError(budgetError);
+ return stableHashWithinBudget(value);
+}
+
+function stableHashWithinBudget(value: unknown): string {
if (value === null || typeof value !== 'object') {
return JSON.stringify(value);
}
if (Array.isArray(value)) {
- return `[${value.map(stableHash).join(',')}]`;
+ return `[${value.map(stableHashWithinBudget).join(',')}]`;
}
const entries = Object.entries(value as Record<string, unknown>);
entries.sort(([a], [b]) => (a < b ? -1 : a > b ? 1 : 0));
- return `{${entries.map(([k, v]) => `${JSON.stringify(k)}:${stableHash(v)}`).join(',')}}`;
+ return `{${entries.map(([k, v]) => `${JSON.stringify(k)}:${stableHashWithinBudget(v)}`).join(',')}}`;
}
interface ElementJsxAttrs extends Record<string, unknown> {
@@ -223,7 +230,7 @@ export function JsxComponentView({ node, editor, extension, getPos, selected }:
);
const currentProps = (node.attrs.props as Record<string, unknown>) ?? {};
- const primitiveProps = extractPrimitiveProps(node.attrs, descriptor);
+ const { props: primitiveProps, error: propsError } = prepareJsxProps(node.attrs, descriptor);
const needsConfig =
hasEditableProps &&
descriptor.props.some((p) => {
@@ -296,30 +303,11 @@ export function JsxComponentView({ node, editor, extension, getPos, selected }:
}, [boardExpandable]);
const resetKey = `${descriptor.name}::${stableHash(primitiveProps)}`;
- const reportAbortedAction = (action: JsxNodeAction, reason: 'changed' | 'removed') => {
- incrementJsxActionAborted(action);
- console.warn(
- JSON.stringify({
- event: 'jsx-component-action-aborted',
- action,
- reason,
- component: descriptor.name === '*' ? 'wildcard' : descriptor.name,
- rawComponentName: String(node.attrs.componentName ?? '').slice(0, 200),
- }),
- );
- toast.info(
- reason === 'removed' ? t`This component was removed.` : t`This component changed. Try again.`,
- );
- };
-
- const resolveActionTarget = (action: JsxNodeAction) => {
- const target = resolveJsxNodeTarget(editor.state.doc, getPos, node);
- if (target.kind !== 'current') {
- reportAbortedAction(action, target.kind);
- return null;
- }
- return target;
- };
+ const actionContext = { editor, getPos, node, descriptorName: descriptor.name };
+ const reportAbortedAction = (action: JsxNodeAction, reason: 'changed' | 'removed') =>
+ reportJsxActionAborted(actionContext, action, reason);
+ const resolveActionTarget = (action: JsxNodeAction) =>
+ resolveJsxActionTarget(actionContext, action);
const resolveElementActionTarget = (action: JsxNodeAction) => {
const target = resolveJsxNodeTarget(editor.state.doc, getPos, node);
@@ -487,6 +475,27 @@ export function JsxComponentView({ node, editor, extension, getPos, selected }:
);
}
+ if (propsError) {
+ return (
+ <NodeViewWrapper className="jsx-component-wrapper my-2" data-jsx-props-error="">
+ <div
+ className="flex flex-wrap items-center gap-2 px-2 py-1 text-xs text-warning"
+ contentEditable={false}
+ {...{ [OPT_OUT_ATTR]: 'true' }}
+ >
+ <span role="status">
+ <Trans>This component is too large to render.</Trans>
+ </span>
+ <ViewInSourceBubbleButton
+ editor={editor}
+ getTargetPosition={() => resolveActionTarget('edit-source')?.pos}
+ />
+ </div>
+ <NodeViewContent className="component-children" />
+ </NodeViewWrapper>
+ );
+ }
+
if (needsConversion) {
const componentName = node.attrs.componentName as string;
const descriptorLabel = descriptor.displayName ?? descriptor.name;
diff --git a/packages/app/src/editor/extensions/JsxInlineView.dom.test.tsx b/packages/app/src/editor/extensions/JsxInlineView.dom.test.tsx
index d30926d82..f7abe66cc 100644
--- a/packages/app/src/editor/extensions/JsxInlineView.dom.test.tsx
+++ b/packages/app/src/editor/extensions/JsxInlineView.dom.test.tsx
@@ -1,25 +1,65 @@
-import { cleanup, fireEvent, render, screen, waitFor } from '@testing-library/react';
-import type { Editor } from '@tiptap/core';
+import { getParseHealth, resetParseHealth } from '@inkeep/open-knowledge-core';
+import { act, cleanup, fireEvent, render, screen, waitFor } from '@testing-library/react';
+import userEvent from '@testing-library/user-event';
+import { type Editor, getSchema } from '@tiptap/core';
+import Collaboration from '@tiptap/extension-collaboration';
import { EditorContent, useEditor } from '@tiptap/react';
+import { updateYFragment } from '@tiptap/y-tiptap';
import { useEffect, useState } from 'react';
import { createPortal } from 'react-dom';
-import { afterEach, describe, expect, test, vi } from 'vitest';
+import { Toaster, toast } from 'sonner';
+import { afterEach, beforeEach, describe, expect, test, vi } from 'vitest';
+import * as Y from 'yjs';
+import { TooltipProvider } from '@/components/ui/tooltip';
+import { ConfigContext, type ConfigContextValue } from '@/lib/config-context';
+import { OPT_OUT_ATTR } from '../clipboard/index.ts';
+import {
+ clearPendingSourceNavigationsForTest,
+ peekPendingSourceNavigation,
+} from '../source-editor-navigation.ts';
import { getSharedMarkdownManager } from '../utils/md-singleton.ts';
+import { setEditorDocName } from './doc-context.ts';
import { sharedExtensions } from './shared';
vi.mock('@/lib/use-collab-url', () => ({
useCollabUrl: () => ({ collabUrl: null }),
}));
-function Host({ content, onEditor }: { content: object; onEditor: (e: Editor) => void }) {
+const config: ConfigContextValue = {
+ userBinding: null,
+ userSynced: false,
+ projectBinding: null,
+ projectLocalBinding: null,
+ okignoreBinding: null,
+ okignoreSynced: false,
+ userConfig: null,
+ projectConfig: null,
+ projectSynced: false,
+ projectLocalConfig: null,
+ projectLocalSynced: false,
+ merged: null,
+};
+
+function Host({
+ content,
+ onEditor,
+ ydoc,
+}: {
+ content: object;
+ onEditor: (e: Editor) => void;
+ ydoc?: Y.Doc;
+}) {
const editor = useEditor({
- extensions: sharedExtensions.map((extension) =>
- extension.name === 'jsxInline'
- ? extension.configure({ docName: 'all-link-types' })
- : extension,
- ),
+ extensions: [
+ ...sharedExtensions.map((extension) =>
+ extension.name === 'jsxInline'
+ ? extension.configure({ docName: 'all-link-types' })
+ : extension,
+ ),
+ ...(ydoc ? [Collaboration.configure({ document: ydoc })] : []),
+ ],
editable: true,
- content,
+ content: ydoc ? undefined : content,
immediatelyRender: true,
});
const [portalTarget] = useState(() => document.createElement('div'));
@@ -27,7 +67,10 @@ function Host({ content, onEditor }: { content: object; onEditor: (e: Editor) =>
document.body.appendChild(portalTarget);
return () => portalTarget.remove();
}, [portalTarget]);
- if (editor) onEditor(editor);
+ if (editor) {
+ if (ydoc) setEditorDocName(editor, 'budget-recovery');
+ onEditor(editor);
+ }
return createPortal(
// oxlint-disable-next-line ok/no-unportaled-editor-content -- portalled per the H6 contract — this IS the sanctioned createPortal shape, in a test harness with a per-render exclusive target
<EditorContent editor={editor} />,
@@ -35,18 +78,43 @@ function Host({ content, onEditor }: { content: object; onEditor: (e: Editor) =>
);
}
-function mountEditor(content: object): {
+const navigationDocs = new Set<Y.Doc>();
+
+function mountEditor(
+ content: object,
+ source?: string,
+): {
getEditor: () => Editor;
view: ReturnType<typeof render>;
} {
let captured: Editor | null = null;
+ const ydoc = source === undefined ? undefined : new Y.Doc();
+ if (ydoc) {
+ navigationDocs.add(ydoc);
+ ydoc.getText('source').insert(0, source ?? '');
+ updateYFragment(
+ ydoc,
+ ydoc.getXmlFragment('default'),
+ getSchema(sharedExtensions).nodeFromJSON(content),
+ {
+ mapping: new Map(),
+ isOMark: new Map(),
+ },
+ );
+ }
const view = render(
- <Host
- content={content}
- onEditor={(e) => {
- captured = e;
- }}
- />,
+ <ConfigContext value={config}>
+ <TooltipProvider>
+ <Host
+ content={content}
+ ydoc={ydoc}
+ onEditor={(e) => {
+ captured = e;
+ }}
+ />
+ <Toaster />
+ </TooltipProvider>
+ </ConfigContext>,
);
return {
getEditor: () => {
@@ -77,9 +145,230 @@ function docWithInline(attrs: Record<string, unknown>, text?: string) {
};
}
-afterEach(cleanup);
+beforeEach(() => {
+ resetParseHealth();
+ clearPendingSourceNavigationsForTest();
+});
+
+afterEach(() => {
+ cleanup();
+ toast.dismiss();
+ for (const doc of navigationDocs) doc.destroy();
+ navigationDocs.clear();
+});
+
+function recoveryDocument(kind: 'block' | 'inline') {
+ let items: unknown = 0;
+ for (let i = 0; i < 65; i++) items = [items];
+ const attrs = { componentName: 'Callout', props: { items }, sourceDirty: true };
+ const middle =
+ kind === 'block' ? { type: 'jsxComponent', attrs } : docWithInline(attrs).content[0];
+ const content = {
+ type: 'doc',
+ content: [
+ { type: 'paragraph', content: [{ type: 'text', text: 'Prefix.' }] },
+ middle,
+ { type: 'paragraph', content: [{ type: 'text', text: 'Unrelated caret.' }] },
+ ],
+ };
+ const jsx = `<Callout items={${JSON.stringify(items)}} />`;
+ const source = `Prefix.\n\n${kind === 'block' ? jsx : `before ${jsx} after`}\n\nUnrelated caret.\n`;
+ return { content, source };
+}
describe('JsxInlineView', () => {
+ test.each([
+ ['block', 'click'],
+ ['block', 'keyboard'],
+ ['inline', 'click'],
+ ['inline', 'keyboard'],
+ ] as const)(
+ 'mounted over-budget %s recovery targets its node via %s',
+ async (kind, activation) => {
+ const user = userEvent.setup();
+ const { content, source } = recoveryDocument(kind);
+ const { getEditor } = mountEditor(content, source);
+ const button = await screen.findByRole('button', { name: 'View in source markdown' });
+ const editor = getEditor();
+ act(() => editor.commands.setTextSelection(editor.state.doc.content.size - 1));
+ expect(editor.state.selection.$from.index(0)).toBe(2);
+ if (activation === 'click') await user.click(button);
+ else {
+ button.focus();
+ await user.keyboard('{Enter}');
+ }
+ const nav = peekPendingSourceNavigation('budget-recovery');
+ if (nav?.kind !== 'selection-offset') throw new Error('expected source navigation');
+ expect(nav.anchor.blockIndex).toBe(1);
+ },
+ );
+
+ test.each([
+ ['block', 'changed'],
+ ['block', 'removed'],
+ ['inline', 'changed'],
+ ['inline', 'removed'],
+ ] as const)(
+ 'mounted over-budget %s recovery reports a %s target without jumping to the caret',
+ async (kind, reason) => {
+ const { content, source } = recoveryDocument(kind);
+ const { getEditor } = mountEditor(content, source);
+ const button = await screen.findByRole('button', { name: 'View in source markdown' });
+ const editor = getEditor();
+ let targetPos: number | undefined;
+ editor.state.doc.descendants((node, pos) => {
+ if (node.type.name === (kind === 'block' ? 'jsxComponent' : 'jsxInline')) targetPos = pos;
+ });
+ if (targetPos === undefined) throw new Error('target missing');
+ const pos = targetPos;
+ const target = editor.state.doc.nodeAt(pos);
+ if (!target) throw new Error('target missing');
+ act(() => {
+ editor.commands.setTextSelection(editor.state.doc.content.size - 1);
+ const tr = editor.state.tr;
+ if (reason === 'removed') tr.delete(pos, pos + target.nodeSize);
+ else tr.setNodeMarkup(pos, undefined, { ...target.attrs, sourceRaw: 'changed' });
+ editor.view.dispatch(tr);
+ fireEvent.click(button);
+ });
+ expect(peekPendingSourceNavigation('budget-recovery')).toBeNull();
+ expect(
+ await screen.findByText(
+ reason === 'removed'
+ ? 'This component was removed.'
+ : 'This component changed. Try again.',
+ ),
+ ).toBeTruthy();
+ expect(getParseHealth().jsxActionAborted).toEqual({ 'edit-source': 1 });
+ },
+ );
+ test('contains budget overflow introduced by a real legacy prop rename', async () => {
+ const props = { id: 'x'.repeat(999998) };
+ let mounted: ReturnType<typeof mountEditor> | undefined;
+ expect(() => {
+ mounted = mountEditor({
+ type: 'doc',
+ content: [
+ {
+ type: 'jsxComponent',
+ attrs: {
+ componentName: 'MirrorSource',
+ props,
+ sourceRaw: '',
+ sourceDirty: true,
+ },
+ },
+ ],
+ });
+ }).not.toThrow();
+ await waitFor(() => {
+ expect(screen.getByRole('status').textContent).toContain(
+ 'This component is too large to render.',
+ );
+ });
+ expect(mounted?.getEditor().state.doc.firstChild?.attrs.props).toBe(props);
+ });
+
+ test('shows an over-budget block body once instead of repeating cached source', async () => {
+ let items: unknown = 0;
+ for (let i = 0; i < 65; i++) items = [items];
+ mountEditor({
+ type: 'doc',
+ content: [
+ {
+ type: 'jsxComponent',
+ attrs: {
+ componentName: 'Callout',
+ props: { items },
+ sourceDirty: true,
+ sourceRaw: '<Callout>\n\nRetain this body once.\n\n</Callout>',
+ },
+ content: [
+ { type: 'paragraph', content: [{ type: 'text', text: 'Retain this body once.' }] },
+ ],
+ },
+ ],
+ });
+ await waitFor(() => {
+ expect(document.querySelector('[data-jsx-props-error]')).toBeTruthy();
+ });
+ expect(
+ document.querySelector('.ProseMirror')?.textContent?.match(/Retain this body once\./g),
+ ).toHaveLength(1);
+ expect(screen.getByRole('status').textContent).toContain(
+ 'This component is too large to render.',
+ );
+ expect(screen.getByRole('button', { name: 'View in source markdown' })).toBeTruthy();
+ });
+
+ test.each(['block', 'inline'] as const)(
+ 'retains over-budget %s props as recoverable source without changing the document',
+ async (kind) => {
+ const manager = getSharedMarkdownManager();
+ const source = `<Callout items={${'['.repeat(6000)}0${']'.repeat(6000)}} />`;
+ const parsed = manager.parseWithFallback(
+ kind === 'block' ? source : `before ${source} after`,
+ );
+ const { getEditor } = mountEditor(parsed);
+ await waitFor(() => {
+ expect(document.querySelector('.ProseMirror')?.textContent).toContain(source);
+ });
+ const editor = getEditor();
+ const stored =
+ kind === 'block' ? editor.state.doc.firstChild : editor.state.doc.firstChild?.child(1);
+ expect(stored?.type.name).toBe(kind === 'block' ? 'rawMdxFallback' : 'jsxInline');
+ expect(stored?.textContent).toBe(source);
+ expect(manager.serialize(editor.getJSON())).toContain(source);
+ if (kind === 'inline') expect(document.body.textContent).toContain(' after');
+ },
+ );
+
+ test.each([
+ ['block', 'cached'],
+ ['block', 'empty'],
+ ['inline', 'cached'],
+ ['inline', 'empty'],
+ ] as const)(
+ 'contains already-materialized over-budget %s props with %s source without mutating them',
+ async (kind, cached) => {
+ const source = cached === 'cached' ? '<Callout title="Recover in source mode" />' : '';
+ let items: unknown = 0;
+ for (let i = 0; i < 65; i++) items = [items];
+ const attrs = {
+ componentName: 'Callout',
+ props: { items },
+ sourceRaw: source,
+ sourceDirty: true,
+ };
+ const content =
+ kind === 'inline'
+ ? docWithInline(attrs)
+ : {
+ type: 'doc',
+ content: [{ type: 'jsxComponent', attrs }],
+ };
+ const { getEditor } = mountEditor(content);
+ await waitFor(() => {
+ expect(screen.getByRole('status').textContent).toContain(
+ 'This component is too large to render.',
+ );
+ });
+ if (source)
+ expect(document.querySelector('[data-jsx-props-error]')?.textContent).not.toContain(source);
+ expect(screen.getByRole('button', { name: 'View in source markdown' })).toBeTruthy();
+ const notice = screen.getByRole('status');
+ const action = screen.getByRole('button', { name: 'View in source markdown' });
+ expect(notice.querySelector('button')).toBeNull();
+ expect(action.closest('[role="status"]')).toBeNull();
+ expect(notice.closest(`[${OPT_OUT_ATTR}="true"]`)).not.toBeNull();
+ const editor = getEditor();
+ const stored =
+ kind === 'block' ? editor.state.doc.firstChild : editor.state.doc.firstChild?.child(1);
+ expect(stored?.attrs.props).toBe(attrs.props);
+ expect(stored?.attrs.sourceDirty).toBe(true);
+ },
+ );
+
test('normalizes a local inline img src against its document before rendering', async () => {
const desktopWindow = window as typeof window & {
okDesktop?: { config: { apiOrigin: string } };
diff --git a/packages/app/src/editor/extensions/JsxInlineView.tsx b/packages/app/src/editor/extensions/JsxInlineView.tsx
index 93087d96e..f44eb30f0 100644
--- a/packages/app/src/editor/extensions/JsxInlineView.tsx
+++ b/packages/app/src/editor/extensions/JsxInlineView.tsx
@@ -7,10 +7,13 @@ import { useEffect, useRef, useState } from 'react';
import { ErrorBoundary } from 'react-error-boundary';
import { Button } from '../../components/ui/button.tsx';
import { Popover, PopoverContent, PopoverTrigger } from '../../components/ui/popover.tsx';
+import { ViewInSourceBubbleButton } from '../bubble-menu/ViewInSourceBubbleButton.tsx';
+import { OPT_OUT_ATTR } from '../clipboard/index.ts';
import { PropPanel } from '../components/PropPanel.tsx';
import { getDescriptor } from '../registry/index.ts';
import { attrsWithChangedProp, getElementJsxAttrs, stableHash } from './JsxComponentView.tsx';
-import { extractPrimitiveProps, resolveJsxSourceDocName } from './jsx-render-contract.ts';
+import { resolveJsxActionTarget } from './jsx-node-action.ts';
+import { prepareJsxProps, resolveJsxSourceDocName } from './jsx-render-contract.ts';
import { normalizeDocRelativeMediaRenderProps } from './media-render-props.ts';
export function JsxInlineView(viewProps: NodeViewProps) {
@@ -41,11 +44,11 @@ function RegisteredInlineView({
const [popoverOpen, setPopoverOpen] = useState(false);
const wasSelected = useRef(false);
- const primitiveProps = extractPrimitiveProps(node.attrs, descriptor);
- const bodyText = (node.attrs.props as Record<string, unknown> | undefined)?.children;
- if (typeof bodyText === 'string' && bodyText !== '') {
- (primitiveProps as Record<string, unknown>).children = bodyText;
- }
+ const { props: primitiveProps, error: propsError } = prepareJsxProps(
+ node.attrs,
+ descriptor,
+ true,
+ );
const renderProps = normalizeDocRelativeMediaRenderProps(
descriptor.name,
primitiveProps,
@@ -71,6 +74,31 @@ function RegisteredInlineView({
const { children: _body, ...panelValues } = primitiveProps;
+ if (propsError) {
+ return (
+ <NodeViewWrapper as="span" data-jsx-inline="" data-jsx-props-error="">
+ <span
+ className="inline-flex flex-wrap items-center gap-1 text-xs text-warning"
+ contentEditable={false}
+ {...{ [OPT_OUT_ATTR]: 'true' }}
+ >
+ <span role="status">
+ <Trans>This component is too large to render.</Trans>
+ </span>
+ <ViewInSourceBubbleButton
+ editor={editor}
+ getTargetPosition={() =>
+ resolveJsxActionTarget(
+ { editor, getPos, node, descriptorName: descriptor.name },
+ 'edit-source',
+ )?.pos
+ }
+ />
+ </span>
+ </NodeViewWrapper>
+ );
+ }
+
return (
<NodeViewWrapper
as="span"
diff --git a/packages/app/src/editor/extensions/jsx-node-action.ts b/packages/app/src/editor/extensions/jsx-node-action.ts
new file mode 100644
index 000000000..2229e94bf
--- /dev/null
+++ b/packages/app/src/editor/extensions/jsx-node-action.ts
@@ -0,0 +1,41 @@
+import {
+ incrementJsxActionAborted,
+ type JsxNodeAction,
+} from '@inkeep/open-knowledge-core/metrics/parse-health';
+import { t } from '@lingui/core/macro';
+import type { NodeViewProps } from '@tiptap/core';
+import { toast } from 'sonner';
+import { resolveJsxNodeTarget } from './jsx-node-target.ts';
+
+type JsxActionContext = Pick<NodeViewProps, 'editor' | 'getPos' | 'node'> & {
+ descriptorName: string;
+};
+
+export function reportJsxActionAborted(
+ context: Pick<JsxActionContext, 'node' | 'descriptorName'>,
+ action: JsxNodeAction,
+ reason: 'changed' | 'removed',
+): void {
+ incrementJsxActionAborted(action);
+ console.warn(
+ JSON.stringify({
+ event: 'jsx-component-action-aborted',
+ action,
+ reason,
+ component: context.descriptorName === '*' ? 'wildcard' : context.descriptorName,
+ rawComponentName: String(context.node.attrs.componentName ?? '').slice(0, 200),
+ }),
+ );
+ toast.info(
+ reason === 'removed' ? t`This component was removed.` : t`This component changed. Try again.`,
+ );
+}
+
+export function resolveJsxActionTarget(context: JsxActionContext, action: JsxNodeAction) {
+ const target = resolveJsxNodeTarget(context.editor.state.doc, context.getPos, context.node);
+ if (target.kind !== 'current') {
+ reportJsxActionAborted(context, action, target.kind);
+ return null;
+ }
+ return target;
+}
diff --git a/packages/app/src/editor/extensions/jsx-render-contract.test.ts b/packages/app/src/editor/extensions/jsx-render-contract.test.ts
new file mode 100644
index 000000000..7a0b978d8
--- /dev/null
+++ b/packages/app/src/editor/extensions/jsx-render-contract.test.ts
@@ -0,0 +1,36 @@
+import { describe, expect, test } from 'vitest';
+import { getDescriptor } from '../registry/index.ts';
+import { prepareJsxProps } from './jsx-render-contract.ts';
+
+describe('prepareJsxProps', () => {
+ test('contains a real legacy rename that crosses the text budget', () => {
+ const descriptor = getDescriptor('MirrorSource');
+ const value = 'x'.repeat(999996);
+ const allowed = prepareJsxProps({ props: { id: value } }, descriptor);
+ expect(allowed.error).toBeNull();
+ expect(allowed.props.name).toBe(value);
+ expect(prepareJsxProps({ props: { id: `${value}xx` } }, descriptor)).toEqual({
+ props: {},
+ error: 'Component props exceed the rendering budget',
+ });
+ });
+
+ test('includes inline body text before validating transformed props', () => {
+ const result = prepareJsxProps(
+ { props: { id: 'x'.repeat(999989), children: 'a' } },
+ getDescriptor('MirrorSource'),
+ true,
+ );
+ expect(result).toEqual({ props: {}, error: 'Component props exceed the rendering budget' });
+ });
+
+ test('keeps ordinary inline text children while preserving block content holes', () => {
+ const attrs = { props: { type: 'warning', children: 'Keep this body' } };
+ const descriptor = getDescriptor('Callout');
+ expect(prepareJsxProps(attrs, descriptor, true)).toEqual({
+ props: { type: 'warning', children: 'Keep this body' },
+ error: null,
+ });
+ expect(prepareJsxProps(attrs, descriptor)).toEqual({ props: { type: 'warning' }, error: null });
+ });
+});
diff --git a/packages/app/src/editor/extensions/jsx-render-contract.ts b/packages/app/src/editor/extensions/jsx-render-contract.ts
index 4f0c12e3c..0b823e719 100644
--- a/packages/app/src/editor/extensions/jsx-render-contract.ts
+++ b/packages/app/src/editor/extensions/jsx-render-contract.ts
@@ -1,5 +1,9 @@
import { incrementJsxRenderFailure } from '@inkeep/open-knowledge-core/metrics/parse-health';
-import { resolveLegacyProps } from '@inkeep/open-knowledge-core/registry';
+import {
+ COMPONENT_PROPS_BUDGET_ERROR,
+ componentPropsBudgetError,
+ resolveLegacyProps,
+} from '@inkeep/open-knowledge-core/registry';
import type { Editor } from '@tiptap/core';
import type { Node as PmNode } from '@tiptap/pm/model';
import type { ErrorInfo } from 'react';
@@ -11,9 +15,12 @@ import { normalizeDocRelativeMediaRenderProps } from './media-render-props.ts';
export const JSX_WRAPPER_CLASS = 'jsx-component-wrapper my-2';
+type JsxPropsDescriptor = Pick<JsxComponentDescriptor, 'props' | 'reactNodePropNames'>;
+
export function extractPrimitiveProps(
attrs: Record<string, unknown>,
- descriptor: Pick<JsxComponentDescriptor, 'props' | 'reactNodePropNames'>,
+ descriptor: JsxPropsDescriptor,
+ includeTextChildren = false,
): Record<string, unknown> {
const propsObj = resolveLegacyProps(
descriptor.props,
@@ -21,12 +28,33 @@ export function extractPrimitiveProps(
);
const result: Record<string, unknown> = {};
for (const [key, value] of Object.entries(propsObj)) {
- if (descriptor.reactNodePropNames.has(key)) continue;
+ if (
+ descriptor.reactNodePropNames.has(key) &&
+ !(includeTextChildren && key === 'children' && typeof value === 'string' && value !== '')
+ )
+ continue;
result[key] = value;
}
return sanitizeComponentProps(result);
}
+export function prepareJsxProps(
+ attrs: Record<string, unknown>,
+ descriptor: JsxPropsDescriptor,
+ includeTextChildren = false,
+): { props: Record<string, unknown>; error: string | null } {
+ const error = componentPropsBudgetError(attrs.props);
+ if (error) return { props: {}, error };
+ try {
+ return { props: extractPrimitiveProps(attrs, descriptor, includeTextChildren), error: null };
+ } catch (error) {
+ if (error instanceof RangeError && error.message === COMPONENT_PROPS_BUDGET_ERROR) {
+ return { props: {}, error: error.message };
+ }
+ throw error;
+ }
+}
+
export function resolveJsxSourceDocName(extensionOptions: unknown, editor: Editor): string | null {
const configuredDocName = (extensionOptions as { docName?: unknown }).docName;
return typeof configuredDocName === 'string' && configuredDocName
diff --git a/packages/app/src/editor/mode-switch-landing.ts b/packages/app/src/editor/mode-switch-landing.ts
index 4f28edb4b..65400654c 100644
--- a/packages/app/src/editor/mode-switch-landing.ts
+++ b/packages/app/src/editor/mode-switch-landing.ts
@@ -57,11 +57,12 @@ export function requestViewInSource(params: {
editor: Editor;
docName: string;
ytext: Y.Text;
+ pmPosition?: number;
}): void {
const { editor, docName, ytext } = params;
const view = getEditorView(editor);
if (!view) return;
- const pos = view.state.selection.from;
+ const pos = params.pmPosition ?? view.state.selection.from;
const nav = buildSourceLandingNav(view.state.doc, pos, ytext, getSharedResolver(), 'jump');
if (nav) rememberPendingSourceNavigation(docName, nav);
window.dispatchEvent(
diff --git a/packages/app/src/editor/utils/sanitize-url.test.ts b/packages/app/src/editor/utils/sanitize-url.test.ts
index 3bc1e2d3f..959193434 100644
--- a/packages/app/src/editor/utils/sanitize-url.test.ts
+++ b/packages/app/src/editor/utils/sanitize-url.test.ts
@@ -237,6 +237,27 @@ describe('sanitizeComponentProps — style handling', () => {
});
});
+describe('sanitizeComponentProps — rendering limits', () => {
+ test('rejects already-materialized deeply nested props before recursive traversal', () => {
+ const props = { items: JSON.parse(`${'['.repeat(6000)}0${']'.repeat(6000)}`) };
+ expect(() => sanitizeComponentProps(props)).toThrow('rendering budget');
+ });
+
+ test('rejects excessive breadth even without deep nesting', () => {
+ expect(() => sanitizeComponentProps({ items: Array.from({ length: 10001 }, () => 0) })).toThrow(
+ 'rendering budget',
+ );
+ });
+
+ test('retains ordinary nested props and their URL protection', () => {
+ expect(
+ sanitizeComponentProps({
+ items: [{ meta: { href: 'javascript:alert(1)', title: 'Keep me' } }],
+ }),
+ ).toEqual({ items: [{ meta: { href: '#', title: 'Keep me' } }] });
+ });
+});
+
describe('sanitizeComponentProps — nested URL traversal', () => {
test('sanitizes URLs inside nested array of objects (InlineTOC.items shape)', () => {
const input = {
diff --git a/packages/app/src/editor/utils/sanitize-url.ts b/packages/app/src/editor/utils/sanitize-url.ts
index ee6e5b3fb..264e119f9 100644
--- a/packages/app/src/editor/utils/sanitize-url.ts
+++ b/packages/app/src/editor/utils/sanitize-url.ts
@@ -1,5 +1,6 @@
import { isRelativeUrl, SAFE_URL_SCHEMES } from '@inkeep/open-knowledge-core/markdown/safe-url';
import { incrementJsxPropDropped } from '@inkeep/open-knowledge-core/metrics/parse-health';
+import { componentPropsBudgetError } from '@inkeep/open-knowledge-core/registry';
const URL_SCHEME_ALLOWLIST = new Set(SAFE_URL_SCHEMES.map((s) => `${s}:`));
@@ -137,6 +138,8 @@ function sanitizeNested(value: unknown): unknown {
}
export function sanitizeComponentProps(props: Record<string, unknown>): Record<string, unknown> {
+ const budgetError = componentPropsBudgetError(props);
+ if (budgetError) throw new RangeError(budgetError);
let changed = false;
const result: Record<string, unknown> = {};
for (const [key, value] of Object.entries(props)) {
diff --git a/packages/app/src/editor/utils/severity.test.ts b/packages/app/src/editor/utils/severity.test.ts
index 3f0600ac7..4ecc8537b 100644
--- a/packages/app/src/editor/utils/severity.test.ts
+++ b/packages/app/src/editor/utils/severity.test.ts
@@ -2,6 +2,10 @@ import { describe, expect, test } from 'vitest';
import { classifySeverity, SEVERITY_STYLES } from './severity';
describe('classifySeverity', () => {
+ test('rendering-budget fallback is a size limit rather than a parse error', () => {
+ expect(classifySeverity('Component props exceed the rendering budget')).toBe('limit');
+ expect(SEVERITY_STYLES.limit.label).toBe('size limit');
+ });
test('unregistered-component reasons classify as info', () => {
expect(classifySeverity('Unregistered component: DataViz')).toBe('info');
expect(classifySeverity('Unregistered component: SomethingElse')).toBe('info');
diff --git a/packages/app/src/editor/utils/severity.ts b/packages/app/src/editor/utils/severity.ts
index dad5c6c60..22d15a6ff 100644
--- a/packages/app/src/editor/utils/severity.ts
+++ b/packages/app/src/editor/utils/severity.ts
@@ -1,10 +1,12 @@
+import { COMPONENT_PROPS_BUDGET_ERROR } from '@inkeep/open-knowledge-core/registry';
import type { MessageDescriptor } from '@lingui/core';
import { msg } from '@lingui/core/macro';
-type Severity = 'info' | 'warn' | 'error';
+type Severity = 'info' | 'warn' | 'error' | 'limit';
export function classifySeverity(reason: string | undefined): Severity {
if (!reason) return 'error';
+ if (reason === COMPONENT_PROPS_BUDGET_ERROR) return 'limit';
if (reason.startsWith('Unregistered component:')) return 'info';
if (reason.startsWith('Render error in')) return 'warn';
return 'error';
@@ -17,6 +19,11 @@ interface SeverityStyle {
}
export const SEVERITY_STYLES: Record<Severity, SeverityStyle> = {
+ limit: {
+ wrapperClass: 'border-warning/60',
+ badgeClass: 'text-warning bg-warning/10',
+ label: msg`size limit`,
+ },
info: {
wrapperClass: 'border-muted-foreground/30 bg-muted/30',
badgeClass: 'text-muted-foreground bg-muted',
diff --git a/packages/app/src/lib/rendered-diff/diff-jsx-block.tsx b/packages/app/src/lib/rendered-diff/diff-jsx-block.tsx
index 71fa2fc7f..6fc8e7c78 100644
--- a/packages/app/src/lib/rendered-diff/diff-jsx-block.tsx
+++ b/packages/app/src/lib/rendered-diff/diff-jsx-block.tsx
@@ -1,4 +1,4 @@
-import { useLingui } from '@lingui/react/macro';
+import { Trans, useLingui } from '@lingui/react/macro';
import type { Editor } from '@tiptap/core';
import type { Node as PMNode } from '@tiptap/pm/model';
import {
@@ -16,10 +16,10 @@ import { LiveDocAccessContext } from '@/editor/components/live-doc-pool';
import { getEditorDocName } from '@/editor/extensions/doc-context';
import { JsxComponent } from '@/editor/extensions/jsx-component';
import {
- extractPrimitiveProps,
JSX_WRAPPER_CLASS,
jsxChildrenClassName,
jsxWrapperDataAttributes,
+ prepareJsxProps,
reportJsxRenderFailure,
resolveJsxRenderProps,
resolveJsxSourceDocName,
@@ -134,7 +134,17 @@ function DiffJsxBlock({
);
}
- const primitiveProps = extractPrimitiveProps(node.attrs, descriptor);
+ const { props: primitiveProps, error: propsError } = prepareJsxProps(node.attrs, descriptor);
+ if (propsError) {
+ return (
+ <div>
+ <div role="status" className="text-xs text-warning">
+ <Trans>This component is too large to render.</Trans>
+ </div>
+ {children}
+ </div>
+ );
+ }
const renderProps = resolveJsxRenderProps(descriptor, primitiveProps, docName);
if (
diff --git a/packages/app/src/locales/ar/messages.po b/packages/app/src/locales/ar/messages.po
index be5e07055..c9970693e 100644
--- a/packages/app/src/locales/ar/messages.po
+++ b/packages/app/src/locales/ar/messages.po
@@ -9762,6 +9762,9 @@ msgstr "جارٍ تسجيل الدخول إلى {agentName}…"
msgid "Single page"
msgstr "صفحة واحدة"
+msgid "size limit"
+msgstr "حد الحجم"
+
msgid "skill \"{0}\""
msgstr "المهارة «{0}»"
@@ -10935,6 +10938,9 @@ msgstr "هذا التعليق على الخاصية بأكملها"
msgid "This component changed. Try again."
msgstr "لقد تغيّر هذا المكوّن. حاول مرة أخرى."
+msgid "This component is too large to render."
+msgstr "هذا المكوّن كبير جدًا ولا يمكن عرضه."
+
msgid "This component was removed."
msgstr "تمت إزالة هذا المكوّن."
diff --git a/packages/app/src/locales/bn/messages.po b/packages/app/src/locales/bn/messages.po
index b56a65214..b28b986af 100644
--- a/packages/app/src/locales/bn/messages.po
+++ b/packages/app/src/locales/bn/messages.po
@@ -9758,6 +9758,9 @@ msgstr "{agentName}-এ সাইন ইন করা হচ্ছে…"
msgid "Single page"
msgstr "একটি পাতা"
+msgid "size limit"
+msgstr "আকারের সীমা"
+
msgid "skill \"{0}\""
msgstr "স্কিল \"{0}\""
@@ -10931,6 +10934,9 @@ msgstr "এই মন্তব্যটি পুরো প্রপার্ট
msgid "This component changed. Try again."
msgstr "এই উপাদানটি পরিবর্তিত হয়েছে। আবার চেষ্টা করুন।"
+msgid "This component is too large to render."
+msgstr "এই উপাদানটি দেখানোর জন্য খুব বড়।"
+
msgid "This component was removed."
msgstr "এই উপাদানটি সরানো হয়েছে।"
diff --git a/packages/app/src/locales/en/messages.po b/packages/app/src/locales/en/messages.po
index faebc9f6c..2963727ff 100644
--- a/packages/app/src/locales/en/messages.po
+++ b/packages/app/src/locales/en/messages.po
@@ -9762,6 +9762,9 @@ msgstr "Signing in to {agentName}…"
msgid "Single page"
msgstr "Single page"
+msgid "size limit"
+msgstr "size limit"
+
msgid "skill \"{0}\""
msgstr "skill \"{0}\""
@@ -10935,6 +10938,9 @@ msgstr "This comment is on the whole property"
msgid "This component changed. Try again."
msgstr "This component changed. Try again."
+msgid "This component is too large to render."
+msgstr "This component is too large to render."
+
msgid "This component was removed."
msgstr "This component was removed."
diff --git a/packages/app/src/locales/es/messages.po b/packages/app/src/locales/es/messages.po
index 5851e3134..6358700c2 100644
--- a/packages/app/src/locales/es/messages.po
+++ b/packages/app/src/locales/es/messages.po
@@ -9762,6 +9762,9 @@ msgstr "Iniciando sesión en {agentName}…"
msgid "Single page"
msgstr "Página única"
+msgid "size limit"
+msgstr "límite de tamaño"
+
msgid "skill \"{0}\""
msgstr "habilidad \"{0}\""
@@ -10935,6 +10938,9 @@ msgstr "Este comentario es sobre toda la propiedad"
msgid "This component changed. Try again."
msgstr "Este componente ha cambiado. Inténtalo de nuevo."
+msgid "This component is too large to render."
+msgstr "Este componente es demasiado grande para mostrarse."
+
msgid "This component was removed."
msgstr "Este componente se ha eliminado."
diff --git a/packages/app/src/locales/fr/messages.po b/packages/app/src/locales/fr/messages.po
index dec873295..989226819 100644
--- a/packages/app/src/locales/fr/messages.po
+++ b/packages/app/src/locales/fr/messages.po
@@ -9762,6 +9762,9 @@ msgstr "Connexion à {agentName}…"
msgid "Single page"
msgstr "Page unique"
+msgid "size limit"
+msgstr "limite de taille"
+
msgid "skill \"{0}\""
msgstr "compétence « {0} »"
@@ -10935,6 +10938,9 @@ msgstr "Ce commentaire porte sur toute la propriété"
msgid "This component changed. Try again."
msgstr "Ce composant a changé. Réessayez."
+msgid "This component is too large to render."
+msgstr "Ce composant est trop volumineux pour être affiché."
+
msgid "This component was removed."
msgstr "Ce composant a été supprimé."
diff --git a/packages/app/src/locales/hi/messages.po b/packages/app/src/locales/hi/messages.po
index 157098a3b..d1c6c4477 100644
--- a/packages/app/src/locales/hi/messages.po
+++ b/packages/app/src/locales/hi/messages.po
@@ -9758,6 +9758,9 @@ msgstr "{agentName} में साइन इन किया जा रहा
msgid "Single page"
msgstr "एक पेज"
+msgid "size limit"
+msgstr "आकार सीमा"
+
msgid "skill \"{0}\""
msgstr "स्किल \"{0}\""
@@ -10931,6 +10934,9 @@ msgstr "यह टिप्पणी पूरी प्रॉपर्टी
msgid "This component changed. Try again."
msgstr "यह घटक बदल गया है। फिर से कोशिश करें।"
+msgid "This component is too large to render."
+msgstr "यह घटक दिखाने के लिए बहुत बड़ा है।"
+
msgid "This component was removed."
msgstr "यह घटक हटा दिया गया है।"
diff --git a/packages/app/src/locales/id/messages.po b/packages/app/src/locales/id/messages.po
index 6adc295d1..b54f4bf72 100644
--- a/packages/app/src/locales/id/messages.po
+++ b/packages/app/src/locales/id/messages.po
@@ -9758,6 +9758,9 @@ msgstr "Sedang masuk ke {agentName}…"
msgid "Single page"
msgstr "Satu halaman"
+msgid "size limit"
+msgstr "batas ukuran"
+
msgid "skill \"{0}\""
msgstr "keterampilan \"{0}\""
@@ -10931,6 +10934,9 @@ msgstr "Komentar ini berlaku untuk seluruh properti"
msgid "This component changed. Try again."
msgstr "Komponen ini telah berubah. Coba lagi."
+msgid "This component is too large to render."
+msgstr "Komponen ini terlalu besar untuk ditampilkan."
+
msgid "This component was removed."
msgstr "Komponen ini telah dihapus."
diff --git a/packages/app/src/locales/ko/messages.po b/packages/app/src/locales/ko/messages.po
index b65b8f75a..53f9462c7 100644
--- a/packages/app/src/locales/ko/messages.po
+++ b/packages/app/src/locales/ko/messages.po
@@ -9762,6 +9762,9 @@ msgstr "{agentName} 로그인 중…"
msgid "Single page"
msgstr "한 페이지"
+msgid "size limit"
+msgstr "크기 제한"
+
msgid "skill \"{0}\""
msgstr "스킬 \"{0}\""
@@ -10935,6 +10938,9 @@ msgstr "이 댓글, 속성 전체에 적용됨"
msgid "This component changed. Try again."
msgstr "이 컴포넌트가 변경되었습니다. 다시 시도하세요."
+msgid "This component is too large to render."
+msgstr "이 컴포넌트는 너무 커서 표시할 수 없습니다."
+
msgid "This component was removed."
msgstr "이 컴포넌트가 삭제되었습니다."
diff --git a/packages/app/src/locales/pl/messages.po b/packages/app/src/locales/pl/messages.po
index 2489ff111..2cee585b9 100644
--- a/packages/app/src/locales/pl/messages.po
+++ b/packages/app/src/locales/pl/messages.po
@@ -9762,6 +9762,9 @@ msgstr "Logowanie do {agentName}…"
msgid "Single page"
msgstr "Pojedyncza strona"
+msgid "size limit"
+msgstr "limit rozmiaru"
+
msgid "skill \"{0}\""
msgstr "umiejętność \"{0}\""
@@ -10935,6 +10938,9 @@ msgstr "Ten komentarz dotyczy całej właściwości"
msgid "This component changed. Try again."
msgstr "Ten komponent się zmienił. Spróbuj ponownie."
+msgid "This component is too large to render."
+msgstr "Ten komponent jest zbyt duży, aby go wyświetlić."
+
msgid "This component was removed."
msgstr "Ten komponent został usunięty."
diff --git a/packages/app/src/locales/pt-BR/messages.po b/packages/app/src/locales/pt-BR/messages.po
index 6d2363bd1..f410400f9 100644
--- a/packages/app/src/locales/pt-BR/messages.po
+++ b/packages/app/src/locales/pt-BR/messages.po
@@ -9758,6 +9758,9 @@ msgstr "Fazendo login em {agentName}…"
msgid "Single page"
msgstr "Página única"
+msgid "size limit"
+msgstr "limite de tamanho"
+
msgid "skill \"{0}\""
msgstr "habilidade \"{0}\""
@@ -10931,6 +10934,9 @@ msgstr "Este comentário é sobre a propriedade inteira"
msgid "This component changed. Try again."
msgstr "Este componente foi alterado. Tente novamente."
+msgid "This component is too large to render."
+msgstr "Este componente é grande demais para ser exibido."
+
msgid "This component was removed."
msgstr "Este componente foi removido."
diff --git a/packages/app/src/locales/ur/messages.po b/packages/app/src/locales/ur/messages.po
index 403201941..58382ddb4 100644
--- a/packages/app/src/locales/ur/messages.po
+++ b/packages/app/src/locales/ur/messages.po
@@ -9762,6 +9762,9 @@ msgstr "{agentName} میں سائن اِن کیا جا رہا ہے…"
msgid "Single page"
msgstr "ایک صفحہ"
+msgid "size limit"
+msgstr "حجم کی حد"
+
msgid "skill \"{0}\""
msgstr "مہارت «{0}»"
@@ -10935,6 +10938,9 @@ msgstr "یہ تبصرہ پوری خصوصیت پر ہے"
msgid "This component changed. Try again."
msgstr "یہ جزو تبدیل ہو گیا ہے۔ دوبارہ کوشش کریں۔"
+msgid "This component is too large to render."
+msgstr "یہ جزو دکھانے کے لیے بہت بڑا ہے۔"
+
msgid "This component was removed."
msgstr "یہ جزو ہٹا دیا گیا ہے۔"
diff --git a/packages/app/src/locales/zh-Hans/messages.po b/packages/app/src/locales/zh-Hans/messages.po
index 6d1d9e6e5..9d0539497 100644
--- a/packages/app/src/locales/zh-Hans/messages.po
+++ b/packages/app/src/locales/zh-Hans/messages.po
@@ -9762,6 +9762,9 @@ msgstr "正在登录 {agentName}…"
msgid "Single page"
msgstr "单页"
+msgid "size limit"
+msgstr "大小限制"
+
msgid "skill \"{0}\""
msgstr "技能“{0}”"
@@ -10935,6 +10938,9 @@ msgstr "这条评论针对的是整个属性"
msgid "This component changed. Try again."
msgstr "此组件已更改。请重试。"
+msgid "This component is too large to render."
+msgstr "此组件过大,无法显示。"
+
msgid "This component was removed."
msgstr "此组件已被移除。"
diff --git a/packages/app/src/locales/zh-Hant/messages.po b/packages/app/src/locales/zh-Hant/messages.po
index 434b19260..d4128a8f3 100644
--- a/packages/app/src/locales/zh-Hant/messages.po
+++ b/packages/app/src/locales/zh-Hant/messages.po
@@ -9762,6 +9762,9 @@ msgstr "正在登入 {agentName}…"
msgid "Single page"
msgstr "單頁"
+msgid "size limit"
+msgstr "大小限制"
+
msgid "skill \"{0}\""
msgstr "技能「{0}」"
@@ -10935,6 +10938,9 @@ msgstr "這則註解是針對整個屬性的"
msgid "This component changed. Try again."
msgstr "此元件已變更。請再試一次。"
+msgid "This component is too large to render."
+msgstr "此元件過大,無法顯示。"
+
msgid "This component was removed."
msgstr "此元件已被移除。"
diff --git a/packages/app/tests/stress/jsx-props-budget.e2e.ts b/packages/app/tests/stress/jsx-props-budget.e2e.ts
new file mode 100644
index 000000000..415624811
--- /dev/null
+++ b/packages/app/tests/stress/jsx-props-budget.e2e.ts
@@ -0,0 +1,34 @@
+import { randomUUID } from 'node:crypto';
+import { expect, test } from './_helpers';
+
+test('over-budget MDX props remain editable source without disrupting neighboring content', async ({
+ page,
+ api,
+}) => {
+ const docName = `jsx-props-budget-${randomUUID().slice(0, 8)}`;
+ const jsx = `<Callout items={${'['.repeat(6000)}0${']'.repeat(6000)}} />`;
+ const source = `# Before\n\n${jsx}\n\nAfter remains visible.\n`;
+ await api.seedDocs([{ name: docName, markdown: source }]);
+ await page.goto(`/#/${docName}`);
+ await page.waitForFunction(() => Boolean(window.__activeProvider?.isSynced));
+ const fallback = page.getByRole('group', {
+ name: 'Editing broken MDX source: Component props exceed the rendering budget',
+ });
+ await expect(fallback).toBeVisible();
+ await expect(page.getByText('size limit', { exact: true })).toBeVisible();
+ await expect(fallback.getByRole('textbox')).toBeEditable();
+ expect(
+ await page.evaluate(() => {
+ let raw = '';
+ window.__activeEditor?.state.doc.descendants((node) => {
+ if (node.type.name === 'rawMdxFallback') raw = node.textContent;
+ });
+ return raw;
+ }),
+ ).toBe(jsx);
+ await expect(page.getByRole('heading', { name: 'Before', exact: true })).toBeVisible();
+ await expect(page.getByText('After remains visible.', { exact: true })).toBeVisible();
+ expect(
+ await page.evaluate(() => window.__activeProvider?.document.getText('source').toString()),
+ ).toBe(source);
+});
diff --git a/packages/core/src/markdown/index.ts b/packages/core/src/markdown/index.ts
index 35e1beb2c..77f0dc5d7 100644
--- a/packages/core/src/markdown/index.ts
+++ b/packages/core/src/markdown/index.ts
@@ -55,7 +55,7 @@ import {
} from '../bridge/structural-freshness.ts';
import type { LinkStyle } from '../extensions/link-fidelity.ts';
import { isValidSourceLiteralRaw } from '../extensions/source-literal-mark.ts';
-import { createRegistry, jsxAttributeValue } from '../registry/index.ts';
+import { componentPropsBudgetError, createRegistry, jsxAttributeValue } from '../registry/index.ts';
import type { PropDef, SerializeContext } from '../registry/types.ts';
import {
type AuthoredJsxSourceReader,
@@ -751,6 +751,14 @@ function buildMdastToPmHandlers(
const name = node.name ?? '';
const descriptor = registry.getOrWildcard(name);
const structuredAttrs = destructureAttrs(node.attributes, descriptor.props);
+ const propsError = componentPropsBudgetError(structuredAttrs);
+ if (propsError && n.rawMdxFallback) {
+ const raw = rawFromData(node.data) ?? '';
+ return n.rawMdxFallback.createAndFill(
+ { reason: propsError },
+ raw ? schema.text(raw) : null,
+ );
+ }
if (name === 'CommonMarkImage' && typeof structuredAttrs.src === 'string') {
const origUrl = structuredAttrs.src;
const normalized = normalizeDocRelativeAssetUrl(origUrl, parseCtx.current.sourcePath);
@@ -803,6 +811,9 @@ function buildMdastToPmHandlers(
if (bodyText) {
structuredAttrs.children = bodyText;
}
+ if (componentPropsBudgetError(structuredAttrs)) {
+ return n.jsxInline.createAndFill({}, raw ? [schema.text(raw)] : null);
+ }
return n.jsxInline.createAndFill({
componentName: inlineName,
attributes: node.attributes,
diff --git a/packages/core/src/registry/component-props-budget.test.ts b/packages/core/src/registry/component-props-budget.test.ts
new file mode 100644
index 000000000..6005fcf43
--- /dev/null
+++ b/packages/core/src/registry/component-props-budget.test.ts
@@ -0,0 +1,47 @@
+import { describe, expect, test } from 'vitest';
+import {
+ COMPONENT_PROPS_BUDGET_ERROR,
+ componentPropsBudgetError,
+} from './component-props-budget.ts';
+
+describe('componentPropsBudgetError', () => {
+ test('rejects excessive depth without recursive traversal', () => {
+ const props = { items: JSON.parse(`${'['.repeat(6000)}0${']'.repeat(6000)}`) };
+ expect(componentPropsBudgetError(props)).toBe(COMPONENT_PROPS_BUDGET_ERROR);
+ });
+
+ test('permits the depth boundary and rejects one level beyond it', () => {
+ let value: unknown = 'safe';
+ for (let i = 0; i < 63; i++) value = [value];
+ expect(componentPropsBudgetError({ items: value })).toBeNull();
+ expect(componentPropsBudgetError({ items: [value] })).toBe(COMPONENT_PROPS_BUDGET_ERROR);
+ });
+
+ test('bounds total values across sibling props rather than per subtree', () => {
+ const allowed = {
+ a: Array.from({ length: 4999 }, () => 0),
+ b: Array.from({ length: 4998 }, () => 0),
+ };
+ expect(componentPropsBudgetError(allowed)).toBeNull();
+ expect(componentPropsBudgetError({ ...allowed, c: 0 })).toBe(COMPONENT_PROPS_BUDGET_ERROR);
+ });
+
+ test('bounds aggregate text including keys', () => {
+ const allowed = { a: 'x'.repeat(499999), b: 'x'.repeat(499999) };
+ expect(componentPropsBudgetError(allowed)).toBeNull();
+ expect(componentPropsBudgetError({ ...allowed, c: '' })).toBe(COMPONENT_PROPS_BUDGET_ERROR);
+ });
+
+ test('rejects cycles without recursing indefinitely', () => {
+ const props: Record<string, unknown> = {};
+ props.items = props;
+ expect(componentPropsBudgetError(props)).toBe(COMPONENT_PROPS_BUDGET_ERROR);
+ });
+
+ test('bounds sparse arrays before visiting their contents', () => {
+ expect(componentPropsBudgetError({ items: new Array(9998) })).toBeNull();
+ expect(componentPropsBudgetError({ items: new Array(9999) })).toBe(
+ COMPONENT_PROPS_BUDGET_ERROR,
+ );
+ });
+});
diff --git a/packages/core/src/registry/component-props-budget.ts b/packages/core/src/registry/component-props-budget.ts
new file mode 100644
index 000000000..9d1169fe9
--- /dev/null
+++ b/packages/core/src/registry/component-props-budget.ts
@@ -0,0 +1,36 @@
+const MAX_DEPTH = 64;
+const MAX_VALUES = 10_000;
+const MAX_TEXT_LENGTH = 1_000_000;
+export const COMPONENT_PROPS_BUDGET_ERROR = 'Component props exceed the rendering budget';
+
+export function componentPropsBudgetError(value: unknown): string | null {
+ const stack = [{ value, depth: 0 }];
+ let values = 1;
+ let textLength = 0;
+ while (stack.length > 0) {
+ const entry = stack.pop();
+ if (!entry) break;
+ if (entry.depth > MAX_DEPTH) return COMPONENT_PROPS_BUDGET_ERROR;
+ if (typeof entry.value === 'string') textLength += entry.value.length;
+ if (textLength > MAX_TEXT_LENGTH) return COMPONENT_PROPS_BUDGET_ERROR;
+ if (entry.value === null || typeof entry.value !== 'object') continue;
+ if (Array.isArray(entry.value)) {
+ values += entry.value.length;
+ if (values > MAX_VALUES) return COMPONENT_PROPS_BUDGET_ERROR;
+ for (const child of entry.value) stack.push({ value: child, depth: entry.depth + 1 });
+ } else {
+ for (const key in entry.value) {
+ if (!Object.hasOwn(entry.value, key)) continue;
+ values += 1;
+ textLength += key.length;
+ if (values > MAX_VALUES || textLength > MAX_TEXT_LENGTH)
+ return COMPONENT_PROPS_BUDGET_ERROR;
+ stack.push({
+ value: (entry.value as Record<string, unknown>)[key],
+ depth: entry.depth + 1,
+ });
+ }
+ }
+ }
+ return null;
+}
diff --git a/packages/core/src/registry/index.ts b/packages/core/src/registry/index.ts
index 2eb843117..782c6ba27 100644
--- a/packages/core/src/registry/index.ts
+++ b/packages/core/src/registry/index.ts
@@ -1,4 +1,8 @@
export { builtInComponents } from './built-ins.ts';
+export {
+ COMPONENT_PROPS_BUDGET_ERROR,
+ componentPropsBudgetError,
+} from './component-props-budget.ts';
export { type JsxAttributeValueSource, jsxAttributeValue } from './jsx-attribute-value.ts';
export { propDescription, resolveLegacyProps } from './legacy-props.ts';