Beautiful, AI-native markdown IDE and LLM wiki
TypeScript 2nd-brainagent-skillsclaudecodexcompany-braindocsknowledge-knowledge-baseknowledge-managementllmllm-wikillm-wiki-karpathymarkdownmarkdown-editormdmdxnotespkmsecond-brainskills
fix(open-knowledge): add a property by pressing Enter in its value field (#2040)
serafin-garcia97126ef42b80
diff --git a/.changeset/property-add-on-value-enter.md b/.changeset/property-add-on-value-enter.mdnew file mode 100644index 000000000..906dbb144--- /dev/null+++ b/.changeset/property-add-on-value-enter.md@@ -0,0 +1,7 @@+---+"@inkeep/open-knowledge": patch+---++Add a property by pressing Enter in its value field.++When adding a frontmatter property, typing a name, pressing Tab, typing a value, and pressing Enter now commits the new property — the whole interaction is keyboard-driven. Previously Enter in the value field only settled the value and blurred the input, so the property was not added until you clicked "Add" with the mouse. This works for text, number, and date values, in both the document property panel and a folder's properties; editing an existing property's value keeps its prior Enter-to-settle behavior.diff --git a/packages/app/src/components/AddPropertyRow.add-property-focus.dom.test.tsx b/packages/app/src/components/AddPropertyRow.add-property-focus.dom.test.tsxindex aed73576b..2f336c9ee 100644--- a/packages/app/src/components/AddPropertyRow.add-property-focus.dom.test.tsx+++ b/packages/app/src/components/AddPropertyRow.add-property-focus.dom.test.tsx@@ -197,6 +197,131 @@ describe('AddPropertyRow — value-channel ADD gates on non-empty name AND valueexpect(btn.disabled).toBe(false);});+ test('Enter in the VALUE field commits the property (text) — no mouse needed', async () => {+ const commits: Array<string | number | boolean | null | undefined> = [];+ function Harness() {+ const [draft, setDraft] = useState<AddDraft>({+ name: 'status',+ type: 'text',+ value: '',+ error: null,+ });+ return (+ <AddPropertyRow+ draft={draft}+ onChangeName={(name) => setDraft((p) => ({ ...p, name }))}+ onChangeType={() => {}}+ onChangeValue={(value) => setDraft((p) => ({ ...p, value }))}+ onCommit={(valueOverride) => {+ commits.push(valueOverride as string);+ }}+ onCancel={() => {}}+ />+ );+ }+ const user = userEvent.setup();+ render(<Harness />);+ const valueInput = screen.getByTestId('text-widget') as HTMLTextAreaElement;+ await user.click(valueInput);+ await user.keyboard('active{Enter}');+ expect(commits).toEqual(['active']);+ });++ test('Enter in the VALUE field commits the property (number) with the typed value', async () => {+ const commits: Array<string | number | boolean | null | undefined> = [];+ function Harness() {+ const [draft, setDraft] = useState<AddDraft>({+ name: 'count',+ type: 'number',+ value: 0,+ error: null,+ });+ return (+ <AddPropertyRow+ draft={draft}+ onChangeName={(name) => setDraft((p) => ({ ...p, name }))}+ onChangeType={() => {}}+ onChangeValue={(value) => setDraft((p) => ({ ...p, value }))}+ onCommit={(valueOverride) => {+ commits.push(valueOverride as number);+ }}+ onCancel={() => {}}+ />+ );+ }+ const user = userEvent.setup();+ render(<Harness />);+ const valueInput = screen.getByTestId('number-widget') as HTMLInputElement;+ await user.click(valueInput);+ await user.clear(valueInput);+ await user.keyboard('42{Enter}');+ expect(commits).toEqual([42]);+ });++ test('Enter in the VALUE field commits the property (date) with a valid parsed date', async () => {+ const commits: Array<string | number | boolean | null | undefined> = [];+ function Harness() {+ const [draft, setDraft] = useState<AddDraft>({+ name: 'due',+ type: 'date',+ value: '2026-01-15',+ error: null,+ });+ return (+ <AddPropertyRow+ draft={draft}+ onChangeName={(name) => setDraft((p) => ({ ...p, name }))}+ onChangeType={() => {}}+ onChangeValue={(value) => setDraft((p) => ({ ...p, value }))}+ onCommit={(valueOverride) => {+ commits.push(valueOverride as string);+ }}+ onCancel={() => {}}+ />+ );+ }+ const user = userEvent.setup();+ render(<Harness />);+ const dateInput = screen.getByTestId('date-widget').querySelector('input');+ if (!dateInput) throw new Error('date input not found');+ await user.click(dateInput);+ await user.clear(dateInput);+ await user.keyboard('Jan 20, 2026{Enter}');+ expect(commits).toEqual(['2026-01-20']);+ });++ test('Enter in the VALUE field with an INVALID date does not commit (no silent onSubmit(undefined))', async () => {+ const commits: Array<string | number | boolean | null | undefined> = [];+ function Harness() {+ const [draft, setDraft] = useState<AddDraft>({+ name: 'due',+ type: 'date',+ value: '2026-01-15',+ error: null,+ });+ return (+ <AddPropertyRow+ draft={draft}+ onChangeName={(name) => setDraft((p) => ({ ...p, name }))}+ onChangeType={() => {}}+ onChangeValue={(value) => setDraft((p) => ({ ...p, value }))}+ onCommit={(valueOverride) => {+ commits.push(valueOverride as string);+ }}+ onCancel={() => {}}+ />+ );+ }+ const user = userEvent.setup();+ render(<Harness />);+ const dateInput = screen.getByTestId('date-widget').querySelector('input');+ if (!dateInput) throw new Error('date input not found');+ await user.click(dateInput);+ await user.clear(dateInput);+ await user.keyboard('not-a-date{Enter}');+ expect(commits).toEqual([]);+ });+test('Enter-key path bypasses the button gate — consumer must hold the line', async () => {const commitCalls: number[] = [];function Harness() {diff --git a/packages/app/src/components/FolderPropertiesCard.tsx b/packages/app/src/components/FolderPropertiesCard.tsxindex 82bca94e4..5c0996d12 100644--- a/packages/app/src/components/FolderPropertiesCard.tsx+++ b/packages/app/src/components/FolderPropertiesCard.tsx@@ -116,24 +116,25 @@ export function FolderPropertiesCard({ folderPath, state, onChange }: Props) {setAdding((prev) => (prev ? { ...prev, name, error: null } : prev));}- async function commitAdd() {+ async function commitAdd(valueOverride?: FrontmatterValue) {if (!adding) return;+ const value = valueOverride ?? adding.value;const trimmed = adding.name.trim();if (!trimmed) {- setAdding({ ...adding, error: t`Name is required` });+ setAdding({ ...adding, value, error: t`Name is required` });return;}- if (isFrontmatterValueEmpty(adding.value)) {- setAdding({ ...adding, error: t`Value is required` });+ if (isFrontmatterValueEmpty(value)) {+ setAdding({ ...adding, value, error: t`Value is required` });return;}if (Object.hasOwn(own, trimmed)) {- setAdding({ ...adding, error: t`"${trimmed}" already exists here` });+ setAdding({ ...adding, value, error: t`"${trimmed}" already exists here` });return;}- const result = await saveFolderConfig(folderPath, { [trimmed]: adding.value });+ const result = await saveFolderConfig(folderPath, { [trimmed]: value });if (!result.ok) {- setAdding({ ...adding, error: result.error });+ setAdding({ ...adding, value, error: result.error });return;}setAdding(null);@@ -248,7 +249,7 @@ export function FolderPropertiesCard({ folderPath, state, onChange }: Props) {onChangeName={changeAddName}onChangeType={changeAddType}onChangeValue={changeAddValue}- onCommit={() => void commitAdd()}+ onCommit={(v) => void commitAdd(v)}onCancel={() => setAdding(null)}/>) : (diff --git a/packages/app/src/components/FrontmatterRow.tsx b/packages/app/src/components/FrontmatterRow.tsxindex 0a7e57cdb..ce503522e 100644--- a/packages/app/src/components/FrontmatterRow.tsx+++ b/packages/app/src/components/FrontmatterRow.tsx@@ -432,7 +432,7 @@ interface AddPropertyRowProps {onChangeName: (next: string) => void;onChangeType: (next: FrontmatterType) => void;onChangeValue: (next: FrontmatterValue) => void;- onCommit: () => void;+ onCommit: (valueOverride?: FrontmatterValue) => void;onCancel: () => void;}@@ -493,13 +493,14 @@ export function AddPropertyRow({widgetType={draft.type}path={ADD_ROW_PATH}onCommit={onChangeValue}+ onSubmit={onCommit}/></div><Buttontype="button"data-testid="add-property-commit"- onClick={onCommit}+ onClick={() => onCommit()}disabled={isAddDisabled}size="sm"className="rounded bg-primary text-xs text-primary-foreground hover:bg-primary/90"@@ -538,9 +539,10 @@ interface WidgetProps {widgetType: FrontmatterType;path: ReadonlyArray<string | number>;onCommit: (next: FrontmatterValue) => void;+ onSubmit?: (next: FrontmatterValue) => void;}-function Widget({ keyName, value, widgetType, path, onCommit }: WidgetProps) {+function Widget({ keyName, value, widgetType, path, onCommit, onSubmit }: WidgetProps) {if (keyName === 'icon') {const str = typeof value === 'string' ? value : '';return <PageIconWidget keyName={keyName} value={str} onCommit={onCommit} />;@@ -572,15 +574,15 @@ function Widget({ keyName, value, widgetType, path, onCommit }: WidgetProps) {}if (widgetType === 'number') {const num = typeof value === 'number' ? value : 0;- return <NumberWidget keyName={keyName} value={num} onCommit={onCommit} />;+ return <NumberWidget keyName={keyName} value={num} onCommit={onCommit} onSubmit={onSubmit} />;}if (widgetType === 'date') {const str = typeof value === 'string' ? value : '';- return <DateWidget keyName={keyName} value={str} onCommit={onCommit} />;+ return <DateWidget keyName={keyName} value={str} onCommit={onCommit} onSubmit={onSubmit} />;}const str =typeof value === 'string' ? value : Array.isArray(value) ? value.join(', ') : String(value);- return <TextWidget keyName={keyName} value={str} onCommit={onCommit} />;+ return <TextWidget keyName={keyName} value={str} onCommit={onCommit} onSubmit={onSubmit} />;}export function InheritedBadge({diff --git a/packages/app/src/components/PropertyPanel.tsx b/packages/app/src/components/PropertyPanel.tsxindex 13d1a403f..7e3961ed1 100644--- a/packages/app/src/components/PropertyPanel.tsx+++ b/packages/app/src/components/PropertyPanel.tsx@@ -23,6 +23,7 @@ import {fieldErrorsFromError,frontmatterValuesEqual,inferType,+ isFrontmatterValueEmpty,readFmKeys,readFmRegionWithError,} from '@inkeep/open-knowledge-core';@@ -239,29 +240,34 @@ export function PropertyPanel({ provider }: PropertyPanelProps) {setAdding((prev) => (prev ? { ...prev, name, error: null } : prev));}- function commitAdd() {+ function commitAdd(valueOverride?: FrontmatterValue) {if (!adding) return;+ const value = valueOverride ?? adding.value;const trimmed = adding.name.trim();if (!trimmed) {- setAdding({ ...adding, error: t`Name is required` });+ setAdding({ ...adding, value, error: t`Name is required` });+ return;+ }+ if (isFrontmatterValueEmpty(value)) {+ setAdding({ ...adding, value, error: t`Value is required` });return;}if (trimmed === 'frontmatter') {- setAdding({ ...adding, error: t`"frontmatter" is a reserved property name` });+ setAdding({ ...adding, value, error: t`"frontmatter" is a reserved property name` });return;}if (Object.hasOwn(map, trimmed)) {- setAdding({ ...adding, error: t`Property "${trimmed}" already exists` });+ setAdding({ ...adding, value, error: t`Property "${trimmed}" already exists` });return;}- const result = commitPatch({ [trimmed]: adding.value });+ const result = commitPatch({ [trimmed]: value });if (result.ok) {setAdding(null);return;}const fieldError = result.fieldErrors?.[trimmed];const generic = result.error ?? t`Failed to add property`;- setAdding({ ...adding, error: fieldError ?? generic });+ setAdding({ ...adding, value, error: fieldError ?? generic });}function cancelAdd() {diff --git a/packages/app/src/components/PropertyWidgets.tsx b/packages/app/src/components/PropertyWidgets.tsxindex 6a5877af0..7c33e932e 100644--- a/packages/app/src/components/PropertyWidgets.tsx+++ b/packages/app/src/components/PropertyWidgets.tsx@@ -45,9 +45,10 @@ export interface CommonWidgetProps<T extends FrontmatterValue> {keyName: string;value: T;onCommit: (next: T) => void;+ onSubmit?: (next: T) => void;}-export function TextWidget({ keyName, value, onCommit }: CommonWidgetProps<string>) {+export function TextWidget({ keyName, value, onCommit, onSubmit }: CommonWidgetProps<string>) {const { t } = useLingui();const [draft, setDraft] = useState(value);const focusedRef = useRef(false);@@ -155,7 +156,8 @@ export function TextWidget({ keyName, value, onCommit }: CommonWidgetProps<strinif (e.key === 'Enter' && !e.shiftKey && !e.metaKey && !e.ctrlKey) {e.preventDefault();if (draft !== value) onCommit(draft);- (e.currentTarget as HTMLTextAreaElement).blur();+ if (onSubmit) onSubmit(draft);+ else (e.currentTarget as HTMLTextAreaElement).blur();} else if (e.key === 'Escape') {e.preventDefault();revertingRef.current = true;@@ -168,7 +170,7 @@ export function TextWidget({ keyName, value, onCommit }: CommonWidgetProps<strin);}-export function NumberWidget({ keyName, value, onCommit }: CommonWidgetProps<number>) {+export function NumberWidget({ keyName, value, onCommit, onSubmit }: CommonWidgetProps<number>) {const { t } = useLingui();const [draft, setDraft] = useState<string>(String(value));const focusedRef = useRef(false);@@ -202,7 +204,14 @@ export function NumberWidget({ keyName, value, onCommit }: CommonWidgetProps<numonKeyDown={(e) => {if (e.key === 'Enter') {e.preventDefault();- (e.currentTarget as HTMLInputElement).blur();+ if (onSubmit) {+ const parsed = Number.parseFloat(draft);+ const next = Number.isFinite(parsed) ? parsed : 0;+ if (next !== value) onCommit(next);+ onSubmit(next);+ } else {+ (e.currentTarget as HTMLInputElement).blur();+ }} else if (e.key === 'Escape') {e.preventDefault();revertingRef.current = true;@@ -231,7 +240,7 @@ export function BooleanWidget({ keyName, value, onCommit }: CommonWidgetProps<bo);}-export function DateWidget({ keyName, value, onCommit }: CommonWidgetProps<string>) {+export function DateWidget({ keyName, value, onCommit, onSubmit }: CommonWidgetProps<string>) {const { t } = useLingui();const date = parseDate(value);const [inputValue, setInputValue] = useState(formatDateForInput(date));@@ -248,17 +257,18 @@ export function DateWidget({ keyName, value, onCommit }: CommonWidgetProps<strin}}, [value]);- function commitInput() {+ function commitInput(): string | undefined {const parsed = parseFromInput(inputValue);if (parsed) {const iso = format(parsed, 'yyyy-MM-dd');if (iso !== value) onCommit(iso);setInputValue(formatDateForInput(parsed));setMonth(parsed);- } else {- setInputValue(formatDateForInput(date));- setMonth(date);+ return iso;}+ setInputValue(formatDateForInput(date));+ setMonth(date);+ return undefined;}function handleCalendarSelect(selected: Date | undefined) {@@ -296,8 +306,12 @@ export function DateWidget({ keyName, value, onCommit }: CommonWidgetProps<strinonKeyDown={(e) => {if (e.key === 'Enter') {e.preventDefault();- commitInput();- (e.currentTarget as HTMLInputElement).blur();+ const committed = commitInput();+ if (onSubmit) {+ if (committed !== undefined) onSubmit(committed);+ } else {+ (e.currentTarget as HTMLInputElement).blur();+ }} else if (e.key === 'Escape') {e.preventDefault();revertingRef.current = true;diff --git a/packages/app/src/locales/en/messages.po b/packages/app/src/locales/en/messages.poindex 8cb9693af..6f2b0024d 100644--- a/packages/app/src/locales/en/messages.po+++ b/packages/app/src/locales/en/messages.po@@ -6109,6 +6109,7 @@ msgid "Using the <0>OK_EMBEDDINGS_API_KEY</0> environment variable (managed outsmsgstr "Using the <0>OK_EMBEDDINGS_API_KEY</0> environment variable (managed outside Open Knowledge)."#: src/components/FolderPropertiesCard.tsx+#: src/components/PropertyPanel.tsxmsgid "Value is required"msgstr "Value is required"diff --git a/packages/app/src/locales/pseudo/messages.po b/packages/app/src/locales/pseudo/messages.poindex c69d9fdb6..8e2efbff8 100644--- a/packages/app/src/locales/pseudo/messages.po+++ b/packages/app/src/locales/pseudo/messages.po@@ -6104,6 +6104,7 @@ msgid "Using the <0>OK_EMBEDDINGS_API_KEY</0> environment variable (managed outsmsgstr ""#: src/components/FolderPropertiesCard.tsx+#: src/components/PropertyPanel.tsxmsgid "Value is required"msgstr ""