Skip to content

Beautiful, AI-native markdown IDE and LLM wiki

fix(ok): make FR-B2's select-and-delete atomic (#4109)

Nick Gomez98d449c75047
diff --git a/knip.config.ts b/knip.config.ts
index 68adb81cc..a0ba1bf42 100644
--- a/knip.config.ts
+++ b/knip.config.ts
@@ -127,9 +127,7 @@ export default {
'packages/server': {
entry: ['src/**/*.test.ts', 'src/parse-worker.ts'],
project: 'src/**',
- ignoreDependencies: [
- '@types/shell-quote',
- ],
+ ignoreDependencies: ['@types/shell-quote'],
},
'packages/cli': {
entry: ['src/**/*.test.ts', 'scripts/*.ts', 'tests/**/*.ts', 'src/parse-worker.ts'],
diff --git a/packages/app/src/editor/extensions/source-dirty-fold-atomicity.dom.test.tsx b/packages/app/src/editor/extensions/source-dirty-fold-atomicity.dom.test.tsx
index 3a15d1233..9e043d02b 100644
--- a/packages/app/src/editor/extensions/source-dirty-fold-atomicity.dom.test.tsx
+++ b/packages/app/src/editor/extensions/source-dirty-fold-atomicity.dom.test.tsx
@@ -1,4 +1,3 @@
-
import { sharedExtensions as coreExtensions, MarkdownManager } from '@inkeep/open-knowledge-core';
import { type ObserverDispatchKind, setupServerObservers } from '@inkeep/open-knowledge-server';
import { cleanup } from '@testing-library/react';
diff --git a/packages/app/tests/dom/input-rule-atom-ranges.dom.test.tsx b/packages/app/tests/dom/input-rule-atom-ranges.dom.test.tsx
index 65162a22f..f81d64a77 100644
--- a/packages/app/tests/dom/input-rule-atom-ranges.dom.test.tsx
+++ b/packages/app/tests/dom/input-rule-atom-ranges.dom.test.tsx
@@ -1,4 +1,3 @@
-
import { cleanup } from '@testing-library/react';
import { Editor, getSchema } from '@tiptap/core';
import type { MarkType, Node as PMNode } from '@tiptap/pm/model';
diff --git a/packages/app/tests/dom/jsx-interior-input-rule-suppression.dom.test.tsx b/packages/app/tests/dom/jsx-interior-input-rule-suppression.dom.test.tsx
index c5b8ad023..c4c510031 100644
--- a/packages/app/tests/dom/jsx-interior-input-rule-suppression.dom.test.tsx
+++ b/packages/app/tests/dom/jsx-interior-input-rule-suppression.dom.test.tsx
@@ -1,4 +1,3 @@
-
import { cleanup } from '@testing-library/react';
import { Editor, type JSONContent } from '@tiptap/core';
import type { Node as PMNode } from '@tiptap/pm/model';
diff --git a/packages/app/tests/dom/plain-text-clipboard.dom.test.tsx b/packages/app/tests/dom/plain-text-clipboard.dom.test.tsx
index 65b32f4b3..931aaa880 100644
--- a/packages/app/tests/dom/plain-text-clipboard.dom.test.tsx
+++ b/packages/app/tests/dom/plain-text-clipboard.dom.test.tsx
@@ -1,4 +1,3 @@
-
import { cleanup } from '@testing-library/react';
import { Editor } from '@tiptap/core';
import type { Node as PMNode } from '@tiptap/pm/model';
diff --git a/packages/app/tests/dom/serializer-seam-rederive.dom.test.tsx b/packages/app/tests/dom/serializer-seam-rederive.dom.test.tsx
index 2ab40357a..c9744993d 100644
--- a/packages/app/tests/dom/serializer-seam-rederive.dom.test.tsx
+++ b/packages/app/tests/dom/serializer-seam-rederive.dom.test.tsx
@@ -1,4 +1,3 @@
-
import { MarkdownManager, stripFrontmatter } from '@inkeep/open-knowledge-core';
import { cleanup } from '@testing-library/react';
import { Editor, type JSONContent } from '@tiptap/core';
diff --git a/packages/app/tests/dom/task-list-input-rule.dom.test.tsx b/packages/app/tests/dom/task-list-input-rule.dom.test.tsx
index 1db8b25a9..e01856aac 100644
--- a/packages/app/tests/dom/task-list-input-rule.dom.test.tsx
+++ b/packages/app/tests/dom/task-list-input-rule.dom.test.tsx
@@ -1,4 +1,3 @@
-
import { cleanup } from '@testing-library/react';
import type { Editor } from '@tiptap/core';
import type { Node as PMNode } from '@tiptap/pm/model';
diff --git a/packages/app/tests/dom/underline-round-trip.dom.test.tsx b/packages/app/tests/dom/underline-round-trip.dom.test.tsx
index 652d75f43..f0bea3f33 100644
--- a/packages/app/tests/dom/underline-round-trip.dom.test.tsx
+++ b/packages/app/tests/dom/underline-round-trip.dom.test.tsx
@@ -1,4 +1,3 @@
-
import { MarkdownManager, sharedExtensions, stripFrontmatter } from '@inkeep/open-knowledge-core';
import { cleanup } from '@testing-library/react';
import { Editor, getSchema, type JSONContent } from '@tiptap/core';
diff --git a/packages/app/tests/integration/api-error-envelope/create-folder.test.ts b/packages/app/tests/integration/api-error-envelope/create-folder.test.ts
index 079b42e9a..49257d365 100644
--- a/packages/app/tests/integration/api-error-envelope/create-folder.test.ts
+++ b/packages/app/tests/integration/api-error-envelope/create-folder.test.ts
@@ -1,4 +1,3 @@
-
import { CreateFolderSuccessSchema, ProblemDetailsSchema } from '@inkeep/open-knowledge-core';
import { afterAll, beforeAll, describe, expect, test } from 'vitest';
import { HARNESS_BOOT_TIMEOUT_MS } from '../harness-boot-timeout';
diff --git a/packages/app/tests/integration/bug3-source-mode-writeback.test.ts b/packages/app/tests/integration/bug3-source-mode-writeback.test.ts
index a28cc2b18..8a60e5826 100644
--- a/packages/app/tests/integration/bug3-source-mode-writeback.test.ts
+++ b/packages/app/tests/integration/bug3-source-mode-writeback.test.ts
@@ -1,4 +1,3 @@
-
import { readFileSync } from 'node:fs';
import { join } from 'node:path';
import { setTimeout as wait } from 'node:timers/promises';
diff --git a/packages/app/tests/integration/indented-jsx-byte-sacred.test.ts b/packages/app/tests/integration/indented-jsx-byte-sacred.test.ts
index 4fc2c11f9..6fcdc23f2 100644
--- a/packages/app/tests/integration/indented-jsx-byte-sacred.test.ts
+++ b/packages/app/tests/integration/indented-jsx-byte-sacred.test.ts
@@ -1,4 +1,3 @@
-
import { setTimeout as wait } from 'node:timers/promises';
import { normalizeBridge } from '@inkeep/open-knowledge-core';
import { updateYFragment } from '@tiptap/y-tiptap';
diff --git a/packages/app/tests/integration/interior-edit-freshness.test.ts b/packages/app/tests/integration/interior-edit-freshness.test.ts
index 9f2f6feb6..40b5cdfd6 100644
--- a/packages/app/tests/integration/interior-edit-freshness.test.ts
+++ b/packages/app/tests/integration/interior-edit-freshness.test.ts
@@ -1,4 +1,3 @@
-
import { setTimeout as wait } from 'node:timers/promises';
import { updateYFragment, yXmlFragmentToProseMirrorRootNode } from '@tiptap/y-tiptap';
import { afterAll, beforeAll, describe, expect, test } from 'vitest';
diff --git a/packages/app/tests/integration/keystroke-cadence-danger-space.test.ts b/packages/app/tests/integration/keystroke-cadence-danger-space.test.ts
index 2a085742b..93666af70 100644
--- a/packages/app/tests/integration/keystroke-cadence-danger-space.test.ts
+++ b/packages/app/tests/integration/keystroke-cadence-danger-space.test.ts
@@ -1,4 +1,3 @@
-
import { setTimeout as wait } from 'node:timers/promises';
import { updateYFragment, yXmlFragmentToProseMirrorRootNode } from '@tiptap/y-tiptap';
import { afterAll, beforeAll, describe, expect, test } from 'vitest';
diff --git a/packages/app/tests/integration/producer-guard-wiring.test.ts b/packages/app/tests/integration/producer-guard-wiring.test.ts
index 878d5196b..867598d34 100644
--- a/packages/app/tests/integration/producer-guard-wiring.test.ts
+++ b/packages/app/tests/integration/producer-guard-wiring.test.ts
@@ -1,4 +1,3 @@
-
import { setTimeout as wait } from 'node:timers/promises';
import { updateYFragment, yXmlFragmentToProseMirrorRootNode } from '@tiptap/y-tiptap';
import { afterAll, beforeAll, describe, expect, test } from 'vitest';
diff --git a/packages/app/tests/integration/qa-039-reconciliation-counters-http.test.ts b/packages/app/tests/integration/qa-039-reconciliation-counters-http.test.ts
index 4ada3cf26..0970ac12f 100644
--- a/packages/app/tests/integration/qa-039-reconciliation-counters-http.test.ts
+++ b/packages/app/tests/integration/qa-039-reconciliation-counters-http.test.ts
@@ -1,4 +1,3 @@
-
import { randomUUID } from 'node:crypto';
import { afterEach, describe, expect, test } from 'vitest';
import { agentWriteMd, createTestServer, type TestServer } from './test-harness';
diff --git a/packages/app/tests/integration/qa-045-restore-after-gc.test.ts b/packages/app/tests/integration/qa-045-restore-after-gc.test.ts
index cbe2b705f..b632185e1 100644
--- a/packages/app/tests/integration/qa-045-restore-after-gc.test.ts
+++ b/packages/app/tests/integration/qa-045-restore-after-gc.test.ts
@@ -1,4 +1,3 @@
-
import { execFileSync } from 'node:child_process';
import { randomUUID } from 'node:crypto';
import { join } from 'node:path';
diff --git a/packages/app/tests/integration/qa-050-rollback-undo-shipped-path.test.ts b/packages/app/tests/integration/qa-050-rollback-undo-shipped-path.test.ts
index 89bc9b4d9..c530ce4ba 100644
--- a/packages/app/tests/integration/qa-050-rollback-undo-shipped-path.test.ts
+++ b/packages/app/tests/integration/qa-050-rollback-undo-shipped-path.test.ts
@@ -1,4 +1,3 @@
-
import { randomUUID } from 'node:crypto';
import { afterAll, afterEach, beforeAll, describe, expect, test } from 'vitest';
import type * as Y from 'yjs';
diff --git a/packages/app/tests/integration/undo-after-rollback.test.ts b/packages/app/tests/integration/undo-after-rollback.test.ts
index a78aeb0e4..d3767adc9 100644
--- a/packages/app/tests/integration/undo-after-rollback.test.ts
+++ b/packages/app/tests/integration/undo-after-rollback.test.ts
@@ -1,4 +1,3 @@
-
import { ROLLBACK_ORIGIN } from '@inkeep/open-knowledge-server';
import { afterAll, beforeAll, describe, expect, test } from 'vitest';
import * as Y from 'yjs';
diff --git a/packages/app/tests/integration/undo-recycle-reset.test.ts b/packages/app/tests/integration/undo-recycle-reset.test.ts
index 39e64a221..be1a29fbc 100644
--- a/packages/app/tests/integration/undo-recycle-reset.test.ts
+++ b/packages/app/tests/integration/undo-recycle-reset.test.ts
@@ -1,4 +1,3 @@
-
import { writeFileSync } from 'node:fs';
import { join } from 'node:path';
import { setTimeout as wait } from 'node:timers/promises';
diff --git a/packages/app/tests/integration/undo-rederive-survival.test.ts b/packages/app/tests/integration/undo-rederive-survival.test.ts
index 9ddcd0730..7935e35f8 100644
--- a/packages/app/tests/integration/undo-rederive-survival.test.ts
+++ b/packages/app/tests/integration/undo-rederive-survival.test.ts
@@ -1,4 +1,3 @@
-
import { prependFrontmatter } from '@inkeep/open-knowledge-core';
import { Plugin, PluginKey } from '@tiptap/pm/state';
import { updateYFragment, yXmlFragmentToProseMirrorRootNode } from '@tiptap/y-tiptap';
diff --git a/packages/app/tests/stress/_helpers/editor-state.ts b/packages/app/tests/stress/_helpers/editor-state.ts
index b54376e0f..02e6fbaa8 100644
--- a/packages/app/tests/stress/_helpers/editor-state.ts
+++ b/packages/app/tests/stress/_helpers/editor-state.ts
@@ -150,6 +150,10 @@ export async function selectText(page: Page, text: string): Promise<void> {
* Requires `window.__activeEditor` exposure from `DocumentContext.tsx`
* (DEV-gated — tree-shaken from production bundles). Category C per
* precedent #20(a).
+ *
+ * WARN: walks `$from` ancestors, so it can never match a NodeSelection —
+ * there the selected node is `selection.node`, not an ancestor of `$from`.
+ * A caller arming a NodeSelection needs its own predicate.
*/
export async function waitForPmSelectionInNode(
page: Page,
diff --git a/packages/app/tests/stress/jsx-unregistered-backspace-delete.e2e.ts b/packages/app/tests/stress/jsx-unregistered-backspace-delete.e2e.ts
index 1909d1465..4f2e3a11f 100644
--- a/packages/app/tests/stress/jsx-unregistered-backspace-delete.e2e.ts
+++ b/packages/app/tests/stress/jsx-unregistered-backspace-delete.e2e.ts
@@ -9,6 +9,16 @@ interface FallbackNode {
textContent: string;
}
+interface FallbackState {
+ count: number | null;
+ text: string | null;
+}
+
+interface PmSelectionView {
+ from: number;
+ node?: FallbackNode;
+}
+
async function setupDoc(page: Page, api: ApiHelpers, markdown: string): Promise<string> {
const docName = `unreg-del-${randomUUID().slice(0, 8)}`;
await api.createPage(`${docName}.md`);
@@ -42,10 +52,10 @@ async function waitForFallback(page: Page, componentName: string): Promise<void>
);
}
-async function fallbackState(page: Page): Promise<{ count: number; text: string | null }> {
- return page.evaluate(() => {
+async function fallbackState(page: Page): Promise<FallbackState> {
+ return page.evaluate((): FallbackState => {
const ed = window.__activeEditor;
- if (!ed) return { count: 0, text: null };
+ if (!ed) return { count: null, text: null };
let count = 0;
let text: string | null = null;
ed.state.doc.descendants((n: FallbackNode) => {
@@ -58,10 +68,40 @@ async function fallbackState(page: Page): Promise<{ count: number; text: string
});
}
-async function nodeSelectFallbackAndFocusPm(page: Page): Promise<void> {
- await page.evaluate(() => {
+interface PostDeleteState {
+ count: number | null;
+ text: string | null;
+ docText: string | null;
+ selectedNodeType: string | null;
+}
+
+async function postDeleteState(page: Page): Promise<PostDeleteState> {
+ return page.evaluate((): PostDeleteState => {
+ const ed = window.__activeEditor;
+ if (!ed) return { count: null, text: null, docText: null, selectedNodeType: null };
+ let count = 0;
+ let text: string | null = null;
+ ed.state.doc.descendants((n: FallbackNode) => {
+ if (n.type.name === 'rawMdxFallback') {
+ count += 1;
+ if (text === null) text = n.textContent;
+ }
+ });
+ const selection = ed.state.selection as PmSelectionView;
+ return {
+ count,
+ text,
+ docText: ed.state.doc.textContent,
+ selectedNodeType: selection.node?.type.name ?? null,
+ };
+ });
+}
+
+async function nodeSelectFallbackAndDispatchKey(page: Page, key: string): Promise<void> {
+ return page.evaluate((pressed) => {
const ed = window.__activeEditor;
- if (!ed) throw new Error('window.__activeEditor not set');
+ if (!ed) throw new Error('nodeSelectFallbackAndDispatchKey: window.__activeEditor not set');
+
let pos = -1;
ed.state.doc.descendants((n: FallbackNode, p: number) => {
if (pos !== -1) return false;
@@ -71,15 +111,37 @@ async function nodeSelectFallbackAndFocusPm(page: Page): Promise<void> {
}
return true;
});
- if (pos === -1) throw new Error('rawMdxFallback not found');
- ed.chain().focus().setNodeSelection(pos).run();
- });
- await page.evaluate(() => {
- const pm = document.querySelector(
- '.ProseMirror:not(.composer-prosemirror)',
- ) as HTMLElement | null;
- pm?.focus();
- });
+ if (pos === -1) {
+ throw new Error('nodeSelectFallbackAndDispatchKey: rawMdxFallback not found');
+ }
+
+ ed.commands.setNodeSelection(pos);
+ const selection = ed.state.selection as PmSelectionView;
+ if (selection.node?.type.name !== 'rawMdxFallback' || selection.from !== pos) {
+ throw new Error(
+ `nodeSelectFallbackAndDispatchKey: selection landed on ${selection.node?.type.name ?? 'no node'} at ${selection.from}, expected rawMdxFallback at ${pos}`,
+ );
+ }
+
+ const notConsumed = ed.view.dom.dispatchEvent(
+ new KeyboardEvent('keydown', { key: pressed, bubbles: true, cancelable: true }),
+ );
+ if (notConsumed) {
+ throw new Error(
+ `nodeSelectFallbackAndDispatchKey: ProseMirror did not consume ${pressed} (no handler called preventDefault)`,
+ );
+ }
+
+ let survivors = 0;
+ ed.state.doc.descendants((n: FallbackNode) => {
+ if (n.type.name === 'rawMdxFallback') survivors += 1;
+ });
+ if (survivors > 0) {
+ throw new Error(
+ `nodeSelectFallbackAndDispatchKey: ${pressed} was consumed but ${survivors} rawMdxFallback remained after the synchronous dispatch, so the consuming handler did not remove the node`,
+ );
+ }
+ }, key);
}
for (const key of ['Backspace', 'Delete'] as const) {
@@ -95,10 +157,11 @@ for (const key of ['Backspace', 'Delete'] as const) {
await waitForFallback(page, 'UnknownWidget');
expect((await fallbackState(page)).count).toBe(1);
- await nodeSelectFallbackAndFocusPm(page);
- await page.keyboard.press(key);
+ await nodeSelectFallbackAndDispatchKey(page, key);
- await expect.poll(() => fallbackState(page).then((s) => s.count), { timeout: 2_000 }).toBe(0);
+ await expect
+ .poll(() => postDeleteState(page), { timeout: 2_000 })
+ .toEqual({ count: 0, text: null, docText: 'after', selectedNodeType: null });
});
}
diff --git a/packages/app/tests/stress/raw-mdx-fallback-onblur-upgrade.e2e.ts b/packages/app/tests/stress/raw-mdx-fallback-onblur-upgrade.e2e.ts
index 53d1e643d..a40c964c4 100644
--- a/packages/app/tests/stress/raw-mdx-fallback-onblur-upgrade.e2e.ts
+++ b/packages/app/tests/stress/raw-mdx-fallback-onblur-upgrade.e2e.ts
@@ -130,6 +130,14 @@ test('S21: fixing broken MDX in nested CM upgrades rawMdxFallback to jsxComponen
).toHaveLength(1);
});
+/*
+ * WARN: this fixture is still-invalid, so `tryParseUpgrade` returns null and the
+ * on-blur upgrade branch never runs. It does not cover the unregistered-but-VALID
+ * source, where the parse yields a `jsxComponent` that `JsxComponentView` converts
+ * straight back to a `rawMdxFallback` — a two-hop identity churn with no user-visible
+ * change. Covering that needs a new fixture, not stronger assertions here. Evidence:
+ * reports/e2e-jsx-nodeselection-delete/REPORT.md.
+ */
test('S22: blur with still-invalid source does not churn the rawMdxFallback node', async ({
page,
api,
diff --git a/packages/core/src/bridge/compose.ts b/packages/core/src/bridge/compose.ts
index 2a597ec3d..f4cc8a286 100644
--- a/packages/core/src/bridge/compose.ts
+++ b/packages/core/src/bridge/compose.ts
@@ -1,4 +1,3 @@
-
import { prependFrontmatter, stripFrontmatter } from '../extensions/frontmatter.ts';
export type ComposeAdjustment = 'none' | 'body' | 'frontmatter' | 'unresolved';
diff --git a/packages/core/src/bridge/doc-boundary-space.ts b/packages/core/src/bridge/doc-boundary-space.ts
index 01ef76a9f..8fb428b90 100644
--- a/packages/core/src/bridge/doc-boundary-space.ts
+++ b/packages/core/src/bridge/doc-boundary-space.ts
@@ -1,4 +1,3 @@
-
import { FRONTMATTER_RE, stripFrontmatter } from '../extensions/frontmatter.ts';
import { carriedEdgeEmpties, type DocEdgeEmpties } from '../markdown/doc-edge-blank-runs.ts';
diff --git a/packages/core/src/markdown/comment-promoter.ts b/packages/core/src/markdown/comment-promoter.ts
index 20a68d2a1..bfbd5a2e8 100644
--- a/packages/core/src/markdown/comment-promoter.ts
+++ b/packages/core/src/markdown/comment-promoter.ts
@@ -1,4 +1,3 @@
-
import type { Nodes, Paragraph, PhrasingContent, Root, RootContent, Text } from 'mdast';
import { SKIP, visit } from 'unist-util-visit';
import type { VFile } from 'vfile';
diff --git a/packages/core/src/markdown/fixtures/index.ts b/packages/core/src/markdown/fixtures/index.ts
index 6931623c7..00f5771ee 100644
--- a/packages/core/src/markdown/fixtures/index.ts
+++ b/packages/core/src/markdown/fixtures/index.ts
@@ -1,4 +1,3 @@
-
import { readFileSync } from 'node:fs';
import { dirname, resolve } from 'node:path';
import { fileURLToPath } from 'node:url';
@@ -9,7 +8,6 @@ function fixturePath(...segments: string[]): string {
return resolve(FIXTURES_DIR, ...segments);
}
-
interface GfmExample {
section: string;
markdown: string;
@@ -19,7 +17,6 @@ export function loadGfmExamples(): GfmExample[] {
return JSON.parse(readFileSync(fixturePath('gfm', 'examples.json'), 'utf8')) as GfmExample[];
}
-
interface MdxCrashEntry {
id: string;
input: string;
@@ -71,7 +68,6 @@ export function loadLargeEmbedFixtures(): LargeEmbedFixture[] {
) as LargeEmbedFixture[];
}
-
export function loadPrd6955Before(): string {
return readFileSync(fixturePath('regression', 'prd-6955-before.md'), 'utf8');
}
@@ -80,7 +76,6 @@ export function loadPrd6955CorruptedTriplicated(): string {
return readFileSync(fixturePath('regression', 'prd-6955-corrupted-triplicated.md'), 'utf8');
}
-
export interface NgPinnedCase {
id: string;
name: string;
@@ -97,7 +92,6 @@ export function loadNgPinnedCases(): NgPinnedCase[] {
) as NgPinnedCase[];
}
-
export function loadLargeRealistic(): string {
return readFileSync(fixturePath('perf', 'large-realistic.md'), 'utf8');
}
diff --git a/packages/core/src/markdown/fixtures/perf/generate.ts b/packages/core/src/markdown/fixtures/perf/generate.ts
index daa3ef82b..8b1eb8519 100644
--- a/packages/core/src/markdown/fixtures/perf/generate.ts
+++ b/packages/core/src/markdown/fixtures/perf/generate.ts
@@ -1,4 +1,3 @@
-
import { writeFileSync } from 'node:fs';
import { dirname, resolve } from 'node:path';
import { fileURLToPath } from 'node:url';
@@ -11,7 +10,6 @@ const BASELINE_ONLY_COUNTS = [500, 2500] as const;
const SEED = 0xf1de1117;
-
function mulberry32(seed: number): () => number {
let a = seed >>> 0;
return () => {
@@ -38,7 +36,6 @@ function pickWeighted<T>(rand: () => number, items: readonly [T, number][]): T {
return items[items.length - 1][0];
}
-
const WORDS = [
'lorem',
'ipsum',
@@ -156,7 +153,6 @@ function mdxBlock(rand: () => number): string {
return `<${name}>\n\n${sentence(rand)}\n\n</${name}>`;
}
-
type BlockKind = 'paragraph' | 'heading' | 'list' | 'code' | 'table' | 'mdx';
const MIX: readonly [BlockKind, number][] = [
@@ -195,7 +191,6 @@ function generateDocument(blockCount: number, seed: number): string {
return `${blocks.join('\n\n')}\n`;
}
-
function main(): void {
for (const count of [...BLOCK_COUNTS, ...BASELINE_ONLY_COUNTS]) {
const doc = generateDocument(count, SEED);
diff --git a/packages/core/src/markdown/image-promoter.ts b/packages/core/src/markdown/image-promoter.ts
index 994eb6917..706fa9afb 100644
--- a/packages/core/src/markdown/image-promoter.ts
+++ b/packages/core/src/markdown/image-promoter.ts
@@ -1,4 +1,3 @@
-
import type { Image, Paragraph, Root } from 'mdast';
import type { MdxJsxAttribute, MdxJsxFlowElement } from 'mdast-util-mdx';
import { visit } from 'unist-util-visit';
diff --git a/packages/core/src/markdown/math-promoter.ts b/packages/core/src/markdown/math-promoter.ts
index bd79424c7..a5b511f25 100644
--- a/packages/core/src/markdown/math-promoter.ts
+++ b/packages/core/src/markdown/math-promoter.ts
@@ -1,4 +1,3 @@
-
import type { Code, Root } from 'mdast';
import type { Math as MdastMath } from 'mdast-util-math';
import type { MdxJsxAttribute, MdxJsxFlowElement } from 'mdast-util-mdx';
diff --git a/packages/core/src/markdown/merged-walker.ts b/packages/core/src/markdown/merged-walker.ts
index fa3cfcd86..bfd7e3109 100644
--- a/packages/core/src/markdown/merged-walker.ts
+++ b/packages/core/src/markdown/merged-walker.ts
@@ -1,4 +1,3 @@
-
import type { Nodes, Parent, Root } from 'mdast';
import { SKIP, visit } from 'unist-util-visit';
import type { VFile } from 'vfile';
diff --git a/packages/core/src/markdown/safe-url.ts b/packages/core/src/markdown/safe-url.ts
index 8be632ba4..4d3250d3a 100644
--- a/packages/core/src/markdown/safe-url.ts
+++ b/packages/core/src/markdown/safe-url.ts
@@ -1,4 +1,3 @@
-
export const SAFE_URL_SCHEMES = ['https', 'http', 'mailto', 'tel', 'ftp', 'sms'] as const;
const SCHEME_ALT = SAFE_URL_SCHEMES.map((s) => `${s}:`).join('|');
diff --git a/packages/server/src/checkpoint-retention-tie.test.ts b/packages/server/src/checkpoint-retention-tie.test.ts
index 0a43a2773..8a5d82998 100644
--- a/packages/server/src/checkpoint-retention-tie.test.ts
+++ b/packages/server/src/checkpoint-retention-tie.test.ts
@@ -1,4 +1,3 @@
-
import { execFileSync } from 'node:child_process';
import { mkdirSync, mkdtempSync, rmSync } from 'node:fs';
import { tmpdir } from 'node:os';
diff --git a/packages/server/src/qa-degradation-matrix.test.ts b/packages/server/src/qa-degradation-matrix.test.ts
index 00bb6efe7..84e3e5297 100644
--- a/packages/server/src/qa-degradation-matrix.test.ts
+++ b/packages/server/src/qa-degradation-matrix.test.ts
@@ -1,4 +1,3 @@
-
import { afterEach, beforeEach, describe, expect, test, vi } from 'vitest';
import type * as Y from 'yjs';
import { createBridgeDeriveLossReporter } from './bridge-loss-detector.ts';
diff --git a/packages/server/src/qa-gc-budget-isolation.test.ts b/packages/server/src/qa-gc-budget-isolation.test.ts
index b65c4693e..a800ca9f3 100644
--- a/packages/server/src/qa-gc-budget-isolation.test.ts
+++ b/packages/server/src/qa-gc-budget-isolation.test.ts
@@ -1,4 +1,3 @@
-
import { mkdirSync, mkdtempSync, rmSync } from 'node:fs';
import { tmpdir } from 'node:os';
import { join, resolve } from 'node:path';
diff --git a/packages/server/src/qa-watcher-intake-lens.test.ts b/packages/server/src/qa-watcher-intake-lens.test.ts
index 4669d1b98..2337e6c3c 100644
--- a/packages/server/src/qa-watcher-intake-lens.test.ts
+++ b/packages/server/src/qa-watcher-intake-lens.test.ts
@@ -1,4 +1,3 @@
-
import { Hocuspocus } from '@hocuspocus/server';
import { afterEach, beforeEach, describe, expect, test, vi } from 'vitest';
import * as Y from 'yjs';