Beautiful, AI-native markdown IDE and LLM wiki
TypeScript 2nd-brainagent-skillsclaudecodexcompany-braindocsknowledge-knowledge-baseknowledge-managementllmllm-wikillm-wiki-karpathymarkdownmarkdown-editormdmdxnotespkmsecond-brainskills
Stop the desktop test tier writing Python bytecode into the tree (#4856)
Nick Gomez98da06c1bb25
diff --git a/packages/desktop/scripts/smoke-windows-terminal-package.test.mjs b/packages/desktop/scripts/smoke-windows-terminal-package.test.mjsindex 2da4b531e..f4b6dd3cb 100644--- a/packages/desktop/scripts/smoke-windows-terminal-package.test.mjs+++ b/packages/desktop/scripts/smoke-windows-terminal-package.test.mjs@@ -1,5 +1,5 @@import { execFileSync } from 'node:child_process';-import { mkdtempSync, readFileSync, rmSync, writeFileSync } from 'node:fs';+import { existsSync, mkdtempSync, readdirSync, readFileSync, rmSync, writeFileSync } from 'node:fs';import { tmpdir } from 'node:os';import { dirname, join } from 'node:path';import { fileURLToPath, pathToFileURL } from 'node:url';@@ -36,7 +36,7 @@ function runPython(args, env) {code: 0,output: execFileSync(pythonBin, args, {encoding: 'utf8',- env: { ...process.env, ...env },+ env: { ...process.env, ...env, PYTHONDONTWRITEBYTECODE: '1' },stdio: ['ignore', 'pipe', 'pipe'],timeout: 25_000,}),@@ -138,6 +138,15 @@ afterEach(() => {for (const fixture of fixtures.splice(0)) rmSync(fixture, { recursive: true, force: true });});+function drainDriverBytecode() {+ const cacheDir = join(dirname(driverPath), '__pycache__');+ const left = existsSync(cacheDir)+ ? readdirSync(cacheDir).map((entry) => join(cacheDir, entry))+ : [];+ rmSync(cacheDir, { recursive: true, force: true });+ return left;+}+function ptyEchoSnippet() {const extractor = ['import importlib.util, sys, types',@@ -491,4 +500,44 @@ describe('packaged Windows terminal smoke driver', () => {'so one phase overran and was killed before it could report itself',);});++ test('imports the CDP driver without leaving Python bytecode in the repository', () => {+ const driverMarker = MARKER_LINE.trim();+ const readDriverMarker = [+ 'import importlib.util, sys, types',+ "sys.modules['websocket'] = types.ModuleType('websocket')",+ `spec = importlib.util.spec_from_file_location('d', ${JSON.stringify(driverPath)})`,+ 'm = importlib.util.module_from_spec(spec); spec.loader.exec_module(m)',+ 'sys.stdout.write(m.MARKER)',+ ].join('\n');++ drainDriverBytecode();+ try {+ const shippedSnippet = ptyEchoSnippet();+ const afterShippedCallSite = drainDriverBytecode();+ const overriddenCallerClear = runPython(['-c', readDriverMarker], {+ PYTHONDONTWRITEBYTECODE: '',+ });+ const afterHelperOverrodeCallerClear = drainDriverBytecode();++ expect(shippedSnippet).toContain(driverMarker);+ expect(+ overriddenCallerClear.code,+ `the caller-clear arm's python spawn on ${driverPath} exited non-zero: ${overriddenCallerClear.output}`,+ ).toBe(0);+ expect(overriddenCallerClear.output.trim()).toBe(driverMarker);+ expect(+ { afterShippedCallSite, afterHelperOverrodeCallerClear },+ `a python spawn compiled ${driverPath} into the repository: CPython caches an imported module's bytecode beside its source, and the push-boundary gate refuses a tree carrying untracked files`,+ ).toEqual({ afterShippedCallSite: [], afterHelperOverrodeCallerClear: [] });+ } finally {+ try {+ drainDriverBytecode();+ } catch (error) {+ process.stderr.write(+ `[pycache-drain] failed to clear __pycache__ under ${dirname(driverPath)}; python bytecode is left in the working tree, where the push-boundary gate will refuse it: ${error}\n`,+ );+ }+ }+ });});