Skip to content

Beautiful, AI-native markdown IDE and LLM wiki

Fix Windows home expansion test oracle (#7480)

Nick Gomez99ea9c4e9be7
diff --git a/packages/core/src/skills-catalog/acquire/fetch-home.test.ts b/packages/core/src/skills-catalog/acquire/fetch-home.test.ts
index fd793a606..7c917c099 100644
--- a/packages/core/src/skills-catalog/acquire/fetch-home.test.ts
+++ b/packages/core/src/skills-catalog/acquire/fetch-home.test.ts
@@ -1,14 +1,29 @@
import { mkdirSync, mkdtempSync, rmSync } from 'node:fs';
-import { join } from 'node:path';
-import { afterAll, afterEach, describe, expect, test, vi } from 'vitest';
+import { join, sep } from 'node:path';
+import { afterAll, afterEach, describe, expect, onTestFinished, test, vi } from 'vitest';
const fakeHome = vi.hoisted(() => ({ dir: '' }));
+const pathResolution = vi.hoisted(() => ({ win32: false }));
vi.mock('node:os', async (importOriginal) => {
const actual = await importOriginal<typeof import('node:os')>();
return { ...actual, homedir: () => fakeHome.dir };
});
+vi.mock('node:path', async (importOriginal) => {
+ const actual = await importOriginal<typeof import('node:path')>();
+ return {
+ ...actual,
+ resolve: (...paths: string[]) =>
+ pathResolution.win32
+ ? actual.win32
+ .resolve('C:\\', ...paths)
+ .slice(2)
+ .replaceAll('\\', '/')
+ : actual.resolve(...paths),
+ };
+});
+
const { tmpdir } = await vi.importActual<typeof import('node:os')>('node:os');
const { fetchSource } = await import('./fetch.ts');
@@ -25,9 +40,32 @@ describe('fetchSource home expansion', () => {
expect(fetched.dir).toBe(join(fakeHome.dir, 'skills'));
});
- test('expands ~ followed by a backslash', async () => {
- await expect(fetchSource({ kind: 'local', path: '~\\skills' })).rejects.toThrow(
- `Local path not found: ${fakeHome.dir}\\skills`,
- );
- });
+ test.runIf(sep === '/')(
+ 'rejects ~ followed by a backslash as a missing path under POSIX resolution',
+ async () => {
+ await expect(fetchSource({ kind: 'local', path: '~\\skills' })).rejects.toThrow(
+ `Local path not found: ${fakeHome.dir}\\skills`,
+ );
+ },
+ );
+
+ test.runIf(sep === '\\')(
+ 'expands ~ followed by a backslash to the home directory on Windows',
+ async () => {
+ const fetched = await fetchSource({ kind: 'local', path: '~\\skills' });
+ expect(fetched.dir).toBe(join(fakeHome.dir, 'skills'));
+ },
+ );
+
+ test.runIf(sep === '/')(
+ 'expands ~ followed by a backslash to the home directory under win32 resolution',
+ async () => {
+ onTestFinished(() => {
+ pathResolution.win32 = false;
+ });
+ pathResolution.win32 = true;
+ const fetched = await fetchSource({ kind: 'local', path: '~\\skills' });
+ expect(fetched.dir).toBe(join(fakeHome.dir, 'skills'));
+ },
+ );
});