Skip to content

Beautiful, AI-native markdown IDE and LLM wiki

Fix loopback guard Windows paths (#7473)

Nick Gomeza93aa5f09d8e
diff --git a/packages/app/tests/integration/loopback-bind-discipline.test.ts b/packages/app/tests/integration/loopback-bind-discipline.test.ts
index ec014649e..5e1b16eea 100644
--- a/packages/app/tests/integration/loopback-bind-discipline.test.ts
+++ b/packages/app/tests/integration/loopback-bind-discipline.test.ts
@@ -1,5 +1,5 @@
import { readdirSync, readFileSync } from 'node:fs';
-import { basename, dirname, join, relative } from 'node:path';
+import { basename, dirname, join, relative, win32 } from 'node:path';
import { fileURLToPath } from 'node:url';
import { describe, expect, test } from 'vitest';
import { isTestOnlySourceFile } from '../../../../test-support/test-only-source-file.mjs';
@@ -17,7 +17,7 @@ interface FileLines {
lines: string[];
}
-function listScannedFiles(): FileLines[] {
+function listScannedFiles(relativePath: typeof relative = relative): FileLines[] {
const out: FileLines[] = [];
function walk(dir: string) {
for (const entry of readdirSync(dir, { withFileTypes: true })) {
@@ -29,7 +29,7 @@ function listScannedFiles(): FileLines[] {
if (!entry.isFile() || !entry.name.endsWith('.ts')) continue;
if (entry.name === SELF_BASENAME) continue;
out.push({
- path: relative(PACKAGE_ROOT, abs),
+ path: relativePath(PACKAGE_ROOT, abs).replaceAll('\\', '/'),
lines: readFileSync(abs, 'utf-8').split('\n'),
});
}
@@ -141,6 +141,15 @@ describe('loopback bind discipline (app test sources)', () => {
expect(files.some((f) => isTestOnlySourceFile(f.path, 'playwright'))).toBe(true);
});
+ test('win32 path semantics yield the /-separated keys the sanity checks and listen exemptions match', () => {
+ const win32Files = listScannedFiles(win32.relative);
+ expect(win32Files.some((f) => f.path.endsWith('integration/test-harness.ts'))).toBe(true);
+ expect(win32Files.some((f) => f.path.endsWith('_helpers/server-process.ts'))).toBe(true);
+ expect(win32Files.map((f) => f.path)).toContain(RECORDING_OWNERSHIP_CASE);
+ expect(win32Files.flatMap((f) => findUnexemptedListenCalls(f.path, f.lines))).toEqual([]);
+ expect(findStaleListenExemptions(win32Files)).toEqual([]);
+ });
+
test('every .listen( call binds an explicit loopback host literal', () => {
const violations: string[] = [];
for (const file of files) {
diff --git a/packages/cli/src/loopback-bind-discipline.test.ts b/packages/cli/src/loopback-bind-discipline.test.ts
index ad80ccdab..85f893b09 100644
--- a/packages/cli/src/loopback-bind-discipline.test.ts
+++ b/packages/cli/src/loopback-bind-discipline.test.ts
@@ -1,5 +1,5 @@
import { readdirSync, readFileSync } from 'node:fs';
-import { basename, dirname, join, relative } from 'node:path';
+import { basename, dirname, join, relative, win32 } from 'node:path';
import { fileURLToPath } from 'node:url';
import { describe, expect, test } from 'vitest';
import { isTestOnlySourceFile } from '../../../test-support/test-only-source-file.mjs';
@@ -15,7 +15,7 @@ interface FileLines {
lines: string[];
}
-function listScannedTestFiles(): FileLines[] {
+function listScannedTestFiles(relativePath: typeof relative = relative): FileLines[] {
const out: FileLines[] = [];
function walk(dir: string) {
for (const entry of readdirSync(dir, { withFileTypes: true })) {
@@ -31,7 +31,7 @@ function listScannedTestFiles(): FileLines[] {
continue;
if (entry.name === SELF_BASENAME) continue;
out.push({
- path: relative(PACKAGE_ROOT, abs),
+ path: relativePath(PACKAGE_ROOT, abs).replaceAll('\\', '/'),
lines: readFileSync(abs, 'utf-8').split('\n'),
});
}
@@ -91,6 +91,11 @@ describe('loopback bind discipline (cli test sources)', () => {
expect(files.some((f) => f.path.endsWith('commands/start.test.ts'))).toBe(true);
});
+ test('win32 path semantics still yield the /-separated sanity key', () => {
+ const win32Files = listScannedTestFiles(win32.relative);
+ expect(win32Files.some((f) => f.path.endsWith('commands/start.test.ts'))).toBe(true);
+ });
+
test('every .listen( call binds an explicit loopback host literal', () => {
const violations: string[] = [];
for (const file of files) {
diff --git a/packages/server/src/loopback-bind-discipline.test.ts b/packages/server/src/loopback-bind-discipline.test.ts
index 2c1961240..cd25ddcf9 100644
--- a/packages/server/src/loopback-bind-discipline.test.ts
+++ b/packages/server/src/loopback-bind-discipline.test.ts
@@ -1,5 +1,5 @@
import { readdirSync, readFileSync } from 'node:fs';
-import { basename, dirname, join, relative } from 'node:path';
+import { basename, dirname, join, relative, win32 } from 'node:path';
import { fileURLToPath } from 'node:url';
import { describe, expect, test } from 'vitest';
import { isTestOnlySourceFile } from '../../../test-support/test-only-source-file.mjs';
@@ -15,7 +15,7 @@ interface FileLines {
lines: string[];
}
-function listScannedTestFiles(): FileLines[] {
+function listScannedTestFiles(relativePath: typeof relative = relative): FileLines[] {
const out: FileLines[] = [];
function walk(dir: string) {
for (const entry of readdirSync(dir, { withFileTypes: true })) {
@@ -31,7 +31,7 @@ function listScannedTestFiles(): FileLines[] {
continue;
if (entry.name === SELF_BASENAME) continue;
out.push({
- path: relative(PACKAGE_ROOT, abs),
+ path: relativePath(PACKAGE_ROOT, abs).replaceAll('\\', '/'),
lines: readFileSync(abs, 'utf-8').split('\n'),
});
}
@@ -91,6 +91,11 @@ describe('loopback bind discipline (server test sources)', () => {
expect(files.some((f) => f.path.endsWith('share/publish.integration.test.ts'))).toBe(true);
});
+ test('win32 path semantics still yield the /-separated sanity key', () => {
+ const win32Files = listScannedTestFiles(win32.relative);
+ expect(win32Files.some((f) => f.path.endsWith('share/publish.integration.test.ts'))).toBe(true);
+ });
+
test('every .listen( call binds an explicit loopback host literal', () => {
const violations: string[] = [];
for (const file of files) {