Skip to content

Beautiful, AI-native markdown IDE and LLM wiki

Fix note and single-file window layout (#5088)

sarahb2984d53515b
diff --git a/.changeset/note-window-mode-toggle.md b/.changeset/note-window-mode-toggle.md
new file mode 100644
index 000000000..80297e263
--- /dev/null
+++ b/.changeset/note-window-mode-toggle.md
@@ -0,0 +1,5 @@
+---
+"@inkeep/open-knowledge-desktop": patch
+---
+
+The Visual and Markdown toggle in note windows now has the same segmented styling as the regular editor.
diff --git a/.changeset/single-file-bottom-gutter.md b/.changeset/single-file-bottom-gutter.md
new file mode 100644
index 000000000..fbca34a60
--- /dev/null
+++ b/.changeset/single-file-bottom-gutter.md
@@ -0,0 +1,6 @@
+---
+"@inkeep/open-knowledge-desktop": patch
+"@inkeep/open-knowledge": patch
+---
+
+Note and single-file windows now fill the window height, removing the empty strip below the status bar.
diff --git a/knip.config.ts b/knip.config.ts
index acfdfd1c4..9cf70e257 100644
--- a/knip.config.ts
+++ b/knip.config.ts
@@ -143,15 +143,11 @@ export default {
'packages/server': {
entry: ['src/**/*.test.ts', 'src/parse-worker.ts'],
project: 'src/**',
- ignoreDependencies: [
- '@types/shell-quote',
- ],
+ ignoreDependencies: ['@types/shell-quote'],
},
'packages/cli': {
entry: ['src/**/*.test.ts', 'scripts/*.ts', 'tests/**/*.ts', 'src/parse-worker.ts'],
- ignoreDependencies: [
- 'yjs',
- ],
+ ignoreDependencies: ['yjs'],
},
'packages/desktop': {
entry: [
diff --git a/packages/app/src/App.dom.test.tsx b/packages/app/src/App.dom.test.tsx
index 8cff95a50..6b014f101 100644
--- a/packages/app/src/App.dom.test.tsx
+++ b/packages/app/src/App.dom.test.tsx
@@ -12,7 +12,10 @@ import {
recordAppShellCrashTrip,
resetTabSessionRestoreSuppression,
} from '@/lib/tab-session-restore-suppression';
-import { expectVisualClassTokens } from '@/test-utils/visual-contract';
+import {
+ expectVisualClassTokens,
+ expectVisualClassTokensAbsent,
+} from '@/test-utils/visual-contract';
type NavigationTarget =
| { kind: 'doc'; target: string; docName: string }
@@ -356,6 +359,21 @@ describe('App runtime wiring', () => {
expect(screen.queryByTestId('file-sidebar')).toBeNull();
expect(screen.queryByTestId('command-palette')).toBeNull();
expect(screen.queryByTestId('system-doc-subscriber')).toBeNull();
+ expectVisualClassTokens(screen.getByTestId('sidebar-inset').className, ['h-screen']);
+ expectVisualClassTokensAbsent(screen.getByTestId('sidebar-inset').className, [
+ 'h-[calc(100vh-var(--layout-inset-offset))]',
+ ]);
+ });
+
+ test('single-file windows fill the available height', () => {
+ singleFileMode = true;
+ renderApp({ bridge: createBridge() });
+
+ expect(screen.queryByTestId('file-sidebar')).toBeNull();
+ expectVisualClassTokens(screen.getByTestId('sidebar-inset').className, ['h-screen']);
+ expectVisualClassTokensAbsent(screen.getByTestId('sidebar-inset').className, [
+ 'h-[calc(100vh-var(--layout-inset-offset))]',
+ ]);
});
test('keeps the editor and the connecting banner', () => {
@@ -372,6 +390,10 @@ describe('App runtime wiring', () => {
expect(screen.getByTestId('command-palette')).not.toBeNull();
expect(screen.getByTestId('system-doc-subscriber')).not.toBeNull();
expect(screen.getByTestId('editor-pane')).not.toBeNull();
+ expectVisualClassTokens(screen.getByTestId('sidebar-inset').className, [
+ 'h-[calc(100vh-var(--layout-inset-offset))]',
+ ]);
+ expectVisualClassTokensAbsent(screen.getByTestId('sidebar-inset').className, ['h-screen']);
});
});
diff --git a/packages/app/src/App.tsx b/packages/app/src/App.tsx
index ec351e320..9ef38bcb5 100644
--- a/packages/app/src/App.tsx
+++ b/packages/app/src/App.tsx
@@ -559,6 +559,7 @@ function AppBody() {
const [commandPaletteOpen, setCommandPaletteOpen] = useState(false);
const singleFile = useSingleFileMode();
const noteWindow = isNoteWindow();
+ const showFileSidebar = !singleFile && !noteWindow;
const installedClis = useInstalledClis();
const terminalLaunch: TerminalLaunchContextValue | null =
@@ -626,10 +627,14 @@ function AppBody() {
<CommentQueueShortcut />
<SidebarProvider className="h-screen overflow-hidden">
{}
- {!singleFile && !noteWindow && (
- <FileSidebar onOpenSearch={() => setCommandPaletteOpen(true)} />
- )}
- <SidebarInset className="overflow-hidden h-[calc(100vh-var(--layout-inset-offset))]">
+ {showFileSidebar && <FileSidebar onOpenSearch={() => setCommandPaletteOpen(true)} />}
+ <SidebarInset
+ className={
+ showFileSidebar
+ ? 'h-[calc(100vh-var(--layout-inset-offset))] overflow-hidden'
+ : 'h-screen overflow-hidden'
+ }
+ >
<EditorPane onOpenSearch={() => setCommandPaletteOpen(true)} />
</SidebarInset>
</SidebarProvider>
diff --git a/packages/app/src/components/EditorHeader.dom.test.tsx b/packages/app/src/components/EditorHeader.dom.test.tsx
index 11b2e51f1..679b5d4ac 100644
--- a/packages/app/src/components/EditorHeader.dom.test.tsx
+++ b/packages/app/src/components/EditorHeader.dom.test.tsx
@@ -549,9 +549,9 @@ describe('EditorHeader runtime behavior', () => {
expectVisualClassTokens(leadingZone.className, [
'left-[var(--ok-titlebar-reserve-left,1rem)]',
]);
- expect(screen.getByRole('button', { name: 'mode switch' })).toBeTruthy();
const modeToggle = document.querySelector('[data-note-window-mode-toggle]') as HTMLElement;
- expectVisualClassTokens(modeToggle.className, [
+ expect(modeToggle.contains(screen.getByRole('button', { name: 'mode switch' }))).toBe(true);
+ expectVisualClassTokensAbsent(modeToggle.className, [
'[&_[data-slot=toggle-group]]:bg-transparent',
'[&_[data-slot=toggle-group]]:p-0',
'[&_[data-slot=toggle-group-item]]:size-8',
diff --git a/packages/app/src/components/EditorHeader.tsx b/packages/app/src/components/EditorHeader.tsx
index cc7fd44af..c22dd1ae2 100644
--- a/packages/app/src/components/EditorHeader.tsx
+++ b/packages/app/src/components/EditorHeader.tsx
@@ -326,7 +326,7 @@ export function EditorHeader({
{noteWindow && noteModeToggle ? (
<div
data-note-window-mode-toggle=""
- className="absolute inset-y-0 left-1/2 z-30 flex -translate-x-1/2 items-center [-webkit-app-region:no-drag] [&_[data-slot=toggle-group]]:bg-transparent [&_[data-slot=toggle-group]]:p-0 [&_[data-slot=toggle-group-item]]:size-8 [&_[data-slot=toggle-group-item]]:shadow-none"
+ className="absolute inset-y-0 left-1/2 z-30 flex -translate-x-1/2 items-center [-webkit-app-region:no-drag]"
>
{noteModeToggle}
</div>
diff --git a/packages/app/tests/integration/bug3-source-mode-writeback.test.ts b/packages/app/tests/integration/bug3-source-mode-writeback.test.ts
index a28cc2b18..8a60e5826 100644
--- a/packages/app/tests/integration/bug3-source-mode-writeback.test.ts
+++ b/packages/app/tests/integration/bug3-source-mode-writeback.test.ts
@@ -1,4 +1,3 @@
-
import { readFileSync } from 'node:fs';
import { join } from 'node:path';
import { setTimeout as wait } from 'node:timers/promises';
diff --git a/packages/app/tests/integration/indented-jsx-byte-sacred.test.ts b/packages/app/tests/integration/indented-jsx-byte-sacred.test.ts
index 4fc2c11f9..6fcdc23f2 100644
--- a/packages/app/tests/integration/indented-jsx-byte-sacred.test.ts
+++ b/packages/app/tests/integration/indented-jsx-byte-sacred.test.ts
@@ -1,4 +1,3 @@
-
import { setTimeout as wait } from 'node:timers/promises';
import { normalizeBridge } from '@inkeep/open-knowledge-core';
import { updateYFragment } from '@tiptap/y-tiptap';
diff --git a/packages/app/tests/integration/interior-edit-freshness.test.ts b/packages/app/tests/integration/interior-edit-freshness.test.ts
index 9f2f6feb6..40b5cdfd6 100644
--- a/packages/app/tests/integration/interior-edit-freshness.test.ts
+++ b/packages/app/tests/integration/interior-edit-freshness.test.ts
@@ -1,4 +1,3 @@
-
import { setTimeout as wait } from 'node:timers/promises';
import { updateYFragment, yXmlFragmentToProseMirrorRootNode } from '@tiptap/y-tiptap';
import { afterAll, beforeAll, describe, expect, test } from 'vitest';
diff --git a/packages/app/tests/integration/keystroke-cadence-danger-space.test.ts b/packages/app/tests/integration/keystroke-cadence-danger-space.test.ts
index 2a085742b..93666af70 100644
--- a/packages/app/tests/integration/keystroke-cadence-danger-space.test.ts
+++ b/packages/app/tests/integration/keystroke-cadence-danger-space.test.ts
@@ -1,4 +1,3 @@
-
import { setTimeout as wait } from 'node:timers/promises';
import { updateYFragment, yXmlFragmentToProseMirrorRootNode } from '@tiptap/y-tiptap';
import { afterAll, beforeAll, describe, expect, test } from 'vitest';
diff --git a/packages/app/tests/integration/producer-guard-wiring.test.ts b/packages/app/tests/integration/producer-guard-wiring.test.ts
index 878d5196b..867598d34 100644
--- a/packages/app/tests/integration/producer-guard-wiring.test.ts
+++ b/packages/app/tests/integration/producer-guard-wiring.test.ts
@@ -1,4 +1,3 @@
-
import { setTimeout as wait } from 'node:timers/promises';
import { updateYFragment, yXmlFragmentToProseMirrorRootNode } from '@tiptap/y-tiptap';
import { afterAll, beforeAll, describe, expect, test } from 'vitest';
diff --git a/packages/app/tests/integration/qa-039-reconciliation-counters-http.test.ts b/packages/app/tests/integration/qa-039-reconciliation-counters-http.test.ts
index 4ada3cf26..0970ac12f 100644
--- a/packages/app/tests/integration/qa-039-reconciliation-counters-http.test.ts
+++ b/packages/app/tests/integration/qa-039-reconciliation-counters-http.test.ts
@@ -1,4 +1,3 @@
-
import { randomUUID } from 'node:crypto';
import { afterEach, describe, expect, test } from 'vitest';
import { agentWriteMd, createTestServer, type TestServer } from './test-harness';
diff --git a/packages/app/tests/integration/qa-045-restore-after-gc.test.ts b/packages/app/tests/integration/qa-045-restore-after-gc.test.ts
index cbe2b705f..b632185e1 100644
--- a/packages/app/tests/integration/qa-045-restore-after-gc.test.ts
+++ b/packages/app/tests/integration/qa-045-restore-after-gc.test.ts
@@ -1,4 +1,3 @@
-
import { execFileSync } from 'node:child_process';
import { randomUUID } from 'node:crypto';
import { join } from 'node:path';
diff --git a/packages/app/tests/integration/qa-050-rollback-undo-shipped-path.test.ts b/packages/app/tests/integration/qa-050-rollback-undo-shipped-path.test.ts
index 89bc9b4d9..c530ce4ba 100644
--- a/packages/app/tests/integration/qa-050-rollback-undo-shipped-path.test.ts
+++ b/packages/app/tests/integration/qa-050-rollback-undo-shipped-path.test.ts
@@ -1,4 +1,3 @@
-
import { randomUUID } from 'node:crypto';
import { afterAll, afterEach, beforeAll, describe, expect, test } from 'vitest';
import type * as Y from 'yjs';
diff --git a/packages/app/tests/integration/undo-after-rollback.test.ts b/packages/app/tests/integration/undo-after-rollback.test.ts
index a78aeb0e4..d3767adc9 100644
--- a/packages/app/tests/integration/undo-after-rollback.test.ts
+++ b/packages/app/tests/integration/undo-after-rollback.test.ts
@@ -1,4 +1,3 @@
-
import { ROLLBACK_ORIGIN } from '@inkeep/open-knowledge-server';
import { afterAll, beforeAll, describe, expect, test } from 'vitest';
import * as Y from 'yjs';
diff --git a/packages/app/tests/integration/undo-recycle-reset.test.ts b/packages/app/tests/integration/undo-recycle-reset.test.ts
index e7cc69c3f..b076f955c 100644
--- a/packages/app/tests/integration/undo-recycle-reset.test.ts
+++ b/packages/app/tests/integration/undo-recycle-reset.test.ts
@@ -1,4 +1,3 @@
-
import { writeFileSync } from 'node:fs';
import { join } from 'node:path';
import { setTimeout as wait } from 'node:timers/promises';
diff --git a/packages/app/tests/integration/undo-rederive-survival.test.ts b/packages/app/tests/integration/undo-rederive-survival.test.ts
index 9ddcd0730..7935e35f8 100644
--- a/packages/app/tests/integration/undo-rederive-survival.test.ts
+++ b/packages/app/tests/integration/undo-rederive-survival.test.ts
@@ -1,4 +1,3 @@
-
import { prependFrontmatter } from '@inkeep/open-knowledge-core';
import { Plugin, PluginKey } from '@tiptap/pm/state';
import { updateYFragment, yXmlFragmentToProseMirrorRootNode } from '@tiptap/y-tiptap';
diff --git a/packages/core/src/bridge/compose.ts b/packages/core/src/bridge/compose.ts
index 2a597ec3d..f4cc8a286 100644
--- a/packages/core/src/bridge/compose.ts
+++ b/packages/core/src/bridge/compose.ts
@@ -1,4 +1,3 @@
-
import { prependFrontmatter, stripFrontmatter } from '../extensions/frontmatter.ts';
export type ComposeAdjustment = 'none' | 'body' | 'frontmatter' | 'unresolved';
diff --git a/packages/core/src/bridge/doc-boundary-space.ts b/packages/core/src/bridge/doc-boundary-space.ts
index 01ef76a9f..8fb428b90 100644
--- a/packages/core/src/bridge/doc-boundary-space.ts
+++ b/packages/core/src/bridge/doc-boundary-space.ts
@@ -1,4 +1,3 @@
-
import { FRONTMATTER_RE, stripFrontmatter } from '../extensions/frontmatter.ts';
import { carriedEdgeEmpties, type DocEdgeEmpties } from '../markdown/doc-edge-blank-runs.ts';
diff --git a/packages/core/src/markdown/comment-promoter.ts b/packages/core/src/markdown/comment-promoter.ts
index fb0ba5a7c..fc267cbea 100644
--- a/packages/core/src/markdown/comment-promoter.ts
+++ b/packages/core/src/markdown/comment-promoter.ts
@@ -1,4 +1,3 @@
-
import type { Nodes, Paragraph, PhrasingContent, Root, RootContent, Text } from 'mdast';
import { SKIP, visit } from 'unist-util-visit';
import type { VFile } from 'vfile';
diff --git a/packages/core/src/markdown/merged-walker.ts b/packages/core/src/markdown/merged-walker.ts
index fa3cfcd86..bfd7e3109 100644
--- a/packages/core/src/markdown/merged-walker.ts
+++ b/packages/core/src/markdown/merged-walker.ts
@@ -1,4 +1,3 @@
-
import type { Nodes, Parent, Root } from 'mdast';
import { SKIP, visit } from 'unist-util-visit';
import type { VFile } from 'vfile';
diff --git a/packages/core/src/markdown/safe-url.ts b/packages/core/src/markdown/safe-url.ts
index 8be632ba4..4d3250d3a 100644
--- a/packages/core/src/markdown/safe-url.ts
+++ b/packages/core/src/markdown/safe-url.ts
@@ -1,4 +1,3 @@
-
export const SAFE_URL_SCHEMES = ['https', 'http', 'mailto', 'tel', 'ftp', 'sms'] as const;
const SCHEME_ALT = SAFE_URL_SCHEMES.map((s) => `${s}:`).join('|');