Skip to content

Beautiful, AI-native markdown IDE and LLM wiki

route bug-lane-verify inputs through env instead of the shell body (#3805)

Andrew Mikofalvyb51bba292978
diff --git a/.github/scripts/bug-lane-refusal-payload.test.mjs b/.github/scripts/bug-lane-refusal-payload.test.mjs
index 5e109bcdd..c1fecccf5 100644
--- a/.github/scripts/bug-lane-refusal-payload.test.mjs
+++ b/.github/scripts/bug-lane-refusal-payload.test.mjs
@@ -331,9 +331,20 @@ describe('parseArgs', () => {
});
describe('workflow wiring', () => {
- /** Exact bounds of a step: its `- name:` up to the next sibling step. */
+ /**
+ * Exact bounds of a step: its `- name:` up to the next sibling step.
+ *
+ * Throws on a missing name rather than returning a degenerate slice. An
+ * unguarded `indexOf` yields -1, `slice(-1)` yields the file's last
+ * character, and every `not.toContain` / `not.toMatch` assertion below then
+ * passes against that one character — so a renamed or relocated step turns
+ * its own coverage green instead of red. The sibling helper in
+ * release-cascade-shape.test.mjs guards the same way, for the same reason.
+ */
const step = (name) => {
- const rest = bugLaneVerify.slice(bugLaneVerify.indexOf(`- name: ${name}`));
+ const start = bugLaneVerify.indexOf(`- name: ${name}`);
+ if (start === -1) throw new Error(`bug-lane-verify.yml has no step named ${name}`);
+ const rest = bugLaneVerify.slice(start);
const end = rest.indexOf('\n - name: ');
return end === -1 ? rest : rest.slice(0, end);
};
diff --git a/.github/workflows/bug-lane-verify.yml b/.github/workflows/bug-lane-verify.yml
index cdc4dd5ea..9894ab5c6 100644
--- a/.github/workflows/bug-lane-verify.yml
+++ b/.github/workflows/bug-lane-verify.yml
@@ -97,13 +97,23 @@ jobs:
# Only reachable via a hand-typed dispatch: the evaluator never asks
# for a verify without candidates. Fail rather than proceed — an empty
# FIX_REFS would cherry-pick nothing and read as a clean pass.
+ env:
+ # Every inputs.* reference in this workflow goes through env, never
+ # `${{ }}` inside a run: block — the expression engine splices before
+ # the shell parses, so a dispatch value carrying `$(...)` or a quote
+ # break executes in a job that later holds GITHUB_TOKEN and the Slack
+ # webhook secrets. Same convention and same reason as
+ # publish-linux-repo.yml's TAG and point-release.yml's ten inputs.
+ FIX_REFS: ${{ inputs.fix_refs }}
+ STABLE: ${{ inputs.stable }}
+ DISPATCHED_BY: ${{ inputs.dispatched_by }}
run: |
set -euo pipefail
- if [[ -z "${{ inputs.fix_refs }}" ]]; then
+ if [[ -z "$FIX_REFS" ]]; then
echo "::error::bug-lane-verify: fix_refs is empty; nothing to verify."
exit 1
fi
- echo "::notice::bug-lane-verify: ${{ inputs.fix_refs }} over ${{ inputs.stable }} (requested by ${{ inputs.dispatched_by || 'a manual dispatch' }})."
+ echo "::notice::bug-lane-verify: ${FIX_REFS} over ${STABLE} (requested by ${DISPATCHED_BY:-a manual dispatch})."
- name: Checkout with full history and tags
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2