Skip to content

Beautiful, AI-native markdown IDE and LLM wiki

fix(open-knowledge): rank betas by version, not GitHub list order (#2251)

Andrew Mikofalvyc05321871fbc
diff --git a/docs/src/lib/download-links.test.ts b/docs/src/lib/download-links.test.ts
index e75653118..49018b65f 100644
--- a/docs/src/lib/download-links.test.ts
+++ b/docs/src/lib/download-links.test.ts
@@ -40,7 +40,7 @@ function jsonResponse(payload: unknown, status = 200) {
}
describe('pickLatestBetaDmgUrl', () => {
- test('picks the DMG from the first published beta (API order is newest-first)', () => {
+ test('picks the highest-versioned published beta', () => {
const url = pickLatestBetaDmgUrl([
release('v0.12.0-beta.7'),
release('v0.12.0-beta.6'),
@@ -49,6 +49,40 @@ describe('pickLatestBetaDmgUrl', () => {
expect(url).toBe(dmgUrl('v0.12.0-beta.7'));
});
+ test('ranks by version, not the array order GitHub returns (older beta listed first)', () => {
+ const url = pickLatestBetaDmgUrl([
+ release('v0.20.0-beta.9'),
+ release('v0.20.0-beta.8'),
+ release('v0.20.0-beta.13'),
+ release('v0.20.0-beta.12'),
+ release('v0.20.0-beta.10'),
+ ]);
+ expect(url).toBe(dmgUrl('v0.20.0-beta.13'));
+ });
+
+ test('beta.10 outranks beta.9 (no lexical tag compare)', () => {
+ const url = pickLatestBetaDmgUrl([release('v0.20.0-beta.9'), release('v0.20.0-beta.10')]);
+ expect(url).toBe(dmgUrl('v0.20.0-beta.10'));
+ });
+
+ test('ranks across base versions (minor/patch), not just the beta counter', () => {
+ const url = pickLatestBetaDmgUrl([
+ release('v0.20.0-beta.99'),
+ release('v0.21.0-beta.1'),
+ release('v0.20.1-beta.2'),
+ ]);
+ expect(url).toBe(dmgUrl('v0.21.0-beta.1'));
+ });
+
+ test('skips the newest beta when its DMG is missing, ranking the next-newest', () => {
+ const url = pickLatestBetaDmgUrl([
+ release('v0.20.0-beta.13', { assetNames: ['beta-mac.yml'] }),
+ release('v0.20.0-beta.12'),
+ release('v0.20.0-beta.9'),
+ ]);
+ expect(url).toBe(dmgUrl('v0.20.0-beta.12'));
+ });
+
test('skips stable releases even when they appear first', () => {
const url = pickLatestBetaDmgUrl([
release('v0.11.0', { prerelease: false }),
diff --git a/docs/src/lib/download-links.ts b/docs/src/lib/download-links.ts
index b597c20b2..1c5497d3f 100644
--- a/docs/src/lib/download-links.ts
+++ b/docs/src/lib/download-links.ts
@@ -10,7 +10,16 @@ export const RELEASES_PAGE_URL = 'https://github.com/inkeep/open-knowledge/relea
const ASSET_URL_PREFIX = 'https://github.com/inkeep/open-knowledge/releases/download/';
-const BETA_TAG_PATTERN = /^v\d+\.\d+\.\d+-beta\.\d+$/;
+const BETA_TAG_PATTERN = /^v(\d+)\.(\d+)\.(\d+)-beta\.(\d+)$/;
+
+type BetaRank = readonly [number, number, number, number];
+
+function compareBetaRank(a: BetaRank, b: BetaRank): number {
+ for (let i = 0; i < 4; i++) {
+ if (a[i] !== b[i]) return a[i] - b[i];
+ }
+ return 0;
+}
const LKG_TTL_MS = 300_000;
@@ -37,16 +46,22 @@ export function pickLatestBetaDmgUrl(payload: unknown): string | null {
return null;
}
+ let best: { rank: BetaRank; url: string } | null = null;
for (const release of parsed.data) {
if (release.draft || !release.prerelease) continue;
- if (!BETA_TAG_PATTERN.test(release.tag_name)) continue;
+ const parts = BETA_TAG_PATTERN.exec(release.tag_name);
+ if (!parts) continue;
const dmg = release.assets.find(
(asset) =>
asset.name === DMG_ASSET_NAME && asset.browser_download_url.startsWith(ASSET_URL_PREFIX),
);
- if (dmg) return dmg.browser_download_url;
+ if (!dmg) continue;
+ const rank: BetaRank = [Number(parts[1]), Number(parts[2]), Number(parts[3]), Number(parts[4])];
+ if (!best || compareBetaRank(rank, best.rank) > 0) {
+ best = { rank, url: dmg.browser_download_url };
+ }
}
- return null;
+ return best?.url ?? null;
}
export type BetaRedirect =