Skip to content

Beautiful, AI-native markdown IDE and LLM wiki

test(open-knowledge): folder-rename regression coverage for PRD-7045 chain (#2254)

mike-inkeepc1a175a63e1a
diff --git a/packages/app/tests/integration/removal-phantom-resurrection.test.ts b/packages/app/tests/integration/removal-phantom-resurrection.test.ts
index 22b3ee41e..b84af9457 100644
--- a/packages/app/tests/integration/removal-phantom-resurrection.test.ts
+++ b/packages/app/tests/integration/removal-phantom-resurrection.test.ts
@@ -1,7 +1,14 @@
import { afterAll, beforeAll, beforeEach, describe, expect, test } from 'bun:test';
-import { existsSync, renameSync, unlinkSync, writeFileSync } from 'node:fs';
-import { join } from 'node:path';
+import {
+ existsSync,
+ mkdirSync,
+ readFileSync,
+ renameSync,
+ unlinkSync,
+ writeFileSync,
+} from 'node:fs';
+import { dirname, join } from 'node:path';
import { setTimeout as wait } from 'node:timers/promises';
import {
getMetrics,
@@ -66,6 +73,26 @@ async function renamePath(
return { status: res.status, body };
}
+async function renameFolder(
+ port: number,
+ fromPath: string,
+ toPath: string,
+): Promise<{
+ status: number;
+ body: { ok: boolean; renamed?: Array<{ fromDocName: string; toDocName: string }> };
+}> {
+ const res = await fetch(`http://127.0.0.1:${port}/api/rename-path`, {
+ method: 'POST',
+ headers: { 'Content-Type': 'application/json' },
+ body: JSON.stringify({ kind: 'folder', fromPath, toPath }),
+ });
+ const body = (await res.json()) as {
+ ok: boolean;
+ renamed?: Array<{ fromDocName: string; toDocName: string }>;
+ };
+ return { status: res.status, body };
+}
+
async function deletePath(
port: number,
path: string,
@@ -94,7 +121,9 @@ async function createPage(
}
async function seedDoc(server: TestServer, docName: string, content = '# seed\n'): Promise<void> {
- writeFileSync(join(server.contentDir, `${docName}.md`), content, 'utf-8');
+ const filePath = join(server.contentDir, `${docName}.md`);
+ mkdirSync(dirname(filePath), { recursive: true });
+ writeFileSync(filePath, content, 'utf-8');
await pollUntilAsync(async () => {
const res = await fetch(`http://127.0.0.1:${server.port}/api/documents`);
if (!res.ok) return false;
@@ -103,6 +132,15 @@ async function seedDoc(server: TestServer, docName: string, content = '# seed\n'
}, 8000);
}
+async function writeMd(server: TestServer, docName: string, markdown: string): Promise<void> {
+ const res = await fetch(`http://127.0.0.1:${server.port}/api/agent-write-md`, {
+ method: 'POST',
+ headers: { 'Content-Type': 'application/json' },
+ body: JSON.stringify({ docName, markdown, position: 'replace' }),
+ });
+ if (!res.ok) throw new Error(`agent-write-md failed for ${docName}: ${res.status}`);
+}
+
async function pollUntilGuardSettled(
server: TestServer,
docName: string,
@@ -218,6 +256,39 @@ describe('removalRedirectGuard — auth-rejection mechanism', () => {
expect(existsSync(join(server.contentDir, `${c}.md`))).toBe(true);
}, 30_000);
+ test('QA-FOLDER: folder rename arms the cache for every descendant doc (no duplicate folder)', async () => {
+ const fromFolder = `foods-${crypto.randomUUID()}`;
+ const toFolder = `recipes-${crypto.randomUUID()}`;
+ await writeMd(server, `${fromFolder}/apple`, '# Apple\n\nbody-apple\n');
+ await writeMd(server, `${fromFolder}/sub/banana`, '# Banana\n\nbody-banana\n');
+
+ const res = await renameFolder(server.port, fromFolder, toFolder);
+ expect(res.status).toBe(200);
+ expect(res.body.renamed?.map((r) => r.fromDocName).sort()).toEqual([
+ `${fromFolder}/apple`,
+ `${fromFolder}/sub/banana`,
+ ]);
+
+ expect(existsSync(join(server.contentDir, `${fromFolder}/apple.md`))).toBe(false);
+ expect(readFileSync(join(server.contentDir, `${toFolder}/apple.md`), 'utf-8')).toContain(
+ 'body-apple',
+ );
+ expect(readFileSync(join(server.contentDir, `${toFolder}/sub/banana.md`), 'utf-8')).toContain(
+ 'body-banana',
+ );
+
+ for (const [oldName, newName] of [
+ [`${fromFolder}/apple`, `${toFolder}/apple`],
+ [`${fromFolder}/sub/banana`, `${toFolder}/sub/banana`],
+ ]) {
+ const rejection = await runAuthGuard(server, oldName);
+ expect(rejection).toBeInstanceOf(HocuspocusAuthRejection);
+ const parsed = parseAuthRejectionWire((rejection as HocuspocusAuthRejection).reason);
+ expect(parsed.kind).toBe('rename-redirect');
+ expect(parsed.payload).toBe(newName);
+ }
+ }, 30_000);
+
test('QA-016: system + config docNames bypass the guard entirely', async () => {
const systemDoc = '__system__';
const configDoc = '__config__/project';
diff --git a/packages/server/src/api-folder-rename-disk-enum.test.ts b/packages/server/src/api-folder-rename-disk-enum.test.ts
index 8aca04663..eb1909c38 100644
--- a/packages/server/src/api-folder-rename-disk-enum.test.ts
+++ b/packages/server/src/api-folder-rename-disk-enum.test.ts
@@ -131,3 +131,67 @@ describe('folder rename enumerates descendant docs from disk', () => {
expect(indexBody).toContain('[[guides/page]]');
});
});
+
+describe('folder rename rewrites every inbound link shape and preserves intra-folder links', () => {
+ test('rewrites nested `../` inbound links and leaves no stale folder references', async () => {
+ seed(contentDir, 'foods/apple.md', '# Apple\n');
+ seed(contentDir, 'foods/sub/banana.md', '# Banana\n');
+
+ seed(contentDir, 'top-wiki.md', 'See [[foods/apple]].\n');
+ seed(contentDir, 'top-root.md', 'See [apple](/foods/apple.md).\n');
+ seed(contentDir, 'top-dotrel.md', 'See [apple](./foods/apple.md).\n');
+ seed(contentDir, 'one/note.md', 'See [apple](../foods/apple.md).\n');
+ seed(contentDir, 'one/two/note.md', 'See [banana](../../foods/sub/banana.md).\n');
+
+ const { status } = await renameFolder(contentDir, 'foods', 'recipes');
+ expect(status).toBe(200);
+
+ const read = (p: string) => readFileSync(join(contentDir, p), 'utf-8');
+ for (const p of [
+ 'top-wiki.md',
+ 'top-root.md',
+ 'top-dotrel.md',
+ 'one/note.md',
+ 'one/two/note.md',
+ ]) {
+ expect(read(p)).not.toContain('foods');
+ }
+ expect(read('top-wiki.md')).toContain('[[recipes/apple]]');
+ expect(read('top-root.md')).toContain('(/recipes/apple.md)');
+ expect(read('top-dotrel.md')).toContain('(./recipes/apple.md)');
+ expect(read('one/note.md')).toContain('(../recipes/apple.md)');
+ expect(read('one/two/note.md')).toContain('(../../recipes/sub/banana.md)');
+ expect(existsSync(join(contentDir, 'recipes/apple.md'))).toBe(true);
+ expect(existsSync(join(contentDir, 'recipes/sub/banana.md'))).toBe(true);
+ expect(existsSync(join(contentDir, 'foods'))).toBe(false);
+ });
+
+ test('preserves relative links authored INSIDE the renamed folder (no orphans)', async () => {
+ seed(
+ contentDir,
+ 'foods/apple.md',
+ '# Apple\n\nSee [banana](./sub/banana.md) and [carrot](../veg/carrot.md).\n',
+ );
+ seed(
+ contentDir,
+ 'foods/sub/banana.md',
+ '# Banana\n\nSee [apple](../apple.md) and [carrot](../../veg/carrot.md).\n',
+ );
+ seed(contentDir, 'veg/carrot.md', '# Carrot\n');
+
+ const { status } = await renameFolder(contentDir, 'foods', 'recipes');
+ expect(status).toBe(200);
+
+ const apple = readFileSync(join(contentDir, 'recipes/apple.md'), 'utf-8');
+ const banana = readFileSync(join(contentDir, 'recipes/sub/banana.md'), 'utf-8');
+
+ expect(apple).toContain('[banana](sub/banana.md)');
+ expect(apple).toContain('[carrot](../veg/carrot.md)');
+ expect(banana).toContain('[apple](../apple.md)');
+ expect(banana).toContain('[carrot](../../veg/carrot.md)');
+
+ expect(existsSync(join(contentDir, 'recipes/apple.md'))).toBe(true);
+ expect(existsSync(join(contentDir, 'recipes/sub/banana.md'))).toBe(true);
+ expect(existsSync(join(contentDir, 'veg/carrot.md'))).toBe(true);
+ });
+});