Skip to content

Beautiful, AI-native markdown IDE and LLM wiki

(fix) PRD-7920 - Comment edits are discarded with IME (#3397)

shagun-singh-inkeepc692022c1996
diff --git a/.changeset/comment-edit-save-button.md b/.changeset/comment-edit-save-button.md
new file mode 100644
index 000000000..3dc1b8218
--- /dev/null
+++ b/.changeset/comment-edit-save-button.md
@@ -0,0 +1,5 @@
+---
+"@inkeep/open-knowledge": patch
+---
+
+Fixed comment edits being silently discarded. The edit field saved only on Enter, with no visible Save button — and for anyone typing through an IME (Chinese, Japanese, Korean), the Enter that commits the composition never reaches the save, so the revised text sat in the field and was lost when the card closed. The edit field now has explicit Save and Cancel buttons, matching the comment composers elsewhere; Enter still saves and Escape still discards.
diff --git a/packages/app/src/comments/ThreadCard.tsx b/packages/app/src/comments/ThreadCard.tsx
index dca80c193..f98c93210 100644
--- a/packages/app/src/comments/ThreadCard.tsx
+++ b/packages/app/src/comments/ThreadCard.tsx
@@ -146,6 +146,21 @@ export function ThreadCard({
scrollAnchorIntoView(editor, range);
}
+ function cancelEdit() {
+ setDraft(thread.body);
+ setEditing(false);
+ }
+
+ function saveEdit() {
+ const next = draft.trim();
+ if (next.length === 0 || next === thread.body) {
+ setEditing(false);
+ return;
+ }
+ editComment(thread.id, next);
+ setEditing(false);
+ }
+
function rePlaceOnSelection() {
const editor = getEditorForDoc(thread.docName);
if (!editor) return;
@@ -319,32 +334,40 @@ export function ThreadCard({
for an action taken on few of them. Enter saves, Shift+Enter is a
newline, Escape discards the revision. */}
{editing && (
- <Textarea
- ref={editFieldRef}
- rows={1}
- value={draft}
- onChange={(e) => setDraft(e.target.value)}
- onKeyDown={(e) => {
- if (e.key === 'Escape') {
- setDraft(thread.body);
- setEditing(false);
- return;
- }
- if (e.key !== 'Enter' || e.shiftKey) return;
- // Mid-composition Enter belongs to the IME, not to saving.
- if (e.nativeEvent.isComposing) return;
- e.preventDefault();
- const next = draft.trim();
- if (next.length === 0 || next === thread.body) {
- setEditing(false);
- return;
- }
- editComment(thread.id, next);
- setEditing(false);
- }}
- placeholder={t`Edit this comment`}
- className="min-h-0 resize-none px-2 py-1 text-sm leading-5"
- />
+ <div className="flex flex-col gap-1.5">
+ <Textarea
+ ref={editFieldRef}
+ rows={1}
+ value={draft}
+ onChange={(e) => setDraft(e.target.value)}
+ onKeyDown={(e) => {
+ if (e.key === 'Escape') {
+ cancelEdit();
+ return;
+ }
+ if (e.key !== 'Enter' || e.shiftKey) return;
+ // Mid-composition Enter belongs to the IME, not to saving.
+ if (e.nativeEvent.isComposing) return;
+ e.preventDefault();
+ saveEdit();
+ }}
+ placeholder={t`Edit this comment`}
+ className="min-h-0 resize-none px-2 py-1 text-sm leading-5"
+ />
+ <div className="flex items-center justify-end gap-1.5">
+ <Button size="sm" variant="ghost" onClick={cancelEdit}>
+ <Trans>Cancel</Trans>
+ </Button>
+ <Button
+ size="sm"
+ onClick={saveEdit}
+ disabled={draft.trim().length === 0}
+ aria-label={t`Save this comment (Enter)`}
+ >
+ <Trans>Save</Trans>
+ </Button>
+ </div>
+ </div>
)}
{/* Only a resolved thread still needs a row down here. Resolving is
something a SEND does, not something you declare, so there is no
diff --git a/packages/app/src/comments/thread-edit-save.dom.test.tsx b/packages/app/src/comments/thread-edit-save.dom.test.tsx
new file mode 100644
index 000000000..08c0765bd
--- /dev/null
+++ b/packages/app/src/comments/thread-edit-save.dom.test.tsx
@@ -0,0 +1,95 @@
+/**
+ * The edit field's Save and Cancel row.
+ *
+ * The field used to be Enter-only. For an IME user the commit Enter belongs to
+ * the composition — the keydown guard eats it, correctly — and with no visible
+ * way to save, the revision sat in the field until the card closed and was
+ * silently gone. The row is the fix, so what is worth pinning is that Save
+ * actually writes the revision through, that Cancel actually discards it, and
+ * that the no-op cases (unchanged, emptied) do not write at all.
+ */
+
+import { cleanup, fireEvent, render, screen } from '@testing-library/react';
+import { afterEach, beforeEach, describe, expect, test, vi } from 'vitest';
+import type { CommentThread } from './types';
+
+const editComment = vi.fn();
+
+vi.doMock('./store', () => ({
+ editComment,
+ toggleSending: () => {},
+ deleteThread: () => {},
+ reopenThread: () => {},
+ replaceOrphan: () => {},
+ setActiveThread: () => {},
+ clearActiveThread: () => {},
+}));
+
+function thread(overrides: Partial<CommentThread> = {}): CommentThread {
+ return {
+ id: 't1',
+ docName: 'recipes/stir-fry',
+ target: { kind: 'body' },
+ anchor: { quote: 'the tofu', prefix: '', suffix: '', start: 0, end: 8 },
+ status: 'open',
+ body: 'press it?',
+ createdAt: 1000,
+ queued: true,
+ ...overrides,
+ };
+}
+
+async function renderEditing(t: CommentThread = thread()) {
+ const { ThreadCard } = await import('./ThreadCard');
+ const view = render(
+ <ThreadCard thread={t} now={2000} cardRef={() => {}} focused={false} sending={false} />,
+ );
+ fireEvent.click(screen.getByRole('button', { name: /edit this comment/i }));
+ const field = (await screen.findByDisplayValue(t.body)) as HTMLTextAreaElement;
+ return { view, field };
+}
+
+beforeEach(() => editComment.mockClear());
+afterEach(() => cleanup());
+
+describe('saving an edit', () => {
+ test('the Save button writes the revision through and closes the field', async () => {
+ const { field } = await renderEditing();
+ fireEvent.change(field, { target: { value: 'press it overnight' } });
+ fireEvent.click(screen.getByRole('button', { name: /save this comment/i }));
+
+ expect(editComment).toHaveBeenCalledWith('t1', 'press it overnight');
+ expect(screen.queryByRole('textbox')).toBeNull();
+ });
+
+ test('an unchanged comment closes without a write', async () => {
+ await renderEditing();
+ fireEvent.click(screen.getByRole('button', { name: /save this comment/i }));
+
+ expect(editComment).not.toHaveBeenCalled();
+ expect(screen.queryByRole('textbox')).toBeNull();
+ });
+
+ test('an emptied field cannot be saved', async () => {
+ const { field } = await renderEditing();
+ fireEvent.change(field, { target: { value: ' ' } });
+
+ const save = screen.getByRole('button', { name: /save this comment/i });
+ expect(save.hasAttribute('disabled')).toBe(true);
+ });
+});
+
+describe('cancelling an edit', () => {
+ test('Cancel discards the revision and the next open seeds the original', async () => {
+ const { field } = await renderEditing();
+ fireEvent.change(field, { target: { value: 'something else entirely' } });
+ fireEvent.click(screen.getByRole('button', { name: /cancel/i }));
+
+ expect(editComment).not.toHaveBeenCalled();
+ expect(screen.queryByRole('textbox')).toBeNull();
+
+ // The discarded draft must not leak into the next edit.
+ fireEvent.click(screen.getByRole('button', { name: /edit this comment/i }));
+ expect(await screen.findByDisplayValue('press it?')).toBeTruthy();
+ });
+});
diff --git a/packages/app/src/locales/ar/messages.json b/packages/app/src/locales/ar/messages.json
index af13bc0a0..4a8c1be30 100644
--- a/packages/app/src/locales/ar/messages.json
+++ b/packages/app/src/locales/ar/messages.json
@@ -298,6 +298,7 @@
"3V94ia": ["تعذّر إرسال تعليقاتك — مساحة العمل غير جاهزة."],
"3VbwPp": ["فتح ", ["keyName"], " في المتصفح"],
"3VsNTI": ["يجري تحميل المستند"],
+ "3W5kYZ": ["حفظ هذا التعليق (Enter)"],
"3YWddZ": ["لا تغييرات في المحتوى في هذه النسخة"],
"3YvS-c": ["تبويب جديد"],
"3_6U6f": ["الاتصال بـ GitHub"],
diff --git a/packages/app/src/locales/ar/messages.po b/packages/app/src/locales/ar/messages.po
index b51a2e068..bdbec900b 100644
--- a/packages/app/src/locales/ar/messages.po
+++ b/packages/app/src/locales/ar/messages.po
@@ -2063,6 +2063,7 @@ msgid "Can't share this path."
msgstr "تعذّرت مشاركة هذا المسار."
#: src/comments/PropertyCommentButton.tsx
+#: src/comments/ThreadCard.tsx
#: src/components/acp/ThreadHistoryMenu.tsx
#: src/components/ActivityPanelBurstRow.tsx
#: src/components/AuthModal.tsx
@@ -10158,6 +10159,7 @@ msgstr "صورة نموذجية"
msgid "Sandboxed HTML embed — write HTML, see the rendered preview live."
msgstr "تضمين HTML معزول — اكتب HTML وشاهد المعاينة المعروضة مباشرةً."
+#: src/comments/ThreadCard.tsx
#: src/components/AuthModal.tsx
#: src/components/FileTargetRenameDialog.tsx
#: src/components/settings/SearchSection.tsx
@@ -10184,6 +10186,10 @@ msgstr "حفظ الرسالة المنتظرة"
msgid "Save resolution"
msgstr "حفظ الحل"
+#: src/comments/ThreadCard.tsx
+msgid "Save this comment (Enter)"
+msgstr "حفظ هذا التعليق (Enter)"
+
#: src/components/settings/field-controls.tsx
#: src/components/settings/OkignoreSection.tsx
msgid "Saved"
diff --git a/packages/app/src/locales/bn/messages.json b/packages/app/src/locales/bn/messages.json
index 7ae606194..5cfed6e6b 100644
--- a/packages/app/src/locales/bn/messages.json
+++ b/packages/app/src/locales/bn/messages.json
@@ -259,6 +259,7 @@
"3V94ia": ["আপনার মন্তব্য পাঠানো যায়নি — ওয়ার্কস্পেস প্রস্তুত নয়।"],
"3VbwPp": [["keyName"], " ব্রাউজারে খুলুন"],
"3VsNTI": ["নথি লোড হচ্ছে"],
+ "3W5kYZ": ["এই মন্তব্যটি সংরক্ষণ করুন (Enter)"],
"3YWddZ": ["এই সংস্করণে বিষয়বস্তুর কোনো পরিবর্তন নেই"],
"3YvS-c": ["নতুন ট্যাব"],
"3_6U6f": ["GitHub-এর সঙ্গে যুক্ত করুন"],
diff --git a/packages/app/src/locales/bn/messages.po b/packages/app/src/locales/bn/messages.po
index 45be87caa..698ff98a4 100644
--- a/packages/app/src/locales/bn/messages.po
+++ b/packages/app/src/locales/bn/messages.po
@@ -2059,6 +2059,7 @@ msgid "Can't share this path."
msgstr "এই পাথ শেয়ার করা যাচ্ছে না।"
#: src/comments/PropertyCommentButton.tsx
+#: src/comments/ThreadCard.tsx
#: src/components/acp/ThreadHistoryMenu.tsx
#: src/components/ActivityPanelBurstRow.tsx
#: src/components/AuthModal.tsx
@@ -10154,6 +10155,7 @@ msgstr "নমুনা ছবি"
msgid "Sandboxed HTML embed — write HTML, see the rendered preview live."
msgstr "স্যান্ডবক্স করা HTML এমবেড — HTML লিখুন, রেন্ডার করা প্রাকদর্শন সঙ্গে সঙ্গে দেখুন।"
+#: src/comments/ThreadCard.tsx
#: src/components/AuthModal.tsx
#: src/components/FileTargetRenameDialog.tsx
#: src/components/settings/SearchSection.tsx
@@ -10180,6 +10182,10 @@ msgstr "সারিতে থাকা বার্তা সংরক্ষণ
msgid "Save resolution"
msgstr "মীমাংসা সংরক্ষণ করুন"
+#: src/comments/ThreadCard.tsx
+msgid "Save this comment (Enter)"
+msgstr "এই মন্তব্যটি সংরক্ষণ করুন (Enter)"
+
#: src/components/settings/field-controls.tsx
#: src/components/settings/OkignoreSection.tsx
msgid "Saved"
diff --git a/packages/app/src/locales/en/messages.json b/packages/app/src/locales/en/messages.json
index 59b1029c7..46c3f2c28 100644
--- a/packages/app/src/locales/en/messages.json
+++ b/packages/app/src/locales/en/messages.json
@@ -264,6 +264,7 @@
"3V94ia": ["Couldn't send your comments — the workspace isn't ready."],
"3VbwPp": ["Open ", ["keyName"], " in browser"],
"3VsNTI": ["Loading document"],
+ "3W5kYZ": ["Save this comment (Enter)"],
"3YWddZ": ["No content changes in this version"],
"3YvS-c": ["New tab"],
"3_6U6f": ["Connect to GitHub"],
diff --git a/packages/app/src/locales/en/messages.po b/packages/app/src/locales/en/messages.po
index 3c99ed7bc..37c68985e 100644
--- a/packages/app/src/locales/en/messages.po
+++ b/packages/app/src/locales/en/messages.po
@@ -2063,6 +2063,7 @@ msgid "Can't share this path."
msgstr "Can't share this path."
#: src/comments/PropertyCommentButton.tsx
+#: src/comments/ThreadCard.tsx
#: src/components/acp/ThreadHistoryMenu.tsx
#: src/components/ActivityPanelBurstRow.tsx
#: src/components/AuthModal.tsx
@@ -10158,6 +10159,7 @@ msgstr "Sample image"
msgid "Sandboxed HTML embed — write HTML, see the rendered preview live."
msgstr "Sandboxed HTML embed — write HTML, see the rendered preview live."
+#: src/comments/ThreadCard.tsx
#: src/components/AuthModal.tsx
#: src/components/FileTargetRenameDialog.tsx
#: src/components/settings/SearchSection.tsx
@@ -10184,6 +10186,10 @@ msgstr "Save queued message"
msgid "Save resolution"
msgstr "Save resolution"
+#: src/comments/ThreadCard.tsx
+msgid "Save this comment (Enter)"
+msgstr "Save this comment (Enter)"
+
#: src/components/settings/field-controls.tsx
#: src/components/settings/OkignoreSection.tsx
msgid "Saved"
diff --git a/packages/app/src/locales/es/messages.json b/packages/app/src/locales/es/messages.json
index 7ffb4ae71..a7b82524d 100644
--- a/packages/app/src/locales/es/messages.json
+++ b/packages/app/src/locales/es/messages.json
@@ -301,6 +301,7 @@
"3V94ia": ["No se pudieron enviar tus comentarios: el espacio de trabajo no está listo."],
"3VbwPp": ["Abrir ", ["keyName"], " en el navegador"],
"3VsNTI": ["Cargando el documento"],
+ "3W5kYZ": ["Guardar este comentario (Intro)"],
"3YWddZ": ["No hay cambios de contenido en esta versión"],
"3YvS-c": ["Pestaña nueva"],
"3_6U6f": ["Conectar con GitHub"],
diff --git a/packages/app/src/locales/es/messages.po b/packages/app/src/locales/es/messages.po
index 47f4dc400..2b3845cba 100644
--- a/packages/app/src/locales/es/messages.po
+++ b/packages/app/src/locales/es/messages.po
@@ -2063,6 +2063,7 @@ msgid "Can't share this path."
msgstr "No se puede compartir esta ruta."
#: src/comments/PropertyCommentButton.tsx
+#: src/comments/ThreadCard.tsx
#: src/components/acp/ThreadHistoryMenu.tsx
#: src/components/ActivityPanelBurstRow.tsx
#: src/components/AuthModal.tsx
@@ -10158,6 +10159,7 @@ msgstr "Imagen de ejemplo"
msgid "Sandboxed HTML embed — write HTML, see the rendered preview live."
msgstr "Incrustación de HTML aislada: escribe HTML y ve la vista previa renderizada en vivo."
+#: src/comments/ThreadCard.tsx
#: src/components/AuthModal.tsx
#: src/components/FileTargetRenameDialog.tsx
#: src/components/settings/SearchSection.tsx
@@ -10184,6 +10186,10 @@ msgstr "Guardar el mensaje en cola"
msgid "Save resolution"
msgstr "Guardar la resolución"
+#: src/comments/ThreadCard.tsx
+msgid "Save this comment (Enter)"
+msgstr "Guardar este comentario (Intro)"
+
#: src/components/settings/field-controls.tsx
#: src/components/settings/OkignoreSection.tsx
msgid "Saved"
diff --git a/packages/app/src/locales/fr/messages.json b/packages/app/src/locales/fr/messages.json
index 7e4bdf63f..5bc78f2cb 100644
--- a/packages/app/src/locales/fr/messages.json
+++ b/packages/app/src/locales/fr/messages.json
@@ -313,6 +313,7 @@
"3V94ia": ["Impossible d'envoyer vos commentaires — l'espace de travail n'est pas prêt."],
"3VbwPp": ["Ouvrir ", ["keyName"], " dans le navigateur"],
"3VsNTI": ["Chargement du document"],
+ "3W5kYZ": ["Enregistrer ce commentaire (Entrée)"],
"3YWddZ": ["Aucune modification de contenu dans cette version"],
"3YvS-c": ["Nouvel onglet"],
"3_6U6f": ["Se connecter à GitHub"],
diff --git a/packages/app/src/locales/fr/messages.po b/packages/app/src/locales/fr/messages.po
index 99c3d8843..63f8df6c0 100644
--- a/packages/app/src/locales/fr/messages.po
+++ b/packages/app/src/locales/fr/messages.po
@@ -2063,6 +2063,7 @@ msgid "Can't share this path."
msgstr "Impossible de partager ce chemin."
#: src/comments/PropertyCommentButton.tsx
+#: src/comments/ThreadCard.tsx
#: src/components/acp/ThreadHistoryMenu.tsx
#: src/components/ActivityPanelBurstRow.tsx
#: src/components/AuthModal.tsx
@@ -10158,6 +10159,7 @@ msgstr "Image d'exemple"
msgid "Sandboxed HTML embed — write HTML, see the rendered preview live."
msgstr "Intégration HTML en bac à sable — écrivez du HTML, voyez l'aperçu se rendre en direct."
+#: src/comments/ThreadCard.tsx
#: src/components/AuthModal.tsx
#: src/components/FileTargetRenameDialog.tsx
#: src/components/settings/SearchSection.tsx
@@ -10184,6 +10186,10 @@ msgstr "Enregistrer le message en file d'attente"
msgid "Save resolution"
msgstr "Enregistrer la résolution"
+#: src/comments/ThreadCard.tsx
+msgid "Save this comment (Enter)"
+msgstr "Enregistrer ce commentaire (Entrée)"
+
#: src/components/settings/field-controls.tsx
#: src/components/settings/OkignoreSection.tsx
msgid "Saved"
diff --git a/packages/app/src/locales/hi/messages.json b/packages/app/src/locales/hi/messages.json
index 1cde0801b..7ecf03acc 100644
--- a/packages/app/src/locales/hi/messages.json
+++ b/packages/app/src/locales/hi/messages.json
@@ -259,6 +259,7 @@
"3V94ia": ["आपकी टिप्पणियाँ नहीं भेजी जा सकीं — कार्यक्षेत्र तैयार नहीं है।"],
"3VbwPp": [["keyName"], " को ब्राउज़र में खोलें"],
"3VsNTI": ["दस्तावेज़ लोड हो रहा है"],
+ "3W5kYZ": ["यह टिप्पणी सहेजें (Enter)"],
"3YWddZ": ["इस संस्करण में सामग्री का कोई बदलाव नहीं"],
"3YvS-c": ["नया टैब"],
"3_6U6f": ["GitHub से जोड़ें"],
diff --git a/packages/app/src/locales/hi/messages.po b/packages/app/src/locales/hi/messages.po
index 6fd4f077c..4bdcbf798 100644
--- a/packages/app/src/locales/hi/messages.po
+++ b/packages/app/src/locales/hi/messages.po
@@ -2059,6 +2059,7 @@ msgid "Can't share this path."
msgstr "यह पथ साझा नहीं किया जा सकता।"
#: src/comments/PropertyCommentButton.tsx
+#: src/comments/ThreadCard.tsx
#: src/components/acp/ThreadHistoryMenu.tsx
#: src/components/ActivityPanelBurstRow.tsx
#: src/components/AuthModal.tsx
@@ -10154,6 +10155,7 @@ msgstr "नमूना छवि"
msgid "Sandboxed HTML embed — write HTML, see the rendered preview live."
msgstr "सैंडबॉक्स किया गया HTML एम्बेड — HTML लिखें, रेंडर किया गया पूर्वावलोकन तुरंत देखें।"
+#: src/comments/ThreadCard.tsx
#: src/components/AuthModal.tsx
#: src/components/FileTargetRenameDialog.tsx
#: src/components/settings/SearchSection.tsx
@@ -10180,6 +10182,10 @@ msgstr "कतार में लगा संदेश सहेजें"
msgid "Save resolution"
msgstr "समाधान सहेजें"
+#: src/comments/ThreadCard.tsx
+msgid "Save this comment (Enter)"
+msgstr "यह टिप्पणी सहेजें (Enter)"
+
#: src/components/settings/field-controls.tsx
#: src/components/settings/OkignoreSection.tsx
msgid "Saved"
diff --git a/packages/app/src/locales/id/messages.json b/packages/app/src/locales/id/messages.json
index 7da50056c..5365510d5 100644
--- a/packages/app/src/locales/id/messages.json
+++ b/packages/app/src/locales/id/messages.json
@@ -261,6 +261,7 @@
"3V94ia": ["Komentar Anda tidak bisa dikirim — ruang kerjanya belum siap."],
"3VbwPp": ["Buka ", ["keyName"], " di peramban"],
"3VsNTI": ["Memuat dokumen"],
+ "3W5kYZ": ["Simpan komentar ini (Enter)"],
"3YWddZ": ["Tidak ada perubahan isi pada versi ini"],
"3YvS-c": ["Tab baru"],
"3_6U6f": ["Hubungkan ke GitHub"],
diff --git a/packages/app/src/locales/id/messages.po b/packages/app/src/locales/id/messages.po
index 32568ee6f..cdb60bb13 100644
--- a/packages/app/src/locales/id/messages.po
+++ b/packages/app/src/locales/id/messages.po
@@ -2059,6 +2059,7 @@ msgid "Can't share this path."
msgstr "Tidak dapat membagikan jalur ini."
#: src/comments/PropertyCommentButton.tsx
+#: src/comments/ThreadCard.tsx
#: src/components/acp/ThreadHistoryMenu.tsx
#: src/components/ActivityPanelBurstRow.tsx
#: src/components/AuthModal.tsx
@@ -10154,6 +10155,7 @@ msgstr "Contoh gambar"
msgid "Sandboxed HTML embed — write HTML, see the rendered preview live."
msgstr "Sematan HTML tersekat — tulis HTML, lihat pratinjau terendernya secara langsung."
+#: src/comments/ThreadCard.tsx
#: src/components/AuthModal.tsx
#: src/components/FileTargetRenameDialog.tsx
#: src/components/settings/SearchSection.tsx
@@ -10180,6 +10182,10 @@ msgstr "Simpan pesan dalam antrean"
msgid "Save resolution"
msgstr "Simpan penyelesaian"
+#: src/comments/ThreadCard.tsx
+msgid "Save this comment (Enter)"
+msgstr "Simpan komentar ini (Enter)"
+
#: src/components/settings/field-controls.tsx
#: src/components/settings/OkignoreSection.tsx
msgid "Saved"
diff --git a/packages/app/src/locales/pseudo/messages.json b/packages/app/src/locales/pseudo/messages.json
index fdce5c31b..4917a2c37 100644
--- a/packages/app/src/locales/pseudo/messages.json
+++ b/packages/app/src/locales/pseudo/messages.json
@@ -264,6 +264,7 @@
"3V94ia": ["Ćōũĺďń'ţ śēńď ŷōũŕ ćōḿḿēńţś — ţĥē ŵōŕķśƥàćē ĩśń'ţ ŕēàďŷ."],
"3VbwPp": ["Ōƥēń ", ["keyName"], " ĩń ƀŕōŵśēŕ"],
"3VsNTI": ["Ĺōàďĩńĝ ďōćũḿēńţ"],
+ "3W5kYZ": ["Śàvē ţĥĩś ćōḿḿēńţ (Ēńţēŕ)"],
"3YWddZ": ["Ńō ćōńţēńţ ćĥàńĝēś ĩń ţĥĩś vēŕśĩōń"],
"3YvS-c": ["Ńēŵ ţàƀ"],
"3_6U6f": ["Ćōńńēćţ ţō ĜĩţĤũƀ"],
diff --git a/packages/app/src/locales/pseudo/messages.po b/packages/app/src/locales/pseudo/messages.po
index 54ab646cc..f05b9616c 100644
--- a/packages/app/src/locales/pseudo/messages.po
+++ b/packages/app/src/locales/pseudo/messages.po
@@ -2059,6 +2059,7 @@ msgid "Can't share this path."
msgstr ""
#: src/comments/PropertyCommentButton.tsx
+#: src/comments/ThreadCard.tsx
#: src/components/acp/ThreadHistoryMenu.tsx
#: src/components/ActivityPanelBurstRow.tsx
#: src/components/AuthModal.tsx
@@ -10154,6 +10155,7 @@ msgstr ""
msgid "Sandboxed HTML embed — write HTML, see the rendered preview live."
msgstr ""
+#: src/comments/ThreadCard.tsx
#: src/components/AuthModal.tsx
#: src/components/FileTargetRenameDialog.tsx
#: src/components/settings/SearchSection.tsx
@@ -10180,6 +10182,10 @@ msgstr ""
msgid "Save resolution"
msgstr ""
+#: src/comments/ThreadCard.tsx
+msgid "Save this comment (Enter)"
+msgstr ""
+
#: src/components/settings/field-controls.tsx
#: src/components/settings/OkignoreSection.tsx
msgid "Saved"
diff --git a/packages/app/src/locales/pt-BR/messages.json b/packages/app/src/locales/pt-BR/messages.json
index bf68d39de..7bcc997f5 100644
--- a/packages/app/src/locales/pt-BR/messages.json
+++ b/packages/app/src/locales/pt-BR/messages.json
@@ -297,6 +297,7 @@
"3V94ia": ["Não deu para enviar seus comentários — o espaço de trabalho não está pronto."],
"3VbwPp": ["Abrir ", ["keyName"], " no navegador"],
"3VsNTI": ["Carregando o documento"],
+ "3W5kYZ": ["Salvar este comentário (Enter)"],
"3YWddZ": ["Nenhuma alteração de conteúdo nesta versão"],
"3YvS-c": ["Nova aba"],
"3_6U6f": ["Conectar ao GitHub"],
diff --git a/packages/app/src/locales/pt-BR/messages.po b/packages/app/src/locales/pt-BR/messages.po
index 94749ef34..c62cb87d2 100644
--- a/packages/app/src/locales/pt-BR/messages.po
+++ b/packages/app/src/locales/pt-BR/messages.po
@@ -2059,6 +2059,7 @@ msgid "Can't share this path."
msgstr "Não é possível compartilhar este caminho."
#: src/comments/PropertyCommentButton.tsx
+#: src/comments/ThreadCard.tsx
#: src/components/acp/ThreadHistoryMenu.tsx
#: src/components/ActivityPanelBurstRow.tsx
#: src/components/AuthModal.tsx
@@ -10154,6 +10155,7 @@ msgstr "Imagem de exemplo"
msgid "Sandboxed HTML embed — write HTML, see the rendered preview live."
msgstr "HTML incorporado em modo isolado — escreva HTML e veja a pré-visualização renderizada ao vivo."
+#: src/comments/ThreadCard.tsx
#: src/components/AuthModal.tsx
#: src/components/FileTargetRenameDialog.tsx
#: src/components/settings/SearchSection.tsx
@@ -10180,6 +10182,10 @@ msgstr "Salvar a mensagem na fila"
msgid "Save resolution"
msgstr "Salvar a resolução"
+#: src/comments/ThreadCard.tsx
+msgid "Save this comment (Enter)"
+msgstr "Salvar este comentário (Enter)"
+
#: src/components/settings/field-controls.tsx
#: src/components/settings/OkignoreSection.tsx
msgid "Saved"
diff --git a/packages/app/src/locales/ur/messages.json b/packages/app/src/locales/ur/messages.json
index cdcb15b17..29847d84c 100644
--- a/packages/app/src/locales/ur/messages.json
+++ b/packages/app/src/locales/ur/messages.json
@@ -263,6 +263,7 @@
"3V94ia": ["آپ کے تبصرے نہیں بھیجے جا سکے — ورک اسپیس تیار نہیں ہے۔"],
"3VbwPp": [["keyName"], " براؤزر میں کھولیں"],
"3VsNTI": ["دستاویز لوڈ ہو رہی ہے"],
+ "3W5kYZ": ["یہ تبصرہ محفوظ کریں (Enter)"],
"3YWddZ": ["اس ورژن میں مواد کی کوئی تبدیلی نہیں"],
"3YvS-c": ["نیا ٹیب"],
"3_6U6f": ["GitHub سے منسلک ہوں"],
diff --git a/packages/app/src/locales/ur/messages.po b/packages/app/src/locales/ur/messages.po
index d670fe0dd..f405980f3 100644
--- a/packages/app/src/locales/ur/messages.po
+++ b/packages/app/src/locales/ur/messages.po
@@ -2063,6 +2063,7 @@ msgid "Can't share this path."
msgstr "یہ راستہ شیئر نہیں کیا جا سکتا۔"
#: src/comments/PropertyCommentButton.tsx
+#: src/comments/ThreadCard.tsx
#: src/components/acp/ThreadHistoryMenu.tsx
#: src/components/ActivityPanelBurstRow.tsx
#: src/components/AuthModal.tsx
@@ -10158,6 +10159,7 @@ msgstr "نمونہ تصویر"
msgid "Sandboxed HTML embed — write HTML, see the rendered preview live."
msgstr "سینڈ باکسڈ HTML ایمبیڈ — HTML لکھیں، رینڈر شدہ پیش منظر براہِ راست دیکھیں۔"
+#: src/comments/ThreadCard.tsx
#: src/components/AuthModal.tsx
#: src/components/FileTargetRenameDialog.tsx
#: src/components/settings/SearchSection.tsx
@@ -10184,6 +10186,10 @@ msgstr "قطار میں موجود پیغام محفوظ کریں"
msgid "Save resolution"
msgstr "حل محفوظ کریں"
+#: src/comments/ThreadCard.tsx
+msgid "Save this comment (Enter)"
+msgstr "یہ تبصرہ محفوظ کریں (Enter)"
+
#: src/components/settings/field-controls.tsx
#: src/components/settings/OkignoreSection.tsx
msgid "Saved"
diff --git a/packages/app/src/locales/zh-Hans/messages.json b/packages/app/src/locales/zh-Hans/messages.json
index 79f07eddb..5e260097f 100644
--- a/packages/app/src/locales/zh-Hans/messages.json
+++ b/packages/app/src/locales/zh-Hans/messages.json
@@ -238,6 +238,7 @@
"3V94ia": ["无法发送你的评论——工作区尚未就绪。"],
"3VbwPp": ["在浏览器中打开 ", ["keyName"]],
"3VsNTI": ["正在加载文档"],
+ "3W5kYZ": ["保存这条评论(Enter)"],
"3YWddZ": ["这个版本没有内容改动"],
"3YvS-c": ["新建标签页"],
"3_6U6f": ["连接到 GitHub"],
diff --git a/packages/app/src/locales/zh-Hans/messages.po b/packages/app/src/locales/zh-Hans/messages.po
index bd4a33cc0..dec5639c9 100644
--- a/packages/app/src/locales/zh-Hans/messages.po
+++ b/packages/app/src/locales/zh-Hans/messages.po
@@ -2063,6 +2063,7 @@ msgid "Can't share this path."
msgstr "无法共享此路径。"
#: src/comments/PropertyCommentButton.tsx
+#: src/comments/ThreadCard.tsx
#: src/components/acp/ThreadHistoryMenu.tsx
#: src/components/ActivityPanelBurstRow.tsx
#: src/components/AuthModal.tsx
@@ -10158,6 +10159,7 @@ msgstr "示例图片"
msgid "Sandboxed HTML embed — write HTML, see the rendered preview live."
msgstr "沙箱化的 HTML 嵌入——写下 HTML,实时查看渲染效果。"
+#: src/comments/ThreadCard.tsx
#: src/components/AuthModal.tsx
#: src/components/FileTargetRenameDialog.tsx
#: src/components/settings/SearchSection.tsx
@@ -10184,6 +10186,10 @@ msgstr "保存排队中的消息"
msgid "Save resolution"
msgstr "保存解决结果"
+#: src/comments/ThreadCard.tsx
+msgid "Save this comment (Enter)"
+msgstr "保存这条评论(Enter)"
+
#: src/components/settings/field-controls.tsx
#: src/components/settings/OkignoreSection.tsx
msgid "Saved"
diff --git a/packages/app/src/locales/zh-Hant/messages.json b/packages/app/src/locales/zh-Hant/messages.json
index 3134770d3..1f123476d 100644
--- a/packages/app/src/locales/zh-Hant/messages.json
+++ b/packages/app/src/locales/zh-Hant/messages.json
@@ -240,6 +240,7 @@
"3V94ia": ["無法傳送你的註解——工作區還沒準備好。"],
"3VbwPp": ["在瀏覽器中開啟 ", ["keyName"]],
"3VsNTI": ["正在載入文件"],
+ "3W5kYZ": ["儲存這則註解(Enter)"],
"3YWddZ": ["這個版本沒有內容變更"],
"3YvS-c": ["新增分頁"],
"3_6U6f": ["連接到 GitHub"],
diff --git a/packages/app/src/locales/zh-Hant/messages.po b/packages/app/src/locales/zh-Hant/messages.po
index 41afc16b2..5b11b475c 100644
--- a/packages/app/src/locales/zh-Hant/messages.po
+++ b/packages/app/src/locales/zh-Hant/messages.po
@@ -2063,6 +2063,7 @@ msgid "Can't share this path."
msgstr "無法分享這個路徑。"
#: src/comments/PropertyCommentButton.tsx
+#: src/comments/ThreadCard.tsx
#: src/components/acp/ThreadHistoryMenu.tsx
#: src/components/ActivityPanelBurstRow.tsx
#: src/components/AuthModal.tsx
@@ -10158,6 +10159,7 @@ msgstr "範例圖片"
msgid "Sandboxed HTML embed — write HTML, see the rendered preview live."
msgstr "沙箱化的 HTML 嵌入——寫下 HTML,即時看到顯示結果。"
+#: src/comments/ThreadCard.tsx
#: src/components/AuthModal.tsx
#: src/components/FileTargetRenameDialog.tsx
#: src/components/settings/SearchSection.tsx
@@ -10184,6 +10186,10 @@ msgstr "儲存排隊中的訊息"
msgid "Save resolution"
msgstr "儲存解決結果"
+#: src/comments/ThreadCard.tsx
+msgid "Save this comment (Enter)"
+msgstr "儲存這則註解(Enter)"
+
#: src/components/settings/field-controls.tsx
#: src/components/settings/OkignoreSection.tsx
msgid "Saved"
diff --git a/packages/desktop/tests/smoke/terminal-tabs.e2e.ts b/packages/desktop/tests/smoke/terminal-tabs.e2e.ts
index 7f7eae428..189aec6da 100644
--- a/packages/desktop/tests/smoke/terminal-tabs.e2e.ts
+++ b/packages/desktop/tests/smoke/terminal-tabs.e2e.ts
@@ -30,6 +30,7 @@ import type { ElectronApplication, Page } from '@playwright/test';
import { _electron as electron } from '@playwright/test';
import { desktopLaunchOptions, resolveDesktopTarget } from './_helpers/launch-desktop';
import { expect, test } from './_helpers/smoke-test';
+import { waitForShellReady } from './_helpers/terminal-ready';
const TARGET = resolveDesktopTarget();
@@ -149,8 +150,16 @@ async function openTerminal(app: ElectronApplication, page: Page): Promise<void>
{ timeout: 8_000 },
);
}).toPass({ timeout: 40_000, intervals: [2_000] });
+ await waitForShellReady(() => readActiveText(page));
}
+/**
+ * `running` means the PTY spawned, not that the shell behind it has reached its
+ * read loop — so the shell-ready wait is part of the contract here, not an
+ * optional extra. Without it, keystrokes typed while the shell is still sourcing
+ * profile scripts (macOS runners print the bash-to-zsh banner) are swallowed,
+ * and the caller times out on a marker whose command never ran.
+ */
async function waitActiveRunning(page: Page, timeoutMs = 25_000): Promise<void> {
await expect(visibleSection(page)).toBeVisible({ timeout: 15_000 });
await expect(visibleSection(page).locator('[data-terminal-status]')).toHaveAttribute(
@@ -158,6 +167,7 @@ async function waitActiveRunning(page: Page, timeoutMs = 25_000): Promise<void>
'running',
{ timeout: timeoutMs },
);
+ await waitForShellReady(() => readActiveText(page));
}
/** Open a second (or further) tab running a BARE shell via the New-chat carat →