Skip to content

Beautiful, AI-native markdown IDE and LLM wiki

Fix find scroll in the Markdown source editor (#2092)

Andrew Mikofalvyc6d0ca2c2a60
diff --git a/.changeset/source-find-scroll.md b/.changeset/source-find-scroll.md
new file mode 100644
index 000000000..85b667173
--- /dev/null
+++ b/.changeset/source-find-scroll.md
@@ -0,0 +1,5 @@
+---
+"@inkeep/open-knowledge-app": patch
+---
+
+Fix: in the Markdown source editor, Find (Cmd/Ctrl+F) now scrolls an off-screen match into view. Previously, searching for text below the fold selected the match but left the viewport unchanged, so the result stayed hidden. In full-page source mode the editor renders at content height and the page scroller is an ancestor element, where CodeMirror's default "scroll to match" (nearest) is a no-op; the source editor now forces a top-aligned scroll so found matches land just below the toolbar.
diff --git a/README.md b/README.md
index 20cd2e447..3a4d51e8c 100644
--- a/README.md
+++ b/README.md
@@ -1,6 +1,8 @@
-# OpenKnowledge
+# Open Knowledge
-OpenKnowledge is a markdown-powered document editor with integrations for Claude, Codex, and Cursor.
+Open Knowledge is a local-first knowledge base for teams that want docs, help-center content, SOPs, and agent-facing knowledge to live in one structured editing system.
+
+The project includes a desktop app, web app, server, CLI, shared core packages, and docs site. It uses Bun workspaces and Turbo for builds.
## Install
diff --git a/bun.lock b/bun.lock
index 892207a17..693905d70 100644
--- a/bun.lock
+++ b/bun.lock
@@ -70,6 +70,7 @@
"@codemirror/language": "^6.12.3",
"@codemirror/legacy-modes": "^6.5.1",
"@codemirror/merge": "^6.12.1",
+ "@codemirror/search": "^6.6.0",
"@codemirror/state": "^6.6.0",
"@codemirror/view": "^6.41.0",
"@dnd-kit/core": "^6.3.1",
diff --git a/packages/app/package.json b/packages/app/package.json
index 370feb6a9..688e9540b 100644
--- a/packages/app/package.json
+++ b/packages/app/package.json
@@ -24,7 +24,7 @@
"measure:fuzz": "bash scripts/measure-fuzz.sh",
"measure:stress": "bash scripts/measure-stress.sh",
"perf:compare": "bash scripts/perf-compare.sh",
- "test:e2e": "playwright test tests/stress/ux-interactions.e2e.ts tests/stress/file-tree-create.e2e.ts tests/stress/file-tree-drag-to-root.e2e.ts tests/stress/file-tree-deselect-to-root.e2e.ts tests/stress/file-tree-compact-folders.e2e.ts tests/stress/create-then-rename-editable.e2e.ts tests/stress/find-replace.e2e.ts tests/stress/editor-tabs.e2e.ts tests/stress/crdt-stress.e2e.ts tests/stress/slash-command.e2e.ts tests/stress/paste-fidelity.e2e.ts tests/stress/fr-7a-disconnect-source-mode.e2e.ts tests/stress/docs-open.e2e.ts tests/stress/frozen-table-headers.e2e.ts tests/stress/asset-embed.e2e.ts tests/stress/asset-embed-advanced.e2e.ts tests/stress/asset-click-dispatch.e2e.ts tests/stress/handoff.e2e.ts tests/stress/multi-agent-presence.e2e.ts tests/stress/editor-mode-persistence.e2e.ts tests/stress/sidebar-search-pill.e2e.ts tests/stress/command-palette-semantic.e2e.ts tests/stress/agent-activity-panel.e2e.ts tests/stress/drop-pipeline-auto-open.e2e.ts tests/stress/command-palette-flicker.e2e.ts tests/stress/cm6-list-hanging-indent.e2e.ts tests/stress/ng7-rapid-nav-coherence.e2e.ts tests/stress/reveal-on-activate.e2e.ts tests/stress/selection-indicator.e2e.ts tests/stress/new-file-cross-doc-bleed.e2e.ts tests/stress/editor-mode-flip-cross-doc-bleed.e2e.ts tests/stress/editor-area-viewport-resize.e2e.ts tests/stress/qa-sidebar-responsive.e2e.ts tests/stress/prd-6955-reassertion-repro.e2e.ts tests/stress/prd-6955-reassertion-wedge.e2e.ts tests/stress/prd-6914-repro.e2e.ts tests/stress/showall-lazy-tree.e2e.ts tests/stress/tabs-component-strip.e2e.ts",
+ "test:e2e": "playwright test tests/stress/ux-interactions.e2e.ts tests/stress/file-tree-create.e2e.ts tests/stress/file-tree-drag-to-root.e2e.ts tests/stress/file-tree-deselect-to-root.e2e.ts tests/stress/file-tree-compact-folders.e2e.ts tests/stress/create-then-rename-editable.e2e.ts tests/stress/find-replace.e2e.ts tests/stress/editor-tabs.e2e.ts tests/stress/crdt-stress.e2e.ts tests/stress/slash-command.e2e.ts tests/stress/paste-fidelity.e2e.ts tests/stress/fr-7a-disconnect-source-mode.e2e.ts tests/stress/docs-open.e2e.ts tests/stress/frozen-table-headers.e2e.ts tests/stress/asset-embed.e2e.ts tests/stress/asset-embed-advanced.e2e.ts tests/stress/asset-click-dispatch.e2e.ts tests/stress/handoff.e2e.ts tests/stress/multi-agent-presence.e2e.ts tests/stress/editor-mode-persistence.e2e.ts tests/stress/sidebar-search-pill.e2e.ts tests/stress/command-palette-semantic.e2e.ts tests/stress/agent-activity-panel.e2e.ts tests/stress/drop-pipeline-auto-open.e2e.ts tests/stress/command-palette-flicker.e2e.ts tests/stress/cm6-list-hanging-indent.e2e.ts tests/stress/ng7-rapid-nav-coherence.e2e.ts tests/stress/reveal-on-activate.e2e.ts tests/stress/selection-indicator.e2e.ts tests/stress/new-file-cross-doc-bleed.e2e.ts tests/stress/editor-mode-flip-cross-doc-bleed.e2e.ts tests/stress/editor-area-viewport-resize.e2e.ts tests/stress/qa-sidebar-responsive.e2e.ts tests/stress/prd-6955-reassertion-repro.e2e.ts tests/stress/prd-6955-reassertion-wedge.e2e.ts tests/stress/prd-6914-repro.e2e.ts tests/stress/showall-lazy-tree.e2e.ts tests/stress/tabs-component-strip.e2e.ts tests/stress/source-find-scroll.e2e.ts",
"test:e2e:install-browsers": "playwright install chromium webkit firefox",
"test:visual": "playwright test --config playwright.visual.config.ts",
"test:visual:update": "playwright test --config playwright.visual.config.ts --update-snapshots",
@@ -75,6 +75,7 @@
"@codemirror/language": "^6.12.3",
"@codemirror/legacy-modes": "^6.5.1",
"@codemirror/merge": "^6.12.1",
+ "@codemirror/search": "^6.6.0",
"@codemirror/state": "^6.6.0",
"@codemirror/view": "^6.41.0",
"@dnd-kit/core": "^6.3.1",
diff --git a/packages/app/src/editor/SourceEditor.tsx b/packages/app/src/editor/SourceEditor.tsx
index 9ec6743d6..4d9a548ce 100644
--- a/packages/app/src/editor/SourceEditor.tsx
+++ b/packages/app/src/editor/SourceEditor.tsx
@@ -1,4 +1,5 @@
import { indentWithTab } from '@codemirror/commands';
+import { search } from '@codemirror/search';
import { Compartment, EditorSelection, EditorState } from '@codemirror/state';
import { placeholder as cmPlaceholder, EditorView, keymap } from '@codemirror/view';
import type { HocuspocusProvider } from '@hocuspocus/provider';
@@ -141,6 +142,9 @@ export function SourceEditor({
doc: ytext.toString(),
extensions: [
basicSetup,
+ search({
+ scrollToMatch: (range) => EditorView.scrollIntoView(range, { y: 'start' }),
+ }),
keymap.of([indentWithTab]),
yCollab(ytext, provider.awareness),
...createNestedCMExtensions({
diff --git a/packages/app/tests/stress/source-find-scroll.e2e.ts b/packages/app/tests/stress/source-find-scroll.e2e.ts
new file mode 100644
index 000000000..26cc8770c
--- /dev/null
+++ b/packages/app/tests/stress/source-find-scroll.e2e.ts
@@ -0,0 +1,83 @@
+import { randomUUID } from 'node:crypto';
+import type { Page } from '@playwright/test';
+import { expect, test, waitForActiveProviderSynced } from './_helpers';
+
+const TOOLBAR_OVERLAP_PX = 56;
+
+function uniqueDocName(label: string): string {
+ return `test-source-find-${label}-${randomUUID().slice(0, 8)}`;
+}
+
+const sourceToggle = (page: Page) => page.getByRole('radio', { name: 'Markdown source' });
+
+function visibleScrollContainer(page: Page) {
+ return page.locator('[data-testid="editor-scroll-container"]:visible');
+}
+
+async function selectedSearchMatchInScrollport(page: Page): Promise<boolean> {
+ return page.evaluate((toolbar) => {
+ const scrollContainer = Array.from(
+ document.querySelectorAll('[data-testid="editor-scroll-container"]'),
+ ).find(
+ (element): element is HTMLElement =>
+ element instanceof HTMLElement && element.getClientRects().length > 0,
+ );
+ const match = scrollContainer?.querySelector('.cm-searchMatch-selected');
+ if (!scrollContainer || !(match instanceof HTMLElement)) return false;
+ const scrollRect = scrollContainer.getBoundingClientRect();
+ const matchRect = match.getBoundingClientRect();
+ return (
+ matchRect.top >= scrollRect.top + toolbar - 2 && matchRect.bottom <= scrollRect.bottom + 2
+ );
+ }, TOOLBAR_OVERLAP_PX);
+}
+
+test('source-mode find scrolls an off-screen match into view', async ({ page, api }) => {
+ const docName = uniqueDocName('scroll');
+ const filler = Array.from(
+ { length: 120 },
+ (_, index) => `Filler line ${index + 1} with enough plain text to create real scroll distance.`,
+ ).join('\n\n');
+ const marker = 'zqxmarkerzqx';
+
+ await api.seedDocs([
+ {
+ name: docName,
+ markdown: `# Source Find Scroll\n\n${filler}\n\nThe ${marker} token lives near the bottom.`,
+ },
+ ]);
+
+ await page.goto(`/#/${docName}`);
+ await waitForActiveProviderSynced(page);
+ await expect(page.locator('.ProseMirror')).toContainText('Source Find Scroll');
+
+ await sourceToggle(page).click();
+ await page.waitForSelector('.cm-content');
+
+ const scrollContainer = visibleScrollContainer(page);
+ await expect(scrollContainer).toHaveCount(1);
+ await scrollContainer.evaluate((element) => {
+ if (element instanceof HTMLElement) element.scrollTop = 0;
+ });
+ const scrollTopBefore = await scrollContainer.evaluate((element) =>
+ element instanceof HTMLElement ? element.scrollTop : -1,
+ );
+ expect(scrollTopBefore).toBe(0);
+
+ await page.locator('.cm-content').click();
+ await page.keyboard.press('ControlOrMeta+f');
+ const searchField = page.locator('.cm-search input[name="search"]');
+ await expect(searchField).toBeVisible();
+ await searchField.click();
+ await searchField.pressSequentially(marker, { delay: 15 });
+ await searchField.press('Enter');
+
+ await expect
+ .poll(() =>
+ scrollContainer.evaluate((element) =>
+ element instanceof HTMLElement ? element.scrollTop : 0,
+ ),
+ )
+ .toBeGreaterThan(0);
+ await expect.poll(() => selectedSearchMatchInScrollport(page)).toBe(true);
+});