Beautiful, AI-native markdown IDE and LLM wiki
TypeScript 2nd-brainagent-skillsclaudecodexcompany-braindocsknowledge-knowledge-baseknowledge-managementllmllm-wikillm-wiki-karpathymarkdownmarkdown-editormdmdxnotespkmsecond-brainskills
fix(open-knowledge): resolve doc-relative src in inline image node-view (#1622)
Andrew Mikofalvyceef7e8e3ec7
diff --git a/.changeset/inline-image-doc-relative-src.md b/.changeset/inline-image-doc-relative-src.mdnew file mode 100644index 000000000..c0f281822--- /dev/null+++ b/.changeset/inline-image-doc-relative-src.md@@ -0,0 +1,5 @@+---+"@inkeep/open-knowledge-app": patch+---++Fix inline markdown images with a doc-relative path (`` mid-prose) resolving against the SPA root instead of the document's folder. The inline image node-view now applies the same doc-folder base resolution the block image render path already uses, so a relative `src` no longer 404s until a hard reload.diff --git a/packages/app/src/editor/extensions/ImageInlineZoomView.dom.test.tsx b/packages/app/src/editor/extensions/ImageInlineZoomView.dom.test.tsxindex fb08db602..49f5edaef 100644--- a/packages/app/src/editor/extensions/ImageInlineZoomView.dom.test.tsx+++ b/packages/app/src/editor/extensions/ImageInlineZoomView.dom.test.tsx@@ -25,10 +25,18 @@ mock.module('react-medium-image-zoom', () => ({}));const { ImageInlineZoomView } = await import('./ImageInlineZoomView');+const { setEditorDocName } = await import('./doc-context.ts');-function makeNode(attrs: { src?: string; alt?: string; title?: string }) {+function makeNode(attrs: { src?: string; alt?: string; title?: string }, editor?: object) {// biome-ignore lint/suspicious/noExplicitAny: test stub- return { node: { attrs } } as any;+ return { node: { attrs }, editor } as any;+}++function makeEditorWithDocName(docName: string): object {+ const editor = {};+ // biome-ignore lint/suspicious/noExplicitAny: WeakMap key only — the view never calls editor methods+ setEditorDocName(editor as any, docName);+ return editor;}describe('ImageInlineZoomView — inline-image lightbox wrap', () => {@@ -81,4 +89,33 @@ describe('ImageInlineZoomView — inline-image lightbox wrap', () => {const img = document.querySelector('img');expect(img?.getAttribute('src')).toContain('/assets/pic.png');});++ test('resolves a `./`-relative inline src against the document folder, not the SPA root', () => {+ const editor = makeEditorWithDocName('fishing-log/2026-05-16-wind-river-springer');+ render(+ <ImageInlineZoomView {...makeNode({ src: './assets/cat.jpg', alt: 'A cat' }, editor)} />,+ );+ const img = document.querySelector('img');+ expect(img?.getAttribute('src')).toBe('/fishing-log/assets/cat.jpg');+ });++ test('resolves a `../`-relative inline src against the document folder', () => {+ const editor = makeEditorWithDocName('fishing-log/2026/spring/log');+ render(<ImageInlineZoomView {...makeNode({ src: '../../assets/cat.jpg' }, editor)} />);+ const img = document.querySelector('img');+ expect(img?.getAttribute('src')).toBe('/fishing-log/assets/cat.jpg');+ });++ test('leaves a server-absolute src untouched even with a docName (idempotent)', () => {+ const editor = makeEditorWithDocName('fishing-log/2026-05-16-wind-river-springer');+ render(<ImageInlineZoomView {...makeNode({ src: '/fishing-log/assets/cat.jpg' }, editor)} />);+ const img = document.querySelector('img');+ expect(img?.getAttribute('src')).toBe('/fishing-log/assets/cat.jpg');+ });++ test('falls back to the raw src when no docName is registered (no base to resolve against)', () => {+ render(<ImageInlineZoomView {...makeNode({ src: './assets/cat.jpg' })} />);+ const img = document.querySelector('img');+ expect(img?.getAttribute('src')).toBe('./assets/cat.jpg');+ });});diff --git a/packages/app/src/editor/extensions/ImageInlineZoomView.tsx b/packages/app/src/editor/extensions/ImageInlineZoomView.tsxindex b7d1658fa..bf006ad6b 100644--- a/packages/app/src/editor/extensions/ImageInlineZoomView.tsx+++ b/packages/app/src/editor/extensions/ImageInlineZoomView.tsx@@ -1,13 +1,18 @@-import { toDesktopAssetHref } from '@inkeep/open-knowledge-core';+import { normalizeDocRelativeAssetUrl, toDesktopAssetHref } from '@inkeep/open-knowledge-core';import type { NodeViewProps } from '@tiptap/core';import { NodeViewWrapper } from '@tiptap/react';import Zoom from 'react-medium-image-zoom';+import { getEditorDocName } from './doc-context.ts';-export function ImageInlineZoomView({ node }: NodeViewProps) {+export function ImageInlineZoomView({ node, editor }: NodeViewProps) {const rawSrc = node.attrs.src;const rawAlt = node.attrs.alt;const rawTitle = node.attrs.title;- const src = typeof rawSrc === 'string' ? toDesktopAssetHref(rawSrc) : undefined;+ const sourceDocName = editor ? (getEditorDocName(editor) ?? undefined) : undefined;+ const src =+ typeof rawSrc === 'string'+ ? toDesktopAssetHref(normalizeDocRelativeAssetUrl(rawSrc, sourceDocName))+ : undefined;const alt = typeof rawAlt === 'string' ? rawAlt : '';const title = typeof rawTitle === 'string' ? rawTitle : undefined;return (