Skip to content

Beautiful, AI-native markdown IDE and LLM wiki

Read OK changeset bumps with Changesets in the version scripts (#5291)

Nick Gomezcfd66f150f0f
diff --git a/.github/scripts/bug-lane.mjs b/.github/scripts/bug-lane.mjs
index 4e025a25a..4317216c8 100644
--- a/.github/scripts/bug-lane.mjs
+++ b/.github/scripts/bug-lane.mjs
@@ -153,11 +153,7 @@ export function makeIsInStable(stable, git = (args) => spawnSync('git', args, {
}
function realPendingChangesets() {
- const ids = runGit(['ls-tree', '--name-only', 'HEAD', '.changeset/'])
- .split('\n')
- .map((s) => s.trim())
- .filter((p) => p.endsWith('.md') && !p.endsWith('README.md'))
- .map((p) => p.replace(/^\.changeset\//, '').replace(/\.md$/, ''));
+ const ids = realGit.changesetIds('HEAD');
const entries = [];
for (const id of ids) {
diff --git a/.github/scripts/release-cascade-shape.test.mjs b/.github/scripts/release-cascade-shape.test.mjs
index db57d8e09..adbcb39a8 100644
--- a/.github/scripts/release-cascade-shape.test.mjs
+++ b/.github/scripts/release-cascade-shape.test.mjs
@@ -1,10 +1,10 @@
// biome-ignore-all lint/suspicious/noTemplateCurlyInString: shell and GitHub expression fixtures must remain literal.
import { execFileSync } from 'node:child_process';
import { createHash } from 'node:crypto';
-import { existsSync, mkdtempSync, readFileSync, rmSync, writeFileSync } from 'node:fs';
+import { existsSync, mkdtempSync, readdirSync, readFileSync, rmSync, writeFileSync } from 'node:fs';
import { createRequire } from 'node:module';
import { tmpdir } from 'node:os';
-import { dirname, join } from 'node:path';
+import { dirname, join, resolve } from 'node:path';
import { fileURLToPath } from 'node:url';
import { afterAll, describe, expect, test } from 'vitest';
import { parse } from 'yaml';
@@ -1211,6 +1211,48 @@ describe('the macOS artifact is attested signed before it can ship', () => {
});
});
+describe('every job that reads changesets installs the Changesets reader first', () => {
+ const OK_ROOT = join(WORKFLOWS, '..', '..');
+ const READER = join(OK_ROOT, 'scripts', 'compute-next-beta.mjs');
+ const importsReader = (file, seen = new Set()) => {
+ if (file === READER) return true;
+ if (seen.has(file) || !existsSync(file)) return false;
+ seen.add(file);
+ return [...readFileSync(file, 'utf8').matchAll(/\bfrom\s+['"](\.{1,2}\/[^'"]+)['"]/g)].some(([, spec]) =>
+ importsReader(resolve(dirname(file), spec), seen),
+ );
+ };
+ const readsChangesets = (step) =>
+ [...(step.run ?? '').matchAll(/[\w./-]+\.mjs\b/g)].some(([path]) => importsReader(resolve(OK_ROOT, path)));
+ const readerJobs = readdirSync(WORKFLOWS)
+ .filter((file) => file.endsWith('.yml'))
+ .flatMap((file) =>
+ Object.entries(parse(read(file)).jobs ?? {}).flatMap(([id, { steps = [] }]) => {
+ const readAt = steps.findIndex(readsChangesets);
+ return readAt === -1 ? [] : [{ job: `${file}#${id}`, before: steps.slice(0, readAt) }];
+ }),
+ );
+
+ test('the sweep finds every job that runs a version script', () => {
+ expect(readerJobs.map(({ job }) => job)).toEqual(
+ expect.arrayContaining([
+ 'bug-lane.yml#bug-lane',
+ 'point-release.yml#point-release',
+ 'promote-stable.yml#promote',
+ 'release.yml#release',
+ 'select-beta-to-promote.yml#evaluate',
+ ]),
+ );
+ });
+
+ test('each one runs pnpm install before its first read', () => {
+ const uninstalled = readerJobs
+ .filter(({ before }) => !before.some((step) => /\bpnpm install\b/.test(step.run ?? '')))
+ .map(({ job }) => job);
+ expect(uninstalled).toEqual([]);
+ });
+});
+
describe('Linux packaging ships the native prebuilds and checks them before upload', () => {
const NATIVE_GUARD =
'pnpm exec vitest run tests/unit/linux-package-native-guards.test.ts tests/unit/linux-package-terminal-spawn.test.ts';
diff --git a/.github/workflows/bug-lane.yml b/.github/workflows/bug-lane.yml
index 6077a4eb5..de40166a9 100644
--- a/.github/workflows/bug-lane.yml
+++ b/.github/workflows/bug-lane.yml
@@ -83,12 +83,19 @@ jobs:
with:
fetch-depth: 0
fetch-tags: true
+ persist-credentials: false
- name: Set up Node
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
with:
node-version: "24"
+ - name: Install root dependencies for the Changesets reader
+ run: |
+ set -euo pipefail
+ corepack enable
+ pnpm install --frozen-lockfile --filter=. --ignore-scripts
+
- name: Evaluate qualifying fixes
id: evaluate
env:
diff --git a/.github/workflows/point-release.yml b/.github/workflows/point-release.yml
index 28fb48dab..95eb7e37a 100644
--- a/.github/workflows/point-release.yml
+++ b/.github/workflows/point-release.yml
@@ -145,6 +145,12 @@ jobs:
with:
node-version: "24"
+ - name: Install root dependencies for the Changesets reader
+ run: |
+ set -euo pipefail
+ corepack enable
+ pnpm install --frozen-lockfile --filter=. --ignore-scripts
+
- name: Prepare git for the synthetic commit
run: |
set -euo pipefail
diff --git a/.github/workflows/promote-stable.yml b/.github/workflows/promote-stable.yml
index 13f1a09c4..60707b3cd 100644
--- a/.github/workflows/promote-stable.yml
+++ b/.github/workflows/promote-stable.yml
@@ -225,6 +225,17 @@ jobs:
fi
echo "Tag ${BETA_TAG} resolves to $(git rev-parse "refs/tags/${BETA_TAG}")"
+ - name: Set up Node
+ uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
+ with:
+ node-version: "24"
+
+ - name: Install root dependencies for the Changesets reader
+ run: |
+ set -euo pipefail
+ corepack enable
+ pnpm install --frozen-lockfile --filter=. --ignore-scripts
+
- name: Compute stable version from beta tag
id: ver
env:
diff --git a/.github/workflows/select-beta-to-promote.yml b/.github/workflows/select-beta-to-promote.yml
index 5d002c717..58d58738d 100644
--- a/.github/workflows/select-beta-to-promote.yml
+++ b/.github/workflows/select-beta-to-promote.yml
@@ -216,6 +216,12 @@ jobs:
with:
node-version: "24"
+ - name: Install root dependencies for the Changesets reader
+ run: |
+ set -euo pipefail
+ corepack enable
+ pnpm install --frozen-lockfile --filter=. --ignore-scripts
+
- name: Select the beta to promote
id: select
env:
diff --git a/scripts/check-no-major-changeset.mjs b/scripts/check-no-major-changeset.mjs
index f1f45ff69..957569081 100644
--- a/scripts/check-no-major-changeset.mjs
+++ b/scripts/check-no-major-changeset.mjs
@@ -1,25 +1,12 @@
-import { existsSync, lstatSync, readdirSync, readFileSync, statSync } from 'node:fs';
-import { createRequire } from 'node:module';
-import { join, sep } from 'node:path';
+import { existsSync, lstatSync, readdirSync, readFileSync } from 'node:fs';
+import { join } from 'node:path';
import { fileURLToPath } from 'node:url';
-import { parseFrontmatterBumpType, pendingChangesetFiles } from './compute-next-beta.mjs';
-import { changesetIdsFromTreePaths } from './compute-stable-version.mjs';
+import { loadChangesets } from './compute-next-beta.mjs';
const PASS = "No 'major' bumps in changesets.";
const root = fileURLToPath(new URL('..', import.meta.url));
const changesetDir = join(root, '.changeset');
-function loadChangesets() {
- const cliRequire = createRequire(
- createRequire(join(root, 'package.json')).resolve('@changesets/cli/package.json'),
- );
- const readerRequire = createRequire(cliRequire.resolve('@changesets/read'));
- return {
- read: cliRequire('@changesets/read').default,
- parse: readerRequire('@changesets/parse').default,
- };
-}
-
function parseRejection(parse, file) {
try {
parse(readFileSync(join(changesetDir, file), 'utf8'));
@@ -56,16 +43,6 @@ function changesetsEntryPath(id) {
: `.changeset/${id}.md`;
}
-function versionReaderPaths() {
- const tree = readdirSync(changesetDir, { recursive: true })
- .map((entry) => `.changeset/${entry.split(sep).join('/')}`)
- .filter((path) => !statSync(join(root, path)).isDirectory());
- return [
- ...pendingChangesetFiles(changesetDir).map((file) => `.changeset/${file}`),
- ...changesetIdsFromTreePaths(tree).map((id) => `.changeset/${id}.md`),
- ];
-}
-
export async function main() {
if (!existsSync(changesetDir)) {
console.log(PASS);
@@ -73,7 +50,7 @@ export async function main() {
}
let changesets;
try {
- changesets = loadChangesets();
+ changesets = loadChangesets(root);
} catch (error) {
return refuse(`Changesets could not be loaded from ${root}`, error);
}
@@ -94,29 +71,16 @@ export async function main() {
if (readRejections.length > 0) {
return refuse('Changesets could not read .changeset', readRejections[0]);
}
- let violations;
- try {
- violations = new Set([
- ...entries
- .filter(({ releases }) => releases.some(({ type }) => type === 'major'))
- .map(({ id }) => changesetsEntryPath(id)),
- ...versionReaderPaths().filter(
- (path) => parseFrontmatterBumpType(readFileSync(join(root, path), 'utf8')) === 'major',
- ),
- ]);
- } catch (error) {
- return refuse('the release version readers could not read .changeset', error);
- }
- if (violations.size > 0) {
+ const violations = entries
+ .filter(({ releases }) => releases.some(({ type }) => type === 'major'))
+ .map(({ id }) => changesetsEntryPath(id));
+ if (violations.length > 0) {
console.error(
- `::error::Forbidden 'major' bump in changeset(s): ${[...violations].sort().join(' ')}`,
+ `::error::Forbidden 'major' bump in changeset(s): ${violations.sort().join(' ')}`,
);
console.error(
"Open Knowledge is pre-1.0 — declare 'minor' for breaking changes, 'patch' for fixes.",
);
- console.error(
- "The release version scripts read the frontmatter as raw text and count 'major' wherever it ends a line after ':' and optional whitespace, YAML comments included.",
- );
console.error(
'See .changeset/README.md. 1.0.0 is a deliberate team decision, not a single changeset.',
);
diff --git a/scripts/compute-next-beta.mjs b/scripts/compute-next-beta.mjs
index 8e5931b50..898cf5b50 100644
--- a/scripts/compute-next-beta.mjs
+++ b/scripts/compute-next-beta.mjs
@@ -1,14 +1,17 @@
#!/usr/bin/env node
import { spawnSync } from 'node:child_process';
-import { existsSync, readFileSync, readdirSync, writeFileSync } from 'node:fs';
+import { existsSync, readFileSync, writeFileSync } from 'node:fs';
+import { createRequire } from 'node:module';
+import { join } from 'node:path';
+import { fileURLToPath } from 'node:url';
export const FIXED_GROUP_ANCHOR = '@inkeep/open-knowledge';
const PRE_PATH = '.changeset/pre.json';
-const CHANGESET_DIR = '.changeset';
const PUBLIC_REPO = process.env.GITHUB_REPOSITORY || 'inkeep/open-knowledge';
const CHANGELOG_PKGS = ['cli', 'core', 'server', 'app', 'desktop'];
const CONSUMED_MARKER_RE = /<!--\s*ok-consumed-set:\s*(\[[^\]]*\])\s*-->/;
const BUMP_RANK = { patch: 1, minor: 2, major: 3 };
+const OK_ROOT = fileURLToPath(new URL('..', import.meta.url));
function log(...args) {
process.stderr.write(`${args.join(' ')}\n`);
@@ -36,22 +39,25 @@ export function computeBaseVersion(anchor, bumpTypes) {
return bumpSemver(anchor, maxBumpType(bumpTypes));
}
-export function parseFrontmatterBumpType(content) {
- const fmMatch = /^---\r?\n([\s\S]*?)\r?\n---\r?\n/.exec(content);
- if (!fmMatch) return null;
+export function loadChangesets(root = OK_ROOT) {
+ const cliRequire = createRequire(
+ createRequire(join(root, 'package.json')).resolve('@changesets/cli/package.json'),
+ );
+ const readerRequire = createRequire(cliRequire.resolve('@changesets/read'));
+ return {
+ read: cliRequire('@changesets/read').default,
+ parse: readerRequire('@changesets/parse').default,
+ };
+}
+
+export function maxReleaseType(releases) {
let maxType = null;
- for (const m of fmMatch[1].matchAll(/:\s*(patch|minor|major)\s*$/gm)) {
- if (!maxType || BUMP_RANK[m[1]] > BUMP_RANK[maxType]) maxType = m[1];
+ for (const { type } of releases) {
+ if (BUMP_RANK[type] && (!maxType || BUMP_RANK[type] > BUMP_RANK[maxType])) maxType = type;
}
return maxType;
}
-export function pendingChangesetFiles(dir) {
- return readdirSync(dir)
- .filter((f) => f.endsWith('.md') && f !== 'README.md')
- .sort();
-}
-
function findPrevBetaTag() {
const res = spawnSync(
'gh',
@@ -218,7 +224,7 @@ export function renderNotes({ packageDeltas, newConsumedSet, prevBetaTag, newCou
return lines.join('\n');
}
-function main() {
+async function main() {
const pre = JSON.parse(readFileSync(PRE_PATH, 'utf8'));
if (pre.mode !== 'pre') {
throw new Error(`Expected pre.json mode=pre, got mode=${pre.mode}`);
@@ -228,12 +234,12 @@ function main() {
throw new Error(`No initialVersion for ${FIXED_GROUP_ANCHOR} in pre.json`);
}
- const changesetFiles = pendingChangesetFiles(CHANGESET_DIR);
- if (changesetFiles.length === 0) {
+ const changesets = await loadChangesets().read(process.cwd());
+ if (changesets.length === 0) {
console.log(JSON.stringify({ skip: true, reason: 'no pending changesets' }));
return;
}
- const allIds = changesetFiles.map((f) => f.replace(/\.md$/, ''));
+ const allIds = changesets.map(({ id }) => id);
const allIdsSet = new Set(allIds);
const prevBetaTag = findPrevBetaTag();
@@ -255,9 +261,7 @@ function main() {
return;
}
- const cycleBumpTypes = allIds.map((id) =>
- parseFrontmatterBumpType(readFileSync(`${CHANGESET_DIR}/${id}.md`, 'utf8')),
- );
+ const cycleBumpTypes = changesets.map(({ releases }) => maxReleaseType(releases));
const cycleMaxBump = maxBumpType(cycleBumpTypes);
const baseVersion = bumpSemver(anchor, cycleMaxBump);
@@ -303,5 +307,5 @@ function main() {
}
if (import.meta.url === `file://${process.argv[1]}`) {
- main();
+ await main();
}
diff --git a/scripts/compute-next-beta.test.mjs b/scripts/compute-next-beta.test.mjs
index f9ffd967e..9da68215f 100644
--- a/scripts/compute-next-beta.test.mjs
+++ b/scripts/compute-next-beta.test.mjs
@@ -4,7 +4,7 @@ import {
computeBaseVersion,
extractDeltaSection,
maxBumpType,
- parseFrontmatterBumpType,
+ maxReleaseType,
parseSection,
renderNotes,
} from './compute-next-beta.mjs';
@@ -424,22 +424,30 @@ describe('computeBaseVersion — normative cadence vectors', () => {
});
});
-describe('parseFrontmatterBumpType', () => {
- test('returns the max bump declared across the frontmatter block', () => {
- const cs = `---\n"@inkeep/open-knowledge": minor\n"@inkeep/open-knowledge-app": patch\n---\n\nbody`;
- expect(parseFrontmatterBumpType(cs)).toBe('minor');
+describe('maxReleaseType', () => {
+ test('returns the max bump across the releases Changesets read from one changeset', () => {
+ const releases = [
+ { name: '@inkeep/open-knowledge', type: 'minor' },
+ { name: '@inkeep/open-knowledge-app', type: 'patch' },
+ ];
+ expect(maxReleaseType(releases)).toBe('minor');
});
- test('returns major when a changeset declares a major bump', () => {
- const cs = `---\n"@inkeep/open-knowledge": major\n---\n\nbody`;
- expect(parseFrontmatterBumpType(cs)).toBe('major');
+ test('returns major when any release is major', () => {
+ expect(maxReleaseType([{ name: '@inkeep/open-knowledge', type: 'major' }])).toBe('major');
});
- test('returns null when there is no frontmatter', () => {
- expect(parseFrontmatterBumpType('no frontmatter here')).toBeNull();
+ test('returns null for a changeset that declares no release', () => {
+ expect(maxReleaseType([])).toBeNull();
});
- test('returns null for an empty changeset, which declares no bump for any package', () => {
- expect(parseFrontmatterBumpType('---\n---\n\nNo release.\n')).toBeNull();
+ test('ignores a none release, which bumps nothing', () => {
+ expect(maxReleaseType([{ name: '@inkeep/open-knowledge', type: 'none' }])).toBeNull();
+ expect(
+ maxReleaseType([
+ { name: '@inkeep/open-knowledge', type: 'none' },
+ { name: '@inkeep/open-knowledge-app', type: 'patch' },
+ ]),
+ ).toBe('patch');
});
});
diff --git a/scripts/compute-stable-version.mjs b/scripts/compute-stable-version.mjs
index 1150f8a47..41688aa97 100644
--- a/scripts/compute-stable-version.mjs
+++ b/scripts/compute-stable-version.mjs
@@ -3,7 +3,7 @@ import { spawnSync } from 'node:child_process';
import { appendFileSync, readFileSync } from 'node:fs';
import { pathToFileURL } from 'node:url';
import { gitCleanEnv } from './git-clean-env.mjs';
-import { FIXED_GROUP_ANCHOR, bumpSemver, maxBumpType, parseFrontmatterBumpType } from './compute-next-beta.mjs';
+import { FIXED_GROUP_ANCHOR, bumpSemver, loadChangesets, maxBumpType, maxReleaseType } from './compute-next-beta.mjs';
const BETA_TAG_RE = /^v\d+\.\d+\.\d+-beta\.\d+$/;
const STABLE_TAG_RE = /^v\d+\.\d+\.\d+$/;
@@ -154,8 +154,8 @@ function compareVersions(a, b) {
return 0;
}
-export function runGit(args) {
- const res = spawnSync('git', args, { encoding: 'utf8', env: gitCleanEnv() });
+export function runGit(args, cwd) {
+ const res = spawnSync('git', args, { cwd, encoding: 'utf8', env: gitCleanEnv() });
if (res.status !== 0) {
throw new Error(`git ${args.join(' ')} failed (exit ${res.status}): ${String(res.stderr || '').trim()}`);
}
@@ -164,34 +164,41 @@ export function runGit(args) {
export function changesetIdsFromTreePaths(paths) {
const ids = [];
- for (const line of paths) {
- const m = /^\.changeset\/(.+)\.md$/.exec(line.trim());
- if (m && m[1] !== 'README') ids.push(m[1]);
+ for (const path of paths) {
+ const file = path.trim().replace(/^\.changeset\//, '');
+ if (!file.startsWith('.') && file.endsWith('.md') && !/^README\.md$/i.test(file)) {
+ ids.push(file.replace('.md', ''));
+ }
}
return ids;
}
-export const realGit = {
- revParse: (ref) => runGit(['rev-parse', '--verify', `${ref}^{commit}`]).trim(),
- newestStableTag: () => {
- for (const line of runGit(['tag', '--list', 'v*', '--sort=-version:refname']).split('\n')) {
- const t = line.trim();
- if (STABLE_TAG_RE.test(t)) return t;
- }
- return '';
- },
- changesetIds: (sha) =>
- changesetIdsFromTreePaths(runGit(['ls-tree', '-r', '--name-only', sha, '--', '.changeset']).split('\n')),
- isAncestor: (a, b) => {
- const res = spawnSync('git', ['merge-base', '--is-ancestor', a, b], { encoding: 'utf8', env: gitCleanEnv() });
- if (res.status === 0) return true;
- if (res.status === 1) return false;
- throw new Error(
- `git merge-base --is-ancestor ${a} ${b} failed (exit ${res.status}): ${String(res.stderr || '').trim()}`,
- );
- },
- bumpTypeOf: (sha, id) => parseFrontmatterBumpType(runGit(['show', `${sha}:.changeset/${id}.md`])),
-};
+export function gitAt(cwd) {
+ return {
+ revParse: (ref) => runGit(['rev-parse', '--verify', `${ref}^{commit}`], cwd).trim(),
+ newestStableTag: () => {
+ for (const line of runGit(['tag', '--list', 'v*', '--sort=-version:refname'], cwd).split('\n')) {
+ const t = line.trim();
+ if (STABLE_TAG_RE.test(t)) return t;
+ }
+ return '';
+ },
+ changesetIds: (sha) =>
+ changesetIdsFromTreePaths(runGit(['ls-tree', '--name-only', sha, '--', '.changeset/'], cwd).split('\n')),
+ isAncestor: (a, b) => {
+ const res = spawnSync('git', ['merge-base', '--is-ancestor', a, b], { cwd, encoding: 'utf8', env: gitCleanEnv() });
+ if (res.status === 0) return true;
+ if (res.status === 1) return false;
+ throw new Error(
+ `git merge-base --is-ancestor ${a} ${b} failed (exit ${res.status}): ${String(res.stderr || '').trim()}`,
+ );
+ },
+ bumpTypeOf: (sha, id) =>
+ maxReleaseType(loadChangesets().parse(runGit(['show', `${sha}:./.changeset/${id}.md`], cwd)).releases),
+ };
+}
+
+export const realGit = gitAt();
export function readAnchorVersion() {
const pre = JSON.parse(readFileSync('.changeset/pre.json', 'utf8'));
diff --git a/scripts/compute-stable-version.test.mjs b/scripts/compute-stable-version.test.mjs
index 63f4e5c46..f73640f37 100644
--- a/scripts/compute-stable-version.test.mjs
+++ b/scripts/compute-stable-version.test.mjs
@@ -1,5 +1,17 @@
-import { describe, expect, test } from 'vitest';
-import { computePointReleaseVersion, computeStablePromotion, evaluateAnchorGuard } from './compute-stable-version.mjs';
+import { spawnSync } from 'node:child_process';
+import { mkdirSync, mkdtempSync, rmSync, writeFileSync } from 'node:fs';
+import { tmpdir } from 'node:os';
+import { dirname, join } from 'node:path';
+import { afterEach, describe, expect, test } from 'vitest';
+import { loadChangesets, maxReleaseType } from './compute-next-beta.mjs';
+import {
+ changesetIdsFromTreePaths,
+ computePointReleaseVersion,
+ computeStablePromotion,
+ evaluateAnchorGuard,
+ gitAt,
+} from './compute-stable-version.mjs';
+import { gitCleanEnv } from './git-clean-env.mjs';
function fakeGit({ shas = {}, newestStable = '', changesets = {}, ancestor = () => false, bumps = {} } = {}) {
return {
@@ -334,3 +346,89 @@ describe('computePointReleaseVersion', () => {
expect(r.addedIds).toEqual(['fix']);
});
});
+
+const repos = [];
+
+afterEach(() => {
+ while (repos.length) rmSync(repos.pop(), { recursive: true, force: true });
+});
+
+function git(cwd, args) {
+ const res = spawnSync('git', args, { cwd, env: gitCleanEnv(), encoding: 'utf8' });
+ if (res.status !== 0) throw new Error(`git ${args.join(' ')} failed: ${res.stderr}`);
+ return res.stdout;
+}
+
+function committedChangesets(files, { subtree = '' } = {}) {
+ const root = mkdtempSync(join(tmpdir(), 'stable-version-changesets-'));
+ repos.push(root);
+ for (const [name, body] of Object.entries(files)) {
+ const target = join(root, subtree, '.changeset', name);
+ mkdirSync(dirname(target), { recursive: true });
+ writeFileSync(target, body);
+ }
+ git(root, ['init', '-q', '-b', 'main']);
+ git(root, ['add', '-A']);
+ git(root, ['-c', 'user.name=t', '-c', '[email protected]', 'commit', '-q', '-m', 'changesets']);
+ return root;
+}
+
+const OK = '@inkeep/open-knowledge';
+const bump = (body) => `---\n${body}\n---\n\nA change.\n`;
+
+const disagreementsWithTheOldRawReader = {
+ 'quoted.md': bump(`"${OK}": "major"`),
+ 'trailing-comment.md': bump(`"${OK}": minor # was: major`),
+ 'comment-line.md': bump(`# bump: major\n"${OK}": patch`),
+ 'readme.md': bump(`"${OK}": major`),
+ 'README.md': '# Changesets\n',
+ '.hidden.md': bump(`"${OK}": major`),
+ 'plain.md': bump(`"${OK}": patch`),
+ 'config.json': '{}',
+};
+
+describe('changesetIdsFromTreePaths', () => {
+ test('keeps what @changesets/read keeps: top-level .md files except dotfiles and README in any case', () => {
+ const paths = [
+ '.changeset/README.md',
+ '.changeset/readme.md',
+ '.changeset/.hidden.md',
+ '.changeset/config.json',
+ '.changeset/wise-cats-sing.md',
+ '',
+ ];
+ expect(changesetIdsFromTreePaths(paths)).toEqual(['wise-cats-sing']);
+ });
+});
+
+describe('gitAt reads a commit\'s changesets the way Changesets reads the same tree', () => {
+ test('the ids and bumps it reads at HEAD equal @changesets/read on the checkout', async () => {
+ const root = committedChangesets(disagreementsWithTheOldRawReader);
+ const reader = gitAt(root);
+ const fromGit = Object.fromEntries(
+ reader.changesetIds('HEAD').map((id) => [id, reader.bumpTypeOf('HEAD', id)]),
+ );
+ const fromChangesets = Object.fromEntries(
+ (await loadChangesets().read(root)).map(({ id, releases }) => [id, maxReleaseType(releases)]),
+ );
+ expect(fromGit).toEqual(fromChangesets);
+ expect(fromGit).toEqual({
+ quoted: 'major',
+ 'trailing-comment': 'minor',
+ 'comment-line': 'patch',
+ plain: 'patch',
+ });
+ });
+
+ test('from a subtree checkout it reads the subtree\'s .changeset, as in the monorepo', () => {
+ const root = committedChangesets({ 'quoted.md': bump(`"${OK}": "minor"`) }, { subtree: 'public/open-knowledge' });
+ const reader = gitAt(join(root, 'public/open-knowledge'));
+ expect(reader.changesetIds('HEAD')).toEqual(['quoted']);
+ expect(reader.bumpTypeOf('HEAD', 'quoted')).toBe('minor');
+ });
+
+ test('a changeset Changesets cannot parse fails the read instead of counting as no bump', () => {
+ const root = committedChangesets({ 'broken.md': bump(`"${OK}": Major`) });
+ expect(() => gitAt(root).bumpTypeOf('HEAD', 'broken')).toThrow();
+ });
+});