Beautiful, AI-native markdown IDE and LLM wiki
TypeScript 2nd-brainagent-skillsclaudecodexcompany-braindocsknowledge-knowledge-baseknowledge-managementllmllm-wikillm-wiki-karpathymarkdownmarkdown-editormdmdxnotespkmsecond-brainskills
fix(open-knowledge): extinguish playwright flake classes, gate e2e (#1751)
Nick Gomezd77390b0f6f5
diff --git a/biome-plugins/README.md b/biome-plugins/README.mdindex a01ca8f06..9fae624dc 100644--- a/biome-plugins/README.md+++ b/biome-plugins/README.md@@ -99,6 +99,19 @@ The rule does NOT catch:Plugin: [`biome-plugins/playwright-topass-budget.grit`](playwright-topass-budget.grit). Fixture: [`biome-plugins/__fixtures__/playwright-topass-budget.fixture.tsx`](__fixtures__/playwright-topass-budget.fixture.tsx). Test: [`packages/desktop/tests/integration/playwright-topass-budget.test.ts`](../packages/desktop/tests/integration/playwright-topass-budget.test.ts). See [PRECEDENTS.md #42](../PRECEDENTS.md#custom-lint-enforcement-precedent-42) for the GritQL-plugin convention.+### `playwright-prefer-to-have-count.grit`++Flags `expect(await locator.count())` — the one-shot count snapshot that never retries. Under CI CPU contention the DOM settles a few frames after the read, so the assertion flakes while the auto-retrying web-first form `await expect(locator).toHaveCount(n)` passes deterministically (the no-retry read was one of the hidden-flake shapes in the 2026-06 e2e CI audit). The pattern matches the probe sub-expression regardless of the matcher that follows (`.toBe`, `.toEqual`, `.toBeGreaterThanOrEqual`, ...). Upstream precedent: eslint-plugin-playwright `prefer-to-have-count`.++**Scoped via `overrides[].plugins`** to `packages/app/tests/{stress,visual,a11y}/**/*.e2e.ts` (the same three dirs `tests/integration/e2e-stop-rules.test.ts` source-scans) + the fixture. Not workspace-wide: outside Playwright specs, `.count()` is usually not a `Locator` and the web-first rewrite does not apply.++The rule does NOT catch:+- `expect.soft(await locator.count())` — different callee node shape; zero occurrences today.+- A count read assigned to a variable and asserted later (`const n = await loc.count(); expect(n).toBe(2)`) — two statements; GritQL cannot correlate them. Add an e2e-stop-rules source-scan rule if the split form ever recurs.+- Biome 2.4 plugin diagnostics are diagnostic-only — the `toHaveCount` rewrite is named in the message but not auto-applied.++Plugin: [`biome-plugins/playwright-prefer-to-have-count.grit`](playwright-prefer-to-have-count.grit). Fixture: [`biome-plugins/__fixtures__/playwright-prefer-to-have-count.fixture.tsx`](__fixtures__/playwright-prefer-to-have-count.fixture.tsx). Test: [`packages/app/tests/lint-plugins/playwright-prefer-to-have-count.test.ts`](../packages/app/tests/lint-plugins/playwright-prefer-to-have-count.test.ts). See [PRECEDENTS.md #42](../PRECEDENTS.md#custom-lint-enforcement-precedent-42) for the GritQL-plugin convention.+## SuppressionInline `// biome-ignore` comments silence individual diagnostics. The most specific form names the rule and the reason:diff --git a/biome-plugins/__fixtures__/playwright-prefer-to-have-count.fixture.tsx b/biome-plugins/__fixtures__/playwright-prefer-to-have-count.fixture.tsxnew file mode 100644index 000000000..0cd449906--- /dev/null+++ b/biome-plugins/__fixtures__/playwright-prefer-to-have-count.fixture.tsx@@ -0,0 +1,46 @@+/**+ * Fixture for `playwright-prefer-to-have-count.grit`.+ *+ * 3 positive cases (one-shot count reads — plugin MUST fire) paired with+ * 5 negative cases (web-first / legitimately different shapes — plugin+ * must NOT fire). The fixture-file test asserts the diagnostic count with+ * exact equality (`toBe(3)`) so both weakened-pattern and widened-pattern+ * drift fail the gate.+ *+ * Deliberately NOT linted by the main `bun run lint` pass (biome-plugins/+ * is outside the lint paths); only the scoped override in biome.jsonc+ * reaches it, via the fixture-file test.+ */++declare const expect: any;+declare const page: any;++async function positives() {+ const rows = page.locator('[role="treeitem"]');+ // P1: one-shot count + toBe — the canonical banned shape.+ expect(await rows.count()).toBe(0);+ // P2: same shape, different matcher — still a no-retry snapshot.+ expect(await page.locator('.pill').count()).toEqual(1);+ // P3: comparison matcher on a one-shot count read.+ expect(await rows.count()).toBeGreaterThanOrEqual(2);+}++async function negatives() {+ const rows = page.locator('[role="treeitem"]');+ // N1: the web-first replacement — must NOT fire.+ await expect(rows).toHaveCount(3);+ // N2: expect.poll over a count probe is auto-retrying — must NOT fire.+ await expect.poll(async () => rows.count()).toBe(4);+ // N3: a bare count read without an expect wrapper — must NOT fire.+ const n = await rows.count();+ void n;+ // N4: an expect over a different awaited method — must NOT fire.+ expect(await rows.boundingBox()).toBeTruthy();+ // N5: count read assigned to a variable, then asserted in a separate+ // statement — the documented two-statement escape hatch (GritQL cannot+ // correlate across statements; see the plugin docblock); must NOT fire.+ const c = await rows.count();+ expect(c).toBe(2);+}++export { negatives, positives };diff --git a/biome-plugins/playwright-prefer-to-have-count.grit b/biome-plugins/playwright-prefer-to-have-count.gritnew file mode 100644index 000000000..d6b774203--- /dev/null+++ b/biome-plugins/playwright-prefer-to-have-count.grit@@ -0,0 +1,35 @@+// playwright-prefer-to-have-count — flag `expect(await locator.count())`.+//+// A one-shot `expect(await locator.count()).toBe(N)` snapshots the count at+// a single instant and never retries — under CI CPU contention the DOM can+// settle a few frames later, which is the canonical hidden-flake shape the+// 2026-06 e2e audit measured across the suite. Playwright's web-first+// `await expect(locator).toHaveCount(N)` auto-retries against the live DOM+// for the expect timeout and is the official replacement+// (https://playwright.dev/docs/test-assertions). Upstream precedent:+// eslint-plugin-playwright's `prefer-to-have-count` rule bans the same+// shape.+//+// The pattern matches the probe sub-expression regardless of which matcher+// follows (`.toBe`, `.toEqual`, `.toBeGreaterThan`, ...) — every matcher on+// a one-shot count read shares the no-retry defect.+//+// Does NOT catch (document-honestly per the README convention):+// - `expect.soft(await locator.count())` — different callee node shape.+// - A count read assigned to a variable and asserted later+// (`const n = await loc.count(); expect(n).toBe(2)`) — two statements;+// GritQL can't correlate them. The e2e-stop-rules source-scan tier is+// the place for that shape if it ever recurs.+//+// Suppress a genuinely non-retryable count read (e.g. counting against a+// deliberately frozen page state) with:+// // biome-ignore lint/plugin/playwright-prefer-to-have-count: <reason>++language js++`expect(await $x.count())` as $probe where {+ register_diagnostic(+ span = $probe,+ message = "One-shot count read never retries — use the web-first `await expect(locator).toHaveCount(n)` so the assertion polls the live DOM. See https://github.com/inkeep/open-knowledge-legacy/blob/main/biome-plugins/README.md#playwright-prefer-to-have-countgrit"+ )+}diff --git a/biome.jsonc b/biome.jsoncindex b4644a250..09ff7b6ca 100644--- a/biome.jsonc+++ b/biome.jsonc@@ -69,6 +69,21 @@],"plugins": ["./biome-plugins/playwright-topass-budget.grit"]},+ {+ // One-shot `expect(await locator.count())` reads never retry and are+ // the canonical hidden-flake assertion shape (2026-06 e2e audit).+ // Scoped to the browser e2e suites (all three dirs the e2e-stop-rules+ // source-scan also covers) + the plugin's own fixture. Not workspace-+ // wide: outside Playwright specs, `.count()` is usually not a Locator+ // and the web-first rewrite does not apply.+ "includes": [+ "packages/app/tests/stress/**/*.e2e.ts",+ "packages/app/tests/visual/**/*.e2e.ts",+ "packages/app/tests/a11y/**/*.e2e.ts",+ "biome-plugins/__fixtures__/playwright-prefer-to-have-count.fixture.tsx"+ ],+ "plugins": ["./biome-plugins/playwright-prefer-to-have-count.grit"]+ },{// UI primitives discipline (see PR #937 retrospective). Scoped to// packages/{app,desktop,plugin}/src/**/*.tsx — production UI surfaces.diff --git a/packages/app/package.json b/packages/app/package.jsonindex a36e6d402..faf575a2b 100644--- a/packages/app/package.json+++ b/packages/app/package.json@@ -5,7 +5,7 @@"private": true,"type": "module","scripts": {- "predev": "turbo run build --filter=@inkeep/open-knowledge-core --filter=@inkeep/open-knowledge-server && bun run i18n:compile",+ "predev": "turbo run build --filter=@inkeep/open-knowledge-core --filter=@inkeep/open-knowledge-server && sh scripts/i18n-compile-unless-skipped.sh","dev": "vite","build": "bun run i18n:compile && tsc --noEmit && vite build","typecheck": "tsc --noEmit",diff --git a/packages/app/playwright.config.ts b/packages/app/playwright.config.tsindex 8fa2c19ae..b95f8a4b7 100644--- a/packages/app/playwright.config.ts+++ b/packages/app/playwright.config.ts@@ -5,6 +5,7 @@ const isCI = !!process.env.CI;export default defineConfig({testDir: './tests/stress',testMatch: /.*\.e2e\.ts$/,+ globalSetup: './tests/stress/_helpers/global-warm-cache.ts',timeout: 120_000,retries: isCI ? 2 : 0,failOnFlakyTests: false,diff --git a/packages/app/scripts/i18n-compile-unless-skipped.sh b/packages/app/scripts/i18n-compile-unless-skipped.shnew file mode 100644index 000000000..5815168a8--- /dev/null+++ b/packages/app/scripts/i18n-compile-unless-skipped.sh@@ -0,0 +1,15 @@+#!/bin/sh+# predev i18n gate: e2e fixture-spawned dev servers set+# OK_TEST_SKIP_I18N_COMPILE=1 because N concurrent boots otherwise run+# `lingui compile` + `biome format --write` against the SHARED+# src/locales/*/messages.json — racing writers tear the JSON for any+# concurrent reader (the corrupted-catalog playwright failure in CI run+# 27182560489, reproduced locally by check:full:parallel booting the+# e2e/visual/a11y projects together). The catalogs are committed and+# drift-checked in CI, and the e2e warm-cache globalSetup boot (single,+# uncontended, before any worker) compiles them once per run.+if [ -n "$OK_TEST_SKIP_I18N_COMPILE" ]; then+ echo "[predev] i18n:compile skipped (OK_TEST_SKIP_I18N_COMPILE set)"+ exit 0+fi+exec bun run i18n:compilediff --git a/packages/app/tests/integration/e2e-stop-rules.test.ts b/packages/app/tests/integration/e2e-stop-rules.test.tsindex 212b3c64a..1e49758b9 100644--- a/packages/app/tests/integration/e2e-stop-rules.test.ts+++ b/packages/app/tests/integration/e2e-stop-rules.test.ts@@ -63,6 +63,27 @@ function listAppSrcTsFiles(): FileLines[] {return out;}+const SPAWN_BUN_PATTERN = /spawn\(\s*['"]bun['"]/;+const SPAWN_REQUIRED_ENV_KEYS = ['OK_TEST_VITE_CACHE_DIR', 'OK_TEST_SKIP_I18N_COMPILE'] as const;++function findSpawnIsolationViolations(+ lines: string[],+): Array<{ line: number; missingKey: string }> {+ const spawnLines: number[] = [];+ for (let i = 0; i < lines.length; i++) {+ if (SPAWN_BUN_PATTERN.test(lines[i] ?? '')) spawnLines.push(i + 1);+ }+ if (spawnLines.length === 0) return [];+ const source = lines.join('\n');+ const violations: Array<{ line: number; missingKey: string }> = [];+ for (const key of SPAWN_REQUIRED_ENV_KEYS) {+ if (!source.includes(key)) {+ violations.push({ line: spawnLines[0] ?? 1, missingKey: key });+ }+ }+ return violations;+}+function collectMatches(files: FileLines[],predicate: (line: string, lineIdx: number, file: FileLines) => boolean,@@ -260,6 +281,62 @@ describe('E2E STOP rule — zero allowlist', () => {}});+ test('e2e files that spawn a dev server must isolate shared mutable state (vite cache + i18n compile)', () => {+ const violations: string[] = [];+ for (const file of e2eFiles) {+ for (const v of findSpawnIsolationViolations(file.lines)) {+ violations.push(+ ` ${file.path}:${v.line} spawn('bun', …) without ${v.missingKey} anywhere in the file`,+ );+ }+ }+ if (violations.length > 0) {+ throw new Error(+ `dev-server spawn without shared-state isolation — pass OK_TEST_VITE_CACHE_DIR (via prepareViteCacheDir from ./_helpers, rmSync in teardown) and OK_TEST_SKIP_I18N_COMPILE: '1' in the spawn env:\n${violations.join('\n')}`,+ );+ }+ });++ test('spawn-isolation rule fires on a planted violation and not on adjacent negatives', () => {+ const planted = [+ "const proc = spawn('bun', ['run', '--silent', 'dev'], {",+ ' env: { ...process.env, VITE_PORT: String(port) },',+ '});',+ ];+ const fired = findSpawnIsolationViolations(planted);+ expect(fired.length).toBe(2);+ expect(fired[0]?.line).toBe(1);++ const compliant = [+ "const proc = spawn('bun', ['run', '--silent', 'dev'], {",+ " env: { OK_TEST_VITE_CACHE_DIR: dir, OK_TEST_SKIP_I18N_COMPILE: '1' },",+ '});',+ ];+ expect(findSpawnIsolationViolations(compliant).length).toBe(0);++ const otherSpawn = ["const proc = spawn('node', ['script.js'], { env: {} });"];+ expect(findSpawnIsolationViolations(otherSpawn).length).toBe(0);++ const halfCompliant = [+ "const proc = spawn('bun', ['run', '--silent', 'dev'], {",+ ' env: { OK_TEST_VITE_CACHE_DIR: dir },',+ '});',+ ];+ const halfFired = findSpawnIsolationViolations(halfCompliant);+ expect(halfFired.length).toBe(1);+ expect(halfFired[0]?.missingKey).toBe('OK_TEST_SKIP_I18N_COMPILE');++ const multiSpawn = [+ "const p1 = spawn('bun', ['run', '--silent', 'dev'], {",+ " env: { OK_TEST_VITE_CACHE_DIR: d, OK_TEST_SKIP_I18N_COMPILE: '1' },",+ '});',+ "const p2 = spawn('bun', ['run', '--silent', 'dev'], {",+ ' env: { VITE_PORT: String(port) },',+ '});',+ ];+ expect(findSpawnIsolationViolations(multiSpawn).length).toBe(0);+ });+test('window.__activeEditor is published only by DocumentContext.tsx (regression — PR #168 merge collision)', () => {const srcFiles = listAppSrcTsFiles();const directAssignPattern = /window\.__activeEditor\s*=/;diff --git a/packages/app/tests/lint-plugins/playwright-prefer-to-have-count.test.ts b/packages/app/tests/lint-plugins/playwright-prefer-to-have-count.test.tsnew file mode 100644index 000000000..1299bb644--- /dev/null+++ b/packages/app/tests/lint-plugins/playwright-prefer-to-have-count.test.ts@@ -0,0 +1,59 @@+/**+ * playwright-prefer-to-have-count — Biome GritQL plugin fixture test.+ *+ * Plugin: `biome-plugins/playwright-prefer-to-have-count.grit`+ * Fixture: `biome-plugins/__fixtures__/playwright-prefer-to-have-count.fixture.tsx`+ *+ * Per precedent #42 (custom Biome enforcement is GritQL plugins). Bans the+ * one-shot `expect(await locator.count())` snapshot read in the browser+ * e2e suites — the no-retry assertion shape behind several of the 2026-06+ * CI audit's hidden flakes — in favor of the web-first auto-retrying+ * `await expect(locator).toHaveCount(n)`. Upstream precedent:+ * eslint-plugin-playwright `prefer-to-have-count`.+ *+ * The fixture pairs 3 positive cases (one-shot reads through different+ * matchers — plugin must fire) with 5 negative cases (toHaveCount,+ * expect.poll, bare count read, different awaited method, two-statement+ * read-then-assert — plugin must NOT fire). Exact-equality (`toBe(3)`)+ * catches both false-negative regressions (weakened pattern drops below 3)+ * and false-positive widenings (above 3).+ */++import { describe, expect, test } from 'bun:test';+import { spawnSync } from 'node:child_process';+import { join } from 'node:path';++const REPO_ROOT = join(__dirname, '..', '..', '..', '..');+const FIXTURE_REL = 'biome-plugins/__fixtures__/playwright-prefer-to-have-count.fixture.tsx';+const PLUGIN_REL = './biome-plugins/playwright-prefer-to-have-count.grit';++describe('playwright-prefer-to-have-count GritQL plugin', () => {+ test('fires on exactly 3 one-shot count reads (and on no negative case)', () => {+ const result = spawnSync('bunx', ['biome', 'check', FIXTURE_REL], {+ cwd: REPO_ROOT,+ encoding: 'utf-8',+ });+ expect(result.status).not.toBe(0);+ const output = `${result.stdout}\n${result.stderr}`;+ const fires = (output.match(/One-shot count read never retries/g) ?? []).length;+ expect(fires).toBe(3);+ expect(output).toContain('use the web-first `await expect(locator).toHaveCount(n)`');+ expect(output).toMatch(/https?:\/\/[^\s]+/);+ expect(output).toContain('biome-plugins/README.md#playwright-prefer-to-have-countgrit');+ });++ test('plugin is registered as an override scoped to the e2e suites (not workspace-wide)', () => {+ const config = require(join(REPO_ROOT, 'biome.jsonc'));+ const rootPlugins: string[] = config.plugins ?? [];+ expect(rootPlugins).not.toContain(PLUGIN_REL);++ const overrides: Array<{ includes?: string[]; plugins?: string[] }> = config.overrides ?? [];+ const entry = overrides.find((o) => (o.plugins ?? []).includes(PLUGIN_REL));+ expect(entry).toBeDefined();+ const includes = entry?.includes ?? [];+ expect(includes).toContain(FIXTURE_REL);+ for (const dir of ['stress', 'visual', 'a11y']) {+ expect(includes).toContain(`packages/app/tests/${dir}/**/*.e2e.ts`);+ }+ });+});diff --git a/packages/app/tests/stress/_helpers/editor-state.ts b/packages/app/tests/stress/_helpers/editor-state.tsindex 2fb2e3d2d..26ccee05f 100644--- a/packages/app/tests/stress/_helpers/editor-state.ts+++ b/packages/app/tests/stress/_helpers/editor-state.ts@@ -11,7 +11,7 @@ export async function selectAllAndWaitForSelection(page: Page, selector: string));}-export async function focusEditor(page: Page, timeoutMs = 2_000): Promise<void> {+export async function focusEditor(page: Page, timeoutMs = 5_000): Promise<void> {await page.evaluate(() => {const editor = window.__activeEditor;if (!editor) return;diff --git a/packages/app/tests/stress/_helpers/fixtures.ts b/packages/app/tests/stress/_helpers/fixtures.tsindex 0093a207c..d304de174 100644--- a/packages/app/tests/stress/_helpers/fixtures.ts+++ b/packages/app/tests/stress/_helpers/fixtures.ts@@ -1,16 +1,19 @@import { spawn } from 'node:child_process';import { mkdirSync, mkdtempSync, rmSync, writeFileSync } from 'node:fs';import { tmpdir } from 'node:os';-import { dirname, join, resolve } from 'node:path';-import { fileURLToPath } from 'node:url';-import { HocuspocusProvider } from '@hocuspocus/provider';-import { SYSTEM_DOC_NAME } from '@inkeep/open-knowledge-core';+import { join } from 'node:path';import { test as base } from '@playwright/test';-import * as Y from 'yjs';-import { getFreePort, killGracefully, waitForHttpReady } from './server-process.ts';--const HELPERS_DIR = dirname(fileURLToPath(import.meta.url));-const APP_PACKAGE_ROOT = resolve(HELPERS_DIR, '..', '..', '..');+import {+ APP_PACKAGE_ROOT,+ checkCollabSync,+ closeServerLog,+ getFreePort,+ killGracefully,+ openServerLog,+ prepareViteCacheDir,+ tailServerLog,+ waitForHttpReady,+} from './server-process.ts';export interface WorkerServer {port: number;@@ -70,41 +73,14 @@ async function checkApiConfig(baseURL: string, timeoutMs = 2_000): Promise<void>}}-async function checkCollabSync(port: number, timeoutMs = 10_000): Promise<void> {- const doc = new Y.Doc();- const provider = new HocuspocusProvider({- url: `ws://localhost:${port}/collab`,- name: SYSTEM_DOC_NAME,- document: doc,- connect: false,- });- try {- await new Promise<void>((resolve, reject) => {- const timer = setTimeout(() => {- reject(new Error(`/collab sync round-trip did not complete within ${timeoutMs}ms`));- }, timeoutMs);- provider.on('synced', () => {- clearTimeout(timer);- resolve();- });- provider.connect();- });- } finally {- try {- provider.destroy();- } catch {}- try {- doc.destroy();- } catch {}- }-}-async function waitForServerReady(baseURL: string, port: number): Promise<void> {- await waitForHttpReady(baseURL, 30_000);+ await waitForHttpReady(baseURL, 60_000);await checkApiConfig(baseURL);await checkCollabSync(port);}+export const REQUIRED_FIXTURE_ENTRY_NAMES = ['test-doc.md', 'sidebar-folder'] as const;+function seedRequiredFixtureFiles(contentDir: string): void {writeFileSync(join(contentDir, 'test-doc.md'), '', 'utf-8');mkdirSync(join(contentDir, 'sidebar-folder'), { recursive: true });@@ -117,13 +93,12 @@ export const test = base.extend<TestFixtures, WorkerFixtures>({async ({}, use, workerInfo) => {const port = await getFreePort();const contentDir = mkdtempSync(join(tmpdir(), `ok-w${workerInfo.workerIndex}-`));- mkdirSync(join(APP_PACKAGE_ROOT, 'node_modules'), { recursive: true });- const viteCacheDir = mkdtempSync(- join(APP_PACKAGE_ROOT, 'node_modules', `.vite-w${workerInfo.workerIndex}-`),- );+ const viteCacheDir = prepareViteCacheDir(`w${workerInfo.workerIndex}`);seedRequiredFixtureFiles(contentDir);const baseURL = `http://localhost:${port}`;+ const serverLog = openServerLog(`w${workerInfo.workerIndex}`);+const proc = spawn('bun', ['run', '--silent', 'dev'], {cwd: APP_PACKAGE_ROOT,env: {@@ -131,10 +106,11 @@ export const test = base.extend<TestFixtures, WorkerFixtures>({VITE_PORT: String(port),OK_TEST_CONTENT_DIR: contentDir,OK_TEST_VITE_CACHE_DIR: viteCacheDir,+ OK_TEST_SKIP_I18N_COMPILE: '1',OK_TEST_GIT_ENABLED: '1',NO_COLOR: process.env.NO_COLOR ?? '1',},- stdio: ['ignore', 'ignore', 'inherit'],+ stdio: ['ignore', serverLog.fd, 'inherit'],});proc.on('error', (err) => {@@ -144,19 +120,31 @@ export const test = base.extend<TestFixtures, WorkerFixtures>({try {await waitForServerReady(baseURL, port);} catch (err) {- await killGracefully(proc);- rmSync(contentDir, { recursive: true, force: true });- rmSync(viteCacheDir, { recursive: true, force: true });- throw err;+ const reason = err instanceof Error ? err.message : String(err);+ try {+ await killGracefully(proc);+ } finally {+ closeServerLog(serverLog);+ rmSync(contentDir, { recursive: true, force: true });+ rmSync(viteCacheDir, { recursive: true, force: true });+ }+ throw new Error(+ `${reason}\n--- dev server log tail (${serverLog.path}) ---\n${tailServerLog(serverLog)}`,+ );}await use({ port, baseURL, contentDir });- await killGracefully(proc);- rmSync(contentDir, { recursive: true, force: true });- rmSync(viteCacheDir, { recursive: true, force: true });+ try {+ await killGracefully(proc);+ } finally {+ closeServerLog(serverLog);+ rmSync(serverLog.path, { force: true });+ rmSync(contentDir, { recursive: true, force: true });+ rmSync(viteCacheDir, { recursive: true, force: true });+ }},- { scope: 'worker', timeout: 60_000 },+ { scope: 'worker', timeout: 120_000 },],baseURL: async ({ workerServer }, use) => {@@ -165,41 +153,49 @@ export const test = base.extend<TestFixtures, WorkerFixtures>({api: async ({ workerServer }, use) => {const { baseURL } = workerServer;- const helpers: ApiHelpers = {- async createPage(path: string): Promise<void> {- const res = await fetch(`${baseURL}/api/create-page`, {+ const API_CALL_TIMEOUT_MS = 30_000;+ async function post(path: string, body?: unknown): Promise<Response> {+ try {+ return await fetch(`${baseURL}${path}`, {method: 'POST',- headers: { 'Content-Type': 'application/json' },- body: JSON.stringify({ path }),+ ...(body !== undefined+ ? { headers: { 'Content-Type': 'application/json' }, body: JSON.stringify(body) }+ : {}),+ signal: AbortSignal.timeout(API_CALL_TIMEOUT_MS),});+ } catch (err) {+ const name = (err as { name?: string })?.name;+ if (name === 'TimeoutError' || name === 'AbortError') {+ throw new Error(+ `POST ${path} timed out after ${API_CALL_TIMEOUT_MS}ms — server stalled mid-test (port ${workerServer.port})`,+ );+ }+ throw err;+ }+ }+ const helpers: ApiHelpers = {+ async createPage(path: string): Promise<void> {+ const res = await post('/api/create-page', { path });if (res.status === 409) return;if (!res.ok) {throw new Error(`create-page failed for ${path}: ${res.status}`);}},async replaceDoc(docName: string, markdown: string): Promise<void> {- const res = await fetch(`${baseURL}/api/agent-write-md`, {- method: 'POST',- headers: { 'Content-Type': 'application/json' },- body: JSON.stringify({ docName, markdown, position: 'replace' }),- });+ const res = await post('/api/agent-write-md', { docName, markdown, position: 'replace' });if (!res.ok) {throw new Error(`agent-write-md failed for ${docName}: ${res.status}`);}},async writeAsAgent(docName: string, markdown: string, identity): Promise<void> {- const res = await fetch(`${baseURL}/api/agent-write-md`, {- method: 'POST',- headers: { 'Content-Type': 'application/json' },- body: JSON.stringify({- docName,- markdown,- position: 'replace',- agentId: identity.agentId,- agentName: identity.agentName,- clientName: identity.clientName,- colorSeed: identity.colorSeed,- }),+ const res = await post('/api/agent-write-md', {+ docName,+ markdown,+ position: 'replace',+ agentId: identity.agentId,+ agentName: identity.agentName,+ clientName: identity.clientName,+ colorSeed: identity.colorSeed,});if (!res.ok) {throw new Error(@@ -208,10 +204,9 @@ export const test = base.extend<TestFixtures, WorkerFixtures>({}},async testReset(docName?: string): Promise<void> {- const url = docName- ? `${baseURL}/api/test-reset?docName=${encodeURIComponent(docName)}`- : `${baseURL}/api/test-reset`;- const res = await fetch(url, { method: 'POST' });+ const res = await post(+ docName ? `/api/test-reset?docName=${encodeURIComponent(docName)}` : '/api/test-reset',+ );if (!res.ok) {throw new Error(`test-reset failed${docName ? ` for ${docName}` : ''}: ${res.status}`);}diff --git a/packages/app/tests/stress/_helpers/global-warm-cache.ts b/packages/app/tests/stress/_helpers/global-warm-cache.tsnew file mode 100644index 000000000..7d531e2b1--- /dev/null+++ b/packages/app/tests/stress/_helpers/global-warm-cache.ts@@ -0,0 +1,161 @@+import { spawn } from 'node:child_process';+import { createHash } from 'node:crypto';+import {+ existsSync,+ mkdirSync,+ mkdtempSync,+ readdirSync,+ readFileSync,+ renameSync,+ rmSync,+ statSync,+ writeFileSync,+} from 'node:fs';+import { tmpdir } from 'node:os';+import { join } from 'node:path';+import { setTimeout as wait } from 'node:timers/promises';+import {+ APP_PACKAGE_ROOT,+ closeServerLog,+ getFreePort,+ killGracefully,+ openServerLog,+ tailServerLog,+ VITE_E2E_SEED_DIR,+ waitForHttpReady,+} from './server-process.ts';++const SEED_KEY_FILENAME = '.seed-key';+const OPTIMIZER_SETTLE_BUDGET_MS = 90_000;+const WARM_ATTEMPTS = 2;++function computeSeedKey(): string {+ const inputs = [+ join(APP_PACKAGE_ROOT, '..', '..', 'bun.lock'),+ join(APP_PACKAGE_ROOT, 'vite.config.ts'),+ join(APP_PACKAGE_ROOT, 'vite.dedupe.ts'),+ join(APP_PACKAGE_ROOT, 'vite.react-babel.ts'),+ join(APP_PACKAGE_ROOT, 'package.json'),+ ];+ const hash = createHash('sha256');+ for (const file of inputs) {+ hash.update(file);+ hash.update(existsSync(file) ? readFileSync(file) : 'absent');+ }+ return hash.digest('hex');+}++function depsDirSignature(depsDir: string): string {+ try {+ return readdirSync(depsDir)+ .map((name) => {+ try {+ return `${name}:${statSync(join(depsDir, name)).size}`;+ } catch {+ return `${name}:?`;+ }+ })+ .sort()+ .join('|');+ } catch {+ return 'absent';+ }+}++async function buildSeedOnce(key: string): Promise<void> {+ const port = await getFreePort();+ const contentDir = mkdtempSync(join(tmpdir(), 'ok-warm-cache-content-'));+ mkdirSync(join(APP_PACKAGE_ROOT, 'node_modules'), { recursive: true });+ const buildDir = mkdtempSync(join(APP_PACKAGE_ROOT, 'node_modules', '.vite-e2e-seed-building-'));+ const log = openServerLog('warm-cache');+ const proc = spawn('bun', ['run', '--silent', 'dev'], {+ cwd: APP_PACKAGE_ROOT,+ env: {+ ...process.env,+ VITE_PORT: String(port),+ OK_TEST_CONTENT_DIR: contentDir,+ OK_TEST_VITE_CACHE_DIR: buildDir,+ NO_COLOR: process.env.NO_COLOR ?? '1',+ },+ stdio: ['ignore', log.fd, log.fd],+ });+ proc.on('error', (err) => {+ console.warn('[e2e warm-cache] spawn error:', err);+ });+ let succeeded = false;+ try {+ await waitForHttpReady(`http://localhost:${port}`, 60_000);+ const depsDir = join(buildDir, 'deps');+ const metaPath = join(depsDir, '_metadata.json');+ const deadline = Date.now() + OPTIMIZER_SETTLE_BUDGET_MS;+ let lastSignature = '';+ let stablePolls = 0;+ while (Date.now() < deadline) {+ if (existsSync(metaPath)) {+ const signature = depsDirSignature(depsDir);+ if (signature === lastSignature) {+ stablePolls += 1;+ if (stablePolls >= 2) break;+ } else {+ stablePolls = 0;+ lastSignature = signature;+ }+ }+ await wait(1_000);+ }+ if (!existsSync(metaPath)) {+ throw new Error(+ `optimizer metadata never appeared within ${OPTIMIZER_SETTLE_BUDGET_MS}ms — server log tail:\n${tailServerLog(log)}`,+ );+ }+ if (stablePolls < 2) {+ throw new Error(+ `optimizer deps dir did not stabilize within ${OPTIMIZER_SETTLE_BUDGET_MS}ms (stablePolls=${stablePolls}) — server log tail:\n${tailServerLog(log)}`,+ );+ }+ writeFileSync(join(buildDir, SEED_KEY_FILENAME), key, 'utf-8');+ succeeded = true;+ } finally {+ try {+ await killGracefully(proc);+ } finally {+ closeServerLog(log);+ rmSync(contentDir, { recursive: true, force: true });+ if (!succeeded) {+ rmSync(buildDir, { recursive: true, force: true });+ }+ }+ }+ try {+ rmSync(VITE_E2E_SEED_DIR, { recursive: true, force: true });+ renameSync(buildDir, VITE_E2E_SEED_DIR);+ rmSync(log.path, { force: true });+ } catch (promoteErr) {+ rmSync(buildDir, { recursive: true, force: true });+ rmSync(log.path, { force: true });+ throw promoteErr;+ }+}++export default async function globalWarmViteCache(): Promise<void> {+ const key = computeSeedKey();+ const keyPath = join(VITE_E2E_SEED_DIR, SEED_KEY_FILENAME);+ const metaPath = join(VITE_E2E_SEED_DIR, 'deps', '_metadata.json');+ if (existsSync(keyPath) && existsSync(metaPath) && readFileSync(keyPath, 'utf-8') === key) {+ return;+ }+ for (let attempt = 1; attempt <= WARM_ATTEMPTS; attempt += 1) {+ try {+ await buildSeedOnce(key);+ return;+ } catch (err) {+ console.warn(+ `[e2e warm-cache] seed build attempt ${attempt}/${WARM_ATTEMPTS} failed${+ attempt === WARM_ATTEMPTS+ ? ' — workers will boot with a cold optimizer cache'+ : ', retrying'+ }: ${String(err)}`,+ );+ }+ }+}diff --git a/packages/app/tests/stress/_helpers/index.ts b/packages/app/tests/stress/_helpers/index.tsindex dca0d336c..a6451eff8 100644--- a/packages/app/tests/stress/_helpers/index.ts+++ b/packages/app/tests/stress/_helpers/index.ts@@ -9,6 +9,7 @@ export {type AgentIdentity,type ApiHelpers,expect,+ REQUIRED_FIXTURE_ENTRY_NAMES,test,type WorkerServer,} from './fixtures.ts';@@ -18,7 +19,17 @@ export {type WaitForProviderOptions,waitForActiveProviderSynced,} from './provider.ts';-export { getFreePort, killGracefully, waitForHttpReady } from './server-process.ts';+export {+ checkCollabSync,+ closeServerLog,+ getFreePort,+ killGracefully,+ openServerLog,+ prepareViteCacheDir,+ type ServerLog,+ tailServerLog,+ waitForHttpReady,+} from './server-process.ts';export { sidebarFileButton } from './sidebar.ts';export {getSelectedItemSnapshot,diff --git a/packages/app/tests/stress/_helpers/server-process.ts b/packages/app/tests/stress/_helpers/server-process.tsindex 5d0252e32..54aa38f09 100644--- a/packages/app/tests/stress/_helpers/server-process.ts+++ b/packages/app/tests/stress/_helpers/server-process.ts@@ -1,6 +1,96 @@import type { ChildProcess } from 'node:child_process';+import {+ closeSync,+ cpSync,+ existsSync,+ mkdirSync,+ mkdtempSync,+ openSync,+ readFileSync,+} from 'node:fs';import { type AddressInfo, createServer as createNetServer } from 'node:net';+import { tmpdir } from 'node:os';+import { dirname, join, resolve } from 'node:path';import { setTimeout as wait } from 'node:timers/promises';+import { fileURLToPath } from 'node:url';+import { HocuspocusProvider } from '@hocuspocus/provider';+import { SYSTEM_DOC_NAME } from '@inkeep/open-knowledge-core';+import * as Y from 'yjs';++const HELPERS_DIR = dirname(fileURLToPath(import.meta.url));+export const APP_PACKAGE_ROOT = resolve(HELPERS_DIR, '..', '..', '..');++export const VITE_E2E_SEED_DIR = join(APP_PACKAGE_ROOT, 'node_modules', '.vite-e2e-seed');++export function viteSeedIsReady(): boolean {+ return existsSync(join(VITE_E2E_SEED_DIR, 'deps', '_metadata.json'));+}++export function prepareViteCacheDir(prefix: string): string {+ mkdirSync(join(APP_PACKAGE_ROOT, 'node_modules'), { recursive: true });+ const dir = mkdtempSync(join(APP_PACKAGE_ROOT, 'node_modules', `.vite-${prefix}-`));+ if (viteSeedIsReady()) {+ cpSync(VITE_E2E_SEED_DIR, dir, { recursive: true, force: true });+ }+ return dir;+}++export interface ServerLog {+ path: string;+ fd: number;+}++export function openServerLog(label: string): ServerLog {+ const path = join(+ tmpdir(),+ `ok-e2e-${label}-${process.pid}-${Math.random().toString(36).slice(2, 8)}.log`,+ );+ return { path, fd: openSync(path, 'w') };+}++export function closeServerLog(log: ServerLog): void {+ try {+ closeSync(log.fd);+ } catch {}+}++export function tailServerLog(log: ServerLog, lines = 40): string {+ try {+ const content = readFileSync(log.path, 'utf-8');+ return content.split('\n').slice(-lines).join('\n');+ } catch {+ return '(server log unreadable)';+ }+}++export async function checkCollabSync(port: number, timeoutMs = 10_000): Promise<void> {+ const doc = new Y.Doc();+ const provider = new HocuspocusProvider({+ url: `ws://localhost:${port}/collab`,+ name: SYSTEM_DOC_NAME,+ document: doc,+ connect: false,+ });+ try {+ await new Promise<void>((resolve, reject) => {+ const timer = setTimeout(() => {+ reject(new Error(`/collab sync round-trip did not complete within ${timeoutMs}ms`));+ }, timeoutMs);+ provider.on('synced', () => {+ clearTimeout(timer);+ resolve();+ });+ provider.connect();+ });+ } finally {+ try {+ provider.destroy();+ } catch {}+ try {+ doc.destroy();+ } catch {}+ }+}export async function getFreePort(): Promise<number> {return new Promise((resolve, reject) => {diff --git a/packages/app/tests/stress/agent-activity-panel.e2e.ts b/packages/app/tests/stress/agent-activity-panel.e2e.tsindex eb5d7474a..f58e80fdd 100644--- a/packages/app/tests/stress/agent-activity-panel.e2e.ts+++ b/packages/app/tests/stress/agent-activity-panel.e2e.ts@@ -24,20 +24,19 @@ test.describe('Activity mode (DocPanel) — avatar drill-in, back-arrow exit', (const claude = agentId('claude-t1');await api.writeAsAgent(docA, '# Claude wrote to A', {agentId: claude,- agentName: 'Claude',+ agentName: 'Claude T1',clientName: 'claude-code',});await api.writeAsAgent(docB, '# Claude also wrote to B', {agentId: claude,- agentName: 'Claude',+ agentName: 'Claude T1',clientName: 'claude-code',});const bar = page.locator('[data-slot="presence-bar"]');const claudeAvatar = bar- .locator('[data-presence-badge="agent"]')- .filter({ has: page.locator('[aria-label*="Claude"]') })+ .locator('[data-presence-badge="agent"][aria-label*="Claude T1"]').first();await expect(claudeAvatar).toBeVisible({ timeout: 10_000 });await claudeAvatar.click();@@ -76,13 +75,12 @@ test.describe('Activity mode (DocPanel) — avatar drill-in, back-arrow exit', (const claude = agentId('claude-t2');await api.writeAsAgent(docAgent, '# Claude', {agentId: claude,- agentName: 'Claude',+ agentName: 'Claude T2',clientName: 'claude-code',});const claudeAvatar = page- .locator('[data-slot="presence-bar"] [data-presence-badge="agent"]')- .filter({ has: page.locator('[aria-label*="Claude"]') })+ .locator('[data-slot="presence-bar"] [data-presence-badge="agent"][aria-label*="Claude T2"]').first();await expect(claudeAvatar).toBeVisible({ timeout: 10_000 });@@ -114,13 +112,12 @@ test.describe('Activity mode (DocPanel) — avatar drill-in, back-arrow exit', (const claude = agentId('claude-t3');await api.writeAsAgent(docAgent, '# Claude', {agentId: claude,- agentName: 'Claude',+ agentName: 'Claude T3',clientName: 'claude-code',});const claudeAvatar = page- .locator('[data-slot="presence-bar"] [data-presence-badge="agent"]')- .filter({ has: page.locator('[aria-label*="Claude"]') })+ .locator('[data-slot="presence-bar"] [data-presence-badge="agent"][aria-label*="Claude T3"]').first();await expect(claudeAvatar).toBeVisible({ timeout: 10_000 });await claudeAvatar.click();@@ -151,13 +148,12 @@ test.describe('Activity mode (DocPanel) — avatar drill-in, back-arrow exit', (const claude = agentId('claude-t6');await api.writeAsAgent(docTarget, '# Claude wrote target', {agentId: claude,- agentName: 'Claude',+ agentName: 'Claude T6',clientName: 'claude-code',});const claudeAvatar = page- .locator('[data-slot="presence-bar"] [data-presence-badge="agent"]')- .filter({ has: page.locator('[aria-label*="Claude"]') })+ .locator('[data-slot="presence-bar"] [data-presence-badge="agent"][aria-label*="Claude T6"]').first();await expect(claudeAvatar).toBeVisible({ timeout: 10_000 });await claudeAvatar.click();@@ -196,16 +192,16 @@ test.describe('Activity mode (DocPanel) — avatar drill-in, back-arrow exit', (const claude = agentId('claude-t7');await api.writeAsAgent(docAgent, '# Claude wrote burst 1', {agentId: claude,- agentName: 'Claude',+ agentName: 'Claude T7',clientName: 'claude-code',});const urlBefore = page.url();const claudeAvatar = page- .locator('[data-slot="presence-bar"] [data-presence-badge="agent"]')- .filter({ has: page.locator('[aria-label*="Claude"]') })+ .locator('[data-slot="presence-bar"] [data-presence-badge="agent"][aria-label*="Claude T7"]').first();+ await expect(claudeAvatar).toBeVisible({ timeout: 10_000 });await claudeAvatar.click();const panel = page.locator('[data-testid="activity-panel"]');await expect(panel).toBeVisible({ timeout: 5_000 });diff --git a/packages/app/tests/stress/asset-click-dispatch.e2e.ts b/packages/app/tests/stress/asset-click-dispatch.e2e.tsindex 1eca592ff..c23fa90c9 100644--- a/packages/app/tests/stress/asset-click-dispatch.e2e.ts+++ b/packages/app/tests/stress/asset-click-dispatch.e2e.ts@@ -182,27 +182,11 @@ test.describe('asset-click dispatcher — P9 E2E scenarios (SPEC 2026-04-23)', (await expect(page.locator('[data-resolution-state="asset"]').first()).toBeVisible({timeout: 10_000,});- await page.evaluate(() => {- const w = window as typeof window & { __assetOpenCalls?: string[] };- const originalOpen = window.open.bind(window);- w.__assetOpenCalls = [];- window.open = ((url?: string | URL, target?: string, features?: string) => {- w.__assetOpenCalls?.push(String(url ?? ''));- return originalOpen(url, target, features);- }) as typeof window.open;- });-const [newPage] = await Promise.all([context.waitForEvent('page', { timeout: 5_000 }),page.click('span[data-link]', { modifiers: ['Meta'] }),]);- await expect- .poll(async () =>- page.evaluate(() => {- return (window as typeof window & { __assetOpenCalls?: string[] }).__assetOpenCalls ?? [];- }),- )- .toContain('./guide.html');+ await newPage.waitForURL('**/guide.html', { timeout: 10_000 });await newPage.close();});diff --git a/packages/app/tests/stress/docs-open.e2e.ts b/packages/app/tests/stress/docs-open.e2e.tsindex 02a6be61d..c32b68ba4 100644--- a/packages/app/tests/stress/docs-open.e2e.ts+++ b/packages/app/tests/stress/docs-open.e2e.ts@@ -660,7 +660,7 @@ test.describe('docs-open — hybrid navigation UX', () => {await waitForActiveProviderSynced(page);await expect(page.getByText('Content rendered from a .mdx file')).toBeVisible({- timeout: 10_000,+ timeout: 30_000,});await expect(page.getByRole('main').getByRole('button', { name: `${docName}.mdx`, exact: true }),diff --git a/packages/app/tests/stress/editor-tabs.e2e.ts b/packages/app/tests/stress/editor-tabs.e2e.tsindex d3d98ed07..2c2697399 100644--- a/packages/app/tests/stress/editor-tabs.e2e.ts+++ b/packages/app/tests/stress/editor-tabs.e2e.ts@@ -2,7 +2,14 @@ import { randomUUID } from 'node:crypto';import { readdirSync, rmSync, writeFileSync } from 'node:fs';import { join } from 'node:path';import type { Locator, Page } from '@playwright/test';-import { type ApiHelpers, createPngBuffer, expect, test, type WorkerServer } from './_helpers';+import {+ type ApiHelpers,+ createPngBuffer,+ expect,+ REQUIRED_FIXTURE_ENTRY_NAMES,+ test,+ type WorkerServer,+} from './_helpers';function testId(): string {return randomUUID().slice(0, 8);@@ -52,6 +59,7 @@ async function deletePathIfExists(async function clearVisibleContentEntries(workerServer: WorkerServer): Promise<void> {for (const entry of readdirSync(workerServer.contentDir, { withFileTypes: true })) {if (entry.name.startsWith('.')) continue;+ if ((REQUIRED_FIXTURE_ENTRY_NAMES as readonly string[]).includes(entry.name)) continue;if (entry.isDirectory()) {await deletePathIfExists(workerServer.baseURL, 'folder', entry.name);continue;@@ -295,13 +303,18 @@ test.describe('Editor tabs', () => {await expect(sidebarItem).not.toHaveAttribute('aria-selected', 'true');});- test('sidebar click fills the active third new tab in place', async ({ page, api }) => {+ test('sidebar click fills the active third new tab in place', async ({+ page,+ api,+ workerServer,+ }) => {const id = testId();const firstDoc = `new-tab-fill-first-${id}`;const selectedDoc = `new-tab-fill-selected-${id}`;const firstLabel = `${firstDoc}.md`;const selectedLabel = `${selectedDoc}.md`;+ await clearVisibleContentEntries(workerServer);await seedMarkdownDocs(api, [{ name: firstDoc, markdown: `# First ${id}` },{ name: selectedDoc, markdown: `# Selected ${id}` },@@ -336,6 +349,7 @@ test.describe('Editor tabs', () => {test('sidebar folder click replaces the active file tab with the folder tab', async ({page,api,+ workerServer,}) => {const id = testId();const fileDoc = `folder-click-file-${id}`;@@ -344,6 +358,7 @@ test.describe('Editor tabs', () => {const fileLabel = `${fileDoc}.md`;const folderLabel = `${folder}/`;+ await clearVisibleContentEntries(workerServer);await seedMarkdownDocs(api, [{ name: fileDoc, markdown: `# File ${id}` },{ name: nestedDoc, markdown: `# Nested ${id}` },@@ -373,6 +388,7 @@ test.describe('Editor tabs', () => {const docLabel = `${docName}.md`;const assetPath = `asset-tab-${id}.png`;+ await clearVisibleContentEntries(workerServer);await seedReferencedAssetDoc(api, workerServer, docName, assetPath);await page.goto(`/#/${docName}`);@@ -628,6 +644,7 @@ test.describe('Editor tabs', () => {test('tab click selects the already-open foo.md tab without rewriting the bar.md tab', async ({page,api,+ workerServer,}) => {const id = testId();const fooDoc = `foo-click-${id}`;@@ -635,6 +652,7 @@ test.describe('Editor tabs', () => {const fooLabel = `${fooDoc}.md`;const barLabel = `${barDoc}.md`;+ await clearVisibleContentEntries(workerServer);await seedMarkdownDocs(api, [{ name: fooDoc, markdown: `# Foo Click ${id}` },{ name: barDoc, markdown: `# Bar Click ${id}` },diff --git a/packages/app/tests/stress/file-tree-create.e2e.ts b/packages/app/tests/stress/file-tree-create.e2e.tsindex a25f65000..a6392ba4d 100644--- a/packages/app/tests/stress/file-tree-create.e2e.ts+++ b/packages/app/tests/stress/file-tree-create.e2e.ts@@ -317,10 +317,15 @@ test.describe('FileTree sidebar create', () => {await page.goto('/#/zz-bulk-delete-a');await page.waitForLoadState('domcontentloaded');+ await expect(+ page.locator('[data-slot="sidebar-container"]').getByRole('treeitem').first(),+ ).toBeVisible({ timeout: 30_000 });+const firstItem = await visibleSidebarItemByPath(page, 'zz-bulk-delete-a.md');const secondItem = await visibleSidebarItemByPath(page, 'zz-bulk-delete-b.md');await firstItem.click();+ await expect(firstItem).toHaveAttribute('aria-selected', 'true');await secondItem.click({modifiers: [process.platform === 'darwin' ? 'Meta' : 'Control'],});@@ -761,16 +766,16 @@ test.describe('FileTree sidebar create', () => {await expect(page).toHaveURL(new RegExp(`#/${name}$`));await folderItem.click();+ await expect(page).toHaveURL(new RegExp(`#/${name}/$`));await expect(activeEditorTabButton(page, `${name}/`)).toBeVisible({timeout: 10_000,});- await expect(page).toHaveURL(new RegExp(`#/${name}/$`));await fileItem.click();+ await expect(page).toHaveURL(new RegExp(`#/${name}$`));await expect(activeEditorTabButton(page, `${name}.md`)).toBeVisible({timeout: 10_000,});- await expect(page).toHaveURL(new RegExp(`#/${name}$`));expect(existsSync(join(workerServer.contentDir, name))).toBe(true);expect(statSync(join(workerServer.contentDir, name)).isDirectory()).toBe(true);diff --git a/packages/app/tests/stress/init-load-byte-stable.e2e.ts b/packages/app/tests/stress/init-load-byte-stable.e2e.tsindex 9d2fe7fc2..f17e1e8dd 100644--- a/packages/app/tests/stress/init-load-byte-stable.e2e.ts+++ b/packages/app/tests/stress/init-load-byte-stable.e2e.ts@@ -13,8 +13,13 @@ import {snapshotMarkdownOnly,} from '../integration/_fixtures/init-load-byte-stable-snapshot.ts';import {+ checkCollabSync,+ closeServerLog,getFreePort,killGracefully,+ openServerLog,+ prepareViteCacheDir,+ tailServerLog,waitForActiveProviderSynced,waitForHttpReady,} from './_helpers';@@ -48,31 +53,47 @@ const test = base.extend<{ okFixture: OkFixture }>({});const baseURL = `http://localhost:${port}`;+ const viteCacheDir = prepareViteCacheDir('init-load');+ const serverLog = openServerLog('init-load');const proc = spawn('bun', ['run', '--silent', 'dev'], {cwd: APP_PACKAGE_ROOT,env: {...process.env,VITE_PORT: String(port),OK_TEST_CONTENT_DIR: contentDir,+ OK_TEST_VITE_CACHE_DIR: viteCacheDir,+ OK_TEST_SKIP_I18N_COMPILE: '1',NO_COLOR: process.env.NO_COLOR ?? '1',},- stdio: ['ignore', 'ignore', 'inherit'],+ stdio: ['ignore', serverLog.fd, 'inherit'],});try {await Promise.race([- waitForHttpReady(baseURL, 60_000),+ (async () => {+ await waitForHttpReady(baseURL, 60_000);+ await checkCollabSync(port);+ })(),new Promise<never>((_, reject) => {proc.once('error', (err) => reject(err));proc.once('exit', (code, signal) => {- if (code !== 0 && code !== null)- reject(new Error(`dev server exited early: code=${code} signal=${signal}`));+ if (code !== null)+ reject(+ new Error(+ `dev server exited early: code=${code} signal=${signal}\n--- dev server log tail (${serverLog.path}) ---\n${tailServerLog(serverLog)}`,+ ),+ );});}),]);} catch (err) {- await killGracefully(proc);- rmSync(contentDir, { recursive: true, force: true });+ try {+ await killGracefully(proc);+ } finally {+ closeServerLog(serverLog);+ rmSync(contentDir, { recursive: true, force: true });+ rmSync(viteCacheDir, { recursive: true, force: true });+ }throw err;}@@ -82,7 +103,10 @@ const test = base.extend<{ okFixture: OkFixture }>({try {await killGracefully(proc);} finally {+ closeServerLog(serverLog);+ rmSync(serverLog.path, { force: true });rmSync(contentDir, { recursive: true, force: true });+ rmSync(viteCacheDir, { recursive: true, force: true });}}},diff --git a/packages/app/tests/stress/multi-agent-presence.e2e.ts b/packages/app/tests/stress/multi-agent-presence.e2e.tsindex 17f5d376a..f32ec3a5e 100644--- a/packages/app/tests/stress/multi-agent-presence.e2e.ts+++ b/packages/app/tests/stress/multi-agent-presence.e2e.ts@@ -122,6 +122,11 @@ test.describe('multi-agent presence — sectioned PresenceBar (FR-9)', () => {{ hasText: '' },);await expect(crossDocAvatar.first()).toBeVisible({ timeout: 10_000 });+ await api.writeAsAgent(docBar, '# Cursor on bar', {+ agentId: agentId('cursor-nav-bar'),+ agentName: 'Cursor',+ clientName: 'cursor',+ });await crossDocAvatar.first().click();const panel = page.locator('[data-testid="activity-panel"]');@@ -154,9 +159,14 @@ test.describe('multi-agent presence — sectioned PresenceBar (FR-9)', () => {'[data-presence-section="crossdoc"] [data-presence-badge="agent"][data-presence-crossdoc="true"]',);await expect(crossDocAvatar.first()).toBeVisible({ timeout: 10_000 });+ await api.writeAsAgent(docBar, '# Cursor on bar', {+ agentId: agentId('cursor-nodoc-bar'),+ agentName: 'Cursor',+ clientName: 'cursor',+ });await crossDocAvatar.first().click();- await expect(panel).toBeVisible({ timeout: 10_000 });await expect.poll(() => page.url()).toContain(`#/${docBar}`);+ await expect(panel).toBeVisible({ timeout: 10_000 });});});diff --git a/packages/app/tests/stress/new-file-cross-doc-bleed.e2e.ts b/packages/app/tests/stress/new-file-cross-doc-bleed.e2e.tsindex 5f523b551..43fd874de 100644--- a/packages/app/tests/stress/new-file-cross-doc-bleed.e2e.ts+++ b/packages/app/tests/stress/new-file-cross-doc-bleed.e2e.ts@@ -3,11 +3,18 @@ import type { Locator, Page } from '@playwright/test';import { expect, test, waitForActiveProviderSynced } from './_helpers';async function yieldFramesInPage(page: Page): Promise<void> {- await page.evaluate(- () =>- new Promise<void>((resolve) => {- requestAnimationFrame(() => requestAnimationFrame(() => resolve()));- }),+ await page.waitForFunction(+ () => {+ const w = window as typeof window & { __okYieldFrameCount?: number };+ w.__okYieldFrameCount = (w.__okYieldFrameCount ?? 0) + 1;+ if (w.__okYieldFrameCount >= 3) {+ w.__okYieldFrameCount = 0;+ return true;+ }+ return false;+ },+ null,+ { polling: 'raf', timeout: 10_000 },);}diff --git a/packages/app/tests/stress/ng7-rapid-nav-coherence.e2e.ts b/packages/app/tests/stress/ng7-rapid-nav-coherence.e2e.tsindex f04bce8f4..c64dad1f8 100644--- a/packages/app/tests/stress/ng7-rapid-nav-coherence.e2e.ts+++ b/packages/app/tests/stress/ng7-rapid-nav-coherence.e2e.ts@@ -24,6 +24,8 @@ test.describe('NG7 Pattern D — rapid-nav coherence', () => {const aRow = page.getByRole('treeitem', { name: `${docA}.md`, exact: true });const bRow = page.getByRole('treeitem', { name: `${docB}.md`, exact: true });+ await expect(aRow).toBeVisible({ timeout: 30_000 });+ await expect(bRow).toBeVisible({ timeout: 30_000 });const navStartTime = await page.evaluate(() => performance.now());await aRow.click({ timeout: 10_000 });await bRow.click({ timeout: 10_000 });@@ -43,6 +45,26 @@ test.describe('NG7 Pattern D — rapid-nav coherence', () => {expect(totalPmCount).toBeLessThanOrEqual(3);expect(totalPmCount).toBeGreaterThanOrEqual(1);+ await page.waitForFunction(+ ({ targetDoc, since }) => {+ const isMountSettle = (entry: PerformanceEntry) =>+ entry.name === 'ok/mount/resolve' ||+ entry.name === 'ok/mount/reject' ||+ entry.name === 'ok/cache/hit';+ return performance+ .getEntriesByType('measure')+ .filter(isMountSettle)+ .filter((m) => m.startTime >= since)+ .some((m) => {+ const detail = (m as unknown as { detail?: { devtools?: { properties?: unknown } } })+ .detail;+ const props = (detail?.devtools?.properties ?? []) as Array<[string, string]>;+ return props.find(([k]) => k === 'docName')?.[1] === targetDoc;+ });+ },+ { targetDoc: docA, since: navStartTime },+ { timeout: 30_000 },+ );const aSettleMarks = await page.evaluate(({ targetDoc, since }) => {const isMountSettle = (entry: PerformanceEntry) =>diff --git a/packages/app/tests/stress/selection-indicator.e2e.ts b/packages/app/tests/stress/selection-indicator.e2e.tsindex 916e55fdb..198990419 100644--- a/packages/app/tests/stress/selection-indicator.e2e.ts+++ b/packages/app/tests/stress/selection-indicator.e2e.ts@@ -88,12 +88,16 @@ test('S1c: ArrowDown into compound Callout descends into body (no NodeSelect)',await page.waitForSelector('.jsx-component-wrapper[data-component-type="callout"]');await page.locator('.ProseMirror h1').first().click();+ await focusEditor(page);+ await waitForPmSelectionInNode(page, 'heading');await page.keyboard.press('End');await page.keyboard.press('ArrowDown');await expect(page.locator('.jsx-component-wrapper[data-selected="true"]')).toHaveCount(0);+ await waitForPmSelectionInNode(page, 'jsxComponent');+const insideBody = await page.evaluate(() => {const editor = window.__activeEditor;if (!editor) return false;@@ -252,8 +256,7 @@ test('S3: nested Callout/Accordion — only innermost paints halo', async ({ pagconst outerDataSelected = await outerCallout.getAttribute('data-selected');expect(outerDataSelected).toBeNull();- const selectedCount = await page.locator('[data-selected="true"]').count();- expect(selectedCount).toBe(1);+ await expect(page.locator('[data-selected="true"]')).toHaveCount(1);});test('S3b: outer-NodeSelection on Callout with nested Accordion — only outer paints halo', async ({@@ -276,8 +279,7 @@ test('S3b: outer-NodeSelection on Callout with nested Accordion — only outer pconst innerDataSelected = await innerAccordion.getAttribute('data-selected');expect(innerDataSelected).toBeNull();- const selectedCount = await page.locator('[data-selected="true"]').count();- expect(selectedCount).toBe(1);+ await expect(page.locator('[data-selected="true"]')).toHaveCount(1);});test('S4: dragstart/dragend toggles data-dragging', async ({ page, api }) => {diff --git a/packages/app/tests/stress/sidebar-search-pill.e2e.ts b/packages/app/tests/stress/sidebar-search-pill.e2e.tsindex 8234929d9..cc95be923 100644--- a/packages/app/tests/stress/sidebar-search-pill.e2e.ts+++ b/packages/app/tests/stress/sidebar-search-pill.e2e.ts@@ -109,7 +109,7 @@ test.describe('sidebar-search-pill — discovery, click, keyboard, semantics', (await page.goto('/#/q002');await page.waitForSelector('[role="treeitem"]', { timeout: 15_000 });- expect(await cmdkRoot(page).count()).toBe(0);+ await expect(cmdkRoot(page)).toHaveCount(0);await pill(page).click();await expect(cmdkRoot(page)).toBeVisible({ timeout: 2_000 });@@ -214,7 +214,7 @@ test.describe('sidebar-search-pill — discovery, click, keyboard, semantics', (});const searchInsideHeader = sidebarHeader(page).getByRole('button', { name: 'Search' });- expect(await searchInsideHeader.count()).toBe(0);+ await expect(searchInsideHeader).toHaveCount(0);await expect(sidebarHeader(page).getByRole('button', { name: 'Tree View Options' }),@@ -236,7 +236,7 @@ test.describe('sidebar-search-pill — discovery, click, keyboard, semantics', (await page.waitForSelector('[role="treeitem"]', { timeout: 15_000 });const matchingPills = page.getByRole('button', { name: /^Search/ });- expect(await matchingPills.count()).toBe(1);+ await expect(matchingPills).toHaveCount(1);const ariaLabel = await pill(page).getAttribute('aria-label');expect(ariaLabel).toBeNull();diff --git a/packages/app/tests/stress/single-file-ephemeral.e2e.ts b/packages/app/tests/stress/single-file-ephemeral.e2e.tsindex 4946fd47b..0194df592 100644--- a/packages/app/tests/stress/single-file-ephemeral.e2e.ts+++ b/packages/app/tests/stress/single-file-ephemeral.e2e.ts@@ -13,8 +13,13 @@ import {snapshotMarkdownOnly,} from '../integration/_fixtures/init-load-byte-stable-snapshot.ts';import {+ checkCollabSync,+ closeServerLog,getFreePort,killGracefully,+ openServerLog,+ prepareViteCacheDir,+ tailServerLog,waitForActiveProviderSynced,waitForHttpReady,} from './_helpers';@@ -51,34 +56,50 @@ const test = base.extend<{ ephemeral: EphemeralFixture }>({const projectDir = createEphemeralProjectDir(notesDir);const baseURL = `http://localhost:${port}`;+ const viteCacheDir = prepareViteCacheDir('sf-ephemeral');+ const serverLog = openServerLog('sf-ephemeral');const proc = spawn('bun', ['run', '--silent', 'dev'], {cwd: APP_PACKAGE_ROOT,env: {...process.env,VITE_PORT: String(port),OK_TEST_CONTENT_DIR: notesDir,+ OK_TEST_VITE_CACHE_DIR: viteCacheDir,+ OK_TEST_SKIP_I18N_COMPILE: '1',OK_TEST_SINGLE_DOC_REL_PATH: FILE_NAME,OK_TEST_PROJECT_DIR: projectDir,NO_COLOR: process.env.NO_COLOR ?? '1',},- stdio: ['ignore', 'ignore', 'inherit'],+ stdio: ['ignore', serverLog.fd, 'inherit'],});try {await Promise.race([- waitForHttpReady(baseURL, 60_000),+ (async () => {+ await waitForHttpReady(baseURL, 60_000);+ await checkCollabSync(port);+ })(),new Promise<never>((_, reject) => {proc.once('error', (err) => reject(err));proc.once('exit', (code, signal) => {- if (code !== 0 && code !== null)- reject(new Error(`dev server exited early: code=${code} signal=${signal}`));+ if (code !== null)+ reject(+ new Error(+ `dev server exited early: code=${code} signal=${signal}\n--- dev server log tail (${serverLog.path}) ---\n${tailServerLog(serverLog)}`,+ ),+ );});}),]);} catch (err) {- await killGracefully(proc);- rmSync(userDir, { recursive: true, force: true });- rmSync(projectDir, { recursive: true, force: true });+ try {+ await killGracefully(proc);+ } finally {+ closeServerLog(serverLog);+ rmSync(userDir, { recursive: true, force: true });+ rmSync(projectDir, { recursive: true, force: true });+ rmSync(viteCacheDir, { recursive: true, force: true });+ }throw err;}@@ -88,8 +109,11 @@ const test = base.extend<{ ephemeral: EphemeralFixture }>({try {await killGracefully(proc);} finally {+ closeServerLog(serverLog);+ rmSync(serverLog.path, { force: true });rmSync(userDir, { recursive: true, force: true });rmSync(projectDir, { recursive: true, force: true });+ rmSync(viteCacheDir, { recursive: true, force: true });}}},diff --git a/packages/app/vite.config.ts b/packages/app/vite.config.tsindex 22022211b..f8f1397d5 100644--- a/packages/app/vite.config.ts+++ b/packages/app/vite.config.ts@@ -17,6 +17,9 @@ const viteCacheDir = process.env.OK_TEST_VITE_CACHE_DIR;export default defineConfig({base: './',cacheDir: viteCacheDir,+ optimizeDeps: {+ entries: ['index.html'],+ },plugins: [rejectionLoopGuardPlugin(),chromeTokensVitePlugin(),