Beautiful, AI-native markdown IDE and LLM wiki
TypeScript 2nd-brainagent-skillsclaudecodexcompany-braindocsknowledge-knowledge-baseknowledge-managementllmllm-wikillm-wiki-karpathymarkdownmarkdown-editormdmdxnotespkmsecond-brainskills
Show preparing state instead of false search failure on cold load (#2020)
Andrew Mikofalvydcdb62dbe70b
diff --git a/.changeset/search-coldload-preparing-state.md b/.changeset/search-coldload-preparing-state.mdnew file mode 100644index 000000000..b9e052d35--- /dev/null+++ b/.changeset/search-coldload-preparing-state.md@@ -0,0 +1,7 @@+---+"@inkeep/open-knowledge": patch+---++Stop the command palette from showing a false "Search failed." right after a project opens.++When you opened a project and searched immediately, the body-text search could fire before the workspace had finished loading and lose the race with the palette's request timeout, surfacing "Search failed." even though nothing was wrong. The palette now waits for the page list to finish its initial load before running the server search, and shows a "Preparing search" status in that window instead. Once the page list is ready the search runs automatically, and file- and folder-name matching is available as soon as the list has loaded.diff --git a/packages/app/src/components/CommandPalette.dom.test.tsx b/packages/app/src/components/CommandPalette.dom.test.tsxindex 012e8d720..f5ca75d96 100644--- a/packages/app/src/components/CommandPalette.dom.test.tsx+++ b/packages/app/src/components/CommandPalette.dom.test.tsx@@ -39,6 +39,7 @@ const installedAgentStates = {cursor: { installed: false },};const workspaceValue = { rootPath: '/workspace' };+let pageListLoading = false;mock.module('@lingui/react/macro', () => ({Trans: ({ children }: { children?: ReactNode }) => <>{children}</>,@@ -142,6 +143,8 @@ mock.module('@/components/PageListContext', () => ({pageTitles: new Map<string, string>(),pageMeta: new Map<string, unknown>(),folderPaths: new Set<string>(),+ filePaths: new Set<string>(),+ loading: pageListLoading,}),}));@@ -236,6 +239,7 @@ describe('CommandPalette DOM behavior', () => {cleanup();activeDocName = 'docs/active';activeTarget = { kind: 'doc', docName: 'docs/active' };+ pageListLoading = false;requestDocPanelTabCalls = [];seedDialogProps = [];newItemDialogProps = [];@@ -371,6 +375,59 @@ describe('CommandPalette DOM behavior', () => {expect(commandDialogProps.at(-1)?.transition).toBeUndefined();expect(commandDialogProps.at(-1)?.placement).toBeUndefined();});++ test('during cold load, a typed query shows a preparing state and never fires the body search', async () => {+ pageListLoading = true;+ await renderPalette({ bridge: null });++ await setQuery('rename');++ await waitFor(() =>+ expect(screen.getByTestId('command-palette-search-preparing')).not.toBeNull(),+ );+ expect(screen.queryByText('Search failed.')).toBeNull();+ expect(screen.queryByText('No matching commands.')).toBeNull();++ const fetchMock = globalThis.fetch as unknown as { mock: { calls: unknown[][] } };+ expect(fetchMock.mock.calls.some((call) => call[0] === '/api/search')).toBe(false);+ });++ test('once the page list has loaded, a typed query fires the body search with no preparing state', async () => {+ await renderPalette({ bridge: null });++ await setQuery('rename');++ await waitFor(() => {+ const fetchMock = globalThis.fetch as unknown as { mock: { calls: unknown[][] } };+ expect(fetchMock.mock.calls.some((call) => call[0] === '/api/search')).toBe(true);+ });+ expect(screen.queryByTestId('command-palette-search-preparing')).toBeNull();+ });++ test('a query typed during cold load auto-fires the body search once the page list loads', async () => {+ pageListLoading = true;+ const { CommandPalette } = await import('./CommandPalette');+ const onOpenChange = mock(() => {});+ const { rerender } = render(+ <CommandPalette bridge={null} open={true} onOpenChange={onOpenChange} />,+ );+ await waitFor(() => expect(screen.getByRole('dialog')).not.toBeNull());++ await setQuery('rename');+ await waitFor(() =>+ expect(screen.getByTestId('command-palette-search-preparing')).not.toBeNull(),+ );+ const fetchMock = globalThis.fetch as unknown as { mock: { calls: unknown[][] } };+ expect(fetchMock.mock.calls.some((call) => call[0] === '/api/search')).toBe(false);++ pageListLoading = false;+ rerender(<CommandPalette bridge={null} open={true} onOpenChange={onOpenChange} />);++ await waitFor(() =>+ expect(fetchMock.mock.calls.some((call) => call[0] === '/api/search')).toBe(true),+ );+ expect(screen.queryByTestId('command-palette-search-preparing')).toBeNull();+ });});describe('NavigationItem path subtitle', () => {diff --git a/packages/app/src/components/CommandPalette.tsx b/packages/app/src/components/CommandPalette.tsxindex e9a3a14d4..a6754a77c 100644--- a/packages/app/src/components/CommandPalette.tsx+++ b/packages/app/src/components/CommandPalette.tsx@@ -258,7 +258,14 @@ export function CommandPalette({ bridge = null, open, onOpenChange }: CommandPalconst semanticAbortRef = useRef<AbortController | null>(null);const semanticTimerRef = useRef<number | null>(null);const { activeDocName, activeTarget } = useDocumentContext();- const { pages, pageTitles, pageMeta, folderPaths, filePaths } = usePageList();+ const {+ pages,+ pageTitles,+ pageMeta,+ folderPaths,+ filePaths,+ loading: pagesLoading,+ } = usePageList();const workspace = useWorkspace();const { states: installStates, refresh: refreshInstallStates } = useInstalledAgents();const { dispatch: dispatchHandoff } = useHandoffDispatch();@@ -419,7 +426,7 @@ export function CommandPalette({ bridge = null, open, onOpenChange }: CommandPal}, [open, tagDocsTarget]);useEffect(() => {- if (!open || !trimmedDeferredQuery || inExclusiveMode) {+ if (!open || !trimmedDeferredQuery || inExclusiveMode || pagesLoading) {setSearchResults([]);setSearchStatus('idle');setSearchTruncated(false);@@ -456,7 +463,7 @@ export function CommandPalette({ bridge = null, open, onOpenChange }: CommandPalwindow.clearTimeout(timeout);controller.abort();};- }, [open, trimmedDeferredQuery, inExclusiveMode]);+ }, [open, trimmedDeferredQuery, inExclusiveMode, pagesLoading]);const runAction = (fn: () => Promise<void> | void, fallback = t`Command failed.`) => {onOpenChange(false);@@ -495,6 +502,8 @@ export function CommandPalette({ bridge = null, open, onOpenChange }: CommandPaltrimmedDeferredQuery !== '' &&searchStatus === 'loading' &&!showNavigation;+ const showSearchPreparing =+ !inExclusiveMode && trimmedDeferredQuery !== '' && pagesLoading && !showNavigation;const showCreateFile =!inExclusiveMode && matchesCommandQuery(t`New file`, deferredQuery, ['create file']);const showCreateFolder =@@ -568,6 +577,7 @@ export function CommandPalette({ bridge = null, open, onOpenChange }: CommandPalshowRecentNavigation ||showNavigation ||showSearchLoading ||+ showSearchPreparing ||showCreateFile ||showCreateFolder ||showGraphCommand ||@@ -613,6 +623,7 @@ export function CommandPalette({ bridge = null, open, onOpenChange }: CommandPalfunction fireSemanticSearch(raw: string) {const q = raw.trim();if (!q) return;+ if (pagesLoading) return;semanticAbortRef.current?.abort();if (semanticTimerRef.current !== null) window.clearTimeout(semanticTimerRef.current);const controller = new AbortController();@@ -846,6 +857,17 @@ export function CommandPalette({ bridge = null, open, onOpenChange }: CommandPal) : null}</>) : null}+ {showSearchPreparing ? (+ <div+ className="flex items-center justify-center gap-2 py-6 text-muted-foreground text-sm"+ role="status"+ aria-live="polite"+ data-testid="command-palette-search-preparing"+ >+ <Loader2 className="size-4 animate-spin" />+ <Trans>Preparing search</Trans>+ </div>+ ) : null}{showSearchLoading && !showNavigation ? (<CommandEmpty><Trans>Searching</Trans>diff --git a/packages/app/src/locales/en/messages.json b/packages/app/src/locales/en/messages.jsonindex b26514506..efecfd76b 100644--- a/packages/app/src/locales/en/messages.json+++ b/packages/app/src/locales/en/messages.json@@ -1895,6 +1895,7 @@]],"yHikCO": ["Open CodeMirror's go-to-line prompt."],+ "yIPXut": ["Preparing search"],"yKu_3Y": ["Restore"],"yLq4w4": ["Separator"],"yMgL_E": ["Find field navigation"],diff --git a/packages/app/src/locales/en/messages.po b/packages/app/src/locales/en/messages.poindex d215e1fcf..4967704a1 100644--- a/packages/app/src/locales/en/messages.po+++ b/packages/app/src/locales/en/messages.po@@ -4312,6 +4312,10 @@ msgstr "Plain"msgid "Preferences"msgstr "Preferences"+#: src/components/CommandPalette.tsx+msgid "Preparing search"+msgstr "Preparing search"+#: src/components/PublishToGitHubDialog.tsxmsgid "Preparing share URL..."msgstr "Preparing share URL..."diff --git a/packages/app/src/locales/pseudo/messages.json b/packages/app/src/locales/pseudo/messages.jsonindex baaede039..1ccb6bc83 100644--- a/packages/app/src/locales/pseudo/messages.json+++ b/packages/app/src/locales/pseudo/messages.json@@ -1895,6 +1895,7 @@]],"yHikCO": ["Ōƥēń ĆōďēḾĩŕŕōŕ'ś ĝō-ţō-ĺĩńē ƥŕōḿƥţ."],+ "yIPXut": ["Ƥŕēƥàŕĩńĝ śēàŕćĥ"],"yKu_3Y": ["Ŕēśţōŕē"],"yLq4w4": ["Śēƥàŕàţōŕ"],"yMgL_E": ["Ƒĩńď ƒĩēĺď ńàvĩĝàţĩōń"],diff --git a/packages/app/src/locales/pseudo/messages.po b/packages/app/src/locales/pseudo/messages.poindex 52a4f2e71..461b678cc 100644--- a/packages/app/src/locales/pseudo/messages.po+++ b/packages/app/src/locales/pseudo/messages.po@@ -4307,6 +4307,10 @@ msgstr ""msgid "Preferences"msgstr ""+#: src/components/CommandPalette.tsx+msgid "Preparing search"+msgstr ""+#: src/components/PublishToGitHubDialog.tsxmsgid "Preparing share URL..."msgstr ""