Beautiful, AI-native markdown IDE and LLM wiki
TypeScript 2nd-brainagent-skillsclaudecodexcompany-braindocsknowledge-knowledge-baseknowledge-managementllmllm-wikillm-wiki-karpathymarkdownmarkdown-editormdmdxnotespkmsecond-brainskills
Fix stress test template leakage (#7278)
Nick Gomeze11d8f794979
diff --git a/packages/app/tests/stress/_helpers/boot-verdict/verdict-fixture.ts b/packages/app/tests/stress/_helpers/boot-verdict/verdict-fixture.tsindex d2ea8b9e0..1a4dc19a3 100644--- a/packages/app/tests/stress/_helpers/boot-verdict/verdict-fixture.ts+++ b/packages/app/tests/stress/_helpers/boot-verdict/verdict-fixture.ts@@ -37,6 +37,10 @@ const verdictTest = stressTest.extend({},{ scope: 'worker' },],+ // biome-ignore lint/correctness/noEmptyPattern: Playwright fixture contract+ templateInventory: async ({}, use) => {+ await use(undefined);+ },});export const bootFailureTest = verdictTest.extend({diff --git a/packages/app/tests/stress/_helpers/content-reset.ts b/packages/app/tests/stress/_helpers/content-reset.tsindex 49d793fcc..855d8a0a7 100644--- a/packages/app/tests/stress/_helpers/content-reset.ts+++ b/packages/app/tests/stress/_helpers/content-reset.ts@@ -1,7 +1,69 @@import { readdirSync, rmSync } from 'node:fs';import { join } from 'node:path';+import {+ TemplateDeleteSuccessSchema,+ TemplatesListSuccessSchema,+} from '@inkeep/open-knowledge-core/schemas/api';import { REQUIRED_FIXTURE_DOC_NAMES, REQUIRED_FIXTURE_ENTRY_NAMES } from './fixtures.ts';+async function readTemplateInventory(baseURL: string, requestTimeoutMs: number) {+ const res = await fetch(`${baseURL}/api/templates`, {+ signal: AbortSignal.timeout(requestTimeoutMs),+ });+ if (!res.ok) {+ throw new Error(`GET /api/templates failed: ${res.status} ${await res.text()}`);+ }+ let body: unknown;+ try {+ body = await res.json();+ } catch (error) {+ throw new Error(`GET /api/templates returned invalid JSON: ${String(error)}`);+ }+ const parsed = TemplatesListSuccessSchema.safeParse(body);+ if (!parsed.success) {+ throw new Error(`GET /api/templates returned an invalid response: ${parsed.error.message}`);+ }+ if (parsed.data.truncated) {+ throw new Error('GET /api/templates returned a truncated inventory');+ }+ return parsed.data.templates;+}++async function deleteTemplate(+ baseURL: string,+ folder: string,+ name: string,+ requestTimeoutMs: number,+): Promise<void> {+ const query = new URLSearchParams({ folder, name });+ const res = await fetch(`${baseURL}/api/template?${query}`, {+ method: 'DELETE',+ signal: AbortSignal.timeout(requestTimeoutMs),+ });+ if (!res.ok) {+ throw new Error(+ `DELETE /api/template failed for ${folder}/${name}: ${res.status} ${await res.text()}`,+ );+ }+ let body: unknown;+ try {+ body = await res.json();+ } catch (error) {+ throw new Error(+ `DELETE /api/template returned invalid JSON for ${folder}/${name}: ${String(error)}`,+ );+ }+ const parsed = TemplateDeleteSuccessSchema.safeParse(body);+ if (!parsed.success) {+ throw new Error(+ `DELETE /api/template returned an invalid response for ${folder}/${name}: ${parsed.error.message}`,+ );+ }+ if (!parsed.data.existed) {+ throw new Error(`DELETE /api/template made no progress for ${folder}/${name}`);+ }+}+async function deletePathIfExists(baseURL: string,kind: 'file' | 'folder',@@ -46,6 +108,24 @@ export async function resetContentToFixtureBaseline(await removeEntriesOutside(baseURL, contentDir, '', new Set(REQUIRED_FIXTURE_ENTRY_NAMES));}+export async function resetTemplateInventory(+ baseURL: string,+ requestTimeoutMs: number,+): Promise<void> {+ const templates = await readTemplateInventory(baseURL, requestTimeoutMs);+ if (templates.length === 0) return;+ for (const template of templates) {+ await deleteTemplate(baseURL, template.source_folder, template.name, requestTimeoutMs);+ }+ const remaining = await readTemplateInventory(baseURL, requestTimeoutMs);+ if (remaining.length > 0) {+ const names = remaining.map((template) => `${template.source_folder}/${template.name}`);+ throw new Error(+ `template inventory reset did not reach an empty inventory: ${names.join(', ')} remain`,+ );+ }+}+export async function resetFixtureFolders(baseURL: string, contentDir: string): Promise<void> {const preservedByFolder = new Map<string, Set<string>>();for (const docName of REQUIRED_FIXTURE_DOC_NAMES) {diff --git a/packages/app/tests/stress/_helpers/fixtures.ts b/packages/app/tests/stress/_helpers/fixtures.tsindex f45adf12c..9af2a2370 100644--- a/packages/app/tests/stress/_helpers/fixtures.ts+++ b/packages/app/tests/stress/_helpers/fixtures.ts@@ -3,7 +3,7 @@ import { tmpdir } from 'node:os';import { join } from 'node:path';import type { ProblemType } from '@inkeep/open-knowledge-core';import { test as base } from '@playwright/test';-import { resetContentToFixtureBaseline } from './content-reset.ts';+import { resetContentToFixtureBaseline, resetTemplateInventory } from './content-reset.ts';import { coverageFixture, type E2eCoverage } from './e2e-coverage/e2e-coverage.ts';import { gotoWhileLoadProgresses, requireDeadlineAt } from './load-progress.ts';import { type WorkerServing, workerServingFor } from './prebuilt/prebuilt-serving.ts';@@ -108,9 +108,11 @@ type TestFixtures = {api: ApiHelpers;serverLeaseCheck: undefined;e2eCoverage: E2eCoverage;+ templateInventory: undefined;};export const WORKER_SERVER_BUDGET_TOTAL_MS = 240_000;+const API_CALL_TIMEOUT_MS = 30_000;export const WORKER_SERVER_BUDGET_RESERVES = {apiConfig: 2_000,@@ -525,6 +527,13 @@ export const test = base.extend<TestFixtures, WorkerFixtures>({serverLease: [leaseWorkerServer, { scope: 'worker', timeout: WORKER_SERVER_BUDGET_TOTAL_MS }],serverLeaseCheck: [checkServerLease, { auto: true }],e2eCoverage: [coverageFixture, { auto: true }],+ templateInventory: [+ async ({ workerServer }, use) => {+ await resetTemplateInventory(workerServer.baseURL, API_CALL_TIMEOUT_MS);+ await use(undefined);+ },+ { auto: true },+ ],page: async ({ page, e2eCoverage }, use) => {e2eCoverage.watchContext(page.context());await e2eCoverage.watchPage(page);@@ -676,7 +685,6 @@ export const test = base.extend<TestFixtures, WorkerFixtures>({api: async ({ workerServer }, use) => {const { baseURL } = workerServer;- const API_CALL_TIMEOUT_MS = 30_000;async function post(path: string, body?: unknown): Promise<Response> {try {return await fetch(`${baseURL}${path}`, {