Beautiful, AI-native markdown IDE and LLM wiki
TypeScript 2nd-brainagent-skillsclaudecodexcompany-braindocsknowledge-knowledge-baseknowledge-managementllmllm-wikillm-wiki-karpathymarkdownmarkdown-editormdmdxnotespkmsecond-brainskills
test(graph): cover external Open link routing to OS browser (#2159)
Andrew Mikofalvye4384ea22a4e
diff --git a/packages/app/src/components/GraphPanel.external-link-open.dom.test.tsx b/packages/app/src/components/GraphPanel.external-link-open.dom.test.tsxnew file mode 100644index 000000000..a49494afc--- /dev/null+++ b/packages/app/src/components/GraphPanel.external-link-open.dom.test.tsx@@ -0,0 +1,116 @@+import { afterEach, beforeEach, describe, expect, mock, test } from 'bun:test';+import { act, cleanup, render, screen } from '@testing-library/react';+import userEvent from '@testing-library/user-event';+import type { ReactNode } from 'react';+import { TooltipProvider } from '@/components/ui/tooltip';+import { renderLinguiTemplate } from '@/test-utils/lingui-mock';++mock.module('@lingui/core/macro', () => ({+ t: renderLinguiTemplate,+}));++mock.module('@lingui/react/macro', () => ({+ Plural: ({ one }: { one: string }) => <>{one}</>,+ Trans: ({ children }: { children: ReactNode }) => <>{children}</>,+ useLingui: () => ({ t: renderLinguiTemplate }),+}));++mock.module('next-themes', () => ({+ useTheme: () => ({ resolvedTheme: 'light' }),+}));++mock.module('@/components/PageListContext', () => ({+ usePageList: () => ({+ assetPaths: new Set<string>(),+ error: null,+ folderPaths: new Set<string>(),+ loading: false,+ pages: new Set<string>(['docs/Active']),+ pagesBySlug: new Map<string, string>(),+ pageMeta: new Map(),+ pageTitles: new Map([['docs/Active', 'Active']]),+ refetch: () => {},+ addPage: () => {},+ }),+}));++type ExternalSelection = { kind: 'external'; id: string; label: string; url: string };++const graphHarness: { select?: (sel: ExternalSelection) => void } = {};++mock.module('@/components/GraphView', () => ({+ GraphView: ({+ isExpanded,+ onSelectNode,+ }: {+ isExpanded: boolean;+ onSelectNode?: (sel: ExternalSelection) => void;+ }) => {+ graphHarness.select = onSelectNode;+ return <div data-testid="graph-view" data-expanded={String(isExpanded)} />;+ },+}));++const EXTERNAL_URL = 'https://www.youtube.com/watch?v=abc123';++function setDesktopBridge(openExternal: (url: string) => Promise<void>) {+ (window as unknown as { okDesktop?: unknown }).okDesktop = { shell: { openExternal } };+}++describe('GraphPanel — external "Open link" routes to the OS browser', () => {+ let originalOpen: typeof window.open;++ beforeEach(() => {+ originalOpen = window.open;+ });++ afterEach(() => {+ cleanup();+ window.open = originalOpen;+ delete (window as unknown as { okDesktop?: unknown }).okDesktop;+ graphHarness.select = undefined;+ });++ async function expandAndSelectExternal() {+ const { GraphPanel } = await import('./GraphPanel');+ render(+ <TooltipProvider>+ <GraphPanel activeDocName="docs/Active" />+ </TooltipProvider>,+ );+ await userEvent.click(screen.getByRole('button', { name: 'Expand graph' }));+ act(() => {+ graphHarness.select?.({+ kind: 'external',+ id: 'ext-1',+ label: 'Kayak Fishing PNW',+ url: EXTERNAL_URL,+ });+ });+ }++ test('Electron host: "Open link" calls okDesktop.shell.openExternal and never window.open', async () => {+ const openExternal = mock(async () => {});+ setDesktopBridge(openExternal);+ const openSpy = mock(() => null);+ window.open = openSpy as unknown as typeof window.open;++ await expandAndSelectExternal();+ await userEvent.click(screen.getByRole('button', { name: 'Open link' }));++ expect(openExternal).toHaveBeenCalledTimes(1);+ expect(openExternal).toHaveBeenCalledWith(EXTERNAL_URL);+ expect(openSpy).not.toHaveBeenCalled();+ });++ test('Web host (no bridge): "Open link" falls back to window.open in a new tab', async () => {+ const openSpy = mock(() => null);+ window.open = openSpy as unknown as typeof window.open;++ await expandAndSelectExternal();+ await userEvent.click(screen.getByRole('button', { name: 'Open link' }));++ expect(openSpy).toHaveBeenCalledTimes(1);+ expect(openSpy).toHaveBeenCalledWith(EXTERNAL_URL, '_blank', 'noopener,noreferrer');+ });+});