Skip to content

Beautiful, AI-native markdown IDE and LLM wiki

fix(open-knowledge): stop dead-link check flagging freshly-written docs (PRD-7194) (#2248)

mike-inkeeped7bf31125df
diff --git a/.changeset/fix-dead-links-fresh-doc-false-positive.md b/.changeset/fix-dead-links-fresh-doc-false-positive.md
new file mode 100644
index 000000000..b38e2f995
--- /dev/null
+++ b/.changeset/fix-dead-links-fresh-doc-false-positive.md
@@ -0,0 +1,6 @@
+---
+"@inkeep/open-knowledge-server": patch
+"@inkeep/open-knowledge": patch
+---
+
+Fix `links({ kind: "dead" })` falsely reporting freshly-written docs as dead. The dead-link check decided a target existed only from the file-watcher's file index, which lags behind in-session writes, so a doc the link graph had just registered a backlink for could still be flagged dead until a server restart. Dead-link resolution now also treats any doc the graph already holds as a live node (its body has been indexed) as a valid target, so a newly-written doc is a valid link target immediately — without changing how genuinely-missing targets are reported.
diff --git a/packages/server/src/backlink-index.test.ts b/packages/server/src/backlink-index.test.ts
index 44eb4a37a..a510ef49d 100644
--- a/packages/server/src/backlink-index.test.ts
+++ b/packages/server/src/backlink-index.test.ts
@@ -347,6 +347,53 @@ describe('BacklinkIndex', () => {
}
});
+ test('getDeadLinks does not flag a freshly-indexed target missing from the admitted set', () => {
+ const projectDir = mkdtempSync(join(tmpdir(), 'ok-backlinks-dead-links-fresh-'));
+ const contentDir = join(projectDir, 'content');
+ mkdirSync(contentDir, { recursive: true });
+ try {
+ const index = new BacklinkIndex({ projectDir, contentDir });
+ index.updateDocument('report', [
+ { target: 'evidence/new-target', anchor: null, snippet: 'see new target' },
+ ]);
+ index.updateDocument('evidence/new-target', []);
+
+ expect(index.getBacklinkCount('evidence/new-target')).toBe(1);
+ expect(index.getDeadLinks(['report'])).toEqual([]);
+
+ index.updateDocument('report', [
+ { target: 'evidence/new-target', anchor: null, snippet: 'see new target' },
+ { target: 'evidence/ghost', anchor: null, snippet: 'see ghost' },
+ ]);
+ expect(index.getDeadLinks(['report']).map((entry) => entry.target)).toEqual([
+ 'evidence/ghost',
+ ]);
+ } finally {
+ rmSync(projectDir, { recursive: true, force: true });
+ }
+ });
+
+ test('getDeadLinks reports a target as dead again after deleteDocument removes its forward node', () => {
+ const projectDir = mkdtempSync(join(tmpdir(), 'ok-backlinks-dead-after-delete-'));
+ const contentDir = join(projectDir, 'content');
+ mkdirSync(contentDir, { recursive: true });
+ try {
+ const index = new BacklinkIndex({ projectDir, contentDir });
+ index.updateDocument('report', [
+ { target: 'evidence/new-target', anchor: null, snippet: 'see new target' },
+ ]);
+ index.updateDocument('evidence/new-target', []);
+ expect(index.getDeadLinks(['report'])).toEqual([]);
+
+ index.deleteDocument('evidence/new-target');
+ expect(index.getDeadLinks(['report']).map((entry) => entry.target)).toEqual([
+ 'evidence/new-target',
+ ]);
+ } finally {
+ rmSync(projectDir, { recursive: true, force: true });
+ }
+ });
+
test('rebuilds from disk and persists cache per branch', async () => {
const projectDir = mkdtempSync(join(tmpdir(), 'ok-backlinks-project-'));
const contentDir = join(projectDir, 'content');
diff --git a/packages/server/src/backlink-index.ts b/packages/server/src/backlink-index.ts
index 0d1af8695..0ee06a95b 100644
--- a/packages/server/src/backlink-index.ts
+++ b/packages/server/src/backlink-index.ts
@@ -1174,7 +1174,7 @@ export class BacklinkIndex {
return [...state.backward.entries()]
.filter(([target, sources]) => {
- if (admittedDocSet.has(target)) return false;
+ if (admittedDocSet.has(target) || state.forward.has(target)) return false;
if (!sourceDocSet) return sources.size > 0;
for (const source of sources.keys()) {
if (sourceDocSet.has(source)) return true;