Beautiful, AI-native markdown IDE and LLM wiki
TypeScript 2nd-brainagent-skillsclaudecodexcompany-braindocsknowledge-knowledge-baseknowledge-managementllmllm-wikillm-wiki-karpathymarkdownmarkdown-editormdmdxnotespkmsecond-brainskills
feat(tabs): click active pill opens its options + Enter dismisses popover (#2039)
Abrahamf03ba300accc
diff --git a/.changeset/prd-7062-tab-rename-ux.md b/.changeset/prd-7062-tab-rename-ux.mdnew file mode 100644index 000000000..88e15250f--- /dev/null+++ b/.changeset/prd-7062-tab-rename-ux.md@@ -0,0 +1,26 @@+---+"@inkeep/open-knowledge": patch+---++Tab rename UX: clicking an already-active tab pill opens its properties+popover (Notion-style); pressing Enter inside a single-line string input+in any PropPanel dismisses the popover.++UX research found users couldn't discover how to rename a tab — the pill+itself had no rename affordance, and the only path was a hover-revealed+chrome bar on the Tab body. Clicking the same pill twice now opens the+Tab Properties popover with the Label input focused, so a user who clicks+expecting to edit finds the rename surface on the very next click. The+gear button gained a `data-jsx-gear` attribute so Tabs.tsx can address it+without coupling to its i18n'd `aria-label`.++Enter on a single-line string input now matches the form-submit contract+every text input ships with — pressing Enter after typing acknowledges+"I'm done" and closes the popover. PropPanel auto-saves on every+keystroke, so Enter is acknowledgment, not commit; nothing about the+data path changes. Both PropPanel's plain `<Input>` branch and+SrcAutocomplete's empty-suggestion-list branch route through a new+`onDismiss` callback that JsxComponentView wires to its popover close.+CodeMirror code editors keep Enter as newline (multiline by design);+SrcAutocomplete's existing "Enter picks the highlighted suggestion"+contract takes priority when a suggestion is highlighted.diff --git a/packages/app/src/editor/components/PropPanel.dom.test.tsx b/packages/app/src/editor/components/PropPanel.dom.test.tsxnew file mode 100644index 000000000..5a3860d32--- /dev/null+++ b/packages/app/src/editor/components/PropPanel.dom.test.tsx@@ -0,0 +1,194 @@+import { afterEach, describe, expect, mock, test } from 'bun:test';+import { ALLOWED_IMAGE_MIME_TYPES, type PropDef } from '@inkeep/open-knowledge-core';+import { cleanup, fireEvent, render } from '@testing-library/react';+import type { JsxComponentDescriptor } from '../registry/types.ts';++type GlobalShims = typeof globalThis & {+ ResizeObserver?: unknown;+};+const g = globalThis as GlobalShims;+if (g.ResizeObserver === undefined) {+ class NoopResizeObserver {+ observe() {}+ unobserve() {}+ disconnect() {}+ }+ g.ResizeObserver = NoopResizeObserver;+}+const ElementProto = Element.prototype as Element & {+ hasPointerCapture?: () => boolean;+ releasePointerCapture?: () => void;+ scrollIntoView?: () => void;+};+ElementProto.hasPointerCapture ??= () => false;+ElementProto.releasePointerCapture ??= () => {};+ElementProto.scrollIntoView ??= () => {};++const stubAssetPaths = new Set<string>();+const stubPageListValue = {+ pages: new Set<string>(),+ pagesBySlug: new Map<string, string>(),+ pagesByBasename: new Map<string, string>(),+ pageTitles: new Map<string, string>(),+ pageMeta: new Map<string, unknown>(),+ folderPaths: new Set<string>(),+ assetPaths: stubAssetPaths,+ loading: false,+ error: null,+ refetch: () => {},+ addPage: () => {},+};+mock.module('@/components/PageListContext', () => ({+ usePageList: () => stubPageListValue,+ useOptionalPageList: () => stubPageListValue,+}));++const { PropPanel } = await import('./PropPanel');++afterEach(() => {+ cleanup();+});++function NoopComponent() {+ return null;+}++function makeDescriptor(props: PropDef[]): JsxComponentDescriptor {+ return {+ name: 'TestDescriptor',+ surface: 'canonical',+ displayName: 'TestDescriptor',+ hasChildren: false,+ props,+ serialize: () => ({ type: 'paragraph', children: [] }),+ Component: NoopComponent,+ reactNodePropNames: new Set(),+ };+}++describe('PropPanel — Enter on a single-line string input dismisses', () => {+ test('Enter on a plain string Input (no autocomplete) calls onDismiss', () => {+ const onDismiss = mock(() => {});+ const d = makeDescriptor([+ { name: 'label', type: 'string', required: true, autoFocus: true, defaultValue: 'Tab' },+ ]);+ const { container } = render(+ <PropPanel+ descriptor={d}+ values={{ label: 'Tab 1' }}+ onChange={() => {}}+ onDismiss={onDismiss}+ />,+ );+ const input = container.querySelector('input#prop-label') as HTMLInputElement;+ expect(input).not.toBeNull();+ fireEvent.keyDown(input, { key: 'Enter' });+ expect(onDismiss).toHaveBeenCalledTimes(1);+ });++ test('Enter on a string Input WITHOUT an onDismiss is harmless (no throw, no-op)', () => {+ const d = makeDescriptor([+ { name: 'label', type: 'string', required: true, autoFocus: true, defaultValue: 'Tab' },+ ]);+ const { container } = render(+ <PropPanel descriptor={d} values={{ label: 'Tab 1' }} onChange={() => {}} />,+ );+ const input = container.querySelector('input#prop-label') as HTMLInputElement;+ expect(() => fireEvent.keyDown(input, { key: 'Enter' })).not.toThrow();+ });++ test('Enter on an advanced-tier string Input also calls onDismiss (parity with common tier)', () => {+ const onDismiss = mock(() => {});+ const d = makeDescriptor([+ { name: 'label', type: 'string', required: true, defaultValue: 'Tab' },+ { name: 'id', type: 'string', required: false, advanced: true },+ ]);+ const { container } = render(+ <PropPanel+ descriptor={d}+ values={{ label: 'Tab 1', id: 'tab-1' }}+ onChange={() => {}}+ onDismiss={onDismiss}+ />,+ );+ const advancedTrigger = container.querySelector(+ '[data-prop-panel-advanced-trigger]',+ ) as HTMLButtonElement;+ fireEvent.click(advancedTrigger);+ const advancedInput = container.querySelector('input#prop-id') as HTMLInputElement;+ expect(advancedInput).not.toBeNull();+ fireEvent.keyDown(advancedInput, { key: 'Enter' });+ expect(onDismiss).toHaveBeenCalledTimes(1);+ });++ test('Non-Enter keys do NOT dismiss (only Enter triggers the close gesture)', () => {+ const onDismiss = mock(() => {});+ const d = makeDescriptor([+ { name: 'label', type: 'string', required: true, autoFocus: true, defaultValue: 'Tab' },+ ]);+ const { container } = render(+ <PropPanel+ descriptor={d}+ values={{ label: 'Tab 1' }}+ onChange={() => {}}+ onDismiss={onDismiss}+ />,+ );+ const input = container.querySelector('input#prop-label') as HTMLInputElement;+ fireEvent.keyDown(input, { key: 'a' });+ fireEvent.keyDown(input, { key: 'Escape' });+ fireEvent.keyDown(input, { key: 'Tab' });+ fireEvent.keyDown(input, { key: 'ArrowDown' });+ expect(onDismiss).not.toHaveBeenCalled();+ });++ test('Enter on a cssLengthInput string dismisses (Embed.width / Embed.height)', () => {+ const onDismiss = mock(() => {});+ const d = makeDescriptor([+ { name: 'width', type: 'string', required: false, cssLengthInput: true },+ ]);+ const { container } = render(+ <PropPanel descriptor={d} values={{}} onChange={() => {}} onDismiss={onDismiss} />,+ );+ const input = container.querySelector('[data-prop-css-length-input]') as HTMLInputElement;+ expect(input).not.toBeNull();+ fireEvent.keyDown(input, { key: 'Enter' });+ expect(onDismiss).toHaveBeenCalledTimes(1);+ });++ test('Enter on a number Input dismisses', () => {+ const onDismiss = mock(() => {});+ const d = makeDescriptor([{ name: 'width', type: 'number', required: false }]);+ const { container } = render(+ <PropPanel descriptor={d} values={{}} onChange={() => {}} onDismiss={onDismiss} />,+ );+ const input = container.querySelector('input#prop-width') as HTMLInputElement;+ expect(input).not.toBeNull();+ expect(input.type).toBe('number');+ fireEvent.keyDown(input, { key: 'Enter' });+ expect(onDismiss).toHaveBeenCalledTimes(1);+ });++ test('Enter on the accept-bearing SrcAutocomplete branch dismisses (PropPanel-level wiring)', () => {+ stubAssetPaths.clear();+ const onDismiss = mock(() => {});+ const d = makeDescriptor([+ {+ name: 'src',+ type: 'string',+ required: true,+ autoFocus: true,+ defaultValue: '',+ accept: ALLOWED_IMAGE_MIME_TYPES,+ },+ ]);+ const { container } = render(+ <PropPanel descriptor={d} values={{}} onChange={() => {}} onDismiss={onDismiss} />,+ );+ const input = container.querySelector('input#prop-src') as HTMLInputElement;+ expect(input).not.toBeNull();+ fireEvent.focus(input);+ fireEvent.keyDown(input, { key: 'Enter' });+ expect(onDismiss).toHaveBeenCalledTimes(1);+ });+});diff --git a/packages/app/src/editor/components/PropPanel.tsx b/packages/app/src/editor/components/PropPanel.tsxindex 1e17525da..e7f50947a 100644--- a/packages/app/src/editor/components/PropPanel.tsx+++ b/packages/app/src/editor/components/PropPanel.tsx@@ -85,9 +85,10 @@ interface PropPanelProps {descriptor: JsxComponentDescriptor;values: Record<string, unknown>;onChange: (propName: string, value: unknown) => void;+ onDismiss?: () => void;}-export function PropPanel({ descriptor, values, onChange }: PropPanelProps) {+export function PropPanel({ descriptor, values, onChange, onDismiss }: PropPanelProps) {const editableProps = descriptor.props.filter((p) => !('hidden' in p && p.hidden) && p.hideWhen?.(values) !== true && p.type !== 'reactnode',);@@ -109,6 +110,7 @@ export function PropPanel({ descriptor, values, onChange }: PropPanelProps) {propDef={propDef}value={values[propDef.name]}onChange={(v) => onChange(propDef.name, v)}+ onDismiss={onDismiss}isAutoFocused={propDef.name === autoFocusedPropName}/>))}@@ -143,6 +145,7 @@ export function PropPanel({ descriptor, values, onChange }: PropPanelProps) {propDef={propDef}value={values[propDef.name]}onChange={(v) => onChange(propDef.name, v)}+ onDismiss={onDismiss}isAutoFocused={propDef.name === autoFocusedPropName}/>))}@@ -162,13 +165,23 @@ function PropControl({propDef,value,onChange,+ onDismiss,isAutoFocused,}: {propDef: PropDef;value: unknown;onChange: (value: unknown) => void;+ onDismiss?: () => void;isAutoFocused: boolean;}) {+ const handleDismissKeyDown = onDismiss+ ? (e: React.KeyboardEvent) => {+ if (e.key === 'Enter') {+ e.preventDefault();+ onDismiss();+ }+ }+ : undefined;switch (propDef.type) {case 'reactnode':return null;@@ -271,6 +284,7 @@ function PropControl({}onChange(raw);}}+ onKeyDown={handleDismissKeyDown}autoFocus={isAutoFocused}data-prop-autofocus={isAutoFocused ? '' : undefined}aria-invalid={cssError !== null ? true : undefined}@@ -329,6 +343,7 @@ function PropControl({}onChange(raw);}}+ onSubmit={onDismiss}accept={accept}placeholder={mediaPlaceholder}autoFocus={isAutoFocused}@@ -351,6 +366,7 @@ function PropControl({}onChange(raw);}}+ onKeyDown={handleDismissKeyDown}autoFocus={isAutoFocused}data-prop-autofocus={isAutoFocused ? '' : undefined}aria-invalid={mediaErrorMessage !== null ? true : undefined}@@ -440,6 +456,7 @@ function PropControl({const num = Number(raw);if (!Number.isNaN(num)) onChange(num);}}+ onKeyDown={handleDismissKeyDown}className="h-7 text-sm"/></div>diff --git a/packages/app/src/editor/components/SrcAutocomplete.dom.test.tsx b/packages/app/src/editor/components/SrcAutocomplete.dom.test.tsxindex 9401ff120..91088fd81 100644--- a/packages/app/src/editor/components/SrcAutocomplete.dom.test.tsx+++ b/packages/app/src/editor/components/SrcAutocomplete.dom.test.tsx@@ -189,7 +189,7 @@ describe('SrcAutocomplete — keyboard handling', () => {expect(getOptions().length).toBe(0);});- test('Enter with no matching suggestions is a no-op (does NOT call onChange)', () => {+ test('Enter with no matching suggestions does NOT call onChange (no phantom selection)', () => {const onChange = mock((_v: string) => {});render(@@ -206,6 +206,43 @@ describe('SrcAutocomplete — keyboard handling', () => {fireEvent.keyDown(input, { key: 'Enter' });expect(onChange).not.toHaveBeenCalled();});++ test('Enter with no highlighted suggestion calls onSubmit (Tab rename Enter-commits-and-closes)', () => {+ const onSubmit = mock(() => {});+ render(+ <SrcAutocomplete+ id="prop-src"+ value=""+ onChange={() => {}}+ onSubmit={onSubmit}+ accept={ALLOWED_IMAGE_MIME_TYPES}+ />,+ );+ const input = document.getElementById('prop-src') as HTMLInputElement;+ fireEvent.focus(input);+ fireEvent.keyDown(input, { key: 'Enter' });+ expect(onSubmit).toHaveBeenCalledTimes(1);+ });++ test('Enter with a highlighted suggestion picks the suggestion, NOT onSubmit', () => {+ stubAssetPaths.add('assets/photo.png');+ const onChange = mock((_v: string) => {});+ const onSubmit = mock(() => {});+ render(+ <SrcAutocomplete+ id="prop-src"+ value=""+ onChange={onChange}+ onSubmit={onSubmit}+ accept={ALLOWED_IMAGE_MIME_TYPES}+ />,+ );+ const input = document.getElementById('prop-src') as HTMLInputElement;+ fireEvent.focus(input);+ fireEvent.keyDown(input, { key: 'Enter' });+ expect(onChange).toHaveBeenCalledWith('/assets/photo.png');+ expect(onSubmit).not.toHaveBeenCalled();+ });});describe('SrcAutocomplete — popover width tracks the trigger', () => {diff --git a/packages/app/src/editor/components/SrcAutocomplete.tsx b/packages/app/src/editor/components/SrcAutocomplete.tsxindex f692f5261..1a633b73e 100644--- a/packages/app/src/editor/components/SrcAutocomplete.tsx+++ b/packages/app/src/editor/components/SrcAutocomplete.tsx@@ -30,6 +30,7 @@ interface SrcAutocompleteProps {ariaDescribedBy?: string;dataPropAutofocus?: string;className?: string;+ onSubmit?: () => void;}interface AssetItem {@@ -99,6 +100,7 @@ export function SrcAutocomplete({ariaDescribedBy,dataPropAutofocus,className,+ onSubmit,}: SrcAutocompleteProps): ReactNode {const pageList = useOptionalPageList();const assetPaths: ReadonlySet<string> = pageList?.assetPaths ?? EMPTY_ASSET_SET;@@ -175,11 +177,18 @@ export function SrcAutocomplete({return;}if (e.key === 'Enter') {- if (!wantOpen) return;- const item = suggestions[highlight];- if (!item) return;- e.preventDefault();- selectSuggestion(item);+ if (wantOpen) {+ const item = suggestions[highlight];+ if (item) {+ e.preventDefault();+ selectSuggestion(item);+ return;+ }+ }+ if (onSubmit) {+ e.preventDefault();+ onSubmit();+ }return;}if (e.key === 'Escape') {diff --git a/packages/app/src/editor/components/Tabs.dom.test.tsx b/packages/app/src/editor/components/Tabs.dom.test.tsxindex 0b5798670..1e9760d59 100644--- a/packages/app/src/editor/components/Tabs.dom.test.tsx+++ b/packages/app/src/editor/components/Tabs.dom.test.tsx@@ -1,8 +1,11 @@import { afterEach, describe, expect, test } from 'bun:test';import { cleanup } from '@testing-library/react';-import { readTabSlots } from './Tabs.tsx';+import { findNthTabGearButton, readTabSlots } from './Tabs.tsx';afterEach(cleanup);+afterEach(() => {+ document.body.innerHTML = '';+});function contentDom(childRenderers: string): string {return `<div class="component-children" data-node-view-content><div data-node-view-content-react>${childRenderers}</div></div>`;@@ -12,6 +15,15 @@ function tabRenderer(label: string, id: string, nestedContentDom = ''): string {return `<div class="react-renderer node-jsxComponent"><div class="jsx-component-wrapper" data-component-type="tab"><section class="tab-panel" data-tab-label="${label}" data-tab-id="${id}">${nestedContentDom}</section></div></div>`;}+function tabRendererWithGear(+ label: string,+ id: string,+ gearOwner: string,+ nestedContentDom = '',+): string {+ return `<div class="react-renderer node-jsxComponent"><div class="jsx-component-chrome"><button type="button" data-jsx-gear="" data-gear-owner="${gearOwner}"></button></div><div class="jsx-component-wrapper" data-component-type="tab"><section class="tab-panel" data-tab-label="${label}" data-tab-id="${id}">${nestedContentDom}</section></div></div>`;+}+function containerRenderer(type: string, childRenderers = ''): string {return `<div class="react-renderer node-jsxComponent"><div class="jsx-component-wrapper" data-component-type="${type}">${contentDom(childRenderers)}</div></div>`;}@@ -104,3 +116,66 @@ describe('readTabSlots — counts only the Tabs own direct Tab children', () =>expect(readTabSlots(mountOuterTabs(''))).toHaveLength(0);});});++describe('findNthTabGearButton — Notion-style rename gear lookup', () => {+ test('returns the gear button of the Nth Tab in the strip', () => {+ const root = mountOuterTabs(+ tabRendererWithGear('Alpha', 'alpha', 'gear-0') ++ tabRendererWithGear('Bravo', 'bravo', 'gear-1') ++ tabRendererWithGear('Charlie', 'charlie', 'gear-2'),+ );+ expect(findNthTabGearButton(root, 0)?.dataset.gearOwner).toBe('gear-0');+ expect(findNthTabGearButton(root, 1)?.dataset.gearOwner).toBe('gear-1');+ expect(findNthTabGearButton(root, 2)?.dataset.gearOwner).toBe('gear-2');+ });++ test('returns null when the index is out of range', () => {+ const root = mountOuterTabs(+ tabRendererWithGear('Alpha', 'alpha', 'gear-0') ++ tabRendererWithGear('Bravo', 'bravo', 'gear-1'),+ );+ expect(findNthTabGearButton(root, 2)).toBeNull();+ expect(findNthTabGearButton(root, 99)).toBeNull();+ });++ test('returns null when the Tab at the slot has no gear (placeholder mode)', () => {+ const root = mountOuterTabs(+ tabRendererWithGear('Alpha', 'alpha', 'gear-0') + tabRenderer('Bravo', 'bravo'),+ );+ expect(findNthTabGearButton(root, 0)).not.toBeNull();+ expect(findNthTabGearButton(root, 1)).toBeNull();+ });++ test('the returned button is the one .click() opens — round-trip the dispatch', () => {+ const root = mountOuterTabs(+ tabRendererWithGear('Alpha', 'alpha', 'gear-0') ++ tabRendererWithGear('Bravo', 'bravo', 'gear-1'),+ );+ const gear = findNthTabGearButton(root, 1);+ expect(gear).not.toBeNull();+ let fired = 0;+ gear?.addEventListener('click', () => {+ fired++;+ });+ gear?.click();+ expect(fired).toBe(1);+ });++ test('nested Tabs: inner pills do NOT count toward the outer Tabs slot set', () => {+ const innerTabs = nestedTabsRenderer(+ tabRendererWithGear('Inner one', 'inner-1', 'inner-gear-0') ++ tabRendererWithGear('Inner two', 'inner-2', 'inner-gear-1'),+ );+ const tab1 = tabRendererWithGear('Outer one', 'outer-1', 'outer-gear-0', contentDom(innerTabs));+ const root = mountOuterTabs(tab1 + tabRendererWithGear('Outer two', 'outer-2', 'outer-gear-1'));++ expect(findNthTabGearButton(root, 0)?.dataset.gearOwner).toBe('outer-gear-0');+ expect(findNthTabGearButton(root, 1)?.dataset.gearOwner).toBe('outer-gear-1');+ expect(findNthTabGearButton(root, 2)).toBeNull();++ const innerContent = document.querySelectorAll<HTMLElement>('.tabs-content')[1];+ if (!innerContent) throw new Error('expected an inner .tabs-content');+ expect(findNthTabGearButton(innerContent, 0)?.dataset.gearOwner).toBe('inner-gear-0');+ expect(findNthTabGearButton(innerContent, 1)?.dataset.gearOwner).toBe('inner-gear-1');+ });+});diff --git a/packages/app/src/editor/components/Tabs.tsx b/packages/app/src/editor/components/Tabs.tsxindex a037eb07f..718ee5c8f 100644--- a/packages/app/src/editor/components/Tabs.tsx+++ b/packages/app/src/editor/components/Tabs.tsx@@ -27,6 +27,13 @@ export function readTabSlots(root: HTMLElement): TabSummary[] {});}+export function findNthTabGearButton(root: HTMLElement, index: number): HTMLButtonElement | null {+ const renderers = Array.from(root.querySelectorAll<HTMLElement>(SLOT_SELECTOR));+ const target = renderers[index];+ if (!target) return null;+ return target.querySelector<HTMLButtonElement>('[data-jsx-gear]');+}+export function Tabs({ id, children }: TabsProps) {const [activeIndex, setActiveIndex] = useState(0);const [labels, setLabels] = useState<TabSummary[]>([]);@@ -122,7 +129,15 @@ export function Tabs({ id, children }: TabsProps) {aria-controls={s.panelId ?? undefined}tabIndex={s.index === safeActive ? 0 : -1}onMouseDown={(e) => e.preventDefault()}- onClick={() => setActiveIndex(s.index)}+ onClick={() => {+ if (s.index !== safeActive) {+ setActiveIndex(s.index);+ return;+ }+ const root = contentRef.current;+ if (!root) return;+ findNthTabGearButton(root, s.index)?.click();+ }}>{s.label}</button>diff --git a/packages/app/src/editor/extensions/JsxComponentView.tsx b/packages/app/src/editor/extensions/JsxComponentView.tsxindex a90fb90e3..cecf71195 100644--- a/packages/app/src/editor/extensions/JsxComponentView.tsx+++ b/packages/app/src/editor/extensions/JsxComponentView.tsx@@ -813,6 +813,7 @@ export function JsxComponentView({ node, editor, extension, getPos, selected }:<buttontype="button"className="jsx-chrome-btn"+ data-jsx-gear=""aria-label={t`${settingsDescriptorLabel} properties`}><Settings2 size={12} aria-hidden="true" />@@ -1007,6 +1008,7 @@ export function JsxComponentView({ node, editor, extension, getPos, selected }:<PropPaneldescriptor={descriptor}values={primitiveProps}+ onDismiss={() => setPopoverOpen(false)}onChange={(propName, value) => {const p = typeof getPos === 'function' ? getPos() : undefined;if (typeof p !== 'number') return;