Beautiful, AI-native markdown IDE and LLM wiki
TypeScript 2nd-brainagent-skillsclaudecodexcompany-braindocsknowledge-knowledge-baseknowledge-managementllmllm-wikillm-wiki-karpathymarkdownmarkdown-editormdmdxnotespkmsecond-brainskills
fix(open-knowledge): open Open-with-AI menu via click in desktop app (#1604)
Andrew Mikofalvyf29ebbde66fd
diff --git a/.changeset/open-with-ai-electron-click.md b/.changeset/open-with-ai-electron-click.mdnew file mode 100644index 000000000..3bb354042--- /dev/null+++ b/.changeset/open-with-ai-electron-click.md@@ -0,0 +1,9 @@+---+"@inkeep/open-knowledge": patch+"@inkeep/open-knowledge-core": patch+"@inkeep/open-knowledge-server": patch+"@inkeep/open-knowledge-app": patch+"@inkeep/open-knowledge-desktop": patch+---++Fix the editor toolbar's "Open with AI" menu not opening in the macOS desktop app. The header sits in a macOS title-bar drag region (`-webkit-app-region: drag`), and macOS swallows the `pointerdown` event on its children — even on the `no-drag` button — before the DOM sees it. Radix's dropdown opens on `pointerdown`, so clicking the button did nothing. The synthesized `click` still fires, so on the desktop host the menu now opens from the click instead. Browsers (`ok ui`) are unaffected and keep Radix's default behavior. This regressed when the button's redundant hover tooltip was removed, which had incidentally kept pointer events flowing to the trigger.diff --git a/packages/app/src/components/handoff/OpenInAgentMenu.test.ts b/packages/app/src/components/handoff/OpenInAgentMenu.test.tsindex 33bd51ff2..b09b256e2 100644--- a/packages/app/src/components/handoff/OpenInAgentMenu.test.ts+++ b/packages/app/src/components/handoff/OpenInAgentMenu.test.ts@@ -48,4 +48,10 @@ describe('OpenInAgentMenu source-level guards', () => {expect(SRC).not.toContain('<TooltipContent>');expect(SRC).toContain('<Trans>Open with AI</Trans>');});++ test('opens from click on the Electron host (macOS drag region swallows pointerdown)', () => {+ expect(SRC).toMatch(/onClick=\{\s*isElectronHost/);+ expect(SRC).toMatch(/onPointerDown=\{\s*isElectronHost/);+ expect(SRC).toContain('sawPointerDownRef');+ });});diff --git a/packages/app/src/components/handoff/OpenInAgentMenu.tsx b/packages/app/src/components/handoff/OpenInAgentMenu.tsxindex 45ab4d9b1..3b06500de 100644--- a/packages/app/src/components/handoff/OpenInAgentMenu.tsx+++ b/packages/app/src/components/handoff/OpenInAgentMenu.tsx@@ -2,7 +2,7 @@ import { composeFilePrompt, type TargetData } from '@inkeep/open-knowledge-core'import { Trans, useLingui } from '@lingui/react/macro';import { ExternalLink, Sparkles } from 'lucide-react';import type { ReactNode } from 'react';-import { useState } from 'react';+import { useRef, useState } from 'react';import { Button } from '@/components/ui/button';import {DropdownMenu,@@ -38,6 +38,7 @@ export function OpenInAgentMenu({ input, open, onOpenChange }: OpenInAgentMenuPrconst { merged } = useConfigContext();const autoOpen = merged?.appearance?.preview?.autoOpen ?? true;const [internalOpen, setInternalOpen] = useState(false);+ const sawPointerDownRef = useRef(false);const isEmbedded = useIsEmbedded();if (isEmbedded) return null;@@ -83,6 +84,24 @@ export function OpenInAgentMenu({ input, open, onOpenChange }: OpenInAgentMenuPrdisabled={triggerDisabled}className="gap-1.5 text-muted-foreground px-1.5"data-testid="open-in-agent-trigger"+ onPointerDown={+ isElectronHost+ ? () => {+ sawPointerDownRef.current = true;+ }+ : undefined+ }+ onClick={+ isElectronHost+ ? () => {+ if (sawPointerDownRef.current) {+ sawPointerDownRef.current = false;+ return;+ }+ handleOpenChange(true);+ }+ : undefined+ }><Sparkles className="size-3.5" aria-hidden="true" /><Trans>Open with AI</Trans>