Beautiful, AI-native markdown IDE and LLM wiki
TypeScript 2nd-brainagent-skillsclaudecodexcompany-braindocsknowledge-knowledge-baseknowledge-managementllmllm-wikillm-wiki-karpathymarkdownmarkdown-editormdmdxnotespkmsecond-brainskills
fix(prop-panel): discoverable upload affordance + autocomplete width (#1943)
Abrahamf69693776edd
diff --git a/.changeset/prd-7054-image-upload-affordance.md b/.changeset/prd-7054-image-upload-affordance.mdnew file mode 100644index 000000000..72b5efcfb--- /dev/null+++ b/.changeset/prd-7054-image-upload-affordance.md@@ -0,0 +1,30 @@+---+"@inkeep/open-knowledge": patch+---++Make the image / video / audio upload affordance discoverable on the property+panel and consolidate alignment to one surface. Three changes:++- Collapse three alignment surfaces into one. Image / video / Embed /+ CommonMarkImage previously exposed alignment in the floating bubble menu,+ in the per-block chrome bar, AND in the PropPanel `Align` Select. The+ bubble menu (`ImageAlignButtons`) is the canonical surface; the chrome-bar+ trio and PropPanel Select are removed, and the `align` PropDef carries+ `hidden: true` so the prop still travels through the registry (MCP queries,+ descriptor docs, render path) without producing a redundant control. The+ rest of the cluster (PRD-7054 origin findings) follows:++- The upload control rendered as an icon-only square next to the URL input,+ which read as decoration; users skipped it entirely and fell back to+ URL-paste as the only "working" path. Replaced with a full-width labeled+ "Upload from computer" button that pairs the icon with explicit text — the+ visible label doubles as the assistive-tech accessible name, so the screen-+ reader contract stays intact without `aria-label`.+- The asset-autocomplete dropdown bound its width with the Tailwind v3+ implicit-`var()` shorthand `w-[--radix-popover-trigger-width]`. In Tailwind+ v4 that form emits literal `width: --radix-popover-trigger-width` — invalid+ CSS, silently ignored — so the suggestion list auto-sized to its longest+ asset path (~550px-wide) and overflowed the parent prop panel, swallowing+ the upload affordance in the visual chaos. Switched to v4's parenthesized+ form `w-(--radix-popover-trigger-width)`; a DOM-level regression test pins+ the syntax so a future revert fails CI instead of users.diff --git a/packages/app/src/editor/components/PropPanel.test.tsx b/packages/app/src/editor/components/PropPanel.test.tsxindex 40e63983f..fa503fa75 100644--- a/packages/app/src/editor/components/PropPanel.test.tsx+++ b/packages/app/src/editor/components/PropPanel.test.tsx@@ -304,14 +304,14 @@ describe('PropPanel — upload button affordance', () => {expect(html).not.toContain('data-prop-upload-input');});- test('upload button uses aria-label="Upload file"', () => {+ test('upload button surfaces visible "Upload from computer" text as its accessible name', () => {const d = makeCanonicalDescriptor('img', [{ name: 'src', type: 'string', required: true, accept: ['image/png'] },]);const html = withFakeStorage(() =>renderToString(<PropPanel descriptor={d} values={{}} onChange={() => {}} />),);- expect(html).toMatch(/aria-label="Upload file"/);+ expect(html).toMatch(/data-prop-upload-trigger="">.*Upload from computer/);});});@@ -405,7 +405,7 @@ describe('PropPanel — descriptor.props narrowing (real registry)', () => {});expect(html).toContain('id="prop-src"');expect(html).toContain('id="prop-alt"');- expect(html).toContain('id="prop-align"');+ expect(html).not.toContain('id="prop-align"');expect(html).toContain('data-prop-panel-advanced-trigger');expect(html).toContain('id="prop-width"');expect(html).toContain('id="prop-height"');@@ -418,7 +418,29 @@ describe('PropPanel — descriptor.props narrowing (real registry)', () => {expect(html).toContain('id="prop-crossorigin"');expect(html).toContain('id="prop-referrerpolicy"');const propIds = html.match(/id="prop-[^"]+"/g) ?? [];- expect(propIds.length).toBe(13);+ expect(propIds.length).toBe(12);+ });++ test('canonical video descriptor: align is hidden from PropPanel (bubble-menu owns it)', () => {+ const d = findBuiltIn('video');+ const html = withFakeStorage(() => {+ persistAdvancedOpenState('video', true);+ return renderToString(<PropPanel descriptor={d} values={{}} onChange={() => {}} />);+ });+ expect(html).toContain('id="prop-src"');+ expect(html).not.toContain('id="prop-align"');+ });++ test('canonical Embed descriptor: align is hidden from PropPanel (bubble-menu owns it)', () => {+ const d = findBuiltIn('Embed');+ const html = withFakeStorage(() => {+ persistAdvancedOpenState('Embed', true);+ return renderToString(+ <PropPanel descriptor={d} values={{ src: 'https://example.com' }} onChange={() => {}} />,+ );+ });+ expect(html).toContain('id="prop-src"');+ expect(html).not.toContain('id="prop-align"');});});diff --git a/packages/app/src/editor/components/PropPanel.tsx b/packages/app/src/editor/components/PropPanel.tsxindex ae209f630..1e17525da 100644--- a/packages/app/src/editor/components/PropPanel.tsx+++ b/packages/app/src/editor/components/PropPanel.tsx@@ -1,6 +1,6 @@import type { PropDef } from '@inkeep/open-knowledge-core';import { t } from '@lingui/core/macro';-import { Trans, useLingui } from '@lingui/react/macro';+import { Trans } from '@lingui/react/macro';import { ChevronDown, Loader2, Upload } from 'lucide-react';import { useRef, useState } from 'react';import { toast } from 'sonner';@@ -310,7 +310,14 @@ function PropControl({<label htmlFor={stringId} className="text-xs text-muted-foreground">{humanizePropName(propDef.name)}</label>- <div className="flex gap-1">+ {/* Two-row layout: src input on its own line, then the upload+ affordance below it as a labeled full-width button. UX+ research found users skipping the icon-only upload button+ entirely — the row-with-icon shape read as "URL field with a+ decoration on the right," not "URL field OR pick a file."+ Stacking the affordances and giving the upload button visible+ "Upload from computer" text makes the second path explicit. */}+ <div className="flex flex-col gap-1.5">{accept !== undefined ? (<SrcAutocompleteid={stringId}@@ -451,7 +458,6 @@ function PropUploadButton({accept: readonly string[];onUploaded: (url: string) => void;}) {- const { t } = useLingui();const [uploading, setUploading] = useState(false);const inputRef = useRef<HTMLInputElement>(null);return (@@ -478,15 +484,20 @@ function PropUploadButton({variant="outline"size="sm"disabled={uploading}- aria-label={t`Upload file`}data-prop-upload-trigger=""- className="h-7 px-2"+ className="h-7 w-full justify-center gap-1.5 px-2 text-xs"onClick={() => inputRef.current?.click()}>{uploading ? (- <Loader2 className="size-3.5 animate-spin" />+ <>+ <Loader2 className="size-3.5 animate-spin" aria-hidden="true" />+ <Trans>Uploading</Trans>+ </>) : (- <Upload className="size-3.5" />+ <>+ <Upload className="size-3.5" aria-hidden="true" />+ <Trans>Upload from computer</Trans>+ </>)}</Button></>diff --git a/packages/app/src/editor/components/SrcAutocomplete.dom.test.tsx b/packages/app/src/editor/components/SrcAutocomplete.dom.test.tsxindex 3fab8af05..9401ff120 100644--- a/packages/app/src/editor/components/SrcAutocomplete.dom.test.tsx+++ b/packages/app/src/editor/components/SrcAutocomplete.dom.test.tsx@@ -207,3 +207,27 @@ describe('SrcAutocomplete — keyboard handling', () => {expect(onChange).not.toHaveBeenCalled();});});++describe('SrcAutocomplete — popover width tracks the trigger', () => {+ test('PopoverContent uses the Tailwind v4 implicit-var width syntax (`w-(...)`, not `w-[...]`)', () => {+ stubAssetPaths.add('assets/photo.png');+ render(+ <SrcAutocomplete+ id="prop-src"+ value=""+ onChange={() => {}}+ accept={ALLOWED_IMAGE_MIME_TYPES}+ />,+ );+ const input = document.getElementById('prop-src') as HTMLInputElement;+ fireEvent.focus(input);++ const option = screen.getAllByTestId('src-autocomplete-option')[0];+ expect(option).toBeDefined();+ const content = option?.closest('[data-slot="popover-content"]') as HTMLElement | null;+ expect(content).not.toBeNull();+ const classes = content?.className ?? '';+ expect(classes).toContain('w-(--radix-popover-trigger-width)');+ expect(classes).not.toContain('w-[--radix-popover-trigger-width]');+ });+});diff --git a/packages/app/src/editor/components/SrcAutocomplete.tsx b/packages/app/src/editor/components/SrcAutocomplete.tsxindex b06705057..f692f5261 100644--- a/packages/app/src/editor/components/SrcAutocomplete.tsx+++ b/packages/app/src/editor/components/SrcAutocomplete.tsx@@ -198,7 +198,7 @@ export function SrcAutocomplete({<PopoverContentalign="start"sideOffset={4}- className="z-70 w-[--radix-popover-trigger-width] p-1"+ className="z-70 w-(--radix-popover-trigger-width) p-1"onOpenAutoFocus={(e) => {e.preventDefault();}}@@ -212,39 +212,54 @@ export function SrcAutocomplete({}}}>- <ul id={listboxId} aria-label="Asset suggestions" className="flex flex-col gap-px">+ {/* Container is a `<div role="listbox">` rather than `<ul>` —+ the WAI-ARIA combobox pattern requires the popup referenced+ by the input's `aria-controls` to carry `role="listbox"` so+ assistive tech can resolve the combobox↔listbox ownership+ and the `aria-activedescendant` target; mirrors the+ companion `WikiLinkSuggestionMenu` + `link-path-suggestions`+ sites, which made the same `<ul>` → `<div role="listbox">`+ choice to satisfy biome's `noNoninteractiveElementToInteractiveRole`+ rule without suppression. The `<button role="option">`+ children stay — buttons accept the listbox-option role+ cleanly. */}+ <div+ id={listboxId}+ role="listbox"+ aria-label="Asset suggestions"+ className="flex flex-col gap-px"+ >{suggestions.map((item, idx) => {const optionId = `${listboxId}-opt-${idx}`;const isHighlighted = idx === highlight;return (- <li key={item.path}>- <button- id={optionId}- type="button"- role="option"- aria-selected={isHighlighted}- data-testid="src-autocomplete-option"- data-highlighted={isHighlighted ? '' : undefined}- className={cn(- 'flex w-full flex-col items-start gap-0.5 rounded-sm px-2 py-1 text-left text-xs',- 'transition-colors',- isHighlighted ? 'bg-accent text-accent-foreground' : 'hover:bg-accent/50',- )}- onMouseEnter={() => setHighlight(idx)}- onMouseDown={(e) => {- e.preventDefault();- selectSuggestion(item);- }}- >- <span className="font-medium">{item.basename}</span>- {item.basename !== item.path && (- <span className="text-muted-foreground/70">{item.path}</span>- )}- </button>- </li>+ <button+ key={item.path}+ id={optionId}+ type="button"+ role="option"+ aria-selected={isHighlighted}+ data-testid="src-autocomplete-option"+ data-highlighted={isHighlighted ? '' : undefined}+ className={cn(+ 'flex w-full flex-col items-start gap-0.5 rounded-sm px-2 py-1 text-left text-xs',+ 'transition-colors',+ isHighlighted ? 'bg-accent text-accent-foreground' : 'hover:bg-accent/50',+ )}+ onMouseEnter={() => setHighlight(idx)}+ onMouseDown={(e) => {+ e.preventDefault();+ selectSuggestion(item);+ }}+ >+ <span className="font-medium">{item.basename}</span>+ {item.basename !== item.path && (+ <span className="text-muted-foreground/70">{item.path}</span>+ )}+ </button>);})}- </ul>+ </div></PopoverContent></Popover>);diff --git a/packages/app/src/editor/extensions/JsxComponentView.tsx b/packages/app/src/editor/extensions/JsxComponentView.tsxindex 1ee0c14bd..a90fb90e3 100644--- a/packages/app/src/editor/extensions/JsxComponentView.tsx+++ b/packages/app/src/editor/extensions/JsxComponentView.tsx@@ -48,17 +48,7 @@ import { Trans, useLingui } from '@lingui/react/macro';import type { NodeViewProps } from '@tiptap/core';import { TextSelection } from '@tiptap/pm/state';import { NodeViewContent, NodeViewWrapper } from '@tiptap/react';-import {- AlignCenter,- AlignLeft,- AlignRight,- ArrowDown,- ArrowUp,- ExternalLink,- Pencil,- Settings2,- Trash2,-} from 'lucide-react';+import { ArrowDown, ArrowUp, ExternalLink, Pencil, Settings2, Trash2 } from 'lucide-react';import type { ReactNode } from 'react';import { useEffect, useRef, useState } from 'react';import { ErrorBoundary, type FallbackProps } from 'react-error-boundary';@@ -91,7 +81,6 @@ import {focusInsertedComponent,} from '../slash-command/component-items.tsx';import { ALIGNABLE_DESCRIPTOR_NAMES } from '../utils/alignable-descriptors.ts';-import { runWithAlignAnimation } from '../utils/animate-align-change.ts';import { formatContainerAriaLabel } from '../utils/editor-strings.ts';import { reconstructSource } from '../utils/reconstruct-source.ts';import { sanitizeComponentProps } from '../utils/sanitize-url.ts';@@ -603,82 +592,16 @@ export function JsxComponentView({ node, editor, extension, getPos, selected }:onMouseDown={(e) => e.stopPropagation()}{...{ [OPT_OUT_ATTR]: 'true' }}>- {/* Alignment — left / center / right buttons. Renders for every- descriptor in `ALIGNABLE_DESCRIPTOR_NAMES` (`img` + `CommonMarkImage`- + `Embed` + `video`). Placed in the hover-revealed chrome bar- rather than the bubble menu because clicking an image triggers- `react-medium-image-zoom`'s lightbox before PM can settle a- NodeSelection — the bubble-menu path doesn't reach the user.- Chrome bar shows on HOVER, no click required, so it sidesteps- the click-vs-zoom conflict for image and stays consistent for- video / Embed.-- CommonMarkImage's prop set is just src/alt/title — no align.- When the user picks a non-`center` alignment on a CommonMarkImage,- the click handler upgrades the descriptor to `img` (which DOES- have `align`) so the value persists through serialization. The- `` source upgrades to `<img ... align="…" />` on save- — a one-way conversion the user can revert by deleting the- block and re-typing the markdown. */}- {isAlignable &&- (- [- { value: 'left' as const, label: t`Align left`, Icon: AlignLeft },- { value: 'center' as const, label: t`Align center`, Icon: AlignCenter },- { value: 'right' as const, label: t`Align right`, Icon: AlignRight },- ] as const- ).map(({ value, label, Icon }) => {- const rawAlign =- typeof currentProps.align === 'string' ? currentProps.align : 'center';- const currentAlign =- rawAlign === 'left' || rawAlign === 'right' || rawAlign === 'center'- ? rawAlign- : 'center';- const isActive = currentAlign === value;- return (- <button- key={value}- type="button"- className="jsx-chrome-btn"- aria-label={label}- aria-pressed={isActive}- data-active={isActive ? 'true' : undefined}- onClick={(e) => {- if (typeof pos !== 'number') return;- const curNode = editor.state.doc.nodeAt(pos);- if (!curNode || curNode.type.name !== 'jsxComponent') return;- const wrapperEl = (e.currentTarget as HTMLElement).closest<HTMLElement>(- '.jsx-component-wrapper',- );- const curDescriptorName = String(curNode.attrs.componentName ?? '');- if (!ALIGNABLE_DESCRIPTOR_NAMES.has(curDescriptorName)) {- return;- }- const elementAttrs = getElementJsxAttrs(curNode.attrs);- if (!elementAttrs) return;- const isCommonMark = curDescriptorName === 'CommonMarkImage';- const nextProps = {- ...elementAttrs.props,- align: value,- };- const nextAttrs = isCommonMark- ? {- ...elementAttrs,- componentName: 'img',- props: nextProps,- sourceDirty: true,- }- : { ...elementAttrs, props: nextProps, sourceDirty: true };- runWithAlignAnimation(wrapperEl, () => {- editor.view.dispatch(editor.state.tr.setNodeMarkup(pos, null, nextAttrs));- markUserTyping();- });- }}- >- <Icon size={12} aria-hidden="true" />- </button>- );- })}+ {/* Alignment intentionally absent here — the bubble menu's+ `ImageAlignButtons` is the single alignment surface for every+ descriptor in `ALIGNABLE_DESCRIPTOR_NAMES` (`img` /+ `CommonMarkImage` / `Embed` / `video`). NodeSelection fires+ on the image click and the floating bubble bar lands centered+ above the block, so the old chrome-bar trio + PropPanel+ `Align` Select were redundant duplicates. CommonMarkImage's+ descriptor-upgrade path on first non-default alignment lives+ in `ImageAlignButtons` itself; removing it here doesn't lose+ the conversion. */}{/* Open in new tab — `Embed` only. Lets the reader hop to theembedded URL when they want the full browser surface.diff --git a/packages/app/src/locales/en/messages.json b/packages/app/src/locales/en/messages.jsonindex 80aa3bf1d..0d40e50b4 100644--- a/packages/app/src/locales/en/messages.json+++ b/packages/app/src/locales/en/messages.json@@ -87,7 +87,6 @@"2BBAbc": ["List"],"2FYpfJ": ["More"],"2GT3Hf": ["Global"],- "2IXDgU": ["Upload file"],"2QM24L": ["All tags"],"2RBzMG": ["Network error — check your connection and try again"],"2XQ8Ww": ["Open preview when agent edits"],@@ -322,7 +321,6 @@"8eW0WQ": ["No matching repositories."],"8fRyLo": ["Invalid patch payload"],"8fc_3j": ["Protected branch — cannot push"],- "8nOdkO": ["Align center"],"8tjQCz": ["Explore"],"8uAWix": ["This template lives in a parent folder — deleting it affects every folder beneath it that doesn't define its own version."@@ -596,7 +594,6 @@"IN4UX8": ["Search (", ["searchShortcut"], ")"],"INEQsp": ["Items to be created"],"IQPyrD": ["Missing page — click to create"],- "IR6Txi": ["Align left"],"IRv9cH": ["Cloned ", ["repoName"], "."],"IWGfGF": ["Checking your GitHub connection"],"IX7-sq": ["Something went wrong opening \"", ["docName"], "\"."],@@ -1122,6 +1119,7 @@"_VRtd7": ["Couldn't send the selection — please try again."],"_W-elG": ["(inline)"],"_XWY2J": ["Terminal disabled"],+ "_eguJc": ["Uploading"],"_gkGSK": ["deleted template"],"_pY_Vq": ["The repository was moved, renamed, or deleted."],"_qD6mn": ["Pick the folder where you've cloned it."],@@ -1248,6 +1246,7 @@"eBIT9h": ["Paste failed.", ["restoreSuffix"]],"eFJkVt": ["Clone failed: ", ["cloneError"]],"eG8Jsg": ["Toggle source tab focus mode"],+ "eJitUk": ["Upload from computer"],"eKThTQ": ["Failed to reorder"],"eNQGRb": ["Inline LaTeX math rendered with KaTeX."],"ePK91l": ["Edit"],@@ -1596,7 +1595,6 @@"pajIrl": ["Could not turn off the terminal: ", ["0"]],"pbwTg6": [["seconds"], "s ago"],"pckX1A": [["0", "plural", { "one": ["#", " use"], "other": ["#", " uses"] }]],- "pd0UH2": ["Align right"],"pgq_xf": [["0"], "/", ["1"], " ", ["2"]],"phM8Kh": ["Found the repo but could not open the project. Please try again."],"pha01Y": ["Project-level pages with no incoming graph edges."],diff --git a/packages/app/src/locales/en/messages.po b/packages/app/src/locales/en/messages.poindex 40f1de21f..cdeec4449 100644--- a/packages/app/src/locales/en/messages.po+++ b/packages/app/src/locales/en/messages.po@@ -606,18 +606,6 @@ msgstr "Agent activity"msgid "Agent configuration file"msgstr "Agent configuration file"-#: src/editor/extensions/JsxComponentView.tsx-msgid "Align center"-msgstr "Align center"--#: src/editor/extensions/JsxComponentView.tsx-msgid "Align left"-msgstr "Align left"--#: src/editor/extensions/JsxComponentView.tsx-msgid "Align right"-msgstr "Align right"-#: src/components/FolderOverview.tsxmsgid "All files"msgstr "All files"@@ -5926,13 +5914,17 @@ msgid "Upload failed: {message}"msgstr "Upload failed: {message}"#: src/editor/components/PropPanel.tsx-msgid "Upload file"-msgstr "Upload file"+msgid "Upload from computer"+msgstr "Upload from computer"#: src/components/FileTree.tsxmsgid "Upload may have succeeded but the sidebar is out of date — refresh to resync"msgstr "Upload may have succeeded but the sidebar is out of date — refresh to resync"+#: src/editor/components/PropPanel.tsx+msgid "Uploading"+msgstr "Uploading"+#: src/editor/image-upload/index.tsmsgid "Uploading {fileName}"msgstr "Uploading {fileName}"diff --git a/packages/app/src/locales/pseudo/messages.json b/packages/app/src/locales/pseudo/messages.jsonindex 6628ae1c7..d9bc7e4de 100644--- a/packages/app/src/locales/pseudo/messages.json+++ b/packages/app/src/locales/pseudo/messages.json@@ -87,7 +87,6 @@"2BBAbc": ["Ĺĩśţ"],"2FYpfJ": ["Ḿōŕē"],"2GT3Hf": ["Ĝĺōƀàĺ"],- "2IXDgU": ["Ũƥĺōàď ƒĩĺē"],"2QM24L": ["Àĺĺ ţàĝś"],"2RBzMG": ["Ńēţŵōŕķ ēŕŕōŕ — ćĥēćķ ŷōũŕ ćōńńēćţĩōń àńď ţŕŷ àĝàĩń"],"2XQ8Ww": ["Ōƥēń ƥŕēvĩēŵ ŵĥēń àĝēńţ ēďĩţś"],@@ -322,7 +321,6 @@"8eW0WQ": ["Ńō ḿàţćĥĩńĝ ŕēƥōśĩţōŕĩēś."],"8fRyLo": ["Ĩńvàĺĩď ƥàţćĥ ƥàŷĺōàď"],"8fc_3j": ["Ƥŕōţēćţēď ƀŕàńćĥ — ćàńńōţ ƥũśĥ"],- "8nOdkO": ["Àĺĩĝń ćēńţēŕ"],"8tjQCz": ["Ēxƥĺōŕē"],"8uAWix": ["Ţĥĩś ţēḿƥĺàţē ĺĩvēś ĩń à ƥàŕēńţ ƒōĺďēŕ — ďēĺēţĩńĝ ĩţ àƒƒēćţś ēvēŕŷ ƒōĺďēŕ ƀēńēàţĥ ĩţ ţĥàţ ďōēśń'ţ ďēƒĩńē ĩţś ōŵń vēŕśĩōń."@@ -596,7 +594,6 @@"IN4UX8": ["Śēàŕćĥ (", ["searchShortcut"], ")"],"INEQsp": ["Ĩţēḿś ţō ƀē ćŕēàţēď"],"IQPyrD": ["Ḿĩśśĩńĝ ƥàĝē — ćĺĩćķ ţō ćŕēàţē"],- "IR6Txi": ["Àĺĩĝń ĺēƒţ"],"IRv9cH": ["Ćĺōńēď ", ["repoName"], "."],"IWGfGF": ["Ćĥēćķĩńĝ ŷōũŕ ĜĩţĤũƀ ćōńńēćţĩōń"],"IX7-sq": ["Śōḿēţĥĩńĝ ŵēńţ ŵŕōńĝ ōƥēńĩńĝ \"", ["docName"], "\"."],@@ -1122,6 +1119,7 @@"_VRtd7": ["Ćōũĺďń'ţ śēńď ţĥē śēĺēćţĩōń — ƥĺēàśē ţŕŷ àĝàĩń."],"_W-elG": ["(ĩńĺĩńē)"],"_XWY2J": ["Ţēŕḿĩńàĺ ďĩśàƀĺēď"],+ "_eguJc": ["Ũƥĺōàďĩńĝ"],"_gkGSK": ["ďēĺēţēď ţēḿƥĺàţē"],"_pY_Vq": ["Ţĥē ŕēƥōśĩţōŕŷ ŵàś ḿōvēď, ŕēńàḿēď, ōŕ ďēĺēţēď."],"_qD6mn": ["Ƥĩćķ ţĥē ƒōĺďēŕ ŵĥēŕē ŷōũ'vē ćĺōńēď ĩţ."],@@ -1248,6 +1246,7 @@"eBIT9h": ["Ƥàśţē ƒàĩĺēď.", ["restoreSuffix"]],"eFJkVt": ["Ćĺōńē ƒàĩĺēď: ", ["cloneError"]],"eG8Jsg": ["Ţōĝĝĺē śōũŕćē ţàƀ ƒōćũś ḿōďē"],+ "eJitUk": ["Ũƥĺōàď ƒŕōḿ ćōḿƥũţēŕ"],"eKThTQ": ["Ƒàĩĺēď ţō ŕēōŕďēŕ"],"eNQGRb": ["Ĩńĺĩńē ĹàŢēX ḿàţĥ ŕēńďēŕēď ŵĩţĥ ĶàŢēX."],"ePK91l": ["Ēďĩţ"],@@ -1596,7 +1595,6 @@"pajIrl": ["Ćōũĺď ńōţ ţũŕń ōƒƒ ţĥē ţēŕḿĩńàĺ: ", ["0"]],"pbwTg6": [["seconds"], "ś àĝō"],"pckX1A": [["0", "plural", { "one": ["#", " ũśē"], "other": ["#", " ũśēś"] }]],- "pd0UH2": ["Àĺĩĝń ŕĩĝĥţ"],"pgq_xf": [["0"], "/", ["1"], " ", ["2"]],"phM8Kh": ["Ƒōũńď ţĥē ŕēƥō ƀũţ ćōũĺď ńōţ ōƥēń ţĥē ƥŕōĴēćţ. Ƥĺēàśē ţŕŷ àĝàĩń."],"pha01Y": ["ƤŕōĴēćţ-ĺēvēĺ ƥàĝēś ŵĩţĥ ńō ĩńćōḿĩńĝ ĝŕàƥĥ ēďĝēś."],diff --git a/packages/app/src/locales/pseudo/messages.po b/packages/app/src/locales/pseudo/messages.poindex d9d958f58..759d70a86 100644--- a/packages/app/src/locales/pseudo/messages.po+++ b/packages/app/src/locales/pseudo/messages.po@@ -601,18 +601,6 @@ msgstr ""msgid "Agent configuration file"msgstr ""-#: src/editor/extensions/JsxComponentView.tsx-msgid "Align center"-msgstr ""--#: src/editor/extensions/JsxComponentView.tsx-msgid "Align left"-msgstr ""--#: src/editor/extensions/JsxComponentView.tsx-msgid "Align right"-msgstr ""-#: src/components/FolderOverview.tsxmsgid "All files"msgstr ""@@ -5921,13 +5909,17 @@ msgid "Upload failed: {message}"msgstr ""#: src/editor/components/PropPanel.tsx-msgid "Upload file"+msgid "Upload from computer"msgstr ""#: src/components/FileTree.tsxmsgid "Upload may have succeeded but the sidebar is out of date — refresh to resync"msgstr ""+#: src/editor/components/PropPanel.tsx+msgid "Uploading"+msgstr ""+#: src/editor/image-upload/index.tsmsgid "Uploading {fileName}"msgstr ""diff --git a/packages/core/src/registry/built-ins.ts b/packages/core/src/registry/built-ins.tsindex 0773009b2..ec15c0375 100644--- a/packages/core/src/registry/built-ins.ts+++ b/packages/core/src/registry/built-ins.ts@@ -187,6 +187,7 @@ const htmlImgProps: PropDef[] = [required: false,omitOnDefault: true,description: 'Alignment within the column',+ hidden: true,},];@@ -229,6 +230,7 @@ const embedProps: PropDef[] = [required: false,omitOnDefault: true,description: 'Alignment within the column',+ hidden: true,},];@@ -334,6 +336,7 @@ const htmlVideoProps: PropDef[] = [required: false,omitOnDefault: true,description: 'Alignment within the column',+ hidden: true,},];diff --git a/packages/core/src/registry/registry.test.ts b/packages/core/src/registry/registry.test.tsindex d0f8fa18b..43b5674d7 100644--- a/packages/core/src/registry/registry.test.ts+++ b/packages/core/src/registry/registry.test.ts@@ -232,7 +232,7 @@ describe('builtInComponents manifest', () => {);});- test('img.align is a 3-value enum with center default (omitOnDefault, common-tier)', () => {+ test('img.align is a 3-value enum with center default, hidden from PropPanel', () => {const img = builtInComponents.find((m) => m.name === 'img');const align = img?.props.find((p) => p.name === 'align');expect(align).toBeDefined();@@ -241,6 +241,7 @@ describe('builtInComponents manifest', () => {expect(align.defaultValue).toBe('center');expect(align.omitOnDefault).toBe(true);expect(align.advanced).toBeUndefined();+ expect(align.hidden).toBe(true);expect(align.enumValues[0]).toBe('center');}});@@ -332,6 +333,16 @@ describe('builtInComponents manifest', () => {expect(videoAlign).toEqual(imgAlign);});+ test('Embed.align mirrors img.align (single alignment surface — bubble menu)', () => {+ const img = builtInComponents.find((m) => m.name === 'img');+ const embed = builtInComponents.find((m) => m.name === 'Embed');+ const imgAlign = img?.props.find((p) => p.name === 'align');+ const embedAlign = embed?.props.find((p) => p.name === 'align');+ expect(imgAlign).toBeDefined();+ expect(embedAlign).toBeDefined();+ expect(embedAlign).toEqual(imgAlign);+ });+test('video has `controls` as a boolean with `true` default', () => {const video = builtInComponents.find((m) => m.name === 'video');const controls = video?.props.find((p) => p.name === 'controls');