Skip to content

Beautiful, AI-native markdown IDE and LLM wiki

Apply logical assignment shorthand across oxlint-flagged sites (#1779)

Dimitri POSTOLOVfd093df8f8d3
diff --git a/oxlint.config.ts b/oxlint.config.ts
index e70cdf1dc..429266274 100644
--- a/oxlint.config.ts
+++ b/oxlint.config.ts
@@ -7,6 +7,13 @@ export default defineConfig({
},
jsPlugins: ['oxlint-plugin-eslint'],
rules: {
+ 'eslint/logical-assignment-operators': [
+ 'error',
+ 'always',
+ {
+ enforceForIfStatements: true,
+ },
+ ],
'eslint-js/no-restricted-syntax': [
'error',
{
diff --git a/packages/app/src/editor/components/Mermaid.tsx b/packages/app/src/editor/components/Mermaid.tsx
index e3f587ee3..b76c73568 100644
--- a/packages/app/src/editor/components/Mermaid.tsx
+++ b/packages/app/src/editor/components/Mermaid.tsx
@@ -14,23 +14,21 @@ interface RenderState {
let mermaidPromise: Promise<typeof import('mermaid').default> | null = null;
function loadMermaid() {
- if (!mermaidPromise) {
- mermaidPromise = import('mermaid')
- .then((mod) => {
- const m = mod.default;
- m.initialize({
- startOnLoad: false,
- securityLevel: 'strict',
- theme: 'default',
- suppressErrorRendering: true,
- });
- return m;
- })
- .catch((err) => {
- mermaidPromise = null;
- throw err;
+ mermaidPromise ||= import('mermaid')
+ .then((mod) => {
+ const m = mod.default;
+ m.initialize({
+ startOnLoad: false,
+ securityLevel: 'strict',
+ theme: 'default',
+ suppressErrorRendering: true,
});
- }
+ return m;
+ })
+ .catch((err) => {
+ mermaidPromise = null;
+ throw err;
+ });
return mermaidPromise;
}
diff --git a/packages/app/src/editor/editor-cache.ts b/packages/app/src/editor/editor-cache.ts
index fa01921ab..4aa7e4d57 100644
--- a/packages/app/src/editor/editor-cache.ts
+++ b/packages/app/src/editor/editor-cache.ts
@@ -382,9 +382,7 @@ export function parkTiptapEditor(entry: TiptapCacheEntry): void {
if (parent) {
parent.removeChild(view.dom);
}
- if (!entry.parkingNode) {
- entry.parkingNode = tryCreateParkingNode();
- }
+ entry.parkingNode ||= tryCreateParkingNode();
if (entry.parkingNode) {
entry.parkingNode.appendChild(view.dom);
}
@@ -569,9 +567,7 @@ export function parkCmEditor(entry: CmCacheEntry): void {
if (parent) {
parent.removeChild(dom);
}
- if (!entry.parkingNode) {
- entry.parkingNode = tryCreateParkingNode();
- }
+ entry.parkingNode ||= tryCreateParkingNode();
if (entry.parkingNode) {
entry.parkingNode.appendChild(dom);
}
diff --git a/packages/app/src/editor/extensions/preview-iframe-csp-violation.test.ts b/packages/app/src/editor/extensions/preview-iframe-csp-violation.test.ts
index c2faa4ed7..f07817fb2 100644
--- a/packages/app/src/editor/extensions/preview-iframe-csp-violation.test.ts
+++ b/packages/app/src/editor/extensions/preview-iframe-csp-violation.test.ts
@@ -10,7 +10,7 @@ function evalBootstrap() {
const script = header.match(/<script>([\s\S]*?)<\/script>/)?.[1] ?? '';
const listeners: Record<string, Array<(e: unknown) => void>> = {};
const addEventListener = (type: string, fn: (e: unknown) => void) => {
- if (!listeners[type]) listeners[type] = [];
+ listeners[type] ||= [];
listeners[type].push(fn);
};
const postMessage = mock((_msg: unknown, _origin?: string) => {});
diff --git a/packages/app/src/editor/extensions/selection-state-plugin.ts b/packages/app/src/editor/extensions/selection-state-plugin.ts
index e9d7e5f1c..49cbb9e5e 100644
--- a/packages/app/src/editor/extensions/selection-state-plugin.ts
+++ b/packages/app/src/editor/extensions/selection-state-plugin.ts
@@ -118,7 +118,7 @@ function deriveRangeEncompassedBlockIds(
const node = state.doc.nodeAt(pos);
if (!node) continue;
if (pos + node.nodeSize > to) continue;
- if (!ids) ids = new Set<string>();
+ ids ||= new Set<string>();
ids.add(id);
}
return ids ?? EMPTY_RANGE_SET;
diff --git a/packages/app/src/editor/extensions/tag-suggestion.ts b/packages/app/src/editor/extensions/tag-suggestion.ts
index f71bb2910..3e22b042b 100644
--- a/packages/app/src/editor/extensions/tag-suggestion.ts
+++ b/packages/app/src/editor/extensions/tag-suggestion.ts
@@ -110,9 +110,7 @@ export function configureTagSuggestion(editor: Editor) {
items: async ({ query }) => {
if (!tagsLoaded) {
- if (!tagsPromise) {
- tagsPromise = fetchTags();
- }
+ tagsPromise ||= fetchTags();
try {
cachedTags = await tagsPromise;
fetchError = null;
diff --git a/packages/app/src/editor/extensions/wiki-link-suggestion.ts b/packages/app/src/editor/extensions/wiki-link-suggestion.ts
index ce3c97229..de929ee1c 100644
--- a/packages/app/src/editor/extensions/wiki-link-suggestion.ts
+++ b/packages/app/src/editor/extensions/wiki-link-suggestion.ts
@@ -320,9 +320,7 @@ export function configureWikiLinkSuggestion(editor: Editor) {
}
if (!pagesLoaded) {
- if (!pagesPromise) {
- pagesPromise = fetchPages();
- }
+ pagesPromise ||= fetchPages();
try {
cachedPages = await pagesPromise;
fetchError = null;
diff --git a/packages/app/src/editor/utils/md-singleton.ts b/packages/app/src/editor/utils/md-singleton.ts
index 73c44d62c..cd45c8e87 100644
--- a/packages/app/src/editor/utils/md-singleton.ts
+++ b/packages/app/src/editor/utils/md-singleton.ts
@@ -3,8 +3,6 @@ import { MarkdownManager, sharedExtensions } from '@inkeep/open-knowledge-core';
let manager: MarkdownManager | null = null;
export function getSharedMarkdownManager(): MarkdownManager {
- if (!manager) {
- manager = new MarkdownManager({ extensions: sharedExtensions });
- }
+ manager ||= new MarkdownManager({ extensions: sharedExtensions });
return manager;
}
diff --git a/packages/app/src/lib/perf/collector.ts b/packages/app/src/lib/perf/collector.ts
index 64bc16c83..f679acee6 100644
--- a/packages/app/src/lib/perf/collector.ts
+++ b/packages/app/src/lib/perf/collector.ts
@@ -51,9 +51,7 @@ function createCollector(): PerfCollector {
export function getCollector(): PerfCollector | undefined {
if (import.meta.env?.PROD) return undefined;
const g = globalThis as unknown as PerfGlobal;
- if (!g[GLOBAL_KEY]) {
- g[GLOBAL_KEY] = createCollector();
- }
+ g[GLOBAL_KEY] ||= createCollector();
return g[GLOBAL_KEY];
}
diff --git a/packages/app/tests/dom/jsdom-preload.ts b/packages/app/tests/dom/jsdom-preload.ts
index c15c77fd9..dd888861d 100644
--- a/packages/app/tests/dom/jsdom-preload.ts
+++ b/packages/app/tests/dom/jsdom-preload.ts
@@ -62,9 +62,7 @@ const matchMediaStub = (query: string): MediaQueryList =>
(globalThis as { matchMedia?: typeof matchMediaStub }).matchMedia = matchMediaStub;
(win as { matchMedia?: typeof matchMediaStub }).matchMedia = matchMediaStub;
-if (!win.HTMLElement.prototype.scrollIntoView) {
- win.HTMLElement.prototype.scrollIntoView = () => {};
-}
+win.HTMLElement.prototype.scrollIntoView ||= () => {};
if (typeof (globalThis as { MessageChannel?: unknown }).MessageChannel === 'undefined') {
class MinimalMessagePort {
diff --git a/packages/app/tests/integration/jsx-schema-narrowing-safety.test.ts b/packages/app/tests/integration/jsx-schema-narrowing-safety.test.ts
index c8d88f4c3..043714d87 100644
--- a/packages/app/tests/integration/jsx-schema-narrowing-safety.test.ts
+++ b/packages/app/tests/integration/jsx-schema-narrowing-safety.test.ts
@@ -11,7 +11,7 @@ interface YpsCounters {
function readCounters(): YpsCounters {
const host = globalThis as { __okYpsCounters?: YpsCounters };
- if (!host.__okYpsCounters) host.__okYpsCounters = { block: 0, inline: 0 };
+ host.__okYpsCounters ||= { block: 0, inline: 0 };
return { ...host.__okYpsCounters };
}
diff --git a/packages/app/tests/integration/y-tiptap-schema-throw-substitution.test.ts b/packages/app/tests/integration/y-tiptap-schema-throw-substitution.test.ts
index 5f8adf755..de1e35795 100644
--- a/packages/app/tests/integration/y-tiptap-schema-throw-substitution.test.ts
+++ b/packages/app/tests/integration/y-tiptap-schema-throw-substitution.test.ts
@@ -12,9 +12,7 @@ interface YpsCounters {
function readCounters(): YpsCounters {
const host = globalThis as { __okYpsCounters?: YpsCounters };
- if (!host.__okYpsCounters) {
- host.__okYpsCounters = { block: 0, inline: 0 };
- }
+ host.__okYpsCounters ||= { block: 0, inline: 0 };
return { ...host.__okYpsCounters };
}
diff --git a/packages/cli/src/commands/start.ts b/packages/cli/src/commands/start.ts
index 703142c41..d5b987a64 100644
--- a/packages/cli/src/commands/start.ts
+++ b/packages/cli/src/commands/start.ts
@@ -471,9 +471,7 @@ export async function bootStartServer(opts: BootStartServerOptions): Promise<Boo
...(opts.reactShellDistDir ? { reactShellDistDir: opts.reactShellDistDir } : {}),
});
- if (!uiSpawnDecision) {
- uiSpawnDecision = { action: 'skip', reason: 'alive', pid: 0, port: 0 };
- }
+ uiSpawnDecision ||= { action: 'skip', reason: 'alive', pid: 0, port: 0 };
const decisionAtBoot: UiSpawnDecision = uiSpawnDecision;
let resolvedUiPort: number | null = null;
diff --git a/packages/core/src/markdown/callout-transformer.ts b/packages/core/src/markdown/callout-transformer.ts
index f5c78cc0f..83d47404a 100644
--- a/packages/core/src/markdown/callout-transformer.ts
+++ b/packages/core/src/markdown/callout-transformer.ts
@@ -204,7 +204,7 @@ export function calloutTransformerPlugin() {
opener = inspectOpenerLine(source, node.position.start.offset);
if (opener) {
title = opener.title;
- if (!type) type = normalizeType(opener.rawType);
+ type ||= normalizeType(opener.rawType);
}
}
diff --git a/packages/core/src/markdown/html-to-mdast.test.ts b/packages/core/src/markdown/html-to-mdast.test.ts
index b5f693d77..d4d7f8f58 100644
--- a/packages/core/src/markdown/html-to-mdast.test.ts
+++ b/packages/core/src/markdown/html-to-mdast.test.ts
@@ -172,7 +172,7 @@ describe('htmlToMdast — Branch D source-form attr defaults (FR-39)', () => {
): T | undefined {
let found: T | undefined;
visit(tree, type, (node) => {
- if (!found) found = node as T;
+ found ||= node as T;
});
return found;
}
diff --git a/packages/core/src/markdown/index.ts b/packages/core/src/markdown/index.ts
index 05203d59b..1644f78cd 100644
--- a/packages/core/src/markdown/index.ts
+++ b/packages/core/src/markdown/index.ts
@@ -920,8 +920,8 @@ function buildMdastToPmHandlers(
});
}
- if (!handlers.math) handlers.math = blockUnknownHandler;
- if (!handlers.inlineMath) handlers.inlineMath = inlineUnknownHandler;
+ handlers.math ||= blockUnknownHandler;
+ handlers.inlineMath ||= inlineUnknownHandler;
if (n.footnoteReference) {
handlers.footnoteReference = (node: FootnoteReference) =>
@@ -929,8 +929,8 @@ function buildMdastToPmHandlers(
identifier: node.identifier,
label: node.label ?? node.identifier,
});
- } else if (!handlers.footnoteReference) {
- handlers.footnoteReference = (node: FootnoteReference) => {
+ } else {
+ handlers.footnoteReference ||= (node: FootnoteReference) => {
console.warn(
JSON.stringify({
event: 'unknown-mdast-type',
@@ -949,8 +949,8 @@ function buildMdastToPmHandlers(
label: def.label ?? def.identifier,
};
});
- } else if (!handlers.footnoteDefinition) {
- handlers.footnoteDefinition = (node: FootnoteDefinition) => {
+ } else {
+ handlers.footnoteDefinition ||= (node: FootnoteDefinition) => {
console.warn(
JSON.stringify({
event: 'unknown-mdast-type',
@@ -1517,8 +1517,8 @@ function buildPmToMdastHandlers(schema: Schema): {
for (const child of children) {
if (child.type === 'text' && child.value) {
const textChild = child as Text;
- textChild.data = textChild.data ?? {};
- textChild.data.escapedChars = textChild.data.escapedChars ?? [];
+ textChild.data ??= {};
+ textChild.data.escapedChars ??= [];
for (let i = 0; i < textChild.value.length; i++) {
textChild.data.escapedChars.push({ offset: i, char: textChild.value[i] });
}
@@ -1535,7 +1535,7 @@ function buildPmToMdastHandlers(schema: Schema): {
const textChild = children[0] as Text;
const candidate = raw || textChild.value;
if (isValidSourceLiteralRaw(candidate, textChild.value)) {
- textChild.data = textChild.data ?? {};
+ textChild.data ??= {};
textChild.data.sourceRaw = candidate;
}
return textChild;
diff --git a/packages/core/src/markdown/position-slice.test.ts b/packages/core/src/markdown/position-slice.test.ts
index 6a302a9b0..7a1f07a2b 100644
--- a/packages/core/src/markdown/position-slice.test.ts
+++ b/packages/core/src/markdown/position-slice.test.ts
@@ -19,7 +19,7 @@ function parseMdast(source: string): Root {
function findNode<T extends AnyNode = AnyNode>(tree: Root, type: string): T {
let found: AnyNode | null = null;
visit(tree, type, (node) => {
- if (!found) found = node as AnyNode;
+ found ||= node as AnyNode;
});
return found as unknown as T;
}
diff --git a/packages/core/src/markdown/position-slice.ts b/packages/core/src/markdown/position-slice.ts
index e6f7a26e2..90a412726 100644
--- a/packages/core/src/markdown/position-slice.ts
+++ b/packages/core/src/markdown/position-slice.ts
@@ -450,7 +450,7 @@ export function applyPositionSliceToNode(
while (rightPad < seg.length - leftPad && seg[seg.length - 1 - rightPad] === ' ') {
rightPad++;
}
- if (!cell.data) cell.data = {};
+ cell.data ||= {};
cell.data.sourcePadding = { left: leftPad, right: rightPad };
}
}
diff --git a/packages/core/src/markdown/remark-mdx-agnostic.ts b/packages/core/src/markdown/remark-mdx-agnostic.ts
index b9b16e19b..c570a5806 100644
--- a/packages/core/src/markdown/remark-mdx-agnostic.ts
+++ b/packages/core/src/markdown/remark-mdx-agnostic.ts
@@ -9,9 +9,9 @@ const TO_MARKDOWN_EXT = mdxToMarkdown();
export function remarkMdxAgnostic(this: Processor): void {
const data = this.data();
- if (!data.micromarkExtensions) data.micromarkExtensions = [];
- if (!data.fromMarkdownExtensions) data.fromMarkdownExtensions = [];
- if (!data.toMarkdownExtensions) data.toMarkdownExtensions = [];
+ data.micromarkExtensions ||= [];
+ data.fromMarkdownExtensions ||= [];
+ data.toMarkdownExtensions ||= [];
const micromarkExts = data.micromarkExtensions as unknown[];
if (!micromarkExts.some((e) => e === MICROMARK_EXT)) {
diff --git a/packages/core/src/markdown/wiki-link-micromark.ts b/packages/core/src/markdown/wiki-link-micromark.ts
index 7aaf1099c..6dad26200 100644
--- a/packages/core/src/markdown/wiki-link-micromark.ts
+++ b/packages/core/src/markdown/wiki-link-micromark.ts
@@ -394,17 +394,17 @@ export function remarkWikiLink(this: Processor) {
toMarkdownExtensions?: unknown[];
};
- if (!data.micromarkExtensions) data.micromarkExtensions = [];
+ data.micromarkExtensions ||= [];
if (!data.micromarkExtensions.some((e) => e === MICROMARK_EXT)) {
data.micromarkExtensions.push(MICROMARK_EXT);
}
- if (!data.fromMarkdownExtensions) data.fromMarkdownExtensions = [];
+ data.fromMarkdownExtensions ||= [];
if (!data.fromMarkdownExtensions.some((e) => e === wikiLinkFromMarkdown)) {
data.fromMarkdownExtensions.push(wikiLinkFromMarkdown);
}
- if (!data.toMarkdownExtensions) data.toMarkdownExtensions = [];
+ data.toMarkdownExtensions ||= [];
if (!data.toMarkdownExtensions.some((e) => e === wikiLinkToMarkdown)) {
data.toMarkdownExtensions.push(wikiLinkToMarkdown);
}
diff --git a/packages/core/src/metrics/parse-health.test.ts b/packages/core/src/metrics/parse-health.test.ts
index 5bcb635b7..18df64d16 100644
--- a/packages/core/src/metrics/parse-health.test.ts
+++ b/packages/core/src/metrics/parse-health.test.ts
@@ -106,7 +106,7 @@ describe('parse-health metrics', () => {
__okYpsCounters?: { block: number; inline: number };
};
const g = globalThis as GlobalWithCounters;
- g.__okYpsCounters = g.__okYpsCounters || { block: 0, inline: 0 };
+ g.__okYpsCounters ||= { block: 0, inline: 0 };
g.__okYpsCounters.block += 5;
g.__okYpsCounters.inline += 2;
diff --git a/packages/core/src/metrics/parse-health.ts b/packages/core/src/metrics/parse-health.ts
index daef50f0c..b950584f3 100644
--- a/packages/core/src/metrics/parse-health.ts
+++ b/packages/core/src/metrics/parse-health.ts
@@ -9,9 +9,7 @@ interface YpsCountersHost {
function ypsCounters(): YpsCounters {
const host = globalThis as YpsCountersHost;
- if (!host.__okYpsCounters) {
- host.__okYpsCounters = { block: 0, inline: 0 };
- }
+ host.__okYpsCounters ||= { block: 0, inline: 0 };
return host.__okYpsCounters;
}
diff --git a/packages/core/src/utils/link-targets.ts b/packages/core/src/utils/link-targets.ts
index 0aa10299c..622105cd5 100644
--- a/packages/core/src/utils/link-targets.ts
+++ b/packages/core/src/utils/link-targets.ts
@@ -163,9 +163,7 @@ export function buildRelativeMarkdownHref(
const downSegments = targetSegments.slice(commonPrefixLength);
let relativePath = [...upSegments, ...downSegments].join('/');
- if (!relativePath) {
- relativePath = targetSegments.at(-1) ?? targetDocName;
- }
+ relativePath ||= targetSegments.at(-1) ?? targetDocName;
if (!relativePath.startsWith('./') && !relativePath.startsWith('../')) {
relativePath = `./${relativePath}`;
diff --git a/packages/desktop/src/main/index.ts b/packages/desktop/src/main/index.ts
index 1191fdbaf..8b7ad5f6f 100644
--- a/packages/desktop/src/main/index.ts
+++ b/packages/desktop/src/main/index.ts
@@ -2606,23 +2606,19 @@ function bootPrimaryInstance(): void {
let _trashItemDurationHistCache: ReturnType<ReturnType<typeof getMeter>['createHistogram']> | null =
null;
function _trashItemDurationHist() {
- if (!_trashItemDurationHistCache) {
- _trashItemDurationHistCache = getMeter().createHistogram('ok.shell.trash_item.duration_ms', {
- description: 'Duration of ok:shell:trash-item IPC dispatches in milliseconds',
- unit: 'ms',
- });
- }
+ _trashItemDurationHistCache ||= getMeter().createHistogram('ok.shell.trash_item.duration_ms', {
+ description: 'Duration of ok:shell:trash-item IPC dispatches in milliseconds',
+ unit: 'ms',
+ });
return _trashItemDurationHistCache;
}
let _trashItemFailureCounterCache: ReturnType<ReturnType<typeof getMeter>['createCounter']> | null =
null;
function _trashItemFailureCounter() {
- if (!_trashItemFailureCounterCache) {
- _trashItemFailureCounterCache = getMeter().createCounter('ok.shell.trash_item.failures', {
- description: 'Count of ok:shell:trash-item handler failures, labeled by reason',
- });
- }
+ _trashItemFailureCounterCache ||= getMeter().createCounter('ok.shell.trash_item.failures', {
+ description: 'Count of ok:shell:trash-item handler failures, labeled by reason',
+ });
return _trashItemFailureCounterCache;
}
@@ -2630,15 +2626,13 @@ let _openInTerminalDurationHistCache: ReturnType<
ReturnType<typeof getMeter>['createHistogram']
> | null = null;
function _openInTerminalDurationHist() {
- if (!_openInTerminalDurationHistCache) {
- _openInTerminalDurationHistCache = getMeter().createHistogram(
- 'ok.shell.open_in_terminal.duration_ms',
- {
- description: 'Duration of ok:shell:open-in-terminal IPC dispatches in milliseconds',
- unit: 'ms',
- },
- );
- }
+ _openInTerminalDurationHistCache ||= getMeter().createHistogram(
+ 'ok.shell.open_in_terminal.duration_ms',
+ {
+ description: 'Duration of ok:shell:open-in-terminal IPC dispatches in milliseconds',
+ unit: 'ms',
+ },
+ );
return _openInTerminalDurationHistCache;
}
@@ -2646,13 +2640,11 @@ let _openInTerminalFailureCounterCache: ReturnType<
ReturnType<typeof getMeter>['createCounter']
> | null = null;
function _openInTerminalFailureCounter() {
- if (!_openInTerminalFailureCounterCache) {
- _openInTerminalFailureCounterCache = getMeter().createCounter(
- 'ok.shell.open_in_terminal.failures',
- {
- description: 'Count of ok:shell:open-in-terminal handler failures, labeled by reason',
- },
- );
- }
+ _openInTerminalFailureCounterCache ||= getMeter().createCounter(
+ 'ok.shell.open_in_terminal.failures',
+ {
+ description: 'Count of ok:shell:open-in-terminal handler failures, labeled by reason',
+ },
+ );
return _openInTerminalFailureCounterCache;
}
diff --git a/packages/desktop/tests/main/url-scheme-handler.test.ts b/packages/desktop/tests/main/url-scheme-handler.test.ts
index 5f6c92220..2ea9c1d18 100644
--- a/packages/desktop/tests/main/url-scheme-handler.test.ts
+++ b/packages/desktop/tests/main/url-scheme-handler.test.ts
@@ -120,7 +120,7 @@ function makeEnv(opts?: { isPackaged?: boolean }): TestEnv {
): Promise<FakeWindowHandle | null> => {
const win: FakeWindowHandle = { id: `win-${p}` };
existingWindows.set(p, win);
- if (!readyWindow) readyWindow = win;
+ readyWindow ||= win;
return win;
},
),
diff --git a/packages/server/src/api-extension.ts b/packages/server/src/api-extension.ts
index 46bb10773..9d59cf116 100644
--- a/packages/server/src/api-extension.ts
+++ b/packages/server/src/api-extension.ts
@@ -458,38 +458,32 @@ import { getDocumentHistory, getFolderTimeline } from './timeline-query.ts';
let _httpDurationHist: ReturnType<ReturnType<typeof getMeter>['createHistogram']> | null = null;
function httpDurationHist(): ReturnType<ReturnType<typeof getMeter>['createHistogram']> {
- if (!_httpDurationHist) {
- _httpDurationHist = getMeter().createHistogram('http.server.request.duration', {
- description: 'HTTP server request duration in seconds',
- unit: 's',
- });
- }
+ _httpDurationHist ||= getMeter().createHistogram('http.server.request.duration', {
+ description: 'HTTP server request duration in seconds',
+ unit: 's',
+ });
return _httpDurationHist;
}
let _hintEmittedCounter: ReturnType<ReturnType<typeof getMeter>['createCounter']> | null = null;
function hintEmittedCounter(): ReturnType<ReturnType<typeof getMeter>['createCounter']> {
- if (!_hintEmittedCounter) {
- _hintEmittedCounter = getMeter().createCounter('ok.preview_attach.hint_emitted', {
- description:
- 'Count of preview-attach hints emitted on write-tool responses when no editor is attached to __system__. Covers both attach-preview-once (URL exists, no browser) and start-ui (no UI running anywhere) variants — the tool side disambiguates via the warning action; the metric name is retained as-is so existing dashboards keep working.',
- });
- }
+ _hintEmittedCounter ||= getMeter().createCounter('ok.preview_attach.hint_emitted', {
+ description:
+ 'Count of preview-attach hints emitted on write-tool responses when no editor is attached to __system__. Covers both attach-preview-once (URL exists, no browser) and start-ui (no UI running anywhere) variants — the tool side disambiguates via the warning action; the metric name is retained as-is so existing dashboards keep working.',
+ });
return _hintEmittedCounter;
}
let _agentPatchFmTouchCounter: ReturnType<ReturnType<typeof getMeter>['createCounter']> | null =
null;
function agentPatchFmTouchCounter(): ReturnType<ReturnType<typeof getMeter>['createCounter']> {
- if (!_agentPatchFmTouchCounter) {
- _agentPatchFmTouchCounter = getMeter().createCounter(
- 'ok.frontmatter.agent_patch_fm_touch_total',
- {
- description:
- 'Count of agent-patch calls whose find string targets the frontmatter region. Measures incidence during the soft-deprecation window before agent-patch FM-intersecting calls are enforced as 400. Bounded label: result ∈ {rejected, pre_deprecation_passthrough}.',
- },
- );
- }
+ _agentPatchFmTouchCounter ||= getMeter().createCounter(
+ 'ok.frontmatter.agent_patch_fm_touch_total',
+ {
+ description:
+ 'Count of agent-patch calls whose find string targets the frontmatter region. Measures incidence during the soft-deprecation window before agent-patch FM-intersecting calls are enforced as 400. Bounded label: result ∈ {rejected, pre_deprecation_passthrough}.',
+ },
+ );
return _agentPatchFmTouchCounter;
}
@@ -502,24 +496,20 @@ function findLooksLikeFrontmatter(find: string): boolean {
let _renameAttributionCounter: ReturnType<ReturnType<typeof getMeter>['createCounter']> | null =
null;
function renameAttributionCounter(): ReturnType<ReturnType<typeof getMeter>['createCounter']> {
- if (!_renameAttributionCounter) {
- _renameAttributionCounter = getMeter().createCounter('ok.rename.attribution_kind', {
- description:
- 'Count of rename and rollback handler dispatches by attribution kind (agent | principal | anonymous)',
- });
- }
+ _renameAttributionCounter ||= getMeter().createCounter('ok.rename.attribution_kind', {
+ description:
+ 'Count of rename and rollback handler dispatches by attribution kind (agent | principal | anonymous)',
+ });
return _renameAttributionCounter;
}
let _agentWriteGateFiredCounter: ReturnType<ReturnType<typeof getMeter>['createCounter']> | null =
null;
function agentWriteGateFiredCounter(): ReturnType<ReturnType<typeof getMeter>['createCounter']> {
- if (!_agentWriteGateFiredCounter) {
- _agentWriteGateFiredCounter = getMeter().createCounter('ok.agent_write.gate_fired_total', {
- description:
- 'Count of agent writes that ran the Site A content-divergence gate (denominator for the divergence rate). Bounded label: handler ∈ {agent-write-md, agent-patch, rollback}.',
- });
- }
+ _agentWriteGateFiredCounter ||= getMeter().createCounter('ok.agent_write.gate_fired_total', {
+ description:
+ 'Count of agent writes that ran the Site A content-divergence gate (denominator for the divergence rate). Bounded label: handler ∈ {agent-write-md, agent-patch, rollback}.',
+ });
return _agentWriteGateFiredCounter;
}
@@ -529,15 +519,13 @@ let _agentWriteContentDivergenceCounter: ReturnType<
function agentWriteContentDivergenceCounter(): ReturnType<
ReturnType<typeof getMeter>['createCounter']
> {
- if (!_agentWriteContentDivergenceCounter) {
- _agentWriteContentDivergenceCounter = getMeter().createCounter(
- 'ok.agent_write.content_divergence_total',
- {
- description:
- 'Count of agent writes whose converged Y.Text diverged from the composed intent (numerator for the divergence rate). Bounded labels: handler ∈ {agent-write-md, agent-patch, rollback}, divergence_type.',
- },
- );
- }
+ _agentWriteContentDivergenceCounter ||= getMeter().createCounter(
+ 'ok.agent_write.content_divergence_total',
+ {
+ description:
+ 'Count of agent writes whose converged Y.Text diverged from the composed intent (numerator for the divergence rate). Bounded labels: handler ∈ {agent-write-md, agent-patch, rollback}, divergence_type.',
+ },
+ );
return _agentWriteContentDivergenceCounter;
}
diff --git a/packages/server/src/config-persistence.ts b/packages/server/src/config-persistence.ts
index ab55af34f..e7d4f30a4 100644
--- a/packages/server/src/config-persistence.ts
+++ b/packages/server/src/config-persistence.ts
@@ -40,11 +40,9 @@ function configScopeAttr(documentName: string): WriteScope | undefined {
let _okignoreRejectionCounter: Counter | null = null;
function okignoreRejectionCounter(): Counter {
- if (!_okignoreRejectionCounter) {
- _okignoreRejectionCounter = getMeter().createCounter('ok.config.ignore.rejection_total', {
- description: 'Count of okignore L3 rejections by error code.',
- });
- }
+ _okignoreRejectionCounter ||= getMeter().createCounter('ok.config.ignore.rejection_total', {
+ description: 'Count of okignore L3 rejections by error code.',
+ });
return _okignoreRejectionCounter;
}
diff --git a/packages/server/src/embeddings/embeddings-telemetry.ts b/packages/server/src/embeddings/embeddings-telemetry.ts
index 2b0b586dc..93f3450eb 100644
--- a/packages/server/src/embeddings/embeddings-telemetry.ts
+++ b/packages/server/src/embeddings/embeddings-telemetry.ts
@@ -29,52 +29,42 @@ let _queryTotal: Counter | null = null;
let _queryEmbedDuration: Histogram | null = null;
function tokensCounter(): Counter {
- if (!_tokens) {
- _tokens = getMeter().createCounter('ok.embeddings.tokens_total', {
- description:
- 'Embeddings tokens billed, by role. Bounded label: role ∈ {query, document}. Makes spend legible; never includes content.',
- });
- }
+ _tokens ||= getMeter().createCounter('ok.embeddings.tokens_total', {
+ description:
+ 'Embeddings tokens billed, by role. Bounded label: role ∈ {query, document}. Makes spend legible; never includes content.',
+ });
return _tokens;
}
function errorsCounter(): Counter {
- if (!_errors) {
- _errors = getMeter().createCounter('ok.embeddings.provider_errors_total', {
- description:
- 'Embeddings provider failures, by reason. Bounded label: reason ∈ {rate_limit, timeout, http_error, network, dims_mismatch, malformed_response}.',
- });
- }
+ _errors ||= getMeter().createCounter('ok.embeddings.provider_errors_total', {
+ description:
+ 'Embeddings provider failures, by reason. Bounded label: reason ∈ {rate_limit, timeout, http_error, network, dims_mismatch, malformed_response}.',
+ });
return _errors;
}
function requestDurationHist(): Histogram {
- if (!_requestDuration) {
- _requestDuration = getMeter().createHistogram('ok.embeddings.request_duration_ms', {
- description: 'Wall-clock duration of one embeddings API request. Bounded label: role.',
- unit: 'ms',
- });
- }
+ _requestDuration ||= getMeter().createHistogram('ok.embeddings.request_duration_ms', {
+ description: 'Wall-clock duration of one embeddings API request. Bounded label: role.',
+ unit: 'ms',
+ });
return _requestDuration;
}
function queryTotalCounter(): Counter {
- if (!_queryTotal) {
- _queryTotal = getMeter().createCounter('ok.search.semantic_query_total', {
- description:
- 'Semantic-requested searches, by outcome and caller surface. Bounded labels: outcome ∈ {applied, no_match, warming, incapable, provider_error}, source ∈ {omnibar, mcp, http}. The omnibar/mcp split separates interactive cost from agent cost.',
- });
- }
+ _queryTotal ||= getMeter().createCounter('ok.search.semantic_query_total', {
+ description:
+ 'Semantic-requested searches, by outcome and caller surface. Bounded labels: outcome ∈ {applied, no_match, warming, incapable, provider_error}, source ∈ {omnibar, mcp, http}. The omnibar/mcp split separates interactive cost from agent cost.',
+ });
return _queryTotal;
}
function queryEmbedDurationHist(): Histogram {
- if (!_queryEmbedDuration) {
- _queryEmbedDuration = getMeter().createHistogram('ok.search.semantic_query_embed_ms', {
- description: 'Wall-clock latency of the per-query embed on the semantic search path.',
- unit: 'ms',
- });
- }
+ _queryEmbedDuration ||= getMeter().createHistogram('ok.search.semantic_query_embed_ms', {
+ description: 'Wall-clock latency of the per-query embed on the semantic search path.',
+ unit: 'ms',
+ });
return _queryEmbedDuration;
}
diff --git a/packages/server/src/embeddings/semantic-search-service.ts b/packages/server/src/embeddings/semantic-search-service.ts
index c1339af01..7b3486e83 100644
--- a/packages/server/src/embeddings/semantic-search-service.ts
+++ b/packages/server/src/embeddings/semantic-search-service.ts
@@ -89,7 +89,7 @@ export class SemanticSearchService {
ensureWarm(): Promise<void> {
if (!this.enabled) return Promise.resolve();
if (this.ready) return Promise.resolve();
- if (!this.warmPromise) this.warmPromise = this.warm();
+ this.warmPromise ||= this.warm();
return this.warmPromise;
}
diff --git a/packages/server/src/file-watcher.ts b/packages/server/src/file-watcher.ts
index 02752d5ea..422c91042 100644
--- a/packages/server/src/file-watcher.ts
+++ b/packages/server/src/file-watcher.ts
@@ -913,11 +913,9 @@ export async function handleRawEvents(
let _fwEventsCounterCache: ReturnType<ReturnType<typeof getMeter>['createCounter']> | null = null;
function _fileWatcherEventsCounter() {
- if (!_fwEventsCounterCache) {
- _fwEventsCounterCache = getMeter().createCounter('ok.file_watcher.events', {
- description: 'Number of file-watcher events classified by kind',
- });
- }
+ _fwEventsCounterCache ||= getMeter().createCounter('ok.file_watcher.events', {
+ description: 'Number of file-watcher events classified by kind',
+ });
return _fwEventsCounterCache;
}
@@ -1007,22 +1005,20 @@ async function startChokidarWatcher(
function queueEvent(type: 'create' | 'update' | 'delete', path: string) {
pendingEvents.push({ type, path });
- if (!batchTimer) {
- batchTimer = setTimeout(() => {
- const batch = pendingEvents;
- pendingEvents = [];
- batchTimer = null;
- handleRawEvents(
- batch,
- contentDir,
- contentFilter,
- fileIndex,
- folderIndex,
- onDiskEvent,
- aliasMap,
- ).catch((err) => console.error('[file-watcher] chokidar batch error:', err));
- }, BATCH_WINDOW_MS);
- }
+ batchTimer ||= setTimeout(() => {
+ const batch = pendingEvents;
+ pendingEvents = [];
+ batchTimer = null;
+ handleRawEvents(
+ batch,
+ contentDir,
+ contentFilter,
+ fileIndex,
+ folderIndex,
+ onDiskEvent,
+ aliasMap,
+ ).catch((err) => console.error('[file-watcher] chokidar batch error:', err));
+ }, BATCH_WINDOW_MS);
}
watcher.on('add', (path) => queueEvent('create', path));
diff --git a/packages/server/src/frontmatter-telemetry.ts b/packages/server/src/frontmatter-telemetry.ts
index eca95ea76..32a64811f 100644
--- a/packages/server/src/frontmatter-telemetry.ts
+++ b/packages/server/src/frontmatter-telemetry.ts
@@ -5,12 +5,10 @@ type FrontmatterEditSource = 'source-mode' | 'mcp-write' | 'file-watcher';
let _editSurfaceCounter: Counter | null = null;
function editSurfaceCounter(): Counter {
- if (!_editSurfaceCounter) {
- _editSurfaceCounter = getMeter().createCounter('ok.frontmatter.edit_surface_total', {
- description:
- 'Count of frontmatter edits by surface. Bounded label: source ∈ {source-mode, mcp-write, file-watcher}.',
- });
- }
+ _editSurfaceCounter ||= getMeter().createCounter('ok.frontmatter.edit_surface_total', {
+ description:
+ 'Count of frontmatter edits by surface. Bounded label: source ∈ {source-mode, mcp-write, file-watcher}.',
+ });
return _editSurfaceCounter;
}
diff --git a/packages/server/src/github-permissions.ts b/packages/server/src/github-permissions.ts
index ffb9436ba..9dc7880d5 100644
--- a/packages/server/src/github-permissions.ts
+++ b/packages/server/src/github-permissions.ts
@@ -196,23 +196,19 @@ function outcomeAttributes(result: PushPermission): ProbeOutcomeAttributes {
let _outcomeCounter: Counter | null = null;
function outcomeCounter(): Counter {
- if (!_outcomeCounter) {
- _outcomeCounter = getMeter().createCounter('ok.permissions.probe.outcome_total', {
- description:
- 'Push-permission probe outcomes. Bounded labels: outcome ∈ {allowed,denied,unknown}; denied_reason ∈ {no-collaborator,private-no-access,repo-not-found,none}; error_class ∈ {network,timeout,rate-limit,token-invalid,malformed-response,none}.',
- });
- }
+ _outcomeCounter ||= getMeter().createCounter('ok.permissions.probe.outcome_total', {
+ description:
+ 'Push-permission probe outcomes. Bounded labels: outcome ∈ {allowed,denied,unknown}; denied_reason ∈ {no-collaborator,private-no-access,repo-not-found,none}; error_class ∈ {network,timeout,rate-limit,token-invalid,malformed-response,none}.',
+ });
return _outcomeCounter;
}
let _durationHist: Histogram | null = null;
function durationHist(): Histogram {
- if (!_durationHist) {
- _durationHist = getMeter().createHistogram('ok.permissions.probe.duration_ms', {
- description: 'Push-permission probe wall-clock duration.',
- unit: 'ms',
- });
- }
+ _durationHist ||= getMeter().createHistogram('ok.permissions.probe.duration_ms', {
+ description: 'Push-permission probe wall-clock duration.',
+ unit: 'ms',
+ });
return _durationHist;
}
diff --git a/packages/server/src/http/error-response.ts b/packages/server/src/http/error-response.ts
index 7c36f0b95..10f9e0fac 100644
--- a/packages/server/src/http/error-response.ts
+++ b/packages/server/src/http/error-response.ts
@@ -33,12 +33,10 @@ export type HttpErrorStatus =
let _apiErrorCounter: Counter | null = null;
export function apiErrorCounter(): Counter {
- if (!_apiErrorCounter) {
- _apiErrorCounter = getMeter().createCounter('ok.api.error.count', {
- description: 'API error responses by problem type and handler',
- unit: '1',
- });
- }
+ _apiErrorCounter ||= getMeter().createCounter('ok.api.error.count', {
+ description: 'API error responses by problem type and handler',
+ unit: '1',
+ });
return _apiErrorCounter;
}
diff --git a/packages/server/src/managed-rename-rewrite.ts b/packages/server/src/managed-rename-rewrite.ts
index 9c1d8def1..3d0ff8f39 100644
--- a/packages/server/src/managed-rename-rewrite.ts
+++ b/packages/server/src/managed-rename-rewrite.ts
@@ -235,7 +235,7 @@ function recomputeRelativeImageHref(
const assetFromRoot = posix.resolve(oldDirAnchored, pathPart).slice(1);
let newRef = posix.relative(newDir === '.' ? '' : newDir, assetFromRoot);
- if (!newRef) newRef = posix.basename(assetFromRoot);
+ newRef ||= posix.basename(assetFromRoot);
if (pathPart.startsWith('./') && !newRef.startsWith('./') && !newRef.startsWith('../')) {
newRef = `./${newRef}`;
@@ -278,7 +278,7 @@ function buildAssetHrefFromSource(
const sourceDir = posix.dirname(sourceDocName);
let nextHref = posix.relative(sourceDir === '.' ? '' : sourceDir, newAssetPath);
- if (!nextHref) nextHref = posix.basename(newAssetPath);
+ nextHref ||= posix.basename(newAssetPath);
if (pathPart.startsWith('./') && !nextHref.startsWith('./') && !nextHref.startsWith('../')) {
nextHref = `./${nextHref}`;
@@ -317,7 +317,7 @@ function recomputeRelativeMarkdownHref(
let relativePath = keepsRootPrefix
? `/${newDocName}`
: posix.relative(sourceDir === '.' ? '' : sourceDir, newDocName);
- if (!relativePath) relativePath = posix.basename(newDocName);
+ relativePath ||= posix.basename(newDocName);
if (pathPart.endsWith('.mdx')) {
relativePath += '.mdx';
diff --git a/packages/server/src/persistence.ts b/packages/server/src/persistence.ts
index eca156d76..52d345e87 100644
--- a/packages/server/src/persistence.ts
+++ b/packages/server/src/persistence.ts
@@ -614,15 +614,13 @@ export function createPersistenceExtension(options?: PersistenceOptions): Persis
if (gitCommitTimer) {
clearTimeout(gitCommitTimer);
gitCommitTimer = null;
- if (!commitInFlight) {
- commitInFlight = commitToWipRef().finally(() => {
- commitInFlight = null;
- if (pendingAfterCommit) {
- pendingAfterCommit = false;
- scheduleGitCommit();
- }
- });
- }
+ commitInFlight ||= commitToWipRef().finally(() => {
+ commitInFlight = null;
+ if (pendingAfterCommit) {
+ pendingAfterCommit = false;
+ scheduleGitCommit();
+ }
+ });
}
if (commitInFlight) await commitInFlight;
}
diff --git a/packages/server/src/rename-log.ts b/packages/server/src/rename-log.ts
index a02980a04..a7d04ce4c 100644
--- a/packages/server/src/rename-log.ts
+++ b/packages/server/src/rename-log.ts
@@ -15,21 +15,17 @@ import { getMeter, withSpan } from './telemetry.ts';
let _liveEntriesGauge: ReturnType<ReturnType<typeof getMeter>['createUpDownCounter']> | null = null;
function liveEntriesGauge(): ReturnType<ReturnType<typeof getMeter>['createUpDownCounter']> {
- if (!_liveEntriesGauge) {
- _liveEntriesGauge = getMeter().createUpDownCounter('rename.log_entries_total', {
- description: 'Live rename-log entry count after each append / GC pass',
- });
- }
+ _liveEntriesGauge ||= getMeter().createUpDownCounter('rename.log_entries_total', {
+ description: 'Live rename-log entry count after each append / GC pass',
+ });
return _liveEntriesGauge;
}
let _gcDroppedCounter: ReturnType<ReturnType<typeof getMeter>['createCounter']> | null = null;
function gcDroppedCounter(): ReturnType<ReturnType<typeof getMeter>['createCounter']> {
- if (!_gcDroppedCounter) {
- _gcDroppedCounter = getMeter().createCounter('rename.log_gc_dropped_total', {
- description: 'Cumulative count of rename-log entries dropped by reachability GC',
- });
- }
+ _gcDroppedCounter ||= getMeter().createCounter('rename.log_gc_dropped_total', {
+ description: 'Cumulative count of rename-log entries dropped by reachability GC',
+ });
return _gcDroppedCounter;
}
diff --git a/packages/server/src/timeline-query.ts b/packages/server/src/timeline-query.ts
index ed5a48618..6e3204f0f 100644
--- a/packages/server/src/timeline-query.ts
+++ b/packages/server/src/timeline-query.ts
@@ -96,21 +96,17 @@ function toArray(val: string | string[] | undefined): string[] {
let _chainDepthHist: ReturnType<ReturnType<typeof getMeter>['createHistogram']> | null = null;
function chainDepthHist(): ReturnType<ReturnType<typeof getMeter>['createHistogram']> {
- if (!_chainDepthHist) {
- _chainDepthHist = getMeter().createHistogram('rename.predecessor_chain_depth_histogram', {
- description: 'Predecessor chain depth observed per timeline query',
- });
- }
+ _chainDepthHist ||= getMeter().createHistogram('rename.predecessor_chain_depth_histogram', {
+ description: 'Predecessor chain depth observed per timeline query',
+ });
return _chainDepthHist;
}
let _transientSkipCounter: ReturnType<ReturnType<typeof getMeter>['createCounter']> | null = null;
function transientSkipCounter(): ReturnType<ReturnType<typeof getMeter>['createCounter']> {
- if (!_transientSkipCounter) {
- _transientSkipCounter = getMeter().createCounter('rename.transient_skip_total', {
- description: 'Count of empty-commitSha entries encountered (lazy-population transient skip)',
- });
- }
+ _transientSkipCounter ||= getMeter().createCounter('rename.transient_skip_total', {
+ description: 'Count of empty-commitSha entries encountered (lazy-population transient skip)',
+ });
return _transientSkipCounter;
}