Skip to content

Plan, apply and roll back changes to a production ontology, with a blast radius report and a proof an auditor can re-check.

8.8 KB
Raw Blame
use open_ontologies::enforce::Enforcer;
use open_ontologies::feedback::record_tool_feedback;
use open_ontologies::graph::GraphStore;
use open_ontologies::state::StateDb;
use std::sync::Arc;
use tempfile::NamedTempFile;

fn setup_with_ontology(ttl: &str) -> (StateDb, Arc<GraphStore>) {
    let tmp = NamedTempFile::new().unwrap();
    let path = tmp.path().to_path_buf();
    std::mem::forget(tmp);
    let db = StateDb::open(&path).unwrap();
    let graph = Arc::new(GraphStore::new());
    graph.load_turtle(ttl, None).unwrap();
    (db, graph)
}

#[test]
fn test_enforce_generic_orphan_class() {
    let (db, graph) = setup_with_ontology(r#"
        @prefix owl: <http://www.w3.org/2002/07/owl#> .
        @prefix rdfs: <http://www.w3.org/2000/01/rdf-schema#> .
        @prefix ex: <http://example.org/> .
        ex:Animal a owl:Class .
        ex:Dog a owl:Class ; rdfs:subClassOf ex:Animal .
        ex:OrphanClass a owl:Class .
    "#);

    let enforcer = Enforcer::new(db, graph);
    let result = enforcer.enforce("generic").unwrap();
    let parsed: serde_json::Value = serde_json::from_str(&result).unwrap();

    let violations = parsed["violations"].as_array().unwrap();
    assert!(violations.iter().any(|v| {
        v["rule"].as_str().unwrap() == "orphan_class"
            && v["entity"].as_str().unwrap().contains("OrphanClass")
    }));
}

#[test]
fn test_enforce_generic_missing_domain_range() {
    let (db, graph) = setup_with_ontology(r#"
        @prefix owl: <http://www.w3.org/2002/07/owl#> .
        @prefix ex: <http://example.org/> .
        ex:hasName a owl:DatatypeProperty .
    "#);

    let enforcer = Enforcer::new(db, graph);
    let result = enforcer.enforce("generic").unwrap();
    let parsed: serde_json::Value = serde_json::from_str(&result).unwrap();

    let violations = parsed["violations"].as_array().unwrap();
    assert!(violations.iter().any(|v| v["rule"].as_str().unwrap() == "missing_domain"));
}

#[test]
fn test_enforce_boro_missing_state_class() {
    let (db, graph) = setup_with_ontology(r#"
        @prefix owl: <http://www.w3.org/2002/07/owl#> .
        @prefix rdfs: <http://www.w3.org/2000/01/rdf-schema#> .
        @prefix ies: <http://ies.data.gov.uk/ontology/ies4#> .
        @prefix ex: <http://example.org/> .
        ex:Building a owl:Class ; rdfs:subClassOf ies:Entity .
    "#);

    let enforcer = Enforcer::new(db, graph);
    let result = enforcer.enforce("boro").unwrap();
    let parsed: serde_json::Value = serde_json::from_str(&result).unwrap();

    let violations = parsed["violations"].as_array().unwrap();
    assert!(violations.iter().any(|v| {
        v["rule"].as_str().unwrap() == "missing_state_class"
            && v["entity"].as_str().unwrap().contains("Building")
    }));
}

#[test]
fn test_enforce_boro_passes_with_state() {
    let (db, graph) = setup_with_ontology(r#"
        @prefix owl: <http://www.w3.org/2002/07/owl#> .
        @prefix rdfs: <http://www.w3.org/2000/01/rdf-schema#> .
        @prefix ies: <http://ies.data.gov.uk/ontology/ies4#> .
        @prefix ex: <http://example.org/> .
        ex:Building a owl:Class ; rdfs:subClassOf ies:Entity .
        ex:BuildingState a owl:Class ; rdfs:subClassOf ies:State, ex:Building .
    "#);

    let enforcer = Enforcer::new(db, graph);
    let result = enforcer.enforce("boro").unwrap();
    let parsed: serde_json::Value = serde_json::from_str(&result).unwrap();

    let violations = parsed["violations"].as_array().unwrap();
    assert!(!violations.iter().any(|v| {
        v["rule"].as_str().unwrap() == "missing_state_class"
            && v["entity"].as_str().unwrap().contains("Building")
    }));
}

#[test]
fn test_enforce_value_partition_incomplete() {
    let (db, graph) = setup_with_ontology(r#"
        @prefix owl: <http://www.w3.org/2002/07/owl#> .
        @prefix rdfs: <http://www.w3.org/2000/01/rdf-schema#> .
        @prefix ex: <http://example.org/> .
        ex:Spiciness a owl:Class .
        ex:Hot a owl:Class ; rdfs:subClassOf ex:Spiciness .
        ex:Medium a owl:Class ; rdfs:subClassOf ex:Spiciness .
        ex:Mild a owl:Class ; rdfs:subClassOf ex:Spiciness .
    "#);

    let enforcer = Enforcer::new(db, graph);
    let result = enforcer.enforce("value_partition").unwrap();
    let parsed: serde_json::Value = serde_json::from_str(&result).unwrap();

    let violations = parsed["violations"].as_array().unwrap();
    assert!(violations.iter().any(|v| v["rule"].as_str().unwrap() == "partition_not_disjoint"));
}

#[test]
fn test_enforce_value_partition_passes() {
    let (db, graph) = setup_with_ontology(r#"
        @prefix owl: <http://www.w3.org/2002/07/owl#> .
        @prefix rdfs: <http://www.w3.org/2000/01/rdf-schema#> .
        @prefix ex: <http://example.org/> .
        ex:Spiciness a owl:Class .
        ex:Hot a owl:Class ; rdfs:subClassOf ex:Spiciness ; owl:disjointWith ex:Medium, ex:Mild .
        ex:Medium a owl:Class ; rdfs:subClassOf ex:Spiciness ; owl:disjointWith ex:Hot, ex:Mild .
        ex:Mild a owl:Class ; rdfs:subClassOf ex:Spiciness ; owl:disjointWith ex:Hot, ex:Medium .
        ex:Spiciness owl:equivalentClass [ a owl:Class ; owl:unionOf ( ex:Hot ex:Medium ex:Mild ) ] .
    "#);

    let enforcer = Enforcer::new(db, graph);
    let result = enforcer.enforce("value_partition").unwrap();
    let parsed: serde_json::Value = serde_json::from_str(&result).unwrap();

    let violations = parsed["violations"].as_array().unwrap();
    assert!(violations.is_empty() || !violations.iter().any(|v|
        v["rule"].as_str().unwrap() == "partition_not_disjoint"
            && v["entity"].as_str().unwrap().contains("Spiciness")
    ));
}

#[test]
fn test_enforce_custom_sparql_rule() {
    let (db, graph) = setup_with_ontology(r#"
        @prefix owl: <http://www.w3.org/2002/07/owl#> .
        @prefix ex: <http://example.org/> .
        ex:Drug a owl:Class .
        ex:aspirin a ex:Drug .
    "#);

    let enforcer = Enforcer::new(db.clone(), graph);

    enforcer.add_custom_rule(
        "drug_indication",
        "custom",
        "ASK { ?d a <http://example.org/Drug> . FILTER NOT EXISTS { ?d <http://example.org/hasIndication> ?i } }",
        "error",
        "Drug without indication",
    );

    let result = enforcer.enforce("custom").unwrap();
    let parsed: serde_json::Value = serde_json::from_str(&result).unwrap();

    let violations = parsed["violations"].as_array().unwrap();
    assert!(violations.iter().any(|v| v["rule"].as_str().unwrap() == "drug_indication"));
}

#[test]
fn test_enforce_compliance_score() {
    let (db, graph) = setup_with_ontology(r#"
        @prefix owl: <http://www.w3.org/2002/07/owl#> .
        @prefix rdfs: <http://www.w3.org/2000/01/rdf-schema#> .
        @prefix ex: <http://example.org/> .
        ex:Dog a owl:Class ; rdfs:label "Dog" .
        ex:Cat a owl:Class .
    "#);

    let enforcer = Enforcer::new(db, graph);
    let result = enforcer.enforce("generic").unwrap();
    let parsed: serde_json::Value = serde_json::from_str(&result).unwrap();

    let score = parsed["compliance"].as_f64().unwrap();
    assert!((0.0..=1.0).contains(&score));
}

#[test]
fn test_enforce_with_feedback_suppression() {
    let tmp = NamedTempFile::new().unwrap();
    let path = tmp.path().to_path_buf();
    std::mem::forget(tmp);
    let db = StateDb::open(&path).unwrap();
    let graph = Arc::new(GraphStore::new());

    // Load a class with no label (triggers missing_label rule in generic pack)
    graph
        .load_turtle(
            r#"
        @prefix owl: <http://www.w3.org/2002/07/owl#> .
        @prefix ex: <http://example.org/> .
        ex:Dog a owl:Class .
    "#,
            None,
        )
        .unwrap();

    let enforcer = Enforcer::new(db.clone(), graph.clone());

    // Without feedback, violations should appear
    let result = enforcer.enforce_with_feedback("generic", Some(&db)).unwrap();
    let v: serde_json::Value = serde_json::from_str(&result).unwrap();
    let violations = v["violations"].as_array().unwrap();
    assert!(!violations.is_empty());
    assert_eq!(v["suppressed_count"].as_u64().unwrap(), 0);

    // Find the entity string for the missing_label violation on Dog
    let dog_violation = violations.iter().find(|v| {
        v["rule"].as_str().unwrap_or("") == "missing_label"
            && v["entity"].as_str().unwrap_or("").contains("example.org/Dog")
    });
    assert!(
        dog_violation.is_some(),
        "Should have missing_label violation for Dog"
    );
    let entity_str = dog_violation.unwrap()["entity"].as_str().unwrap();

    // Dismiss 3 times using exact entity string
    for _ in 0..3 {
        record_tool_feedback(&db, "enforce", "missing_label", entity_str, false).unwrap();
    }

    // Now that violation should be suppressed
    let result = enforcer.enforce_with_feedback("generic", Some(&db)).unwrap();
    let v: serde_json::Value = serde_json::from_str(&result).unwrap();
    assert!(v["suppressed_count"].as_u64().unwrap() > 0);
}