Skip to content

Plan, apply and roll back changes to a production ontology, with a blast radius report and a proof an auditor can re-check.

Merge branch 'fix/321-325-shacl-counts-feedback'

FABIOTESSc49293e5bfc7
diff --cc CHANGELOG.md
index 7eba1f55,75fc1e8d..1df98940
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@@ -6,24 -6,31 +6,49 @@@ All notable changes to Open Ontologies
### Fixed
+- **`diff` and `drift` no longer hang on a symmetric blank-node graph** (#293).
+ Both canonicalised blank nodes through oxrdf's RDFC-1.0, which sets no limit
+ on `hash_n_degree_quads` calls, so the cost was factorial: a 7-node
+ blank-node clique took 17 to 23 seconds to diff against itself and an 8-node
+ clique was still running when killed at 120 seconds. They now use the
+ repository's own `canon` module, the same Recommendation gated on the W3C
+ suite and bounded by its 4000-call budget; Pizza gets the same canonical
+ labels as before. When either snapshot exhausts the budget, both are cut to
+ the triples that mention no blank node and the report says so: `exact:
+ false`, `approximate_reason`, and the omitted counts (`omitted_old`/
+ `omitted_new` for diff, `omitted_v1`/`omitted_v2` for drift). `kgcl_json`
+ carries the flag; the `kgcl` CNL format cannot, so it refuses an
+ approximate drift and names the formats that can. Every report now carries
+ `exact`, true on ordinary input. `canon` itself built all k! neighbour
+ permutations before its first budget check, so two identical 11-leaf
+ blank-node stars cost 10 s and 1.78 GB to refuse; permutations are now
+ generated lazily in the same order, and the same input takes 0.04 s and
+ 17 MB.
+ - **Lint and enforce feedback can no longer waive an error, and never drop an
+ issue without a record** (#325, reported by @noahgift). After
+ `suppress_threshold` dismissals (default 3) an issue was removed whatever its
+ severity, leaving only `suppressed_count`, so the orchestrator that loops
+ until enforce is clean could dismiss an error three times and read
+ "0 violations, 1 suppressed" with no rule, entity or severity anywhere. An
+ `error` is now never suppressed or downgraded (a dismissed one stays in
+ `issues`/`violations` at `error` and carries `dismissals`); a warning or info
+ that reaches the threshold moves to a new `suppressed[]` list with `rule`,
+ `entity`, `original_severity`, `dismissals` and `message`. `issue_count`,
+ `compliance` and `suppressed_count` are computed as before.
+ `tests/feedback_suppression_test.rs` holds it for both tools.
+ - **A malformed SHACL count bound no longer turns a shape into a no-op** (#321,
+ reported by @noahgift). `sh:minCount` fell back to 0 and `sh:maxCount` to
+ `u64::MAX` when the bound did not parse, and a bad `sh:qualifiedMinCount` /
+ `sh:qualifiedMaxCount` skipped the row in silence, so `sh:minCount "one"` or
+ `sh:maxCount -1` over a node with no value returned `conforms: true`. All
+ four now go to `skipped_constraints` with the reason, which makes the verdict
+ `conforms: null`, as `sh:minLength` already did. The bound must be a
+ non-negative `xsd:integer` literal: the datatype is checked because the
+ store renders Turtle `1.0` as `"1"^^xsd:decimal`. The verified path
+ (`verified: true`) refuses the same bounds before running `oo-shacl`, whose
+ `readNat` declined "one" and -1 but evaluated `1.0` as 1. `onto_shacl_check`
+ reports every ill-formed count or length literal as `ill_formed_literal`
+ with its reason. `tests/shacl_count_bound_test.rs` holds it.
## [2.1.0] - 2026-10-23