AI-native design editor. Open-source Figma alternative.
perf(canvas): debounce crisp backing during zoom
Danila Poyarkov0960aa519887
diff --git a/packages/core/src/canvas/renderer.ts b/packages/core/src/canvas/renderer.tsindex 3d7ff78a6..b6f8d646f 100644--- a/packages/core/src/canvas/renderer.ts+++ b/packages/core/src/canvas/renderer.ts@@ -96,6 +96,9 @@ export class SkiaRenderer {worldWidth: numberworldHeight: number} | null = null+ sceneBackingPreviewUntil = 0+ sceneBackingNeedsCrispRender = false+ lastSceneViewport: { panX: number; panY: number; zoom: number } | null = nullnodePictureCache = new Map<string, SkPicture | null>()readonly labelCache = new LabelCache()readonly profiler: RenderProfilerdiff --git a/packages/core/src/canvas/renderer/pipeline.ts b/packages/core/src/canvas/renderer/pipeline.tsindex 53b8ff05f..6157d3593 100644--- a/packages/core/src/canvas/renderer/pipeline.ts+++ b/packages/core/src/canvas/renderer/pipeline.ts@@ -117,7 +117,8 @@ function canUseScenePicture(}const now = typeof performance !== 'undefined' ? () => performance.now() : () => 0-const SCENE_BACKING_SCALE = 2+const SCENE_BACKING_SCALE = 3+const SCENE_BACKING_PREVIEW_IDLE_MS = 180function measure<T>(fn: () => T): { value: T; duration: number } {const start = now()@@ -154,6 +155,7 @@ export function render(w: r.viewportWidth / r.zoom,h: r.viewportHeight / r.zoom}+ updateSceneBackingPreviewState(r, layer)const hasPositionPreview =graph.positionPreviewVersion !== r.scenePicturePositionPreviewVersion &&@@ -245,13 +247,32 @@ export function render(p.endFrame()}-function backingCoverageContainsLiveViewport(r: SkiaRenderer, sceneVersion: number): boolean {+function updateSceneBackingPreviewState(r: SkiaRenderer, layer: RenderLayer): void {+ if (layer !== 'scene') return+ const previous = r.lastSceneViewport+ const viewportChanged =+ !previous ||+ previous.panX !== r.panX ||+ previous.panY !== r.panY ||+ previous.zoom !== r.zoom+ if (viewportChanged) {+ r.sceneBackingPreviewUntil = now() + SCENE_BACKING_PREVIEW_IDLE_MS+ r.sceneBackingNeedsCrispRender = !!r.sceneBacking+ r.lastSceneViewport = { panX: r.panX, panY: r.panY, zoom: r.zoom }+ }+}++function backingCoverageContainsLiveViewport(+ r: SkiaRenderer,+ sceneVersion: number,+ allowStaleZoom: boolean+): boolean {const backing = r.sceneBackingif (!backing) return falseif (backing.pageId !== r.pageId) return falseif (backing.sceneVersion !== sceneVersion) return falseif (backing.positionPreviewVersion !== r.scenePicturePositionPreviewVersion) return false- if (Math.abs(backing.zoom - r.zoom) > 0.0001) return false+ if (!allowStaleZoom && Math.abs(backing.zoom - r.zoom) > 0.0001) return falseconst liveX = -r.panX / r.zoomconst liveY = -r.panY / r.zoom@@ -265,9 +286,14 @@ function backingCoverageContainsLiveViewport(r: SkiaRenderer, sceneVersion: numb)}-function drawSceneBacking(r: SkiaRenderer, canvas: Canvas, sceneVersion: number): boolean {+function drawSceneBacking(+ r: SkiaRenderer,+ canvas: Canvas,+ sceneVersion: number,+ allowStaleZoom: boolean+): boolean {const backing = r.sceneBacking- if (!backing || !backingCoverageContainsLiveViewport(r, sceneVersion)) return false+ if (!backing || !backingCoverageContainsLiveViewport(r, sceneVersion, allowStaleZoom)) return falseconst scale = r.zoom / backing.zoomconst x = r.panX - backing.panX * scale@@ -337,6 +363,7 @@ function recordSceneBacking(r: SkiaRenderer, graph: SceneGraph, sceneVersion: nur.scenePictureVersion = sceneVersionr.scenePicturePositionPreviewVersion = graph.positionPreviewVersionr.scenePicturePageId = r.pageId+ r.sceneBackingNeedsCrispRender = false}function renderSceneBacking(@@ -345,10 +372,13 @@ function renderSceneBacking(graph: SceneGraph,sceneVersion: number): boolean {- if (!backingCoverageContainsLiveViewport(r, sceneVersion)) {+ const allowStaleZoom = now() < r.sceneBackingPreviewUntil+ if (!backingCoverageContainsLiveViewport(r, sceneVersion, allowStaleZoom)) {recordSceneBacking(r, graph, sceneVersion)}- return drawSceneBacking(r, canvas, sceneVersion)+ const crisp = Math.abs((r.sceneBacking?.zoom ?? r.zoom) - r.zoom) <= 0.0001+ r.sceneBackingNeedsCrispRender = !crisp+ return drawSceneBacking(r, canvas, sceneVersion, allowStaleZoom)}function renderSceneContent(diff --git a/packages/vue/src/canvas/surface/lifecycle.ts b/packages/vue/src/canvas/surface/lifecycle.tsindex bf16089e4..65089e593 100644--- a/packages/vue/src/canvas/surface/lifecycle.ts+++ b/packages/vue/src/canvas/surface/lifecycle.ts@@ -32,6 +32,13 @@ export function createCanvasSurfaceManager({shouldShowRulers: () => boolean}) {const state: SurfaceManagerState = { renderer: null, glContext: null }+ let sceneBackingRenderTimer: ReturnType<typeof setTimeout> | null = null++ function clearSceneBackingRenderTimer() {+ if (sceneBackingRenderTimer === null) return+ clearTimeout(sceneBackingRenderTimer)+ sceneBackingRenderTimer = null+ }function createSurface(canvas: HTMLCanvasElement,@@ -83,6 +90,11 @@ export function createCanvasSurfaceManager({options?.layer ?? 'full')renderLoop.markRendered()+ clearSceneBackingRenderTimer()+ if (options?.layer === 'scene' && state.renderer.sceneBackingNeedsCrispRender) {+ const delay = Math.max(0, state.renderer.sceneBackingPreviewUntil - performance.now())+ sceneBackingRenderTimer = setTimeout(() => renderLoop.markDirty(), delay)+ }}const renderLoop = createCanvasRenderLoop(editor, renderNow, { layer: options?.layer })@@ -109,6 +121,7 @@ export function createCanvasSurfaceManager({}function destroy() {+ clearSceneBackingRenderTimer()renderLoop.pause()if (state.renderer) editor.removeCanvasRenderer(state.renderer)state.renderer?.destroy()