Skip to content

AI-native design editor. Open-source Figma alternative.

test(editor): dispose flatten test editors so their text measurer does not leak (#999)

Danila Poyarkov613dd87d0b08
diff --git a/packages/core/tests/editor/structure/flatten.test.ts b/packages/core/tests/editor/structure/flatten.test.ts
index 8215e2007..3347ccaf2 100644
--- a/packages/core/tests/editor/structure/flatten.test.ts
+++ b/packages/core/tests/editor/structure/flatten.test.ts
@@ -1,4 +1,4 @@
-import { describe, expect, test } from 'bun:test'
+import { afterEach, describe, expect, test } from 'bun:test'
import { SkiaRenderer } from '@open-pencil/core/canvas'
import { BLACK, TRANSPARENT } from '@open-pencil/core/constants'
@@ -8,6 +8,14 @@ import { fontManager } from '@open-pencil/core/text'
import { textNodeToOutlineLayout } from '#core/text/outlines'
+const cleanups: (() => void)[] = []
+
+// A renderer installs the shared layout text measurer until its editor is disposed; left
+// installed, it measures text in later files without their fonts.
+afterEach(() => {
+ for (const cleanup of cleanups.splice(0)) cleanup()
+})
+
async function createEditorWithRenderer() {
const ck = await initCanvasKit()
const surface = ck.MakeSurface(200, 200)
@@ -15,7 +23,11 @@ async function createEditorWithRenderer() {
const renderer = new SkiaRenderer(ck, surface)
const editor = createEditor()
editor.setCanvasKit(ck, renderer)
- return { editor, surface }
+ cleanups.push(() => {
+ editor.dispose()
+ renderer.destroy()
+ })
+ return { editor }
}
async function loadInterRegular() {
@@ -40,7 +52,7 @@ async function loadNotoSansSC() {
describe('flattenSelected', () => {
test('converts selected shapes into a vector path', async () => {
- const { editor, surface } = await createEditorWithRenderer()
+ const { editor } = await createEditorWithRenderer()
const pageId = editor.state.currentPageId
const first = editor.graph.createNode('RECTANGLE', pageId, {
x: 10,
@@ -68,11 +80,10 @@ describe('flattenSelected', () => {
expect(vector?.vectorNetwork?.vertices.length).toBeGreaterThan(0)
expect(editor.graph.getNode(first.id)).toBeUndefined()
expect(editor.graph.getNode(second.id)).toBeUndefined()
- surface.delete()
})
test('outlines visible strokes into a vector path', async () => {
- const { editor, surface } = await createEditorWithRenderer()
+ const { editor } = await createEditorWithRenderer()
const pageId = editor.state.currentPageId
const rect = editor.graph.createNode('RECTANGLE', pageId, {
x: 20,
@@ -98,11 +109,10 @@ describe('flattenSelected', () => {
expect(vector?.height).toBe(38)
expect(vector?.vectorNetwork?.vertices.length).toBeGreaterThan(0)
expect(editor.graph.getNode(rect.id)).toBeUndefined()
- surface.delete()
})
test('outlines stroked descendants inside groups', async () => {
- const { editor, surface } = await createEditorWithRenderer()
+ const { editor } = await createEditorWithRenderer()
const pageId = editor.state.currentPageId
const rect = editor.graph.createNode('RECTANGLE', pageId, {
x: 20,
@@ -124,11 +134,10 @@ describe('flattenSelected', () => {
expect(vector?.type).toBe('VECTOR')
expect(vector?.name).toBe('Outline stroke')
expect(vector?.vectorNetwork?.vertices.length).toBeGreaterThan(0)
- surface.delete()
})
test('does not outline fill-only shapes as strokes', async () => {
- const { editor, surface } = await createEditorWithRenderer()
+ const { editor } = await createEditorWithRenderer()
const pageId = editor.state.currentPageId
const rect = editor.graph.createNode('RECTANGLE', pageId, {
x: 20,
@@ -143,12 +152,11 @@ describe('flattenSelected', () => {
expect(result).toBeNull()
expect(editor.graph.getNode(rect.id)?.type).toBe('RECTANGLE')
- surface.delete()
})
test('outlines loaded text through the shared text outline path', async () => {
await loadInterRegular()
- const { editor, surface } = await createEditorWithRenderer()
+ const { editor } = await createEditorWithRenderer()
const pageId = editor.state.currentPageId
const text = editor.graph.createNode('TEXT', pageId, {
text: 'Hi',
@@ -168,12 +176,11 @@ describe('flattenSelected', () => {
expect(vector?.name).toBe('Outline text')
expect(vector?.vectorNetwork?.vertices.length).toBeGreaterThan(0)
expect(editor.graph.getNode(text.id)).toBeUndefined()
- surface.delete()
})
test('flattens loaded text as outlines', async () => {
await loadInterRegular()
- const { editor, surface } = await createEditorWithRenderer()
+ const { editor } = await createEditorWithRenderer()
const pageId = editor.state.currentPageId
const text = editor.graph.createNode('TEXT', pageId, {
text: 'Hi',
@@ -192,7 +199,6 @@ describe('flattenSelected', () => {
expect(vector?.type).toBe('VECTOR')
expect(vector?.vectorNetwork?.vertices.length).toBeGreaterThan(0)
expect(editor.graph.getNode(text.id)).toBeUndefined()
- surface.delete()
})
test('wraps loaded text style runs as outlines', async () => {
@@ -219,7 +225,7 @@ describe('flattenSelected', () => {
test('flattens loaded text style runs as outlines', async () => {
await loadInterRegular()
await loadInterBold()
- const { editor, surface } = await createEditorWithRenderer()
+ const { editor } = await createEditorWithRenderer()
const pageId = editor.state.currentPageId
const text = editor.graph.createNode('TEXT', pageId, {
text: 'Hi',
@@ -238,14 +244,13 @@ describe('flattenSelected', () => {
const vector = editor.graph.getNode(vectorId)
expect(vector?.type).toBe('VECTOR')
expect(vector?.vectorNetwork?.vertices.length).toBeGreaterThan(0)
- surface.delete()
})
test('flattens mixed Latin and CJK text with loaded fallback outlines', async () => {
await loadInterRegular()
const hasCJKFallback = await loadNotoSansSC()
if (!hasCJKFallback) return
- const { editor, surface } = await createEditorWithRenderer()
+ const { editor } = await createEditorWithRenderer()
const pageId = editor.state.currentPageId
const text = editor.graph.createNode('TEXT', pageId, {
text: 'Hi你',
@@ -263,12 +268,11 @@ describe('flattenSelected', () => {
const vector = editor.graph.getNode(vectorId)
expect(vector?.type).toBe('VECTOR')
expect(vector?.vectorNetwork?.vertices.length).toBeGreaterThan(0)
- surface.delete()
})
test('does not flatten complex script text without shaping support', async () => {
await loadInterRegular()
- const { editor, surface } = await createEditorWithRenderer()
+ const { editor } = await createEditorWithRenderer()
const pageId = editor.state.currentPageId
const text = editor.graph.createNode('TEXT', pageId, {
text: 'مرحبا',
@@ -284,11 +288,10 @@ describe('flattenSelected', () => {
expect(result).toBeNull()
expect(editor.graph.getNode(text.id)?.type).toBe('TEXT')
- surface.delete()
})
test('does not flatten unsupported text nodes', async () => {
- const { editor, surface } = await createEditorWithRenderer()
+ const { editor } = await createEditorWithRenderer()
const pageId = editor.state.currentPageId
const text = editor.graph.createNode('TEXT', pageId, {
text: 'Nope',
@@ -302,11 +305,10 @@ describe('flattenSelected', () => {
expect(result).toBeNull()
expect(editor.graph.getNode(pageId)?.childIds).toEqual([text.id, rect.id])
expect(editor.state.selectedIds).toEqual(new Set([text.id, rect.id]))
- surface.delete()
})
test('does not flatten containers with unsupported descendants', async () => {
- const { editor, surface } = await createEditorWithRenderer()
+ const { editor } = await createEditorWithRenderer()
const pageId = editor.state.currentPageId
const rect = editor.graph.createNode('RECTANGLE', pageId)
const image = editor.graph.createNode('RECTANGLE', pageId, {
@@ -329,11 +331,10 @@ describe('flattenSelected', () => {
expect(result).toBeNull()
expect(editor.graph.getNode(groupId)?.type).toBe('GROUP')
- surface.delete()
})
test('flattens visual descendants from groups', async () => {
- const { editor, surface } = await createEditorWithRenderer()
+ const { editor } = await createEditorWithRenderer()
const pageId = editor.state.currentPageId
const rect = editor.graph.createNode('RECTANGLE', pageId, {
x: 10,
@@ -358,11 +359,10 @@ describe('flattenSelected', () => {
expect(vector?.type).toBe('VECTOR')
expect(vector?.vectorNetwork?.vertices.length).toBeGreaterThan(0)
expect(editor.graph.getNode(groupId)).toBeUndefined()
- surface.delete()
})
test('includes stroke-only rectangles as flattenable outlines', async () => {
- const { editor, surface } = await createEditorWithRenderer()
+ const { editor } = await createEditorWithRenderer()
const pageId = editor.state.currentPageId
const rect = editor.graph.createNode('RECTANGLE', pageId, {
x: 10,
@@ -383,11 +383,10 @@ describe('flattenSelected', () => {
expect(vector?.type).toBe('VECTOR')
expect(vector?.width).toBeGreaterThan(50)
expect(vector?.height).toBeGreaterThan(40)
- surface.delete()
})
test('undo and redo restore flattened children and vector', async () => {
- const { editor, surface } = await createEditorWithRenderer()
+ const { editor } = await createEditorWithRenderer()
const pageId = editor.state.currentPageId
const before = editor.graph.createNode('RECTANGLE', pageId, { name: 'Before' })
const first = editor.graph.createNode('RECTANGLE', pageId, { name: 'First' })
@@ -411,6 +410,5 @@ describe('flattenSelected', () => {
editor.undo.redo()
expect(editor.graph.getNode(pageId)?.childIds).toEqual([before.id, vectorId, after.id])
expect(editor.graph.getNode(vectorId)?.type).toBe('VECTOR')
- surface.delete()
})
})