Skip to content

AI-native design editor. Open-source Figma alternative.

perf(canvas): avoid zoom preview backing refreshes

Danila Poyarkovd777fddfe99c
diff --git a/packages/core/src/canvas/renderer/pipeline.ts b/packages/core/src/canvas/renderer/pipeline.ts
index b975267a4..9d0fbd2d5 100644
--- a/packages/core/src/canvas/renderer/pipeline.ts
+++ b/packages/core/src/canvas/renderer/pipeline.ts
@@ -300,18 +300,28 @@ function updateSceneBackingPreviewState(r: SkiaRenderer, layer: RenderLayer): vo
}
}
-function backingCoverageContainsLiveViewport(
- r: SkiaRenderer,
- sceneVersion: number,
- allowStaleZoom: boolean
-): boolean {
+function backingMetadataMatches(r: SkiaRenderer, sceneVersion: number): boolean {
+ const backing = r.sceneBacking
+ return !!(
+ backing &&
+ backing.pageId === r.pageId &&
+ backing.sceneVersion === sceneVersion &&
+ backing.positionPreviewVersion === r.scenePicturePositionPreviewVersion
+ )
+}
+
+function backingScreenCoverageContainsViewport(r: SkiaRenderer): boolean {
const backing = r.sceneBacking
if (!backing) return false
- if (backing.pageId !== r.pageId) return false
- if (backing.sceneVersion !== sceneVersion) return false
- if (backing.positionPreviewVersion !== r.scenePicturePositionPreviewVersion) return false
- if (!allowStaleZoom && Math.abs(backing.zoom - r.zoom) > 0.0001) return false
+ const scale = r.zoom / backing.zoom
+ const x = r.panX - backing.panX * scale
+ const y = r.panY - backing.panY * scale
+ return x <= 0 && y <= 0 && x + backing.width * scale >= r.viewportWidth && y + backing.height * scale >= r.viewportHeight
+}
+function backingWorldCoverageContainsLiveViewport(r: SkiaRenderer): boolean {
+ const backing = r.sceneBacking
+ if (!backing) return false
const liveX = -r.panX / r.zoom
const liveY = -r.panY / r.zoom
const liveW = r.viewportWidth / r.zoom
@@ -324,6 +334,17 @@ function backingCoverageContainsLiveViewport(
)
}
+function backingCoverageContainsLiveViewport(
+ r: SkiaRenderer,
+ sceneVersion: number,
+ allowStaleZoom: boolean
+): boolean {
+ if (!backingMetadataMatches(r, sceneVersion)) return false
+ const crispZoom = Math.abs((r.sceneBacking?.zoom ?? r.zoom) - r.zoom) <= 0.0001
+ if (allowStaleZoom && backingScreenCoverageContainsViewport(r)) return true
+ return crispZoom && backingWorldCoverageContainsLiveViewport(r)
+}
+
function drawSceneBacking(
r: SkiaRenderer,
canvas: Canvas,