Skip to content

AI-native design editor. Open-source Figma alternative.

fix(lint): normalize fractional slice bounds

Danila Poyarkoved7f3c140d2e
diff --git a/tools/lint/src/rules/quality/reduce-accumulator-copy.ts b/tools/lint/src/rules/quality/reduce-accumulator-copy.ts
index dcc3eb4ec..5cf907b81 100644
--- a/tools/lint/src/rules/quality/reduce-accumulator-copy.ts
+++ b/tools/lint/src/rules/quality/reduce-accumulator-copy.ts
@@ -83,8 +83,8 @@ function isBoundedSlice(node: ESTree.CallExpression): boolean {
const start = numericLiteral(node.arguments[0])
const end = numericLiteral(node.arguments[1])
return (
- (start !== null && Number.isFinite(start) && start < 0) ||
- (end !== null && Number.isFinite(end) && end >= 0)
+ (start !== null && Number.isFinite(start) && Math.trunc(start) < 0) ||
+ (end !== null && Number.isFinite(end) && Math.trunc(end) >= 0)
)
}
diff --git a/tools/lint/tests/reduce-accumulator-copy.test.ts b/tools/lint/tests/reduce-accumulator-copy.test.ts
index ed8c37de9..4f0e43ab6 100644
--- a/tools/lint/tests/reduce-accumulator-copy.test.ts
+++ b/tools/lint/tests/reduce-accumulator-copy.test.ts
@@ -10,6 +10,8 @@ describe('no-reduce-accumulator-copy', () => {
'items.reduce((acc, item) => acc.concat([item]), [])',
'items.reduce((acc, item) => acc.slice(0, -1), [])',
'items.reduce((acc, item) => acc.slice(2), [])',
+ 'items.reduce((acc, item) => acc.slice(-0.5), [])',
+ 'items.reduce((acc, item) => acc.slice(-0), [])',
'items.reduce((acc, item) => { const next = acc.slice(); next.push(item); return next }, [])',
'items.reduce((acc, item) => Object.assign({}, acc, { [item.id]: item }), {})',
'items.reduce((acc, item) => Array.from(acc), [])'
@@ -24,6 +26,8 @@ describe('no-reduce-accumulator-copy', () => {
'items.reduce(namedReducer, [])',
'items.reduce((acc, item) => acc.slice(0, 1), [0])',
'items.reduce((acc, item) => acc.slice(-2), [0])',
+ 'items.reduce((acc, item) => acc.slice(-1.5), [0])',
+ 'items.reduce((acc, item) => acc.slice(0, -0.5), [0])',
'items.reduce((acc, item) => acc.slice(0, 0), [0])'
])('accepts owned mutation and unrelated copies: %s', async (source) => {
expect(ruleDiagnostics(await lint(source, rules), rule)).toHaveLength(0)