Skip to content

Open-source gym & body-weight tracker, now in the App Store (iPhone + Apple Watch) and as an Android APK. Plan routines, log workouts, see which muscles are trained, import from Strong/Hevy/FitNotes. Self-host it or use it on the phone alone.

Settings: no 'Android app only' hint inside the Android app

Duarte Santos06258ece80b9
diff --git a/frontend/src/views/Settings.jsx b/frontend/src/views/Settings.jsx
index 27c26de1a..772fa8b7e 100644
--- a/frontend/src/views/Settings.jsx
+++ b/frontend/src/views/Settings.jsx
@@ -583,12 +583,12 @@ export default function Settings({ page = null, find = null, via = null }) {
subtitle={canVibrate ? null : iPhone ? t('Not on iPhone') : t('Not supported in this browser.')}>
<Switch checked={canVibrate && S.vibrate !== false} disabled={!canVibrate} onChange={v => update(s => { s.vibrate = v })} />
</Row>
- {/* Android app only (#375): silent mode mutes the ordinary buzz and the notification's,
+ {/* Android app only (#375), and only shown there, so it needs no "Android app only" hint: silent mode mutes the ordinary buzz and the notification's,
so the end of a rest or a hold can buzz as an alarm instead. Opt-in, like the iOS row
above: an alarm-class buzz is the most insistent thing an app can do on some phones. */}
{MOBILE && android && canVibrate && S.vibrate !== false && (
<Row icon="vibrate" iconTint="var(--indigo)" title={t('Vibrate on silent too')}
- subtitle={<>{t('The end of a rest or a hold buzzes like an alarm, even in silent mode.')}<br />{t('Android app only')}</>}>
+ subtitle={t('The end of a rest or a hold buzzes like an alarm, even in silent mode.')}>
<Switch checked={!!S.vibrateOnSilent} onChange={v => update(s => { s.vibrateOnSilent = v })} />
</Row>
)}
diff --git a/frontend/src/views/Settings.vibrate-silent.test.jsx b/frontend/src/views/Settings.vibrate-silent.test.jsx
index 0c23f4c10..905a0a57e 100644
--- a/frontend/src/views/Settings.vibrate-silent.test.jsx
+++ b/frontend/src/views/Settings.vibrate-silent.test.jsx
@@ -97,7 +97,7 @@ describe('Settings — vibrate when the phone is on silent', () => {
await mount()
const row = rowTitled(TITLE)
expect(row).toBeTruthy()
- expect(row.querySelector('.lrow-s').textContent).toBe('The end of a rest or a hold buzzes like an alarm, even in silent mode.Android app only')
+ expect(row.querySelector('.lrow-s').textContent).toBe('The end of a rest or a hold buzzes like an alarm, even in silent mode.')
const rows = [...host.querySelectorAll('.lrow')]
expect(rows.indexOf(row)).toBe(rows.indexOf(rowTitled('Vibrate')) + 1)
expect(switchIn(row).getAttribute('aria-checked')).toBe('false')