Skip to content

Open-source gym & body-weight tracker, now in the App Store (iPhone + Apple Watch) and as an Android APK. Plan routines, log workouts, see which muscles are trained, import from Strong/Hevy/FitNotes. Self-host it or use it on the phone alone.

de: a leg curl is never Beinstrecken, and an extension never Beinbeugen (#631)

choksi2212b75d1e4d45a1
diff --git a/frontend/src/lib/exercise-names.test.js b/frontend/src/lib/exercise-names.test.js
index 8fb7aefd6..d07149186 100644
--- a/frontend/src/lib/exercise-names.test.js
+++ b/frontend/src/lib/exercise-names.test.js
@@ -168,6 +168,21 @@ test('every curated language still ships a name pack, and every pack is enabled'
}
})
+// The movement rule, pinned on both of its directions. The catalogue slipped on the curl side
+// (issue #631); the mirror guards the reverse slip in a future batch: an extension translated as
+// \"Beinbeugen\". Real catalogue entries both ways, so the rule is tested exactly as the
+// translator will meet it.
+test('the movement rule fires in both directions', () => {
+ const extension = EXIDX.get('0585') // lever leg extension
+ expect(checkName(extension, 'Beinstrecken an der Hebelmaschine')).toEqual([])
+ expect(checkName(extension, 'Beinbeugen an der Hebelmaschine'))
+ .toContainEqual({ rule: 'movement', fix: 'Write \"Beinstrecken\" in \"Beinbeugen an der Hebelmaschine\": a leg extension straightens the knee, and \"Beinbeugen\" is the leg curl.' })
+ const curl = EXIDX.get('0586') // lever lying leg curl
+ expect(checkName(curl, 'Liegendes Beinbeugen an der Hebelmaschine')).toEqual([])
+ expect(checkName(curl, 'Liegendes Beinstrecken an der Hebelmaschine'))
+ .toContainEqual({ rule: 'movement', fix: 'Write \"Beinbeugen\" in \"Liegendes Beinstrecken an der Hebelmaschine\": a leg curl bends the knee, and \"Beinstrecken\" is the leg extension.' })
+})
+
for (const lang of EXERCISE_NAME_LANGS) {
describe(`${lang} exercise names`, () => {
const pack = packs[`../exercise-names/${lang}.js`]
diff --git a/scripts/de-name-rules.mjs b/scripts/de-name-rules.mjs
index f225ce085..b35b6b33a 100644
--- a/scripts/de-name-rules.mjs
+++ b/scripts/de-name-rules.mjs
@@ -221,6 +221,21 @@ export function checkName(exercise, german) {
if (!required.test(name)) add('qualifier', `"${english}" is ${pattern.split('|')[0]}: the German name must say "${term}". "${name}" does not.`)
}
+ // A leg curl is knee flexion: Beinbeugen. The batch that translated the lever curls wrote
+ // "Beinstrecken" for them (issue #631), which is the leg extension — 0585 is "Beinstrecken an
+ // der Hebelmaschine" — so a German list read like two spellings of the same exercise, and the
+ // hamstring work was filed with the quad work. "Strecken" stays the right word where the
+ // English really is an extension; this rule only stops it standing in for the curl.
+ if (/leg curl/iu.test(english) && /beinstrecken/iu.test(name)) {
+ add('movement', `Write "Beinbeugen" in "${name}": a leg curl bends the knee, and "Beinstrecken" is the leg extension.`)
+ }
+
+ // The mirror of the rule above, so a future batch cannot slip the other way either: an
+ // extension is the one movement "Beinbeugen" must never name, for the same reason in reverse.
+ if (/leg extension/iu.test(english) && /beinbeugen/iu.test(name)) {
+ add('movement', `Write "Beinstrecken" in "${name}": a leg extension straightens the knee, and "Beinbeugen" is the leg curl.`)
+ }
+
// Inverted English-leak check: anything the German name shares with the English one is a leak
// unless it is on the loanword list. An enumerated list of forbidden English words missed a
// different word every time it was written.