The open source coding agent.
TypeScript
tweak: move the max token exclusions to plugins @rekram1-node (#21225)
Aiden Cline48c1b6b33876
diff --git a/packages/opencode/src/plugin/codex.ts b/packages/opencode/src/plugin/codex.tsindex 77c00eb4f06..bdeef9823ff 100644--- a/packages/opencode/src/plugin/codex.ts+++ b/packages/opencode/src/plugin/codex.ts@@ -599,5 +599,10 @@ export async function CodexAuthPlugin(input: PluginInput): Promise<Hooks> {output.headers["User-Agent"] = `opencode/${Installation.VERSION} (${os.platform()} ${os.release()}; ${os.arch()})`output.headers.session_id = input.sessionID},+ "chat.params": async (input, output) => {+ if (input.model.providerID !== "openai") return+ // Match codex cli+ output.maxOutputTokens = undefined+ },}}diff --git a/packages/opencode/src/plugin/github-copilot/copilot.ts b/packages/opencode/src/plugin/github-copilot/copilot.tsindex ea759b508bc..c0425b7efe8 100644--- a/packages/opencode/src/plugin/github-copilot/copilot.ts+++ b/packages/opencode/src/plugin/github-copilot/copilot.ts@@ -309,6 +309,14 @@ export async function CopilotAuthPlugin(input: PluginInput): Promise<Hooks> {},],},+ "chat.params": async (incoming, output) => {+ if (!incoming.model.providerID.includes("github-copilot")) return++ // Match github copilot cli, omit maxOutputTokens for gpt models+ if (incoming.model.api.id.includes("gpt")) {+ output.maxOutputTokens = undefined+ }+ },"chat.headers": async (incoming, output) => {if (!incoming.model.providerID.includes("github-copilot")) returndiff --git a/packages/opencode/src/session/llm.ts b/packages/opencode/src/session/llm.tsindex 7ef6269b58d..7f60c02b1d9 100644--- a/packages/opencode/src/session/llm.ts+++ b/packages/opencode/src/session/llm.ts@@ -160,11 +160,6 @@ export namespace LLM {...input.messages,]- const maxOutputTokens =- isOpenaiOauth || provider.id.includes("github-copilot")- ? undefined- : ProviderTransform.maxOutputTokens(input.model)-const params = await Plugin.trigger("chat.params",{@@ -180,7 +175,7 @@ export namespace LLM {: undefined,topP: input.agent.topP ?? ProviderTransform.topP(input.model),topK: ProviderTransform.topK(input.model),- maxOutputTokens,+ maxOutputTokens: ProviderTransform.maxOutputTokens(input.model),options,},)diff --git a/packages/opencode/test/session/llm.test.ts b/packages/opencode/test/session/llm.test.tsindex 18b704f4d3d..82ee8c08106 100644--- a/packages/opencode/test/session/llm.test.ts+++ b/packages/opencode/test/session/llm.test.ts@@ -743,8 +743,7 @@ describe("session.llm.stream", () => {expect((body.reasoning as { effort?: string } | undefined)?.effort).toBe("high")const maxTokens = body.max_output_tokens as number | undefined- const expectedMaxTokens = ProviderTransform.maxOutputTokens(resolved)- expect(maxTokens).toBe(expectedMaxTokens)+ expect(maxTokens).toBe(undefined) // match codex cli behavior},})})