The open source coding agent.
TypeScript
fix(task): respect agent permission config for todowrite tool (#19125)
Ariane Emory66a56551beb9
diff --git a/packages/opencode/src/tool/task.ts b/packages/opencode/src/tool/task.tsindex f2a83507fa6..af130a70d91 100644--- a/packages/opencode/src/tool/task.ts+++ b/packages/opencode/src/tool/task.ts@@ -64,6 +64,7 @@ export const TaskTool = Tool.define("task", async (ctx) => {if (!agent) throw new Error(`Unknown agent type: ${params.subagent_type} is not a valid agent type`)const hasTaskPermission = agent.permission.some((rule) => rule.permission === "task")+ const hasTodoWritePermission = agent.permission.some((rule) => rule.permission === "todowrite")const session = await iife(async () => {if (params.task_id) {@@ -75,11 +76,15 @@ export const TaskTool = Tool.define("task", async (ctx) => {parentID: ctx.sessionID,title: params.description + ` (@${agent.name} subagent)`,permission: [- {- permission: "todowrite",- pattern: "*",- action: "deny",- },+ ...(hasTodoWritePermission+ ? []+ : [+ {+ permission: "todowrite" as const,+ pattern: "*" as const,+ action: "deny" as const,+ },+ ]),...(hasTaskPermission? []: [@@ -131,7 +136,7 @@ export const TaskTool = Tool.define("task", async (ctx) => {},agent: agent.name,tools: {- todowrite: false,+ ...(hasTodoWritePermission ? {} : { todowrite: false }),...(hasTaskPermission ? {} : { task: false }),...Object.fromEntries((config.experimental?.primary_tools ?? []).map((t) => [t, false])),},