The open source coding agent.
TypeScript
app: initialize command catalog more efficiently
Brendan Allana43783a6d47a
diff --git a/packages/app/src/context/command.tsx b/packages/app/src/context/command.tsxindex 2c6799d12be..65805f40c8c 100644--- a/packages/app/src/context/command.tsx+++ b/packages/app/src/context/command.tsx@@ -1,10 +1,10 @@-import { createEffect, createMemo, onCleanup, onMount, type Accessor } from "solid-js"-import { createStore } from "solid-js/store"import { createSimpleContext } from "@opencode-ai/ui/context"import { useDialog } from "@opencode-ai/ui/context/dialog"-import { dict as en } from "@/i18n/en"+import { type Accessor, createEffect, createMemo, onCleanup, onMount } from "solid-js"+import { createStore } from "solid-js/store"import { useLanguage } from "@/context/language"import { useSettings } from "@/context/settings"+import { dict as en } from "@/i18n/en"import { Persist, persisted } from "@/utils/persist"const IS_MAC = typeof navigator === "object" && /(Mac|iPod|iPhone|iPad)/.test(navigator.platform)@@ -238,9 +238,10 @@ export const { use: useCommand, provider: CommandProvider } = createSimpleContex})const warnedDuplicates = new Set<string>()+ type CommandCatalog = Record<string, CommandCatalogItem>const [catalog, setCatalog, _, catalogReady] = persisted(Persist.global("command.catalog.v1"),- createStore<Record<string, CommandCatalogItem>>({}),+ createStore<CommandCatalog>({}),)const bind = (id: string, def: KeybindConfig | undefined) => {@@ -259,7 +260,7 @@ export const { use: useCommand, provider: CommandProvider } = createSimpleContexif (seen.has(opt.id)) {if (import.meta.env.DEV && !warnedDuplicates.has(opt.id)) {warnedDuplicates.add(opt.id)- console.warn(`[command] duplicate command id \"${opt.id}\" registered; keeping first entry`)+ console.warn(`[command] duplicate command id "${opt.id}" registered; keeping first entry`)}continue}@@ -274,16 +275,19 @@ export const { use: useCommand, provider: CommandProvider } = createSimpleContexcreateEffect(() => {if (!catalogReady()) return- for (const opt of registered()) {- const id = actionId(opt.id)- setCatalog(id, {- title: opt.title,- description: opt.description,- category: opt.category,- keybind: opt.keybind,- slash: opt.slash,- })- }+ setCatalog(+ registered().reduce((acc, opt) => {+ const id = actionId(opt.id)+ acc[id] = {+ title: opt.title,+ description: opt.description,+ category: opt.category,+ keybind: opt.keybind,+ slash: opt.slash,+ }+ return acc+ }, {} as CommandCatalog),+ )})const catalogOptions = createMemo(() => Object.entries(catalog).map(([id, meta]) => ({ id, ...meta })))