The open source coding agent.
TypeScript
fix(app): move message navigation off cmd+arrow (#18728)
Shoubhit Dashd1c49ba21031
diff --git a/packages/app/src/context/command-keybind.test.ts b/packages/app/src/context/command-keybind.test.tsindex d804195c401..c8e2dbb5d0f 100644--- a/packages/app/src/context/command-keybind.test.ts+++ b/packages/app/src/context/command-keybind.test.ts@@ -32,6 +32,25 @@ describe("command keybind helpers", () => {expect(matchKeybind(keybinds, new KeyboardEvent("keydown", { key: ",", ctrlKey: true, altKey: true }))).toBe(false)})+ test("matchKeybind supports bracket keys", () => {+ const keybinds = parseKeybind("mod+alt+[, mod+alt+]")+ const prev = keybinds[0]+ const next = keybinds[1]++ expect(+ matchKeybind(+ keybinds,+ new KeyboardEvent("keydown", { key: "[", ctrlKey: prev?.ctrl, metaKey: prev?.meta, altKey: true }),+ ),+ ).toBe(true)+ expect(+ matchKeybind(+ keybinds,+ new KeyboardEvent("keydown", { key: "]", ctrlKey: next?.ctrl, metaKey: next?.meta, altKey: true }),+ ),+ ).toBe(true)+ })+test("formatKeybind returns human readable output", () => {const display = formatKeybind("ctrl+alt+arrowup")diff --git a/packages/app/src/pages/session/use-session-commands.tsx b/packages/app/src/pages/session/use-session-commands.tsxindex f17e3f7a1f6..7394765ae6d 100644--- a/packages/app/src/pages/session/use-session-commands.tsx+++ b/packages/app/src/pages/session/use-session-commands.tsx@@ -333,7 +333,7 @@ export const useSessionCommands = (actions: SessionCommandContext) => {id: "message.previous",title: language.t("command.message.previous"),description: language.t("command.message.previous.description"),- keybind: "mod+arrowup",+ keybind: "mod+alt+[",disabled: !params.id,onSelect: () => navigateMessageByOffset(-1),}),@@ -341,7 +341,7 @@ export const useSessionCommands = (actions: SessionCommandContext) => {id: "message.next",title: language.t("command.message.next"),description: language.t("command.message.next.description"),- keybind: "mod+arrowdown",+ keybind: "mod+alt+]",disabled: !params.id,onSelect: () => navigateMessageByOffset(1),}),