The open source coding agent.
TypeScript
refactor: destroy SessionStatus facade (#21968)
Kit Langtonf99812443c97
diff --git a/packages/opencode/specs/effect-migration.md b/packages/opencode/specs/effect-migration.mdindex 7aa94d874d3..dacf55b0731 100644--- a/packages/opencode/specs/effect-migration.md+++ b/packages/opencode/specs/effect-migration.md@@ -336,5 +336,6 @@ For each service, the migration is roughly:### Migration log+- `SessionStatus` — migrated 2026-04-11. Replaced the last route and retry-policy callers with `AppRuntime.runPromise(SessionStatus.Service.use(...))` and removed the `makeRuntime(...)` facade.- `ShareNext` — migrated 2026-04-11. Swapped remaining async callers to `AppRuntime.runPromise(ShareNext.Service.use(...))`, removed the `makeRuntime(...)` facade, and kept instance bootstrap on the shared app runtime.- `Storage` — migrated 2026-04-10. One production caller (`Session.diff`) and all storage.test.ts tests converted to effectful style. Facades and `makeRuntime` removed.diff --git a/packages/opencode/src/server/routes/session.ts b/packages/opencode/src/server/routes/session.tsindex cccaa754119..a2a15d59ec3 100644--- a/packages/opencode/src/server/routes/session.ts+++ b/packages/opencode/src/server/routes/session.ts@@ -94,7 +94,7 @@ export const SessionRoutes = lazy(() =>},}),async (c) => {- const result = await SessionStatus.list()+ const result = await AppRuntime.runPromise(SessionStatus.Service.use((svc) => svc.list()))return c.json(Object.fromEntries(result))},)diff --git a/packages/opencode/src/session/status.ts b/packages/opencode/src/session/status.tsindex 16fccaf3e83..d54d8b79514 100644--- a/packages/opencode/src/session/status.ts+++ b/packages/opencode/src/session/status.ts@@ -1,7 +1,6 @@import { BusEvent } from "@/bus/bus-event"import { Bus } from "@/bus"import { InstanceState } from "@/effect/instance-state"-import { makeRuntime } from "@/effect/run-service"import { SessionID } from "./schema"import { Effect, Layer, ServiceMap } from "effect"import z from "zod"@@ -86,17 +85,4 @@ export namespace SessionStatus {)export const defaultLayer = layer.pipe(Layer.provide(Bus.layer))- const { runPromise } = makeRuntime(Service, defaultLayer)-- export async function get(sessionID: SessionID) {- return runPromise((svc) => svc.get(sessionID))- }-- export async function list() {- return runPromise((svc) => svc.list())- }-- export async function set(sessionID: SessionID, status: Info) {- return runPromise((svc) => svc.set(sessionID, status))- }}diff --git a/packages/opencode/test/session/retry.test.ts b/packages/opencode/test/session/retry.test.tsindex 0204c7a1178..a598c37fcdc 100644--- a/packages/opencode/test/session/retry.test.ts+++ b/packages/opencode/test/session/retry.test.ts@@ -6,6 +6,7 @@ import { Effect, Schedule } from "effect"import { SessionRetry } from "../../src/session/retry"import { MessageV2 } from "../../src/session/message-v2"import { ProviderID } from "../../src/provider/schema"+import { AppRuntime } from "../../src/effect/app-runtime"import { SessionID } from "../../src/session/schema"import { SessionStatus } from "../../src/session/status"import { Instance } from "../../src/project/instance"@@ -94,12 +95,16 @@ describe("session.retry.delay", () => {parse: (err) => err as MessageV2.APIError,set: (info) =>Effect.promise(() =>- SessionStatus.set(sessionID, {- type: "retry",- attempt: info.attempt,- message: info.message,- next: info.next,- }),+ AppRuntime.runPromise(+ SessionStatus.Service.use((svc) =>+ svc.set(sessionID, {+ type: "retry",+ attempt: info.attempt,+ message: info.message,+ next: info.next,+ }),+ ),+ ),),}),)@@ -108,7 +113,7 @@ describe("session.retry.delay", () => {}),)- expect(await SessionStatus.get(sessionID)).toMatchObject({+ expect(await AppRuntime.runPromise(SessionStatus.Service.use((svc) => svc.get(sessionID)))).toMatchObject({type: "retry",attempt: 2,message: "boom",