The open source AI video agent: turns any coding agent into a video agent, with an editor to change anything it makes.
Studio: the second click of a double-click on a card opens nothing (#151)
WEBGRS4df3346442c7
diff --git a/.changeset/double-click-opens-once.md b/.changeset/double-click-opens-once.mdnew file mode 100644index 0000000..251e722--- /dev/null+++ b/.changeset/double-click-opens-once.md@@ -0,0 +1,5 @@+---+"openfilm": patch+---++Projects: double-clicking a folder opens the folder only. Before, its second click opened whichever project had just appeared under the pointer.diff --git a/packages/openfilm/studio/ui/src/components/ProjectsView.tsx b/packages/openfilm/studio/ui/src/components/ProjectsView.tsxindex e972d10..309774a 100644--- a/packages/openfilm/studio/ui/src/components/ProjectsView.tsx+++ b/packages/openfilm/studio/ui/src/components/ProjectsView.tsx@@ -15,7 +15,7 @@ import { useLanguage, useT, type Language } from '@/i18n';import { limitTitleWidth, TITLE_MAX_WIDTH } from '@/lib/title';import { api, type Project } from '@/api';import { folderCounts, folderPosters, folderTrail, parentOf, visibleProjects, type LibrarySort, type ProjectFolder } from '@/lib/project-folders';-import { posterRetryDelay, posterTry } from '@/lib/projects-page';+import { opensOnClick, posterRetryDelay, posterTry } from '@/lib/projects-page';import { ContextMenu } from './ContextMenu';import { ProjectMenu } from './ProjectMenu';import { ProjectCoverContext } from './ProjectCover';@@ -123,6 +123,9 @@ export function ProjectsView({const counts = React.useMemo(() => folderCounts(projects, folders), [projects, folders]);const posters = React.useMemo(() => folderPosters(projects, folders), [projects, folders]);+ /** A card's open: on a click, a key press or its menu, not on the second click of a double-click (lib/projects-page). */+ const opening = (run: () => void) => (event?: { detail: number }) => { if (!event || opensOnClick(event)) run(); };+async function newFolder() {const created = await onCreateFolder(t('projects.untitledFolder'), folderId);if (created) setRenamingFolderId(created.id);@@ -134,7 +137,7 @@ export function ProjectsView({count: counts[folder.id] ?? 0,posters: posters[folder.id] ?? [],renaming: renamingFolderId === folder.id,- onOpen: () => setFolderId(folder.id),+ onOpen: opening(() => setFolderId(folder.id)),onStartRename: () => setRenamingFolderId(folder.id),onCommitRename: (name: string) => {setRenamingFolderId(null);@@ -217,7 +220,7 @@ export function ProjectsView({selected: selectedIds.has(project.id),renaming: renamingId === project.id,onToggleSelect: () => toggleSelected(project.id),- onOpen: () => onOpen(project),+ onOpen: opening(() => onOpen(project)),onStartRename: () => { if (!selecting) setRenamingId(project.id); },onCommitRename: (name: string) => {setRenamingId((current) => (current === project.id ? null : current));@@ -395,7 +398,7 @@ interface ItemProps {selected: boolean;renaming: boolean;onToggleSelect: () => void;- onOpen: () => void;+ onOpen: (event?: { detail: number }) => void;onStartRename: () => void;onCommitRename: (name: string) => void;onCancelRename: () => void;@@ -462,7 +465,7 @@ function ProjectCardTitle({stored: string;renaming: boolean;size: 'card' | 'list';- onOpen: () => void;+ onOpen: (event?: { detail: number }) => void;onCommit: (title: string) => void;onCancel: () => void;}) {@@ -870,7 +873,7 @@ interface FolderItemProps {/** its newest projects, up to four, with their covers when they have one */posters: { id: string; poster?: string }[];renaming: boolean;- onOpen: () => void;+ onOpen: (event?: { detail: number }) => void;onStartRename: () => void;onCommitRename: (name: string) => void;onCancelRename: () => void;diff --git a/packages/openfilm/studio/ui/src/lib/projects-page.test.ts b/packages/openfilm/studio/ui/src/lib/projects-page.test.tsindex 7849ae9..ba7d550 100644--- a/packages/openfilm/studio/ui/src/lib/projects-page.test.ts+++ b/packages/openfilm/studio/ui/src/lib/projects-page.test.ts@@ -1,6 +1,6 @@import { test } from 'node:test';import assert from 'node:assert/strict';-import { posterRetryDelay, posterTry, within } from './projects-page.ts';+import { opensOnClick, posterRetryDelay, posterTry, within } from './projects-page.ts';test('a list that never comes fails in its own time; one that comes or fails is passed on as it is', async () => {assert.equal(await within(Promise.resolve(3), 50), 3);@@ -16,3 +16,12 @@ test('a poster still being drawn is asked for again, less often each time, thenassert.equal(posterTry('/api/projects/a/poster', 2), '/api/projects/a/poster?try=2');assert.equal(posterTry('/api/projects/a/poster?cover=5', 1), '/api/projects/a/poster?cover=5&try=1');});++test('a card opens on a click or a key press, not on the second click of a double-click', () => {+ /* a key press (Enter, Space) is a click of detail 0 */+ assert.equal(opensOnClick({ detail: 0 }), true);+ assert.equal(opensOnClick({ detail: 1 }), true);+ /* the first click already opened a folder; what is under the pointer now was not aimed at */+ assert.equal(opensOnClick({ detail: 2 }), false);+ assert.equal(opensOnClick({ detail: 3 }), false);+});diff --git a/packages/openfilm/studio/ui/src/lib/projects-page.ts b/packages/openfilm/studio/ui/src/lib/projects-page.tsindex 607d98e..143b6fb 100644--- a/packages/openfilm/studio/ui/src/lib/projects-page.ts+++ b/packages/openfilm/studio/ui/src/lib/projects-page.ts@@ -29,3 +29,12 @@ export function posterRetryDelay(tried: number): number | null {export function posterTry(url: string, n: number): string {return n ? `${url}${url.includes('?') ? '&' : '?'}try=${n}` : url;}++/**+ * Whether a click on a card opens it: not the second click of a double-click (`detail` 2 or more). The first click+ * opened something already, a folder say, and what stands under the pointer now was not aimed at. A key press (Enter,+ * Space: `detail` 0) opens.+ */+export function opensOnClick(event: { detail: number }): boolean {+ return event.detail < 2;+}