Skip to content

The ultimate harness for coding agents and beyond. All your agents. All your machines. One command center. Start with code, then follow your curiosity and build across disciplines: CAD, circuits, robots, games and music.

test(cli): keep terminal keyframes delivered with the ready frame (#908)

Dee27eafac26ccd
diff --git a/cli/e2e/terminal.e2e.ts b/cli/e2e/terminal.e2e.ts
index 15811044f..ae5d6a71e 100644
--- a/cli/e2e/terminal.e2e.ts
+++ b/cli/e2e/terminal.e2e.ts
@@ -47,9 +47,12 @@ class Terminal {
/** Opens it, or rejects with the `terminal_error` code the daemon answered. */
static async open(client: LocalClient, agentId: string, options: Record<string, unknown> = {}): Promise<Terminal> {
+ // Found by QA on a quiet machine: ws can deliver the keyframe alongside terminal_ready,
+ // before this await continues. Keep every frame from the request onward.
+ const since = client.binaries.length
const answer = await Terminal.answer(client, { agentId, cols: 100, rows: 30, ...options })
if (answer.type !== 'terminal_ready') throw new Error(String(answer.payload?.code))
- return new Terminal(client, agentId, answer.payload!, client.binaries.length)
+ return new Terminal(client, agentId, answer.payload!, since)
}
/** The frame `terminal_open` is answered with: `terminal_ready`, or `terminal_error` naming why. */
@@ -119,6 +122,35 @@ class Terminal {
}
}
+it('keeps the opening screen when terminal_ready and its keyframe arrive together', async () => {
+ const keyframe: TerminalBinaryClear = {
+ kind: TerminalBinaryKind.keyframe, streamId: 'opened', seq: 0, compressed: false,
+ bytes: Buffer.from('the engine is ready'),
+ }
+ const binaries: TerminalBinaryClear[] = [{ ...keyframe, streamId: 'older' }]
+ let accepts!: (frame: Frame) => boolean
+ let answer!: (frame: Frame) => void
+ const client = {
+ binaries,
+ next(test: (frame: Frame) => boolean) {
+ accepts = test
+ return new Promise<Frame>((resolve) => { answer = resolve })
+ },
+ send(_type: string, payload: Record<string, unknown>) {
+ const ready = { type: 'terminal_ready', payload: { requestId: payload.requestId, streamId: 'opened' } }
+ expect(accepts(ready)).toBe(true)
+ // Found by QA on a quiet machine: ws can deliver both frames in one socket callback,
+ // before the await of terminal_ready continues. The test window must keep that screen.
+ answer(ready)
+ binaries.push({ ...keyframe, streamId: 'another-window' }, keyframe)
+ },
+ } as unknown as LocalClient
+
+ const terminal = await Terminal.open(client, 'agent')
+ expect(terminal.frames()).toEqual([keyframe])
+ expect(terminal.screen()).toBe('the engine is ready')
+})
+
describe('the terminal', () => {
let daemon: IsolatedDaemon | undefined
afterEach(async () => { await daemon?.close(); daemon = undefined })