Skip to content

The ultimate harness for coding agents and beyond. All your agents. All your machines. One command center. Start with code, then follow your curiosity and build across disciplines: CAD, circuits, robots, games and music.

Desktop: the # buddy row stays in the sidebar under the unread filter (Tony) (#2498)

0xken1538a914e2e9c8
diff --git a/desktop/lib/super_tabs/project_sidebar.dart b/desktop/lib/super_tabs/project_sidebar.dart
index f2c41f7ed..165e69a69 100644
--- a/desktop/lib/super_tabs/project_sidebar.dart
+++ b/desktop/lib/super_tabs/project_sidebar.dart
@@ -733,10 +733,9 @@ class ProjectSidebar extends StatelessWidget {
const key = SuperTabController.kSwarmBuddyKey;
final chat = controller.buddyChat(key);
if (chat == null && !controller.canWrite) return null;
- // The unread filter keeps it only with something unread, or open.
- if (controller.unreadOnly && (chat == null || !_keptByFilter(chat))) {
- return null;
- }
+ // The unread filter never hides it: it is the person's one Buddy, pinned
+ // like a personal chat, and bold only while it has something unread
+ // (Tony, 11-02: it vanished from the latest Desktop under the filter).
final agent = controller.buddy(key);
final busy = controller.saving || controller.hasPendingAction;
return _drawRow(
diff --git a/desktop/test/super_tab_activity_test.dart b/desktop/test/super_tab_activity_test.dart
index f614ed225..a3bf5c559 100644
--- a/desktop/test/super_tab_activity_test.dart
+++ b/desktop/test/super_tab_activity_test.dart
@@ -730,19 +730,22 @@ void main() {
c.dispose();
});
- testWidgets('the unread filter keeps it only while it has something '
- 'unread', (tester) async {
+ testWidgets('the unread filter keeps it shown, bold only while it has '
+ 'something unread', (tester) async {
final server = oneBuddySwarm();
giveSwarmBuddy(server);
final c = await show(tester, server);
expect(buddyRow, findsOneWidget);
c.toggleUnreadOnly();
await tester.pumpAndSettle();
- expect(buddyRow, findsNothing);
+ expect(c.unreadOnly, isTrue);
+ expect(buddyRow, findsOneWidget);
+ expect(buddyName(tester).style?.fontWeight, isNot(grid.AppFont.semibold));
server.append('A word from Wren', conversationId: 'swarm-buddy-peer');
await c.refresh();
await tester.pumpAndSettle();
expect(buddyRow, findsOneWidget);
+ expect(buddyName(tester).style?.fontWeight, grid.AppFont.semibold);
await tester.pumpWidget(const SizedBox());
await c.flush();
c.dispose();