The ultimate harness for coding agents and beyond. All your agents. All your machines. One command center. Start with code, then follow your curiosity and build across disciplines: CAD, circuits, robots, games and music.
TypeScript 3d-modelingagent-frameworkagent-harnessai-agentscadclaude-codecodexcoding-agentsdeveloper-toolsesp32game-developmentmcp-servermulti-agentopen-hardwareopencodeopenharnesspcbroboticsterminaltmux
yosys: vcd2json to full coverage; a same-tick glitch is no edge
dee457a7ad4e915
diff --git a/store/agents/yosys/toolchain/test_vcd.py b/store/agents/yosys/toolchain/test_vcd.pyindex 7b9753f07..d1130c6de 100644--- a/store/agents/yosys/toolchain/test_vcd.py+++ b/store/agents/yosys/toolchain/test_vcd.py@@ -1,10 +1,19 @@"""The VCD reader, on a dump shaped exactly like Icarus Verilog's."""+import io+import json+import runpyimport sys+import tempfileimport unittest+from contextlib import redirect_stderr, redirect_stdoutfrom pathlib import Path+from unittest import mocksys.path.insert(0, str(Path(__file__).parent))-from vcd2json import extend, parse, tick_fs # noqa: E402+import vcd2json # noqa: E402+from vcd2json import extend, main, parse, tick_fs # noqa: E402++SCRIPT = Path(__file__).parent / "vcd2json.py"DUMP = """$date\tWed Sep 16 13:10:58 2026@@ -106,6 +115,108 @@ class Changes(unittest.TestCase):self.assertEqual(clk["changes"][-1], [15000, "1"])+ def test_a_same_tick_rewrite_keeps_the_last_value(self):+ w = parse(DUMP + "#20000\n0(\n#20000\nz(\n")+ clk = next(s for s in w["signals"] if s["name"] == "blink_tb.clk")+ self.assertEqual(clk["changes"][-1], [20000, "z"])++ def test_a_same_tick_glitch_back_to_the_old_value_is_no_edge(self):+ # 0 then 1 at #20000 on a clock that was already 1: nothing changed at that tick.+ w = parse(DUMP + "#20000\n0(\n1(\n")+ clk = next(s for s in w["signals"] if s["name"] == "blink_tb.clk")+ self.assertEqual(clk["changes"], [[0, "0"], [5000, "1"], [10000, "0"], [15000, "1"]])++ def test_reals_are_kept_as_written(self):+ w = parse("$var real 1 ! temp $end $enddefinitions $end #0 r1.5 ! #3 R2.25e1 !")+ self.assertEqual(w["signals"][0]["changes"], [[0, "1.5"], [3, "2.25e1"]])++ def test_a_bad_timestamp_is_ignored(self):+ w = parse("$var wire 1 ! a $end $enddefinitions $end #0 0! #oops 1! #7 0!")+ self.assertEqual(w["signals"][0]["changes"], [[0, "1"], [7, "0"]])+ self.assertEqual(w["end"], 7)++ def test_changes_for_an_undeclared_id_are_ignored(self):+ w = parse("$var wire 1 ! a $end $enddefinitions $end #0 0! 1? b101 ?")+ self.assertEqual(w["signals"][0]["changes"], [[0, "0"]])++ def test_a_long_run_is_capped_and_says_so(self):+ with mock.patch.object(vcd2json, "MAX_CHANGES", 3):+ w = parse("$var wire 1 ! a $end $enddefinitions $end #0 0! #1 1! #2 0! #3 1! #4 0!")+ self.assertEqual(w["signals"][0]["changes"], [[0, "0"], [1, "1"], [2, "0"]])+ self.assertTrue(w["truncated"])+ self.assertFalse(parse(DUMP)["truncated"])+++class Declarations(unittest.TestCase):+ def test_a_header_with_no_enddefinitions_still_lists_its_signals(self):+ w = parse("$timescale 10 ns $end $scope module a $end $var wire 1 ! x $end")+ self.assertEqual([s["name"] for s in w["signals"]], ["a.x"])+ self.assertEqual((w["end"], w["tickFs"]), (0, 10 ** 7))++ def test_an_unbalanced_upscope_and_stray_tokens_do_not_derail_the_header(self):+ w = parse("$upscope $end stray $scope module top $end $var wire 1 ! x $end $upscope $end "+ "$var wire 1 # y $end $enddefinitions $end")+ self.assertEqual([s["name"] for s in w["signals"]], ["top.x", "y"])++ def test_a_module_inside_a_task_is_still_skipped(self):+ w = parse("$scope module top $end $scope task t $end $scope module inner $end $var wire 1 ! a $end "+ "$upscope $end $upscope $end $var wire 1 # b $end $upscope $end $enddefinitions $end")+ self.assertEqual([s["name"] for s in w["signals"]], ["top.b"])++ def test_short_vars_bad_widths_and_wide_buses_are_dropped(self):+ w = parse("$var wire 1 ! $end $var wire wide # a $end $var wire 0 $ b $end $var reg 65 % mem $end "+ "$var wire 64 & bus $end $enddefinitions $end")+ self.assertEqual([(s["name"], s["width"]) for s in w["signals"]], [("bus", 64)])++ def test_no_more_lanes_than_the_pane_can_show(self):+ header = " ".join(f"$var wire 1 s{k} n{k} $end" for k in range(vcd2json.MAX_SIGNALS + 5))+ w = parse(header + " $enddefinitions $end")+ self.assertEqual(len(w["signals"]), vcd2json.MAX_SIGNALS)+ self.assertEqual(w["signals"][-1]["name"], f"n{vcd2json.MAX_SIGNALS - 1}")+++class Main(unittest.TestCase):+ def run_main(self, argv):+ out, err = io.StringIO(), io.StringIO()+ with redirect_stdout(out), redirect_stderr(err):+ code = main(argv)+ return code, out.getvalue(), err.getvalue()++ def test_usage(self):+ code, _, err = self.run_main(["vcd2json.py"])+ self.assertEqual(code, 2)+ self.assertIn("usage: vcd2json.py", err)++ def test_a_missing_vcd_says_what_the_testbench_forgot(self):+ with tempfile.TemporaryDirectory() as d:+ code, _, err = self.run_main(["vcd2json.py", str(Path(d) / "sim.vcd")])+ self.assertEqual(code, 1)+ self.assertIn("did the testbench call $dumpfile/$dumpvars?", err)++ def test_writes_the_lanes_beside_the_vcd_or_where_asked(self):+ with tempfile.TemporaryDirectory() as d:+ vcd = Path(d) / "sim.vcd"+ vcd.write_text(DUMP)+ code, out, _ = self.run_main(["vcd2json.py", str(vcd)])+ self.assertEqual(code, 0)+ self.assertEqual(len(json.loads((Path(d) / "sim.json").read_text())["signals"]), 4)+ self.assertIn("4 signal(s), 12 change(s), 0..15000 1ps", out)+ dst = Path(d) / "deeper" / "waves.json"+ code, out, _ = self.run_main(["vcd2json.py", str(vcd), str(dst)])+ self.assertEqual(code, 0)+ self.assertEqual(json.loads(dst.read_text())["end"], 15000)++ def test_runs_as_a_script(self):+ with tempfile.TemporaryDirectory() as d:+ vcd = Path(d) / "sim.vcd"+ vcd.write_text(DUMP)+ with mock.patch.object(sys, "argv", [str(SCRIPT), str(vcd), str(Path(d) / "w.json")]), \+ redirect_stdout(io.StringIO()), self.assertRaises(SystemExit) as exit_:+ runpy.run_path(str(SCRIPT), run_name="__main__")+ self.assertEqual(exit_.exception.code, 0)+ self.assertTrue((Path(d) / "w.json").exists())++class Extend(unittest.TestCase):def test_zero_extends(self):self.assertEqual(extend("1", 4), "0001")diff --git a/store/agents/yosys/toolchain/vcd2json.py b/store/agents/yosys/toolchain/vcd2json.pyindex cb4039abd..7587cd920 100755--- a/store/agents/yosys/toolchain/vcd2json.py+++ b/store/agents/yosys/toolchain/vcd2json.py@@ -132,8 +132,6 @@ def parse(text: str) -> dict:while i < n:t = tokens[i]i += 1- if not t:- continuehead = t[0]if head == "#":try:@@ -164,7 +162,12 @@ def parse(text: str) -> dict:if sig["changes"] and sig["changes"][-1][1] == value:continue # a repeat of the same value carries no edgeif sig["changes"] and sig["changes"][-1][0] == time:- sig["changes"][-1][1] = value # same tick: the last write wins+ # Same tick: the last write wins — unless it puts back the value before it, which+ # makes the tick no edge at all.+ if len(sig["changes"]) > 1 and sig["changes"][-2][1] == value:+ sig["changes"].pop()+ else:+ sig["changes"][-1][1] = valuecontinuesig["changes"].append([time, value])