Skip to content

The ultimate harness for coding agents and beyond. All your agents. All your machines. One command center. Start with code, then follow your curiosity and build across disciplines: CAD, circuits, robots, games and music.

desktop: no "<model> is running" toast

bitcoinbuilder4cb74cc49a0f
diff --git a/desktop/lib/models/models_panel.dart b/desktop/lib/models/models_panel.dart
index 52b0c151b..7e70c3f7a 100644
--- a/desktop/lib/models/models_panel.dart
+++ b/desktop/lib/models/models_panel.dart
@@ -739,8 +739,11 @@ class _ModelsPanelState extends State<ModelsPanel> {
}
}
-/// Discovery appears once. Completion explains where model selection lives;
-/// the overview never creates a session or changes its model implicitly.
+/// Discovery appears once; the overview never creates a session or changes its
+/// model implicitly.
+///
+/// No "`<model>` is running" toast: a started model is shown by its own row in the
+/// Models overview, and a toast in the corner of the workspace repeated it.
class LocalModelInvitation extends StatelessWidget {
const LocalModelInvitation({
super.key,
@@ -755,9 +758,7 @@ class LocalModelInvitation extends StatelessWidget {
Widget build(BuildContext context) => ListenableBuilder(
listenable: controller,
builder: (context, _) {
- final ready = controller.readyModel;
- if (ready == null &&
- (!showIntroduction || !controller.showIntroduction)) {
+ if (!showIntroduction || !controller.showIntroduction) {
return const SizedBox.shrink();
}
return Align(
@@ -777,14 +778,7 @@ class LocalModelInvitation extends StatelessWidget {
padding: const EdgeInsets.fromLTRB(16, 10, 8, 10),
child: Row(
children: [
- if (ready == null)
- const ModelMark()
- else
- Icon(
- LucideIcons.circleCheckBig,
- color: AppColors.success,
- size: 22,
- ),
+ const ModelMark(),
const SizedBox(width: 12),
Expanded(
child: Column(
@@ -792,36 +786,24 @@ class LocalModelInvitation extends StatelessWidget {
crossAxisAlignment: CrossAxisAlignment.start,
children: [
Text(
- ready == null
- ? 'Run AI on this computer'
- : '${ready.name} is running',
+ 'Run AI on this computer',
style: AppType.label(color: AppColors.text),
),
- if (ready == null)
- TextButton(
- onPressed: onOpen,
- style: TextButton.styleFrom(
- padding: EdgeInsets.zero,
- alignment: Alignment.centerLeft,
- ),
- child: const Text('Explore models'),
- )
- else
- Padding(
- padding: const EdgeInsets.only(top: 5),
- child: Text(
- 'Select it from the model picker in a session.',
- style: AppType.body(color: AppColors.textSoft),
- ),
+ TextButton(
+ onPressed: onOpen,
+ style: TextButton.styleFrom(
+ padding: EdgeInsets.zero,
+ alignment: Alignment.centerLeft,
),
+ child: const Text('Explore models'),
+ ),
],
),
),
IconButton(
tooltip: 'Dismiss',
- onPressed: () => ready == null
- ? unawaited(controller.dismissIntroduction())
- : controller.dismissReady(),
+ onPressed: () =>
+ unawaited(controller.dismissIntroduction()),
icon: const Icon(Icons.close, size: 17),
),
],
diff --git a/desktop/lib/screens/swarm_screen.dart b/desktop/lib/screens/swarm_screen.dart
index 1e4534feb..0759a49a8 100644
--- a/desktop/lib/screens/swarm_screen.dart
+++ b/desktop/lib/screens/swarm_screen.dart
@@ -3767,13 +3767,6 @@ class _SwarmScreenState extends State<SwarmScreen>
// Last in the stack, so a banner is never painted
// under a pane, a tab or the palette. It takes
// pointers only on the banners themselves.
- if (!_commandBarOpen && _newHarness == null)
- LocalModelInvitation(
- controller: app.modelManager,
- showIntroduction: false,
- onOpen: () =>
- _toggleModels(initialTab: ModelsTab.local),
- ),
AgentAlertBanners(notifier: app),
],
),
diff --git a/desktop/test/models_panel_test.dart b/desktop/test/models_panel_test.dart
index 6004bc17b..1a78eafa0 100644
--- a/desktop/test/models_panel_test.dart
+++ b/desktop/test/models_panel_test.dart
@@ -401,7 +401,7 @@ void main() {
});
testWidgets(
- 'the one-time invitation leads to discovery and verified readiness explains selection',
+ 'the one-time invitation leads to discovery, and a started model gets no toast',
(tester) async {
final app = ModelManagerTestApp(ModelManagerConnection());
app.stateOf('m')!.agents = [
@@ -432,17 +432,24 @@ void main() {
await tester.tap(find.byTooltip('Dismiss'));
await tester.pump();
expect(find.text('Run AI on this computer'), findsNothing);
+ // A model that has just started gets no toast — its row in the Models
+ // overview is where it is shown.
app.localInventory = modelInventory(scenario: 'ready');
await controller.refresh();
await tester.pump();
- expect(find.text('Qwen3.8-27B is running'), findsOneWidget);
+ expect(controller.readyModel?.name, 'Qwen3.8-27B');
+ expect(find.text('Qwen3.8-27B is running'), findsNothing);
expect(
find.text('Select it from the model picker in a session.'),
- findsOneWidget,
+ findsNothing,
+ );
+ expect(
+ find.descendant(
+ of: find.byType(LocalModelInvitation),
+ matching: find.byType(Material),
+ ),
+ findsNothing,
);
- await tester.tap(find.byTooltip('Dismiss'));
- await tester.pump();
- expect(find.text('Qwen3.8-27B is running'), findsNothing);
expect(app.sent, isEmpty);
await tester.pump(const Duration(milliseconds: 100));
await tester.pumpWidget(const SizedBox());