Skip to content

The ultimate harness for coding agents and beyond. All your agents. All your machines. One command center. Start with code, then follow your curiosity and build across disciplines: CAD, circuits, robots, games and music.

desktop: a pane-menu row says it is clickable before it is clicked

bitcoinbuilder539f1d527b5e
diff --git a/desktop/lib/widgets/pane_menu.dart b/desktop/lib/widgets/pane_menu.dart
index a55e8f6f8..4a34a9110 100644
--- a/desktop/lib/widgets/pane_menu.dart
+++ b/desktop/lib/widgets/pane_menu.dart
@@ -109,13 +109,24 @@ Future<T?> showPaneMenu<T>({
/// InkWell around the whole item painted edge to edge and square, over a selected fill that was
/// neither, and the two reading as different shapes made the current row look like the odd one
/// out.
+/// ⚠️ The cursor is STATED, in both places that can answer for it. A pane menu is drawn in an
+/// overlay above a terminal, and what a person sees while hovering a row was whatever the surface
+/// underneath asked for — an arrow over rows that are the whole point of the menu. `InkWell` carries
+/// a clickable cursor of its own in principle, and in this app it was not what reached the screen;
+/// the control that OPENS this menu needed both annotations before a hand appeared, and these rows
+/// need the same. The cursor a person sees is the innermost annotation under the pointer, so the
+/// MouseRegion covers the row and the InkWell answers for its own ink.
Widget paneMenuItem({required VoidCallback onTap, required Widget child}) =>
Padding(
padding: const EdgeInsets.symmetric(horizontal: kPaneMenuInset),
- child: InkWell(
- onTap: onTap,
- borderRadius: BorderRadius.circular(kPaneMenuRowRadius),
- child: child,
+ child: MouseRegion(
+ cursor: SystemMouseCursors.click,
+ child: InkWell(
+ onTap: onTap,
+ mouseCursor: SystemMouseCursors.click,
+ borderRadius: BorderRadius.circular(kPaneMenuRowRadius),
+ child: child,
+ ),
),
);
diff --git a/desktop/test/grid_model_picker_test.dart b/desktop/test/grid_model_picker_test.dart
index 944fe8c29..1510cfc03 100644
--- a/desktop/test/grid_model_picker_test.dart
+++ b/desktop/test/grid_model_picker_test.dart
@@ -474,6 +474,44 @@ void main() {
},
);
+ testWidgets('every row a person can pick says so under the pointer', (
+ tester,
+ ) async {
+ // A pane menu is drawn over a terminal, and the cursor a person saw while hovering a row was
+ // whatever the surface underneath asked for — an arrow over the rows that are the whole point of
+ // the menu. The subscription row and each Local model are choices; they should look like it
+ // before they are clicked.
+ build(models: [
+ {'id': 'Qwen-Test', 'node': 'macbook-m1max'},
+ ]);
+ await open(tester);
+
+ for (final row in ['Anthropic', 'Qwen-Test']) {
+ final inkWell = tester.widget<InkWell>(
+ find.ancestor(of: find.text(row), matching: find.byType(InkWell)).first,
+ );
+ expect(inkWell.mouseCursor, SystemMouseCursors.click, reason: row);
+ // BOTH annotations, because the innermost one under the pointer is what decides: InkWell
+ // installs a MouseRegion of its own, so an ancestor asking for a hand does not settle it.
+ //
+ // ⚠️ Counted, not read off `.first`. The nearest MouseRegion ancestor of a row IS the one
+ // InkWell made, so asserting on it twice looked like two checks and was one — the wrapper
+ // could be set to `basic` and this test still passed. Two carrying it is what proves both.
+ final asking = tester
+ .widgetList<MouseRegion>(
+ find.ancestor(of: find.text(row), matching: find.byType(MouseRegion)),
+ )
+ .where((region) => region.cursor == SystemMouseCursors.click)
+ .length;
+ expect(asking, greaterThanOrEqualTo(2), reason: row);
+ }
+
+ // ⚠️ This asserts the widgets' contract, NOT the cursor the OS draws. Reading that back through
+ // `MouseTracker.debugDeviceActiveCursor` does not work in this harness — a bare
+ // `MouseRegion(cursor: click)` over a plain box answers `basic` there — so a test written that
+ // way would be measuring the harness rather than the app.
+ });
+
group('which engines are offered a picker at all', () {
test('the three whose switching has been driven end to end', () {
// Not the daemon's `localModelEngines`, which is the wider "could a Local model be handed to