The ultimate harness for coding agents and beyond. All your agents. All your machines. One command center. Start with code, then follow your curiosity and build across disciplines: CAD, circuits, robots, games and music.
TypeScript 3d-modelingagent-frameworkagent-harnessai-agentscadclaude-codecodexcoding-agentsdeveloper-toolsesp32game-developmentmcp-servermulti-agentopen-hardwareopencodeopenharnesspcbroboticsterminaltmux
feat(pro): Console Recent as cards, like a tab (#1309)
0xdiego255519be61a5cc
diff --git a/devices/harness-pro/firmware/main/CMakeLists.txt b/devices/harness-pro/firmware/main/CMakeLists.txtindex 4065f7bb7..8bff42114 100644--- a/devices/harness-pro/firmware/main/CMakeLists.txt+++ b/devices/harness-pro/firmware/main/CMakeLists.txt@@ -49,7 +49,6 @@ idf_component_register("pod/console/cs_ota.c""pod/console/cs_overview.c""pod/console/cs_recap.c"- "pod/console/cs_recent.c""pod/console/cs_tab.c""pod/console/cs_talk.c""pod/console/cs_toast.c"diff --git a/devices/harness-pro/firmware/main/app/pod_glue.c b/devices/harness-pro/firmware/main/app/pod_glue.cindex 0f9a0cda0..ba4cd97d4 100644--- a/devices/harness-pro/firmware/main/app/pod_glue.c+++ b/devices/harness-pro/firmware/main/app/pod_glue.c@@ -209,17 +209,17 @@ static bool scrolls(const pod_ui_t *u){const pod_frame_t *f = top(u);if (!f) return false;- if (u->nav.skin == POD_SKIN_CONSOLE) // Overview pages sideways and a tab's cards page on a swipe (card_page); Recent's rows and- // the Inbox scroll; on Agent and Recap a drag scrolls the host's pane (host_scrolls)- return (f->view == POD_V_TAB && f->tab == POD_TAB_RECENT) || f->view == POD_V_INBOX || f->view == POD_V_AGENT || f->view == POD_V_RECAP;+ if (u->nav.skin == POD_SKIN_CONSOLE) // Overview pages sideways and a tab's (and Recent's) cards page on a swipe (card_page); the+ // Inbox scrolls; on Agent and Recap a drag scrolls the host's pane (host_scrolls)+ return f->view == POD_V_INBOX || f->view == POD_V_AGENT || f->view == POD_V_RECAP;return f->view == POD_V_TABS || f->view == POD_V_TAB || f->view == POD_V_RECAP || f->view == POD_V_INBOX;}-// Console Tab (not Recent): its cards page on a vertical swipe, from anywhere but the bar and the bottom zone (their own swipes;+// Console Tab and Recent: their cards page on a vertical swipe, from anywhere but the bar and the bottom zone (their own swipes;// the caller checks the zone, whose flag is cleared by then).static bool card_page(const pod_ui_t *u){const pod_frame_t *f = top(u);- return u->nav.skin == POD_SKIN_CONSOLE && f && f->view == POD_V_TAB && f->tab != POD_TAB_RECENT && !u->bar;+ return u->nav.skin == POD_SKIN_CONSOLE && f && f->view == POD_V_TAB && !u->bar;}// Whether a vertical drag on this screen scrolls the host's terminal pane (the scroll sink): Recap in both skins, and in Console the// Agent screen too, as on the round. The bar and the bottom zone keep their own swipes (u->bar, u->edge), so a drag there does not.@@ -721,17 +721,11 @@ static uint32_t unit_ms(const pod_ui_t *u)const pod_frame_t *f = top(u);if (u->model.linked && f && f->view == POD_V_TABS && u->nav.skin != POD_SKIN_CONSOLE && u->pg_mode == POD_PG_IDLE && pod_tabs_ribbon(&u->model, pg_page(u)))return POD_TABS_BAR_MS; // the Playing ribbon's bars: three tiny rects- if (u->model.linked && f && f->view == POD_V_TAB && u->nav.skin == POD_SKIN_CONSOLE && f->tab != POD_TAB_RECENT) { // a tab's cards+ if (u->model.linked && f && f->view == POD_V_TAB && u->nav.skin == POD_SKIN_CONSOLE) { // a tab's (or Recent's) cardsconst pod_agent_t *l[CS_PER_PAGE];int n = cs_tab_page(&u->nav, &u->model, l);for (int i = 0; i < n; i++)if (pod_model_eff(&u->model, l[i]) == POD_WORKING) return POD_CS_ANIM_MS;- } else if (u->model.linked && f && f->view == POD_V_TAB && u->nav.skin == POD_SKIN_CONSOLE) { // Recent: the rows on screen- const pod_agent_t *l[POD_AGENTS_MAX];- int n = pod_nav_list(&u->nav, &u->model, l, POD_AGENTS_MAX), max = n > CS_ROWS_MAX ? n - CS_ROWS_MAX : 0;- int first = f->scroll < 0 ? 0 : f->scroll > max ? max : f->scroll;- for (int i = first; i < n && i < first + CS_ROWS_MAX; i++)- if (pod_model_eff(&u->model, l[i]) == POD_WORKING) return POD_CS_ANIM_MS;} else if (u->model.linked && f && f->view == POD_V_TAB) { // Classic: the footer's mark moves while a listed agent worksconst pod_agent_t *l[POD_AGENTS_MAX];int n = pod_nav_list(&u->nav, &u->model, l, POD_AGENTS_MAX);diff --git a/devices/harness-pro/firmware/main/app/pod_glue.h b/devices/harness-pro/firmware/main/app/pod_glue.hindex 2b9d453cb..cbca69eaf 100644--- a/devices/harness-pro/firmware/main/app/pod_glue.h+++ b/devices/harness-pro/firmware/main/app/pod_glue.h@@ -18,7 +18,7 @@ enum { POD_TAP_SLOP = 24 };// Console gestures: hold this long to talk; slide down this far after it to cancel; the command bar's height and the// travel of a swipe down from it.enum { POD_HOLD_MS = 400, POD_BAR_H = 72, POD_BAR_SWIPE = 80, POD_BOTTOM_Y = 620, POD_EDGE_SWIPE = 80 };-// Console Tab (cards and Recent's rows) and the Inbox fill the screen to its bottom margin, so their bottom zone (a swipe up goes+// Console Tab and Recent (cards) and the Inbox fill the screen to its bottom margin, so their bottom zone (a swipe up goes// back) starts below the content instead of at POD_BOTTOM_Y: a swipe up from the last row or card scrolls or pages.enum { POD_LIST_BOTTOM_Y = 692 };enum { POD_PG_IDLE, POD_PG_DRAG, POD_PG_ANIM };diff --git a/devices/harness-pro/firmware/main/pod/console/cs.h b/devices/harness-pro/firmware/main/pod/console/cs.hindex 553f44373..58ad124e0 100644--- a/devices/harness-pro/firmware/main/pod/console/cs.h+++ b/devices/harness-pro/firmware/main/pod/console/cs.h@@ -45,14 +45,8 @@ int cs_runs(const pod_out_frame_t *);// pct % of colour a over colour b, per channel (0xRRGGBB).unsigned cs_mix(unsigned a, unsigned b, unsigned pct);-// ---- Overview and Recent (cs_overview.c, cs_recent.c) --------------------------------------------------------------// Recent's row list: up to CS_ROWS_MAX rows of CS_ROW_H px from `first`, right under the bar.-// Each row: the 44 px logo, the working mark (WORKING) or a dot, the name, the tab's name when tab_col, the time (or "ask") right-// aligned, and the agent's line. Its hit is POD_A_OPEN_AGENT with the agent's index in `list` and its id. Returns the rows drawn.-enum { CS_ROW_H = 104, CS_ROWS_MAX = 6, CS_ROWS_TOP = CS_BAR_H + 4, CS_PER_PAGE = 4 };-int cs_rows(pod_out_frame_t *, const pod_model_t *, const pod_agent_t *const list[], int n, int first, bool tab_col, uint32_t now_ms);-// The scroll limit of a TAB frame: Recent's agents less the rows that show; a tab's last card page.-int cs_rows_max(const pod_nav_t *, const pod_model_t *);+// ---- Overview, Tab and Recent (cs_overview.c, cs_tab.c) -------------------------------------------------------------+enum { CS_PER_PAGE = 4 }; // cards a page, on Overview and on a tab (Recent too)void cs_view_overview(pod_out_frame_t *, const pod_nav_t *, pod_model_t *, uint32_t now_ms);// Overview cards. cs_card_lead: the agent that speaks for cover c (0 = Recent, else tab c - 1), among its first CS_CARD_AGENTS:// the first working, else asking, failed, done, idle; NULL with none. cs_card_scene: the pet scene a card plays for it (WORK, ASK,@@ -73,9 +67,9 @@ pod_scene_t cs_card_scene(const pod_model_t *, const pod_agent_t *);// to the next step of any of them (never sooner than POD_CS_ANIM_MS's beat). False / 1000 on other screens.bool cs_cards_move(const pod_nav_t *, const pod_model_t *);uint32_t cs_cards_next_ms(const pod_nav_t *, const pod_model_t *, uint32_t now_ms);-void cs_view_recent(pod_out_frame_t *, const pod_nav_t *, pod_model_t *, uint32_t now_ms);-// The selected tab: its agents as cards (pro-console-tab-cards.html, B), four a page in the window's own pane order, each tinted by-// its agent's state. The TAB frame's scroll is the page; a vertical swipe pages (the glue), sideways steps tabs.+// The selected tab, or Recent: its agents as cards (pro-console-tab-cards.html, B), four a page (a tab in the window's own pane+// order, Recent newest first), each tinted by its agent's state. The TAB frame's scroll is the page; a vertical swipe pages (the+// glue), sideways steps tabs.void cs_view_tab(pod_out_frame_t *, const pod_nav_t *, pod_model_t *, uint32_t now_ms);// The tab's agents on the page the TAB frame shows (at most CS_PER_PAGE), and the number of pages (at least 1).int cs_tab_page(const pod_nav_t *, const pod_model_t *, const pod_agent_t *out[CS_PER_PAGE]);diff --git a/devices/harness-pro/firmware/main/pod/console/cs_overview.c b/devices/harness-pro/firmware/main/pod/console/cs_overview.cindex e29066c44..0fe95c5d3 100644--- a/devices/harness-pro/firmware/main/pod/console/cs_overview.c+++ b/devices/harness-pro/firmware/main/pod/console/cs_overview.c@@ -130,7 +130,7 @@ static int on_screen(const pod_nav_t *nav, const pod_model_t *m, const pod_agent{const pod_frame_t *f = nav->depth ? &nav->stack[nav->depth - 1] : NULL;if (!f || nav->skin != POD_SKIN_CONSOLE) return 0;- if (f->view == POD_V_TAB && f->tab != POD_TAB_RECENT) return cs_tab_page(nav, m, out);+ if (f->view == POD_V_TAB) return cs_tab_page(nav, m, out);if (f->view != POD_V_TABS) return 0;int first, n = page_span(nav, m, &first), k = 0;for (int i = 0; i < n; i++) {diff --git a/devices/harness-pro/firmware/main/pod/console/cs_recent.c b/devices/harness-pro/firmware/main/pod/console/cs_recent.cdeleted file mode 100644index aa6192f76..000000000--- a/devices/harness-pro/firmware/main/pod/console/cs_recent.c+++ /dev/null@@ -1,101 +0,0 @@-// Console Recent (mockup screen 03, .r2* in style5.css) and the row list it shares with Tab: the agents with the most recent-// tasks, newest first, five rows of 108 px at a time (a drag scrolls the rest). A row: the 44 px logo, the working bars (WORKING)-// or a dot, the name in 32 px, the tab's name, the time (or "ask") at the right, and the agent's line in 27 px.-#include <stdio.h>-#include <string.h>--#include "pod/console/cs.h"-#include "pro_canvas.h"--#define C(rgb) ht_rgb(rgb)-enum { PADX = 24, LOGO = 44, TEXT_X = PADX + LOGO + 16 };--// The one line under the name: the question while asking, the activity while working, else what the agent last did-// (its recap's first line, or the activity). Colours follow the state.-static const char *line_of(const pod_agent_t *a, pod_state_t st, unsigned *rgb)-{- *rgb = CS_MUTED;- if (st == POD_ASKING && a->question[0]) { *rgb = CS_ASK; return a->question; }- if (st == POD_WORKING && a->activity[0]) return a->activity;- if (a->failed) *rgb = CS_FAIL;- if (st != POD_WORKING && a->recap_lines > 0) return a->recap + a->line_at[0];- return a->activity;-}--// A line's newlines read as spaces: the row is one line.-static void one_line(char *out, size_t cap, const char *t)-{- snprintf(out, cap, "%s", t);- for (char *c = out; *c; c++) if (*c == '\n' || *c == '\r' || *c == '\t') *c = ' ';-}--int cs_rows(pod_out_frame_t *f, const pod_model_t *m, const pod_agent_t *const list[], int n, int first, bool tab_col, uint32_t now_ms)-{- ht_scene_t *s = f->scene;- int drawn = 0;- for (int i = 0; i < CS_ROWS_MAX && first + i < n; i++, drawn++) {- const pod_agent_t *a = list[first + i];- pod_state_t st = pod_model_eff(m, a);- const int y = CS_ROWS_TOP + i * CS_ROW_H, cy = y + 34, right = POD_W - PADX;- cs_logo(s, PADX, y + 18, LOGO, a->engine);-- char t[12] = ""; // an unknown time draws nothing- unsigned tc = CS_DIM;- if (st == POD_ASKING) { snprintf(t, sizeof t, "ask"); tc = CS_ASK; }- else if (st == POD_WORKING) { pod_fmt_time(t, sizeof t, pod_agent_secs(a, now_ms)); tc = CS_RUN; }- else if (a->elapsed_s) pod_fmt_time(t, sizeof t, pod_agent_secs(a, now_ms));- int tw = t[0] ? ht_pro_width(&cs_mono_24, t) : 0;- if (tw) cs_text(s, right - tw, cy, tw + 2, &cs_mono_24, tc, t);-- int x = TEXT_X;- if (st == POD_WORKING) { cs_working_mark(s, x, cy - 11, now_ms); x += 26 + 10; }- else { cs_dot(s, x + 6, cy, cs_state_dot(m, a), now_ms); x += 12 + 10; }- char name[sizeof a->name];- one_line(name, sizeof name, a->name);- int avail = right - (tw ? tw + 16 : 0) - x, nw = ht_pro_width(&cs_sb_32, name);- if (nw > (tab_col ? avail * 3 / 5 : avail)) nw = tab_col ? avail * 3 / 5 : avail;- cs_text(s, x, cy, nw, &cs_sb_32, CS_INK, name);- if (tab_col) {- const pod_tab_t *tab = pod_tab_of(m, a);- const char *where = tab ? tab->name : a->machine;- if (avail - nw - 10 > 20) cs_text(s, x + nw + 10, cy, avail - nw - 10, &cs_rg_22, CS_DIM, where);- }-- unsigned lc;- char line[POD_ACTIVITY_BYTES];- one_line(line, sizeof line, line_of(a, st, &lc));- cs_text(s, TEXT_X, y + 72, right - TEXT_X, &cs_rg_27, lc, line);- ht_pro_rect(s, 0, y + CS_ROW_H - 1, POD_W, 1, 0, C(CS_RAISED));- pod_hit_add_id(f, 0, y, POD_W, CS_ROW_H, POD_A_OPEN_AGENT, first + i, a->id);- }- return drawn;-}--int cs_rows_max(const pod_nav_t *nav, const pod_model_t *m)-{- const pod_frame_t *f = nav->depth ? &nav->stack[nav->depth - 1] : NULL;- if (f && f->tab != POD_TAB_RECENT) return cs_tab_pages(nav, m) - 1; // a tab's cards: the frame's scroll is the page- const pod_agent_t *list[POD_AGENTS_MAX];- int n = pod_nav_list(nav, m, list, POD_AGENTS_MAX);- return n > CS_ROWS_MAX ? n - CS_ROWS_MAX : 0;-}--void cs_view_recent(pod_out_frame_t *f, const pod_nav_t *nav, pod_model_t *m, uint32_t now_ms)-{- ht_scene_t *s = f->scene;- int running, asking;- cs_counts(m, &running, &asking);- const char *const crumbs[] = {"Overview", "Recent"};- cs_bar(f, crumbs, 2, running, asking, cs_unread(m), NULL, now_ms);-- const pod_agent_t *list[POD_AGENTS_MAX];- int n = pod_nav_list(nav, m, list, POD_AGENTS_MAX);- if (n == 0) {- const char *msg = "No recent agents";- int w = ht_pro_width(&cs_rg_24, msg);- cs_text(s, (POD_W - w) / 2, POD_W / 2, w + 2, &cs_rg_24, CS_MUTED, msg);- return;- }- int max = n > CS_ROWS_MAX ? n - CS_ROWS_MAX : 0, first = nav->stack[nav->depth - 1].scroll;- cs_rows(f, m, list, n, first < 0 ? 0 : first > max ? max : first, true, now_ms);-}diff --git a/devices/harness-pro/firmware/main/pod/console/cs_tab.c b/devices/harness-pro/firmware/main/pod/console/cs_tab.cindex 6e8cb5e95..862f5e1e0 100644--- a/devices/harness-pro/firmware/main/pod/console/cs_tab.c+++ b/devices/harness-pro/firmware/main/pod/console/cs_tab.c@@ -1,5 +1,5 @@-// Console Tab (pro-console-tab-cards.html, B): the selected tab's agents as cards, four a page (the Overview grid), in the window's-// own pane order. Each card takes its agent's state: green while it works, amber when it asks, a red edge when it failed. Head line:+// Console Tab and Recent (pro-console-tab-cards.html, B): the selected tab's agents as cards, four a page (the Overview grid), in+// the window's own pane order; Recent's agents the same way, newest first. Each card takes its agent's state: green while it works, amber when it asks, a red edge when it failed. Head line:// the agent's name left, its time right ("ask" while it asks); then its pet, logo or ">_"; at the foot the state in a word (the// working bars before "Working"). Tap opens the agent. The TAB frame's scroll is the page; the glue pages on a vertical swipe and// steps tabs on a sideways one. More than one page: dots down the right edge.@@ -65,17 +65,18 @@ void cs_view_tab(pod_out_frame_t *f, const pod_nav_t *nav, pod_model_t *m, uint3{ht_scene_t *s = f->scene;const pod_frame_t *top = &nav->stack[nav->depth - 1];- const pod_tab_t *t = &m->tabs[top->tab];+ const bool recent = top->tab == POD_TAB_RECENT;+ if (!recent && (top->tab < 0 || top->tab >= m->tab_count)) return;int running, asking;cs_counts(m, &running, &asking);- const char *const crumbs[] = {"Overview", t->name};+ const char *const crumbs[] = {"Overview", recent ? "Recent" : m->tabs[top->tab].name};cs_bar(f, crumbs, 2, running, asking, cs_unread(m), NULL, now_ms);const pod_agent_t *page[CS_PER_PAGE];int k = cs_tab_page(nav, m, page), pages = cs_tab_pages(nav, m);if (k <= 0) {- const char *msg = "No panes in this tab";+ const char *msg = recent ? "No recent agents" : "No panes in this tab";int w = ht_pro_width(&cs_rg_24, msg);cs_text(s, (POD_W - w) / 2, POD_W / 2, w + 2, &cs_rg_24, CS_MUTED, msg);return;diff --git a/devices/harness-pro/firmware/main/pod/console/cs_view.c b/devices/harness-pro/firmware/main/pod/console/cs_view.cindex 2a88eb7e8..0e8eeab4f 100644--- a/devices/harness-pro/firmware/main/pod/console/cs_view.c+++ b/devices/harness-pro/firmware/main/pod/console/cs_view.c@@ -9,8 +9,7 @@ void cs_render(pod_out_frame_t *f, const pod_nav_t *nav, pod_model_t *m, uint32_f->scene->background = ht_rgb(CS_GROUND); // the scene's own clear colour: no 720 x 720 ground rect to overdrawconst pod_frame_t *top = nav->depth ? &nav->stack[nav->depth - 1] : NULL;if (!top || top->view == POD_V_TABS) cs_view_overview(f, nav, m, now_ms);- else if (top->view == POD_V_TAB && top->tab == POD_TAB_RECENT) cs_view_recent(f, nav, m, now_ms);- else if (top->view == POD_V_TAB && top->tab >= 0 && top->tab < m->tab_count) cs_view_tab(f, nav, m, now_ms);+ else if (top->view == POD_V_TAB && (top->tab == POD_TAB_RECENT || (top->tab >= 0 && top->tab < m->tab_count))) cs_view_tab(f, nav, m, now_ms);else if (top->view == POD_V_AGENT) cs_view_agent(f, nav, m, now_ms);else if (top->view == POD_V_RECAP) cs_view_recap(f, nav, m, now_ms);else if (top->view == POD_V_TALK) cs_view_talk(f, nav, m, now_ms);diff --git a/devices/harness-pro/firmware/main/pod/pod_view.c b/devices/harness-pro/firmware/main/pod/pod_view.cindex 6794a0416..e9a61ec8c 100644--- a/devices/harness-pro/firmware/main/pod/pod_view.c+++ b/devices/harness-pro/firmware/main/pod/pod_view.c@@ -56,7 +56,7 @@ int pod_scroll_pitch(const pod_nav_t *nav)if (!top) return 0;if (nav->skin == POD_SKIN_CONSOLE && top->view == POD_V_INBOX) return cs_inbox_pitch();if (nav->skin == POD_SKIN_CONSOLE && top->view == POD_V_RECAP) return CS_RECAP_ROW;- if (nav->skin == POD_SKIN_CONSOLE && top->view == POD_V_TAB) return CS_ROW_H;+ if (nav->skin == POD_SKIN_CONSOLE && top->view == POD_V_TAB) return 0; // cards page on a swipe; nothing scrolls by pixelsreturn top->view == POD_V_TABS ? pod_tabs_pitch() :top->view == POD_V_TAB ? pod_tab_pitch() :top->view == POD_V_INBOX ? pod_inbox_pitch() :@@ -68,7 +68,7 @@ int pod_scroll_max(const pod_nav_t *nav, const pod_model_t *m)if (!top) return 0;if (nav->skin == POD_SKIN_CONSOLE && top->view == POD_V_INBOX) return cs_inbox_max_row(m);if (nav->skin == POD_SKIN_CONSOLE && top->view == POD_V_RECAP) return cs_recap_max_row(nav, m);- if (nav->skin == POD_SKIN_CONSOLE && top->view == POD_V_TAB) return cs_rows_max(nav, m);+ if (nav->skin == POD_SKIN_CONSOLE && top->view == POD_V_TAB) return cs_tab_pages(nav, m) - 1;if (nav->skin == POD_SKIN_CONSOLE && top->view == POD_V_TABS) return (pod_tabs_pages_of(nav, m) - 1) * 2;return top->view == POD_V_TABS ? pod_tabs_max_row(m) :top->view == POD_V_TAB ? pod_tab_max_row(nav, m) :diff --git a/devices/harness-pro/firmware/test/cs_perf_baseline.txt b/devices/harness-pro/firmware/test/cs_perf_baseline.txtindex c3c86c2f9..0ab205bc8 100644--- a/devices/harness-pro/firmware/test/cs_perf_baseline.txt+++ b/devices/harness-pro/firmware/test/cs_perf_baseline.txt@@ -1,8 +1,8 @@# Pre-change (v3 Task 4) host us per Console frame: 720x720 in 24-row strips, -O2, best of 18 runs, default font. test_cs_perf.sh needs <= 85% of these.-# tabs: re-baselined for the one-lead-per-tab Overview (tinted cards, four pets' small loops at their stored size, about 212 us measured; 207 before).-tabs 260-# recent: re-baselined for six rows a screen instead of five (no hint strip; about 183 us measured; 196 before).-recent 220+# tabs: re-baselined for the one-lead-per-tab Overview (tinted cards, four pets playing their scenes, about 216 us measured; 207 before).+tabs 265+# recent: re-baselined for Recent as cards like a tab (four pets playing their scenes, about 218 us measured; 196 as rows before).+recent 265# tabp:3: re-baselined for the Tab as cards (three pets playing their scenes instead of rows; about 161 us measured; 127 before).tabp:3 200agent:fw 231diff --git a/devices/harness-pro/firmware/test/golden-console-liberation.txt b/devices/harness-pro/firmware/test/golden-console-liberation.txtindex 81e227eb0..b09797d4c 100644--- a/devices/harness-pro/firmware/test/golden-console-liberation.txt+++ b/devices/harness-pro/firmware/test/golden-console-liberation.txt@@ -2,16 +2,15 @@019f0d0bd20a908188437f74893b1da429271937859ce59505c8978569b27851 agent:fw:long@250001f362325fb62d1eeb5908af9680540f8ab8190e8b895576b8436a6af10aa35b tabs:2+2@12340200f4eeb1eb9e93f22d513f189ed1f0854fac4e596b95ecf64709bb872c9ec1 agent:be:offline@600-06261d1df67f22b5e6ddc299079a3b1405c9a077fbc5a7db6a9ae7dd0fb8e81f recent@60007205c10d6c52aa746e5878cdb6f305e90a4eb0e04559a561e4b646f85b9f7d8 tabp:1@00981018cb689ca0db16e3e5e0c0bf5f4b306f5c01dba05fd1ce2956d41235a3c recap:desk:testfail@0-0ad62fc7831be4bac3c89a6d38b4057517651ecccdfa5ae9914e41fe2b92aa10 recent@12340b3379be2d95dddb3d5151ef418ca25b1f5d506b1d805f23f004d50dc3681e06 agent:desk@25000b3379be2d95dddb3d5151ef418ca25b1f5d506b1d805f23f004d50dc3681e06 recap:desk@25000d5e0c5516f80f8f6e9098628766517a28e52d3b64d9668132c6c61180f2f39e talk:cur@50000f4f57112d17db52c3888bf72e075c9b3a788b88a814b8860c6352cb79a9b35a tabp:8@12340f81659fcd4957bc0982e5cb5d583ed7ac817e0827d823cf8d9bb95556379054 chrome@600126bb1a4b6f2b8791faa4b9cd6f68e4041d958f2f42329d96a68b5209159899f recap:desk:extreme@2500+1354bc11d660b320adad7584d4b155c4586faa1e27533199a7f7f6daaf82246b recent@25001363a3930a98d572429097118bc0c4ea4cb486659c964b95d944f81a5fc89a2c inbox:quiet@2500149bdcd557e5dfa78f0d36c26f365a5997b4caf89851d774dff2592ff7c474b2 tabs:banner@500018aeb657868b34574209e4648297bec2351dac83f2b92d5b7aa22334f4506fe4 recap:desk:extreme@600@@ -73,6 +72,7 @@62a55bb633cff660447d638ff18c0a6ffd55c4b4085a8965b8197fb66b9797af agent:fw@2500641b0cd9aa007fa9711a62aa664431fb9036253ed3cf22c9c350b0b6172cc94c agent:kilo@2500641b0cd9aa007fa9711a62aa664431fb9036253ed3cf22c9c350b0b6172cc94c recap:kilo@2500+64f6286f809c424301c0452f9de6e3abba1b7d47466c7bdff6de42d4f8749750 recent@50006790f505742b6ce01565ea02ed8fb7001540185838cd9e4d8bb1d57f84a9c07c recap:desk:testfail@12346c1c711683532f2bb00a8182fad4498101fd452b115a0b35d193d1a5c268a97c talk:cur@06e4403780e7a08e9ec2f600e4b1a5a4deb1fccc20b65f98d94c419b6bd8561a8 talk:fw@0@@ -106,6 +106,7 @@8ecaf997c5a2829df8815da7a767d06f80a2b4bca0429b96915d782edd83bac1 ota:100@6008fc6a66a127eafa582dc666fe2455d7ae487ebbbf9620f33699c56ad0d5e291e tabs@091682cb091f74b1d8b3deaf9d4629dc00b040a349147ab9271e5b35bbd09f9ac talk:fw@5000+921d63b0b0200ebfe344da777a2c73d272e2238c170253d64722a18c6f2def07 recent@09509ffcc600cc0f4b1ec4df1ae9f5de69e2148bc1580f114b0447078def6203a tabs:banner@2500991e704dbdd4ec1fff2e5be7c6355b480056f28c72f93f452446f9b6a9c14b9b chrome:talk@09d28e969028ed1cf7bc6d62b188cc282cd310b0c8f2175aa31bcc8aae76f903a talk:fw:send@600@@ -131,7 +132,6 @@ ad872a66c1ffae8d7dc4b54183befa749695b5eba2dbb442f60853e7a83e7e11 tabs:0+2@1234ae8dfe2e76ba109fba58a92b63ba6a8ae36d03614631575ae53f3356700bbb54 recap:desk:scroll@2500ae98cc3c91886e476ab36f7b30ee0246f0fb3e1d8aa7127d7276f25c4971bf49 agent:fw:banner@2500b02daa780e26bde43c39f2acd035b13bdc063b69c5ab551a697fda92831e4891 tabs:mock@5000-b11d5e7973404c87721679a0048cf9121f882ced65cf20371803889f26559787 recent@2500b15999a5e364b343dd4e6de9aa063bda27dd2fdb46fe4bfe67b7ee37c1b60148 tabs:0+2@0b2b76476e75b5f4fe3d0682da7183e1cd03d6c953fd69b08aab058d9565a76ba chrome:talk@2500b43a1fd35a1329f0179b0c95b4bfabb309d1ca9f26ab52d3047514fc05973a8d agent:fw:long@0@@ -146,7 +146,6 @@ bf4d19c0ab1a2b05326693b180734fc9f19d4cff3690a0da5d74914531c65ef3 agent:fw@0c26f57bb75f6a204c4d73c54d00d0b0b71c5d7f244fa38e281bc9302bc3865ef inbox:failed@5000c26f57bb75f6a204c4d73c54d00d0b0b71c5d7f244fa38e281bc9302bc3865ef inbox@5000c33900bec8ba1a01852a857a090af27112fe67718f24084ddef3447f941476ab recap:desk:testfail@600-c3daf76603c1db2d0d5cec636f9d124aeb5b5b7e442c0e9cb72f87e79a828b5b recent@0c5e5a1e5a88c76147d2609caeec87bb9cbcf93034273c42a8efc8fb81c6ec025 talk:fw:send@0c6491c1f813b7aa08d07fbe6f9d136111e6d3b9f6ecaa8ae064b2f6624b81a01 agent:cli:banner@5000c6f8a7627ac6bb526f61a2835cf3f5a86b5832b716609b96342590b76ffa5eb3 recap:desk:banner@2500@@ -169,6 +168,7 @@ cf43c1a3f9297cdd9edc10fd746421c78ed4e31d88d8ae0262634aede0aad1b6 ota:0@2500cf43c1a3f9297cdd9edc10fd746421c78ed4e31d88d8ae0262634aede0aad1b6 ota:0@5000cf43c1a3f9297cdd9edc10fd746421c78ed4e31d88d8ae0262634aede0aad1b6 ota:0@600d11bb8da47b6f28e4036d682efe419cd633e941cb70d1fc61107dfb9aee32304 tabp:1@2500+d268c08248e539dccf17521108e4b03bcaf8788777ba2bb8113d99f2f2c69561 recent@1234d429c9b0bdb77f321315c812826e68c4954da0b6943e3c8e7d89120f2d8894d6 tabp:3@600d4ad0137c750685a01d76c2e416dc52db85c91f6c834c4800fc88b29689c28bf recap:desk:banner@0d4ad55c0ccbbf57bb196b8b1219c2abdb71d71ed7342b207c97361e58a1ddb57 agent:fw:banner@5000@@ -188,7 +188,7 @@ e00444c8087dd18dc79c0c36e38e7f3d2701eaf198f0d00730a2a4c7138fda8c inbox:quiet@50e080d716975ee28e50148e8c001ed29559367d8851f5e6c894987d60ee3525cc agent:be:offline@1234e14296692585b389f73ceb9a46df0426666ba4595007fd8a703d7296ac79c520 recap:desk:scroll@600e33234655c2be278fc6c1f99446e28c90e3a3cdd0e0476b4e1a6e11ed7a90589 chrome:talk@5000-e9653f887894747da898c2e07b01c86a009fe8ebbe055d8664bb0cbc2d97a545 recent@5000+e88f52cf5078c4c863ae9e99f7c202e92113570cd362c37475ff86a4eaad643b recent@600ee048a51646358935ad071092805130c4a82279818f9705efa900c669abc1d82 agent:desk@1234ee048a51646358935ad071092805130c4a82279818f9705efa900c669abc1d82 recap:desk@1234eeec47ee739e56a88ec35ee65e758c04d8639805b994d5ca863e262608ff8a1e agent:cli:banner@600diff --git a/devices/harness-pro/firmware/test/golden-console.txt b/devices/harness-pro/firmware/test/golden-console.txtindex 81e227eb0..b09797d4c 100644--- a/devices/harness-pro/firmware/test/golden-console.txt+++ b/devices/harness-pro/firmware/test/golden-console.txt@@ -2,16 +2,15 @@019f0d0bd20a908188437f74893b1da429271937859ce59505c8978569b27851 agent:fw:long@250001f362325fb62d1eeb5908af9680540f8ab8190e8b895576b8436a6af10aa35b tabs:2+2@12340200f4eeb1eb9e93f22d513f189ed1f0854fac4e596b95ecf64709bb872c9ec1 agent:be:offline@600-06261d1df67f22b5e6ddc299079a3b1405c9a077fbc5a7db6a9ae7dd0fb8e81f recent@60007205c10d6c52aa746e5878cdb6f305e90a4eb0e04559a561e4b646f85b9f7d8 tabp:1@00981018cb689ca0db16e3e5e0c0bf5f4b306f5c01dba05fd1ce2956d41235a3c recap:desk:testfail@0-0ad62fc7831be4bac3c89a6d38b4057517651ecccdfa5ae9914e41fe2b92aa10 recent@12340b3379be2d95dddb3d5151ef418ca25b1f5d506b1d805f23f004d50dc3681e06 agent:desk@25000b3379be2d95dddb3d5151ef418ca25b1f5d506b1d805f23f004d50dc3681e06 recap:desk@25000d5e0c5516f80f8f6e9098628766517a28e52d3b64d9668132c6c61180f2f39e talk:cur@50000f4f57112d17db52c3888bf72e075c9b3a788b88a814b8860c6352cb79a9b35a tabp:8@12340f81659fcd4957bc0982e5cb5d583ed7ac817e0827d823cf8d9bb95556379054 chrome@600126bb1a4b6f2b8791faa4b9cd6f68e4041d958f2f42329d96a68b5209159899f recap:desk:extreme@2500+1354bc11d660b320adad7584d4b155c4586faa1e27533199a7f7f6daaf82246b recent@25001363a3930a98d572429097118bc0c4ea4cb486659c964b95d944f81a5fc89a2c inbox:quiet@2500149bdcd557e5dfa78f0d36c26f365a5997b4caf89851d774dff2592ff7c474b2 tabs:banner@500018aeb657868b34574209e4648297bec2351dac83f2b92d5b7aa22334f4506fe4 recap:desk:extreme@600@@ -73,6 +72,7 @@62a55bb633cff660447d638ff18c0a6ffd55c4b4085a8965b8197fb66b9797af agent:fw@2500641b0cd9aa007fa9711a62aa664431fb9036253ed3cf22c9c350b0b6172cc94c agent:kilo@2500641b0cd9aa007fa9711a62aa664431fb9036253ed3cf22c9c350b0b6172cc94c recap:kilo@2500+64f6286f809c424301c0452f9de6e3abba1b7d47466c7bdff6de42d4f8749750 recent@50006790f505742b6ce01565ea02ed8fb7001540185838cd9e4d8bb1d57f84a9c07c recap:desk:testfail@12346c1c711683532f2bb00a8182fad4498101fd452b115a0b35d193d1a5c268a97c talk:cur@06e4403780e7a08e9ec2f600e4b1a5a4deb1fccc20b65f98d94c419b6bd8561a8 talk:fw@0@@ -106,6 +106,7 @@8ecaf997c5a2829df8815da7a767d06f80a2b4bca0429b96915d782edd83bac1 ota:100@6008fc6a66a127eafa582dc666fe2455d7ae487ebbbf9620f33699c56ad0d5e291e tabs@091682cb091f74b1d8b3deaf9d4629dc00b040a349147ab9271e5b35bbd09f9ac talk:fw@5000+921d63b0b0200ebfe344da777a2c73d272e2238c170253d64722a18c6f2def07 recent@09509ffcc600cc0f4b1ec4df1ae9f5de69e2148bc1580f114b0447078def6203a tabs:banner@2500991e704dbdd4ec1fff2e5be7c6355b480056f28c72f93f452446f9b6a9c14b9b chrome:talk@09d28e969028ed1cf7bc6d62b188cc282cd310b0c8f2175aa31bcc8aae76f903a talk:fw:send@600@@ -131,7 +132,6 @@ ad872a66c1ffae8d7dc4b54183befa749695b5eba2dbb442f60853e7a83e7e11 tabs:0+2@1234ae8dfe2e76ba109fba58a92b63ba6a8ae36d03614631575ae53f3356700bbb54 recap:desk:scroll@2500ae98cc3c91886e476ab36f7b30ee0246f0fb3e1d8aa7127d7276f25c4971bf49 agent:fw:banner@2500b02daa780e26bde43c39f2acd035b13bdc063b69c5ab551a697fda92831e4891 tabs:mock@5000-b11d5e7973404c87721679a0048cf9121f882ced65cf20371803889f26559787 recent@2500b15999a5e364b343dd4e6de9aa063bda27dd2fdb46fe4bfe67b7ee37c1b60148 tabs:0+2@0b2b76476e75b5f4fe3d0682da7183e1cd03d6c953fd69b08aab058d9565a76ba chrome:talk@2500b43a1fd35a1329f0179b0c95b4bfabb309d1ca9f26ab52d3047514fc05973a8d agent:fw:long@0@@ -146,7 +146,6 @@ bf4d19c0ab1a2b05326693b180734fc9f19d4cff3690a0da5d74914531c65ef3 agent:fw@0c26f57bb75f6a204c4d73c54d00d0b0b71c5d7f244fa38e281bc9302bc3865ef inbox:failed@5000c26f57bb75f6a204c4d73c54d00d0b0b71c5d7f244fa38e281bc9302bc3865ef inbox@5000c33900bec8ba1a01852a857a090af27112fe67718f24084ddef3447f941476ab recap:desk:testfail@600-c3daf76603c1db2d0d5cec636f9d124aeb5b5b7e442c0e9cb72f87e79a828b5b recent@0c5e5a1e5a88c76147d2609caeec87bb9cbcf93034273c42a8efc8fb81c6ec025 talk:fw:send@0c6491c1f813b7aa08d07fbe6f9d136111e6d3b9f6ecaa8ae064b2f6624b81a01 agent:cli:banner@5000c6f8a7627ac6bb526f61a2835cf3f5a86b5832b716609b96342590b76ffa5eb3 recap:desk:banner@2500@@ -169,6 +168,7 @@ cf43c1a3f9297cdd9edc10fd746421c78ed4e31d88d8ae0262634aede0aad1b6 ota:0@2500cf43c1a3f9297cdd9edc10fd746421c78ed4e31d88d8ae0262634aede0aad1b6 ota:0@5000cf43c1a3f9297cdd9edc10fd746421c78ed4e31d88d8ae0262634aede0aad1b6 ota:0@600d11bb8da47b6f28e4036d682efe419cd633e941cb70d1fc61107dfb9aee32304 tabp:1@2500+d268c08248e539dccf17521108e4b03bcaf8788777ba2bb8113d99f2f2c69561 recent@1234d429c9b0bdb77f321315c812826e68c4954da0b6943e3c8e7d89120f2d8894d6 tabp:3@600d4ad0137c750685a01d76c2e416dc52db85c91f6c834c4800fc88b29689c28bf recap:desk:banner@0d4ad55c0ccbbf57bb196b8b1219c2abdb71d71ed7342b207c97361e58a1ddb57 agent:fw:banner@5000@@ -188,7 +188,7 @@ e00444c8087dd18dc79c0c36e38e7f3d2701eaf198f0d00730a2a4c7138fda8c inbox:quiet@50e080d716975ee28e50148e8c001ed29559367d8851f5e6c894987d60ee3525cc agent:be:offline@1234e14296692585b389f73ceb9a46df0426666ba4595007fd8a703d7296ac79c520 recap:desk:scroll@600e33234655c2be278fc6c1f99446e28c90e3a3cdd0e0476b4e1a6e11ed7a90589 chrome:talk@5000-e9653f887894747da898c2e07b01c86a009fe8ebbe055d8664bb0cbc2d97a545 recent@5000+e88f52cf5078c4c863ae9e99f7c202e92113570cd362c37475ff86a4eaad643b recent@600ee048a51646358935ad071092805130c4a82279818f9705efa900c669abc1d82 agent:desk@1234ee048a51646358935ad071092805130c4a82279818f9705efa900c669abc1d82 recap:desk@1234eeec47ee739e56a88ec35ee65e758c04d8639805b994d5ca863e262608ff8a1e agent:cli:banner@600diff --git a/devices/harness-pro/firmware/test/test_cs_glue.c b/devices/harness-pro/firmware/test/test_cs_glue.cindex 2b7c4273d..8e5e9830a 100644--- a/devices/harness-pro/firmware/test/test_cs_glue.c+++ b/devices/harness-pro/firmware/test/test_cs_glue.c@@ -989,8 +989,8 @@ static void wake_rates(void) {uint32_t n = wakes_in(2000, 10000, &mn);CHECK(n > 10 && n <= 10000 / 66 + 1 && mn >= 1);}- for (int k = 0; k < 4; k++) { // nobody works or asks: Overview's and a Tab's cards still play their pets' rest scenes (never- // faster than 66 ms); Recent and the Inbox, with no pet, wake once a second+ for (int k = 0; k < 4; k++) { // nobody works or asks: the cards of Overview, a Tab and Recent still play their pets' rest+ // scenes (never faster than 66 ms); the Inbox, with no pet, wakes once a secondfresh(POD_SKIN_CONSOLE);calm();pod_model_question_close(&U.model, "a4");@@ -1000,7 +1000,7 @@ static void wake_rates(void) {else if (k == 3) act(POD_A_INBOX, 0);render(1000);uint32_t n = wakes_in(2000, 10000, &mn);- if (k < 2) CHECK(pod_ui_pet_on_screen(&U) && n > 10 && n <= 10000 / 66 + 1);+ if (k < 3) CHECK(pod_ui_pet_on_screen(&U) && n > 10 && n <= 10000 / 66 + 1);else CHECK(n == 10 && mn == 1000);}// an Overview with a Playing ribbon in Classic still polls at 300 ms; Console does not (its bar mark is the only motion)@@ -1107,7 +1107,7 @@ static void tab_cards_page(void) {render(3600);swipe(360, 300, 360, 520, 3600);CHECK(top()->scroll == 0);- // Recent keeps its row scroll, and its sixth row (y 596..700) starts a scroll rather than going back+ // Recent pages its cards like a tab: two pages of four for eight agents; a swipe up from the lower row (y 660) pages, not backfresh(POD_SKIN_CONSOLE);pod_model_agents_begin(&U.model);static const char *const r8[] = {"r1", "r2", "r3", "r4", "r5", "r6", "r7", "r8"};@@ -1116,10 +1116,15 @@ static void tab_cards_page(void) {for (int i = 0; i < 8; i++) pod_model_turn(&U.model, r8[i], "activity", "Editing", 10, 900u + (uint32_t)i);act(POD_A_OPEN_TAB, POD_TAB_RECENT);render(1000);- CHECK(top()->tab == POD_TAB_RECENT && top()->scroll == 0 && pod_scroll_max(&U.nav, &U.model) == 2);+ CHECK(top()->tab == POD_TAB_RECENT && top()->scroll == 0 && pod_scroll_max(&U.nav, &U.model) == 1);depth = U.nav.depth;- t_(true, 360, 660, 1000); t_(true, 360, 560, 1050); t_(true, 360, 450, 1100); t_(false, 360, 450, 1150);- CHECK(U.nav.depth == depth && top()->scroll > 0);+ swipe(360, 660, 360, 450, 1000);+ CHECK(U.nav.depth == depth && top()->scroll == 1 && top()->tab == POD_TAB_RECENT);+ swipe(360, 300, 360, 520, 1200);+ CHECK(top()->scroll == 0);+ render(1400);+ const pod_hit_t *c0 = find(POD_A_OPEN_AGENT); // a tap on a card opens its agent+ CHECK(c0 && tap_(c0->x + c0->w / 2, c0->y + c0->h / 2, 1500).fx == POD_FX_AGENT_OPEN);}// ---- Classic index (Task 4) ----------------------------------------------------------------------------------diff --git a/devices/harness-pro/firmware/test/test_cs_views.c b/devices/harness-pro/firmware/test/test_cs_views.cindex 928dd9bd8..f71aa282f 100644--- a/devices/harness-pro/firmware/test/test_cs_views.c+++ b/devices/harness-pro/firmware/test/test_cs_views.c@@ -307,40 +307,32 @@ int main(void) {N.stack[0].scroll = 0;pod_model_swarms(&M, sw, lists, counts, 3, "s0", NULL, 0);- // Recent: 8 agents, six rows of 104 px at a time (the screen down to its bottom margin); drag scroll shows the rest+ // Recent: 8 agents as cards like a tab, newest first, two pages of four; the frame's scroll is the pagepod_nav_act(&N, &M, POD_A_OPEN_TAB, POD_TAB_RECENT, now);fresh();- cs_view_recent(&F, &N, &M, now);+ cs_view_tab(&F, &N, &M, now);const pod_agent_t *rl[POD_RECENT_MAX];int rn = pod_model_recent(&M, rl, POD_RECENT_MAX);- CHECK(rn == 8 && hits_of(POD_A_OPEN_AGENT) == 6);- for (int i = 0; i < 6; i++) { const pod_hit_t *h = nth_hit(POD_A_OPEN_AGENT, i); CHECK(!strcmp(h->id, rl[i]->id) && h->arg == i && h->y == 76 + i * 104 && h->h == 104); }- CHECK(76 + 6 * 104 <= POD_W - CS_FOOT_H); // the last row ends above the bottom margin- CHECK(text_run("ask") && text_run("Recent") && text_run("Overview") && text_run("go to the ask") == NULL);- CHECK(hits_of(POD_A_BACK) == 1);- CHECK(!text_run("open") && !text_run("tabs") && !text_run("back") && !text_run("home")); // no hint strip+ CHECK(rn == 8 && hits_of(POD_A_OPEN_AGENT) == 4 && cs_tab_pages(&N, &M) == 2);+ for (int i = 0; i < 4; i++) {+ const pod_hit_t *h = nth_hit(POD_A_OPEN_AGENT, i);+ CHECK(!strcmp(h->id, rl[i]->id) && h->arg == i && h->w == CS_CARD_W && h->h == CS_CARD_H);+ CHECK(h->x == CS_CARD_MARGIN + (i % 2) * (CS_CARD_W + CS_CARD_GAP) && h->y == CS_CARD_TOP + (i / 2) * (CS_CARD_H + CS_CARD_GAP));+ }+ CHECK(text_run("Recent") && text_run("Overview") && hits_of(POD_A_BACK) == 1 && !text_run("go to the ask"));+ CHECK(!text_run("Editing a file")); // no activity line, as on a tab's cardsCHECK(cs_runs(&F) <= 184);- CHECK(pod_scroll_pitch(&N) == 104 && pod_scroll_max(&N, &M) == 2);- { // a WORKING agent has the four bars and no dot; the others a dot and no bars- int work = 0, bars = 0, green_dots = 0;- for (int i = 0; i < CS_ROWS_MAX; i++) work += pod_model_eff(&M, rl[i]) == POD_WORKING;- for (int i = 0; i < S.count; i++) {- const ht_run_t *r = &S.runs[i];- bars += r->pro_kind == K_RECT && r->w == 5 && r->fg == ht_rgb(CS_RUN);- green_dots += r->pro_kind == K_RECT_AA && r->w == 12 && r->y > CS_BAR_H && r->fg == ht_rgb(CS_RUN); // the bar has its own- }- CHECK(work >= 2 && bars == 4 * work && green_dots == 0);- const ht_run_t *nm = text_run(rl[0]->name); // the name sits in the 32 px face, the line in the 27 px- CHECK(nm && nm->pro_font == &cs_sb_32);- const ht_run_t *ln = text_run("Editing a file");- CHECK(ln && ln->pro_font == &cs_rg_27);- CHECK(text_run("Firmware")); // Recent names each agent's tab+ CHECK(pod_scroll_pitch(&N) == 0 && pod_scroll_max(&N, &M) == 1);+ { // the state, in a word at each card's foot; the name in the 28 px face+ const ht_run_t *nm = text_run(rl[0]->name);+ CHECK(nm && nm->pro_font == &cs_md_28);+ CHECK(text_run("Working") || text_run("Needs you") || text_run("Done") || text_run("Idle"));}- N.stack[N.depth - 1].scroll = 2;+ N.stack[N.depth - 1].scroll = 1;fresh();- cs_view_recent(&F, &N, &M, now);- CHECK(hits_of(POD_A_OPEN_AGENT) == 6);- for (int i = 0; i < 6; i++) { const pod_hit_t *h = nth_hit(POD_A_OPEN_AGENT, i); CHECK(!strcmp(h->id, rl[2 + i]->id) && h->arg == 2 + i); }+ cs_view_tab(&F, &N, &M, now);+ CHECK(hits_of(POD_A_OPEN_AGENT) == 4);+ for (int i = 0; i < 4; i++) { const pod_hit_t *h = nth_hit(POD_A_OPEN_AGENT, i); CHECK(!strcmp(h->id, rl[4 + i]->id) && h->arg == 4 + i); }N.stack[N.depth - 1].scroll = 0;// ---- Tab: the real pane split (3 panes, then 8) ----