Skip to content

The ultimate harness for coding agents and beyond. All your agents. All your machines. One command center. Start with code, then follow your curiosity and build across disciplines: CAD, circuits, robots, games and music.

Keep update regressions isolated and allow real Git test runtimes

Dee5f9bdd7b95b0
diff --git a/cli/src/authCommand.spec.ts b/cli/src/authCommand.spec.ts
index 48bd1db33..af68e21a0 100644
--- a/cli/src/authCommand.spec.ts
+++ b/cli/src/authCommand.spec.ts
@@ -52,6 +52,9 @@ function envFor(root: string, backendUrl?: string): NodeJS.ProcessEnv {
ADAPTER_CLI_DIR: join(root, 'cli'),
ADAPTER_COMPUTER_ID_FILE: join(root, 'computer-id'),
ADAPTER_UPDATE_DISABLE: 'true',
+ // Sign-in should exercise the fake backend, never a developer's Grid binary or its installer.
+ HARNESS_GRID_BIN: join(root, 'grid-unavailable'),
+ DISABLE_GRID_INSTALL: 'true',
...(backendUrl ? { BACKEND_WS_URL: backendUrl } : {}),
}
}
diff --git a/cli/src/dsh/command.ts b/cli/src/dsh/command.ts
index 9b2fb6b50..803a3822b 100644
--- a/cli/src/dsh/command.ts
+++ b/cli/src/dsh/command.ts
@@ -1,4 +1,3 @@
-import { updateDsh } from './update.js'
/**
* `harness dsh …` — the terminal face of domain-specific harnesses, for a server with no desktop
* and for the development loop (`--link` a checkout, iterate, no re-clone).
@@ -8,6 +7,7 @@ import { DSH_ID_RE, dshTier } from './manifest.js'
import { registrySourceUrl } from './registry.js'
import { catalogEntry, currentDshRegistry, refreshDshRegistry } from './catalog.js'
import { installDsh, removeDsh, resolveInstallSource, runDshDoctor } from './install.js'
+import { updateDsh } from './update.js'
import { dshUpdateInfo } from './updates.js'
import { checkDsh, formatCheck } from './check.js'
diff --git a/cli/src/dsh/update.spec.ts b/cli/src/dsh/update.spec.ts
index 8aec0d959..a7005ed70 100644
--- a/cli/src/dsh/update.spec.ts
+++ b/cli/src/dsh/update.spec.ts
@@ -27,7 +27,7 @@ vi.mock('node:fs', async original => {
}
})
-describe('package updates', () => {
+describe('package updates', { timeout: 30_000 }, () => {
let root: string
let savedRoot: string
const id = 'acme/thing'
diff --git a/desktop/lib/state/app_state.dart b/desktop/lib/state/app_state.dart
index 35f4e5ef8..a1b23ee69 100644
--- a/desktop/lib/state/app_state.dart
+++ b/desktop/lib/state/app_state.dart
@@ -291,7 +291,6 @@ class AppNotifier extends ChangeNotifier {
final AuthSession session;
AppConfig config;
late ApiClient api;
-
/// Signs in, and says whether this computer is signed in: the harness CLI in a desktop build,
/// [ViewerServices.login] in a viewer build — which has no CLI — under one name, so every call
/// site reads the same in both.
@@ -502,9 +501,11 @@ class AppNotifier extends ChangeNotifier {
final target = swarms.where((s) => s.id == entry.swarmId).firstOrNull;
return target == null ||
target.panes.length < maxPanes ||
- target.panes.any(
- (p) => p.machineId == entry.machineId && p.agentId == entry.agentId,
- );
+ target.panes.any(
+ (p) =>
+ p.machineId == entry.machineId &&
+ p.agentId == entry.agentId,
+ );
}
bool _canReopenSwarm(ClosedSwarm saved) {
@@ -2492,8 +2493,7 @@ class AppNotifier extends ChangeNotifier {
final updater = desktopUpdater ?? DesktopUpdater();
final staged = await updater.downloadAndStage(info);
if (staged == null) {
- updateError =
- 'Could not download and verify OpenHarness ${info.version}.';
+ updateError = 'Could not download and verify OpenHarness ${info.version}.';
return false;
}
final applied = await updater.applyStaged(staged, selfPid: pid);
@@ -3559,10 +3559,7 @@ class AppNotifier extends ChangeNotifier {
if (decision == null) return;
// The dialog may list the machines, and the person may have moved the choice.
machineId = decision.machineId;
- final error = await _startLocalModelAgent(
- machineId,
- prompt: decision.prompt,
- );
+ final error = await _startLocalModelAgent(machineId, prompt: decision.prompt);
if (error != null) {
_lastError = error;
_lastErrorRetryable = false;
@@ -3594,10 +3591,7 @@ class AppNotifier extends ChangeNotifier {
/// before this dialog had buttons.
///
/// Null on success, else the sentence for the person.
- Future<String?> _startLocalModelAgent(
- String machineId, {
- String? prompt,
- }) async {
+ Future<String?> _startLocalModelAgent(String machineId, {String? prompt}) async {
final machine = machineStates[machineId];
if (machine == null) return 'Machine not found';
final home = await _homeFolderOf(machine);
diff --git a/desktop/test/store_update_e2e_test.dart b/desktop/test/store_update_e2e_test.dart
index 533c6f3bf..05944db7b 100644
--- a/desktop/test/store_update_e2e_test.dart
+++ b/desktop/test/store_update_e2e_test.dart
@@ -63,17 +63,19 @@ void main() {
final message = jsonDecode(line);
if (message is Map &&
message['port'] is int &&
- !port.isCompleted)
+ !port.isCompleted) {
port.complete(message['port'] as int);
+ }
} on FormatException {
/* Progress also goes to stdout. */
}
},
onDone: () {
- if (!port.isCompleted)
+ if (!port.isCompleted) {
port.completeError(
StateError('Daemon did not start: $diagnostics'),
);
+ }
},
);
final localPort = await port.future.timeout(
@@ -88,8 +90,9 @@ void main() {
onAuthFailure: fail,
onEvent: (event) => unawaited(app.handleEventForTest('m', event)),
onStatus: (status) {
- if (status == ConnectionStatus.connected && !ready.isCompleted)
+ if (status == ConnectionStatus.connected && !ready.isCompleted) {
ready.complete();
+ }
},
transportKind: WsTransportKind.localPlaintext,
localWsUri: Uri.parse('ws://127.0.0.1:$localPort'),
@@ -181,7 +184,10 @@ void main() {
() => connection.request('smoke_reopen'),
);
expect(reopened!['preview'], 'my finished project');
- expect(reopened['instructions'], '<!-- harness:dsh acme/thing -->\noriginal instructions\n\nmy custom instructions\n');
+ expect(
+ reopened['instructions'],
+ '<!-- harness:dsh acme/thing -->\noriginal instructions\n\nmy custom instructions\n',
+ );
expect(reopened['skill'], 'skill version 3');
expect(reopened['verdict'], {'ready': true, 'summary': 'finished'});