The ultimate harness for coding agents and beyond. All your agents. All your machines. One command center. Start with code, then follow your curiosity and build across disciplines: CAD, circuits, robots, games and music.
TypeScript 3d-modelingagent-frameworkagent-harnessai-agentscadclaude-codecodexcoding-agentsdeveloper-toolsesp32game-developmentmcp-servermulti-agentopen-hardwareopencodeopenharnesspcbroboticsterminaltmux
task(mobile): drop the trailing … from terminal menu rows
tony78365e7ee2b7
diff --git a/mobile/lib/phone/terminal_page.dart b/mobile/lib/phone/terminal_page.dartindex f61a9afac..8d6c62f5f 100644--- a/mobile/lib/phone/terminal_page.dart+++ b/mobile/lib/phone/terminal_page.dart@@ -3108,7 +3108,7 @@ class _TerminalPageState extends State<TerminalPage>if (agent.canFork && !agent.isStopped)PhoneSheetAction(icon: LucideIcons.gitFork300,- label: 'Fork…',+ label: 'Fork',value: _forking ? 'forking…' : null,onTap: () => unawaited(_fork()),),@@ -3125,7 +3125,7 @@ class _TerminalPageState extends State<TerminalPage>),PhoneSheetAction(icon: LucideIcons.pencil300,- label: 'Rename…',+ label: 'Rename',onTap: () => showAgentRenameDialog(context,widget.notifier,@@ -3317,7 +3317,7 @@ class _TerminalPageState extends State<TerminalPage>PhoneSheetAction _stopAction(Agent agent) => PhoneSheetAction(icon: LucideIcons.trash2300,// The least used thing here: small at the foot, not a full red row (it still confirms).- label: 'Stop this harness…',+ label: 'Stop this harness',destructive: true,quiet: true,onTap: () => unawaited(@@ -3379,7 +3379,7 @@ class _TerminalPageState extends State<TerminalPage>);return PhoneSheetAction(icon: LucideIcons.trash300,- label: deleting ? 'Deleting…' : 'Delete this harness…',+ label: deleting ? 'Deleting…' : 'Delete this harness',enabled: !deleting,destructive: true,quiet: true,diff --git a/mobile/test/phone_edge/focus_behavior_test.dart b/mobile/test/phone_edge/focus_behavior_test.dartindex 7fad45f51..832707731 100644--- a/mobile/test/phone_edge/focus_behavior_test.dart+++ b/mobile/test/phone_edge/focus_behavior_test.dart@@ -675,11 +675,11 @@ void main() {testWidgets('Fork is offered where the machine can fork, and not on a ''terminal', (tester) async {var focus = await openMenu(tester);- expect(find.text('Fork…'), findsOneWidget);+ expect(find.text('Fork'), findsOneWidget);await focus.close();focus = await openMenu(tester, engine: 'terminal');- expect(find.text('Fork…'), findsNothing);+ expect(find.text('Fork'), findsNothing);await focus.close();});@@ -687,7 +687,7 @@ void main() {'fork opens and the source is left as it was', (tester) async {final conn = forking();final focus = await openMenu(tester, connection: conn);- await tapInView(tester, find.text('Fork…'));+ await tapInView(tester, find.text('Fork'));await frames(tester);expect(find.text('Fork Harness'), findsOneWidget);@@ -735,7 +735,7 @@ void main() {},);final focus = await openMenu(tester, connection: conn);- await tapInView(tester, find.text('Fork…'));+ await tapInView(tester, find.text('Fork'));await frames(tester);await tester.tap(find.byKey(const Key('fork-confirm')));await frames(tester);@@ -749,7 +749,7 @@ void main() {testWidgets('Fork with no name is not sent', (tester) async {final conn = forking();final focus = await openMenu(tester, connection: conn);- await tapInView(tester, find.text('Fork…'));+ await tapInView(tester, find.text('Fork'));await frames(tester);await tester.enterText(find.byKey(const Key('fork-name')), ' ');await tester.tap(find.byKey(const Key('fork-confirm')));@@ -768,7 +768,7 @@ void main() {final focus = await openMenu(tester, connection: conn);setPhone(tester, smallPhone);await frames(tester);- await tapInView(tester, find.text('Fork…'));+ await tapInView(tester, find.text('Fork'));await frames(tester);raiseKeyboard(tester);await frames(tester);@@ -798,7 +798,7 @@ void main() {final reply = Completer<Map<String, dynamic>>();final forkConn = _HeldForkConn(reply.future)..handshaken = true;final focus = await openMenu(tester, connection: forkConn);- await tapInView(tester, find.text('Fork…'));+ await tapInView(tester, find.text('Fork'));await frames(tester);await tester.tap(find.byKey(const Key('fork-confirm')));await frames(tester);@@ -923,7 +923,7 @@ void main() {await tester.tap(find.byKey(const ValueKey('terminal-title')));await frames(tester);expect(find.text('Stop after it finishes'), findsNothing);- expect(find.text('Stop this harness…'), findsOneWidget);+ expect(find.text('Stop this harness'), findsOneWidget);await focus.close();focus = await openMenu(tester, working: true);@@ -939,13 +939,13 @@ void main() {tester,) async {var focus = await openMenu(tester);- expect(find.text('Stop this harness…'), findsOneWidget);- expect(find.text('Delete this harness…'), findsOneWidget);+ expect(find.text('Stop this harness'), findsOneWidget);+ expect(find.text('Delete this harness'), findsOneWidget);await focus.close();focus = await openMenu(tester, engine: 'terminal');- expect(find.text('Stop this harness…'), findsOneWidget);- expect(find.text('Delete this harness…'), findsNothing);+ expect(find.text('Stop this harness'), findsOneWidget);+ expect(find.text('Delete this harness'), findsNothing);await focus.close();});@@ -959,7 +959,7 @@ void main() {);await tester.tap(find.byKey(const ValueKey('terminal-title')));await frames(tester);- await tapInView(tester, find.text('Delete this harness…'));+ await tapInView(tester, find.text('Delete this harness'));await frames(tester);expect(find.text('Delete a?'), findsOneWidget);await tester.tap(find.widgetWithText(FilledButton, 'Delete'));@@ -992,14 +992,14 @@ void main() {);await tester.tap(find.byKey(const ValueKey('terminal-title')));await frames(tester);- await tapInView(tester, find.text('Delete this harness…'));+ await tapInView(tester, find.text('Delete this harness'));await frames(tester);await tester.tap(find.widgetWithText(FilledButton, 'Delete'));await frames(tester);await tester.tap(find.byKey(const ValueKey('terminal-title')));await frames(tester);- expect(find.text('Delete this harness…'), findsNothing);+ expect(find.text('Delete this harness'), findsNothing);await tapInView(tester, find.text('Deleting…'));await frames(tester);expect(find.text('Delete a?'), findsNothing, reason: 'took no tap');@@ -1166,7 +1166,7 @@ void main() {);await frames(tester);- expect(find.text('Rename…'), findsNothing, reason: 'the menu went');+ expect(find.text('Rename'), findsNothing, reason: 'the menu went');expect(find.text('Waiting for the conversation handoff. Try switching again.'),findsOneWidget,@@ -1342,13 +1342,40 @@ void main() {await focus.close();});+ // A row that opens a screen of its own says so by opening it: no trailing `…`. The ellipsis is+ // kept for a row saying something is on its way (`forking…`, `Deleting…`).+ testWidgets('no row ends in an ellipsis', (tester) async {+ final focus = await openMenu(tester);+ for (final label in const [+ 'Fork',+ 'Rename',+ 'Stop this harness',+ 'Delete this harness',+ ]) {+ expect(find.text(label), findsOneWidget);+ }+ expect(+ find.descendant(+ of: find.byType(BottomSheet),+ matching: find.byWidgetPredicate(+ (widget) =>+ widget is Text &&+ (widget.data ?? widget.textSpan?.toPlainText() ?? '')+ .contains('…'),+ ),+ ),+ findsNothing,+ );+ await focus.close();+ });+testWidgets('Rename, Stop and Settings open their own screens', (tester,) async {final focus = await openMenu(tester);// Switched off everywhere for now (`kModelSheetEnabled`): no row that looks like a choice.expect(find.text('Model'), findsNothing);- await tester.tap(find.text('Rename…'));+ await tester.tap(find.text('Rename'));await frames(tester);expect(find.byType(TextField), findsOneWidget);await tester.tap(find.text('Cancel'));@@ -1356,7 +1383,7 @@ void main() {await tester.tap(find.byKey(const ValueKey('terminal-title')));await frames(tester);- await tapInView(tester, find.text('Stop this harness…'));+ await tapInView(tester, find.text('Stop this harness'));await frames(tester);expect(find.text('Cancel'), findsOneWidget);await tester.tap(find.text('Cancel'));diff --git a/mobile/test/phone_edge/focus_layout_test.dart b/mobile/test/phone_edge/focus_layout_test.dartindex 1d95720ee..22923559c 100644--- a/mobile/test/phone_edge/focus_layout_test.dart+++ b/mobile/test/phone_edge/focus_layout_test.dart@@ -177,7 +177,7 @@ void main() {await pumpFocus(tester, app, scale, brightness);await tester.tap(find.byKey(const ValueKey('terminal-title')));await frames(tester);- expect(find.text('Rename…'), findsOneWidget);+ expect(find.text('Rename'), findsOneWidget);});});diff --git a/mobile/test/sample_mode_test.dart b/mobile/test/sample_mode_test.dartindex 97c278183..91dbbce36 100644--- a/mobile/test/sample_mode_test.dart+++ b/mobile/test/sample_mode_test.dart@@ -290,7 +290,7 @@ void main() {await tester.tap(find.byKey(const ValueKey('terminal-title')).first);await settle(tester, const Duration(milliseconds: 500));- await tester.tap(find.text('Rename…'));+ await tester.tap(find.text('Rename'));await settle(tester, const Duration(milliseconds: 500));await tester.enterText(find.byType(TextField).last, 'docs-dark-mode');await tester.testTextInput.receiveAction(TextInputAction.done);@@ -305,7 +305,7 @@ void main() {await tester.tap(find.byKey(const ValueKey('terminal-title')).first);await settle(tester, const Duration(milliseconds: 500));- await tester.tap(find.text('Stop this harness…'));+ await tester.tap(find.text('Stop this harness'));await settle(tester, const Duration(milliseconds: 500));await tester.tap(find.text('Stop').last);await settle(tester, const Duration(seconds: 2));