Skip to content

The ultimate harness for coding agents and beyond. All your agents. All your machines. One command center. Start with code, then follow your curiosity and build across disciplines: CAD, circuits, robots, games and music.

feat(mobile): Search stays reachable while the keyboard is up

bubu-dudu91598e268959
diff --git a/mobile/lib/phone/terminal_action_column.dart b/mobile/lib/phone/terminal_action_column.dart
index 8557f881b..f0e0cc874 100644
--- a/mobile/lib/phone/terminal_action_column.dart
+++ b/mobile/lib/phone/terminal_action_column.dart
@@ -8,6 +8,7 @@ import 'package:harness_mobile/shared/theme/app_theme.dart';
import 'package:harness_mobile/terminal/terminal_session.dart';
import 'floating_glass.dart';
+import 'terminal_header.dart';
import 'voice_input_controller.dart';
import 'voice_mic_button.dart';
import 'voice_mic_face.dart';
@@ -45,6 +46,7 @@ class TerminalActionColumn extends StatefulWidget {
required this.session,
required this.onSearch,
this.unread,
+ this.searchOnly = false,
});
final VoiceInputController voice;
@@ -60,6 +62,16 @@ class TerminalActionColumn extends StatefulWidget {
final VoidCallback onSearch;
+ /// Search alone, with no mic over it — what is left while the keyboard is up.
+ ///
+ /// ⚠️ **The mic does not merely hide here, it has nothing to do.** Typing is
+ /// the other way of saying what the mic says, so with a keyboard on screen
+ /// the two are the same errand and one of them is already under the thumb.
+ /// Search is not: what it reaches — another harness, another machine — has no
+ /// equivalent on the key bar, and being unable to reach it without first
+ /// putting the keyboard away was the whole of the complaint.
+ final bool searchOnly;
+
/// The column's width: the mic's slot, which the smaller buttons centre under.
static const double width = VoiceMicButton.extent;
@@ -70,6 +82,17 @@ class TerminalActionColumn extends StatefulWidget {
/// [inset], so Search clears the agent's own status line under it.
static const double bottomInset = 172;
+ /// How far Search sits from the terminal's TOP edge while the keyboard is up
+ /// — see [searchOnly].
+ ///
+ /// ⚠️ **Below the header's own height, not at the top of the box.** The
+ /// header floats over these same rows and slides away on a scroll; measured
+ /// from the box, Search sat under it whenever it was shown. Below it, the two
+ /// never meet — and the rows Search now covers are the OLDEST on screen,
+ /// which is the opposite end of the pane from the prompt being typed into.
+ /// That is the whole reason it moves rather than staying where it was.
+ static const double topInset = TerminalHeader.height + 8;
+
/// The DRAWN gap between one circle and the next, the same all the way down.
///
/// ⚠️ No smaller than the mic's overhang plus a button's, less the slack
@@ -129,12 +152,15 @@ class _TerminalActionColumnState extends State<TerminalActionColumn> {
mainAxisSize: MainAxisSize.min,
crossAxisAlignment: CrossAxisAlignment.end,
children: [
- if (session != null)
+ if (widget.searchOnly)
+ const SizedBox.shrink()
+ else if (session != null)
_capsule(context, session)
else
// Still attaching: the mic in its place, dimmed and dead.
const VoiceMicButton(face: VoiceMicFace.talk, onPressed: null),
- const SizedBox(height: TerminalActionColumn._underMic),
+ if (!widget.searchOnly)
+ const SizedBox(height: TerminalActionColumn._underMic),
_centred(
_withUnread(
TerminalRoundAction(
diff --git a/mobile/lib/phone/terminal_page.dart b/mobile/lib/phone/terminal_page.dart
index 50cd36f27..e38922dd1 100644
--- a/mobile/lib/phone/terminal_page.dart
+++ b/mobile/lib/phone/terminal_page.dart
@@ -1475,18 +1475,37 @@ class _TerminalPageState extends State<TerminalPage>
onPress: _pressHint,
),
),
- if (!_ownsInput)
- Positioned(
- right: TerminalActionColumn.inset,
- bottom: TerminalActionColumn.bottomInset,
- child: TerminalActionColumn(
- voice: widget.voice,
- session: session,
- onSearch: _openSearch,
- unread:
- widget.notifier.agentNotices.unread,
- ),
+ // ⚠️ **Search stays while the keyboard is up; the
+ // mic goes.** Typing says what the mic says, so
+ // with a keyboard on screen the two are one
+ // errand and the key bar is already under the
+ // thumb. Search is not: another harness, another
+ // machine, and nothing on the key bar reaches
+ // them — so hiding the column whole meant
+ // putting the keyboard away first just to look
+ // something up.
+ //
+ // It moves to the TOP of the pane rather than
+ // staying put. Down here it floats over the
+ // prompt being typed into, which is exactly
+ // what the keyboard is for; up there it covers
+ // the oldest rows on screen.
+ Positioned(
+ right: TerminalActionColumn.inset,
+ top: _ownsInput
+ ? TerminalActionColumn.topInset
+ : null,
+ bottom: _ownsInput
+ ? null
+ : TerminalActionColumn.bottomInset,
+ child: TerminalActionColumn(
+ voice: widget.voice,
+ session: session,
+ onSearch: _openSearch,
+ searchOnly: _ownsInput,
+ unread: widget.notifier.agentNotices.unread,
),
+ ),
],
),
),